[meta-browser][PATCH] chromium.inc: Use setuptools3 instead of setuptools bbclass

[meta-browser][PATCH] chromium.inc: Use setuptools3 instead of setuptools bbclass

[Chandana kalluri]

From dunfell onwards, python2 recipes and classes are not supported. Inherit
setuptools3.bbclass for chromium instead of setuptools.bbclass

Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
---
 recipes-browser/chromium/chromium.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-browser/chromium/chromium.inc b/recipes-browser/chromium/chromium.inc
index a483ec4..49947be 100644
--- a/recipes-browser/chromium/chromium.inc
+++ b/recipes-browser/chromium/chromium.inc
@@ -18,7 +18,7 @@ TOOLCHAIN = "clang"
 # to build the native recipes (e.g. GN) with clang too.
 TOOLCHAIN_class-native = "clang"
 
-inherit python3native setuptools
+inherit python3native setuptools3
 
 # Chromium itself is licensed under the 3-clause BSD license. However, it
 # depends upon several other projects whose copyright files are listed in
-- 
2.7.4

Re: [oe] [meta-browser][PATCH] chromium.inc: Use setuptools3 instead of setuptools bbclass

[Khem Raj]

On 6/22/20 3:11 PM, Chandana kalluri wrote:
>  From dunfell onwards, python2 recipes and classes are not supported. Inherit
> setuptools3.bbclass for chromium instead of setuptools.bbclass
> 
> Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
> ---
>   recipes-browser/chromium/chromium.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-browser/chromium/chromium.inc b/recipes-browser/chromium/chromium.inc
> index a483ec4..49947be 100644
> --- a/recipes-browser/chromium/chromium.inc
> +++ b/recipes-browser/chromium/chromium.inc
> @@ -18,7 +18,7 @@ TOOLCHAIN = "clang"
>   # to build the native recipes (e.g. GN) with clang too.
>   TOOLCHAIN_class-native = "clang"
>   
> -inherit python3native setuptools
> +inherit python3native setuptools3

it still needs python2, better patch is to add meta-python2 to 
meta-browser layer dependencies

e.g in conf/layer.conf
LAYERDEPENDS_browser-layer = "clang-layer core openembedded-layer"


>   
>   # Chromium itself is licensed under the 3-clause BSD license. However, it
>   # depends upon several other projects whose copyright files are listed in
> 
> 
> 
> 

Re: [oe] [meta-browser][PATCH] chromium.inc: Use setuptools3 instead of setuptools bbclass

[Chandana kalluri]

> -----Original Message-----
> From: Khem Raj <raj.khem@gmail.com>
> Sent: Monday, June 22, 2020 4:55 PM
> To: Chandana Kalluri <ckalluri@xilinx.com>; openembedded-
> devel@lists.openembedded.org
> Cc: Chandana Kalluri <ckalluri@xilinx.com>
> Subject: Re: [oe] [meta-browser][PATCH] chromium.inc: Use setuptools3
> instead of setuptools bbclass
> 
> 
> 
> On 6/22/20 3:11 PM, Chandana kalluri wrote:
> >  From dunfell onwards, python2 recipes and classes are not supported.
> > Inherit setuptools3.bbclass for chromium instead of setuptools.bbclass
> >
> > Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
> > ---
> >   recipes-browser/chromium/chromium.inc | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-browser/chromium/chromium.inc
> > b/recipes-browser/chromium/chromium.inc
> > index a483ec4..49947be 100644
> > --- a/recipes-browser/chromium/chromium.inc
> > +++ b/recipes-browser/chromium/chromium.inc
> > @@ -18,7 +18,7 @@ TOOLCHAIN = "clang"
> >   # to build the native recipes (e.g. GN) with clang too.
> >   TOOLCHAIN_class-native = "clang"
> >
> > -inherit python3native setuptools
> > +inherit python3native setuptools3
> 
> it still needs python2, better patch is to add meta-python2 to meta-browser
> layer dependencies
> 
> e.g in conf/layer.conf
> LAYERDEPENDS_browser-layer = "clang-layer core openembedded-layer"
> 
> 
Will try this out. 

Thanks,
Chandana
> >
> >   # Chromium itself is licensed under the 3-clause BSD license. However, it
> >   # depends upon several other projects whose copyright files are
> > listed in
> >
> >
> > 
> >