RE: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware

From: Jolly Shah <JOLLYS@xilinx.com>
To: Michal Simek <michals@xilinx.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
	"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
	"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	Michal Simek <michals@xilinx.com>, Rajan Vaja <RAJANV@xilinx.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
Date: Mon, 7 Oct 2019 18:57:13 +0000	[thread overview]
Message-ID: <BYAPR02MB59922496F636C8C89B26DA70B89B0@BYAPR02MB5992.namprd02.prod.outlook.com> (raw)
In-Reply-To: <765978d6-10b3-b0e3-cf69-3c23104a8b6f@xilinx.com>

Hi Michal and Greg,

> -----Original Message-----
> From: Michal Simek <michal.simek@xilinx.com>
> Sent: Sunday, October 06, 2019 11:14 PM
> To: Greg KH <gregkh@linuxfoundation.org>; Jolly Shah <JOLLYS@xilinx.com>
> Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; matt@codeblueprint.co.uk;
> sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org;
> dmitry.torokhov@gmail.com; Michal Simek <michals@xilinx.com>; Rajan Vaja
> <RAJANV@xilinx.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
> 
> On 04. 10. 19 18:18, Greg KH wrote:
> > On Fri, Sep 27, 2019 at 12:40:05PM -0700, Jolly Shah wrote:
> >> ZynqMP firmware driver can be used for versal also.
> >> Add versal compatible string to zynqmp firmware driver
> >> doc.
> >>
> >> Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
> >> ---
> >>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16
> +++++++++++++++-
> >>  1 file changed, 15 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> >> index a4fe136..18c3aea 100644
> >> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> >> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> >> @@ -11,7 +11,9 @@ power management service, FPGA service and other
> platform management
> >>  services.
> >>
> >>  Required properties:
> >> - - compatible:	Must contain:	"xlnx,zynqmp-firmware"
> >> + - compatible:	Must contain any of below:
> >> +		"xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
> >> +		"xlnx,versal-firmware" for Versal
> >>   - method:	The method of calling the PM-API firmware layer.
> >>  		Permitted values are:
> >>  		  - "smc" : SMC #0, following the SMCCC
> >> @@ -21,6 +23,8 @@ Required properties:
> >>  Example
> >>  -------
> >>
> >> +Zynq Ultrascale+ MPSoC
> >> +----------------------
> >>  firmware {
> >>  	zynqmp_firmware: zynqmp-firmware {
> >>  		compatible = "xlnx,zynqmp-firmware";
> >> @@ -28,3 +32,13 @@ firmware {
> >>  		...
> >>  	};
> >>  };
> >> +
> >> +Versal
> >> +------
> >> +firmware {
> >> +	versal_firmware: versal-firmware {
> >> +		compatible = "xlnx,versal-firmware";
> >> +		method = "smc";
> >> +		...
> >> +	};
> >> +};
> >> --
> >> 2.7.4
> >>
> >
> >
> > For new dt bindings, don't you have to cc: the dt maintainers and
> > mailing list?  I can't take the patch until I get an ack from them.
> 
> Yes dt guys should be in CC and normally I am taking this via ARM soc tree.
> 
> Jolly: Please resend
> 

Sorry missed it earlier. Sent v2 including DT maintainers.

Thanks,
Jolly Shah

> Thanks,
> Michal