All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Dongli Zhang <dongli.zhang@oracle.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"james.smart@broadcom.com" <james.smart@broadcom.com>
Cc: "hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format
Date: Thu, 4 Jun 2020 06:54:10 +0000	[thread overview]
Message-ID: <BYAPR04MB49650D649A53B89DBFE1461286890@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 38a2cfb9-df2a-c5cb-6797-2b96ef049c7c@oracle.com

On 6/3/20 11:46 PM, Dongli Zhang wrote:
> May I get feedback for this?
> 
> For the first time I use fcloop, I set:
> 
> # echo "wwnn=0x3,wwpn=0x1" > /sys/class/fcloop/ctl/add_target_port
> 
> However, I would not be able to move forward if I use "0x3" or "0x1" for nvme-fc
> target or host further. Instead, the address and port should be
> 0x0000000000000003 and 0x0000000000000001.
> 
> This patch would sync the requirements of input format for nvme-fc and
> nvme-fcloop, unless this would break existing test suite (e.g., blktest).
If I remember correctly I don't think we have fc-loop testcases (correct 
me if I'm wrong).

Not an fc expert, but having uniform format for the input make sense to 
me (unless there is an explicit reason). I'll let James have a final say.

WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Dongli Zhang <dongli.zhang@oracle.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"james.smart@broadcom.com" <james.smart@broadcom.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format
Date: Thu, 4 Jun 2020 06:54:10 +0000	[thread overview]
Message-ID: <BYAPR04MB49650D649A53B89DBFE1461286890@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 38a2cfb9-df2a-c5cb-6797-2b96ef049c7c@oracle.com

On 6/3/20 11:46 PM, Dongli Zhang wrote:
> May I get feedback for this?
> 
> For the first time I use fcloop, I set:
> 
> # echo "wwnn=0x3,wwpn=0x1" > /sys/class/fcloop/ctl/add_target_port
> 
> However, I would not be able to move forward if I use "0x3" or "0x1" for nvme-fc
> target or host further. Instead, the address and port should be
> 0x0000000000000003 and 0x0000000000000001.
> 
> This patch would sync the requirements of input format for nvme-fc and
> nvme-fcloop, unless this would break existing test suite (e.g., blktest).
If I remember correctly I don't think we have fc-loop testcases (correct 
me if I'm wrong).

Not an fc expert, but having uniform format for the input make sense to 
me (unless there is an explicit reason). I'll let James have a final say.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-06-04  6:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26  4:21 [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format Dongli Zhang
2020-05-26  4:21 ` Dongli Zhang
2020-06-04  6:43 ` Dongli Zhang
2020-06-04  6:43   ` Dongli Zhang
2020-06-04  6:54   ` Chaitanya Kulkarni [this message]
2020-06-04  6:54     ` Chaitanya Kulkarni
2020-06-04 14:03     ` Hannes Reinecke
2020-06-04 14:03       ` Hannes Reinecke
2020-06-04 15:20 ` James Smart
2020-06-04 15:20   ` James Smart
2020-06-10 14:53   ` Dongli Zhang
2020-06-10 14:53     ` Dongli Zhang
2020-06-04 17:27 ` Sagi Grimberg
2020-06-04 17:27   ` Sagi Grimberg
2020-06-17  8:06 ` Christoph Hellwig
2020-06-17  8:06   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB49650D649A53B89DBFE1461286890@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=dongli.zhang@oracle.com \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.