* [PATCH] nvme: warn of unhandled effects only once
@ 2021-03-17 20:33 Keith Busch
2021-03-18 1:04 ` Chaitanya Kulkarni
2021-03-18 5:18 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2021-03-17 20:33 UTC (permalink / raw)
To: linux-nvme, hch, sagi; +Cc: Keith Busch
We don't need to repeatedly spam the kernel logs with the same warning
about unhandled passthrough IO effects. Just one warning is sufficient
to observe this condition occurs.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index bfc868d6bda9..bb15882c0fd1 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1072,9 +1072,9 @@ u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode)
if (ns->head->effects)
effects = le32_to_cpu(ns->head->effects->iocs[opcode]);
if (effects & ~(NVME_CMD_EFFECTS_CSUPP | NVME_CMD_EFFECTS_LBCC))
- dev_warn(ctrl->device,
- "IO command:%02x has unhandled effects:%08x\n",
- opcode, effects);
+ dev_warn_once(ctrl->device,
+ "IO command:%02x has unhandled effects:%08x\n",
+ opcode, effects);
return 0;
}
--
2.25.4
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: warn of unhandled effects only once
2021-03-17 20:33 [PATCH] nvme: warn of unhandled effects only once Keith Busch
@ 2021-03-18 1:04 ` Chaitanya Kulkarni
2021-03-18 5:18 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2021-03-18 1:04 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-nvme, hch, sagi
On 3/17/21 14:01, Keith Busch wrote:
> We don't need to repeatedly spam the kernel logs with the same warning
> about unhandled passthrough IO effects. Just one warning is sufficient
> to observe this condition occurs.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: warn of unhandled effects only once
2021-03-17 20:33 [PATCH] nvme: warn of unhandled effects only once Keith Busch
2021-03-18 1:04 ` Chaitanya Kulkarni
@ 2021-03-18 5:18 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-03-18 5:18 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-nvme, hch, sagi
Thanks,
applied to nvme-5.13.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-18 5:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 20:33 [PATCH] nvme: warn of unhandled effects only once Keith Busch
2021-03-18 1:04 ` Chaitanya Kulkarni
2021-03-18 5:18 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.