[PATCH 1/1] block: add sysfs entry for virt boundary mask

[PATCH 1/1] block: add sysfs entry for virt boundary mask

[Max Gurtovoy]

This entry will expose the bio vector alignment mask for a specific
block device.

Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
 block/blk-sysfs.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 0f4f0c8a7825..86a545e6d82d 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -264,6 +264,11 @@ static ssize_t queue_max_hw_sectors_show(struct request_queue *q, char *page)
 	return queue_var_show(max_hw_sectors_kb, (page));
 }
 
+static ssize_t queue_virt_boundary_mask_show(struct request_queue *q, char *page)
+{
+	return queue_var_show(q->limits.virt_boundary_mask, (page));
+}
+
 #define QUEUE_SYSFS_BIT_FNS(name, flag, neg)				\
 static ssize_t								\
 queue_##name##_show(struct request_queue *q, char *page)		\
@@ -610,6 +615,7 @@ QUEUE_RO_ENTRY(queue_fua, "fua");
 QUEUE_RO_ENTRY(queue_dax, "dax");
 QUEUE_RW_ENTRY(queue_io_timeout, "io_timeout");
 QUEUE_RW_ENTRY(queue_wb_lat, "wbt_lat_usec");
+QUEUE_RO_ENTRY(queue_virt_boundary_mask, "virt_boundary_mask");
 
 #ifdef CONFIG_BLK_DEV_THROTTLING_LOW
 QUEUE_RW_ENTRY(blk_throtl_sample_time, "throttle_sample_time");
@@ -670,6 +676,7 @@ static struct attribute *queue_attrs[] = {
 #ifdef CONFIG_BLK_DEV_THROTTLING_LOW
 	&blk_throtl_sample_time_entry.attr,
 #endif
+	&queue_virt_boundary_mask_entry.attr,
 	NULL,
 };
 
-- 
2.25.4

Re: [PATCH 1/1] block: add sysfs entry for virt boundary mask

[Chaitanya Kulkarni]

On 4/5/21 06:20, Max Gurtovoy wrote:
> +	return queue_var_show(q->limits.virt_boundary_mask, (page));

's/(page)/page/' ?

Re: [PATCH 1/1] block: add sysfs entry for virt boundary mask

[Ming Lei]

On Tue, Apr 6, 2021 at 4:43 AM Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
>
> This entry will expose the bio vector alignment mask for a specific
> block device.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
>  block/blk-sysfs.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> index 0f4f0c8a7825..86a545e6d82d 100644
> --- a/block/blk-sysfs.c
> +++ b/block/blk-sysfs.c
> @@ -264,6 +264,11 @@ static ssize_t queue_max_hw_sectors_show(struct request_queue *q, char *page)
>         return queue_var_show(max_hw_sectors_kb, (page));
>  }
>
> +static ssize_t queue_virt_boundary_mask_show(struct request_queue *q, char *page)
> +{
> +       return queue_var_show(q->limits.virt_boundary_mask, (page));
> +}
> +
>  #define QUEUE_SYSFS_BIT_FNS(name, flag, neg)                           \
>  static ssize_t                                                         \
>  queue_##name##_show(struct request_queue *q, char *page)               \
> @@ -610,6 +615,7 @@ QUEUE_RO_ENTRY(queue_fua, "fua");
>  QUEUE_RO_ENTRY(queue_dax, "dax");
>  QUEUE_RW_ENTRY(queue_io_timeout, "io_timeout");
>  QUEUE_RW_ENTRY(queue_wb_lat, "wbt_lat_usec");
> +QUEUE_RO_ENTRY(queue_virt_boundary_mask, "virt_boundary_mask");
>
>  #ifdef CONFIG_BLK_DEV_THROTTLING_LOW
>  QUEUE_RW_ENTRY(blk_throtl_sample_time, "throttle_sample_time");
> @@ -670,6 +676,7 @@ static struct attribute *queue_attrs[] = {
>  #ifdef CONFIG_BLK_DEV_THROTTLING_LOW
>         &blk_throtl_sample_time_entry.attr,
>  #endif
> +       &queue_virt_boundary_mask_entry.attr,
>         NULL,
>  };

Reviewed-by: Ming Lei <ming.lei@redhat.com>


-- 
Ming Lei

Re: [PATCH 1/1] block: add sysfs entry for virt boundary mask

[Martin K. Petersen]

Max,

> This entry will expose the bio vector alignment mask for a specific
> block device.

Looks fine except for the (page) that Chaitanya also pointed out.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 1/1] block: add sysfs entry for virt boundary mask

[Max Gurtovoy]

On 4/6/2021 4:53 AM, Martin K. Petersen wrote:
> Max,
>
>> This entry will expose the bio vector alignment mask for a specific
>> block device.
> Looks fine except for the (page) that Chaitanya also pointed out.

thanks for the review. In blk-sysfs.c we see both "(page) or page". I'm 
fine with Both.

Jens, can this be fixed during the merge to the preferred option please ?


>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
>

Re: [PATCH 1/1] block: add sysfs entry for virt boundary mask

[Jens Axboe]

On 4/5/21 7:20 AM, Max Gurtovoy wrote:
> This entry will expose the bio vector alignment mask for a specific
> block device.

Applied with page fixup.

-- 
Jens Axboe