From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Jianxiong Gao <jxgao@google.com>, Keith Busch <kbusch@kernel.org>
Cc: "heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
Saravana Kannan <saravanak@google.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Marc Orr <marcorr@google.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"jroedel@suse.de" <jroedel@suse.de>,
Erdem Aktas <erdemaktas@google.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>
Subject: Re: [PATCH V2 3/3] Adding device_dma_parameters->offset_preserve_mask to NVMe driver.
Date: Mon, 1 Feb 2021 23:59:52 +0000 [thread overview]
Message-ID: <BYAPR04MB4965AAC6C59013D475093D9486B69@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: CAMGD6P1_cs1W8jMt7Sz6broDdnFNPrxbiZW-JZ+GAtg5aoTdOQ@mail.gmail.com
On 2/1/21 13:27, Jianxiong Gao wrote:
>> Why is this setting being done and undone on each IO? Wouldn't it be
>> more efficient to set it once during device initialization?
>>
>> And more importantly, this isn't thread safe: one CPU may be setting the
>> device's dma alignment mask to 0 while another CPU is expecting it to be
>> NVME_CTRL_PAGE_SIZE - 1.
> I was having trouble getting the OS booted when setting it once during
> initialization. However when I rebased to the latest rc6 this morning it
> seems to be working with setting the mask on probe. I am still testing out
> and will appreciate any idea what may cause the nvme driver to fail
> with a single mask.
Based on the Keith's comment it needs to be completely avoided in hot path.
Did you get a chance to bisect the problem in the rc6 ? We need to know the
root cause otherwise it might happen again after we add this patch.
WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Jianxiong Gao <jxgao@google.com>, Keith Busch <kbusch@kernel.org>
Cc: "heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
Saravana Kannan <saravanak@google.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Marc Orr <marcorr@google.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"jroedel@suse.de" <jroedel@suse.de>,
Erdem Aktas <erdemaktas@google.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>
Subject: Re: [PATCH V2 3/3] Adding device_dma_parameters->offset_preserve_mask to NVMe driver.
Date: Mon, 1 Feb 2021 23:59:52 +0000 [thread overview]
Message-ID: <BYAPR04MB4965AAC6C59013D475093D9486B69@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: CAMGD6P1_cs1W8jMt7Sz6broDdnFNPrxbiZW-JZ+GAtg5aoTdOQ@mail.gmail.com
On 2/1/21 13:27, Jianxiong Gao wrote:
>> Why is this setting being done and undone on each IO? Wouldn't it be
>> more efficient to set it once during device initialization?
>>
>> And more importantly, this isn't thread safe: one CPU may be setting the
>> device's dma alignment mask to 0 while another CPU is expecting it to be
>> NVME_CTRL_PAGE_SIZE - 1.
> I was having trouble getting the OS booted when setting it once during
> initialization. However when I rebased to the latest rc6 this morning it
> seems to be working with setting the mask on probe. I am still testing out
> and will appreciate any idea what may cause the nvme driver to fail
> with a single mask.
Based on the Keith's comment it needs to be completely avoided in hot path.
Did you get a chance to bisect the problem in the rc6 ? We need to know the
root cause otherwise it might happen again after we add this patch.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Jianxiong Gao <jxgao@google.com>, Keith Busch <kbusch@kernel.org>
Cc: "heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
Saravana Kannan <saravanak@google.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Marc Orr <marcorr@google.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"jroedel@suse.de" <jroedel@suse.de>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V2 3/3] Adding device_dma_parameters->offset_preserve_mask to NVMe driver.
Date: Mon, 1 Feb 2021 23:59:52 +0000 [thread overview]
Message-ID: <BYAPR04MB4965AAC6C59013D475093D9486B69@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: CAMGD6P1_cs1W8jMt7Sz6broDdnFNPrxbiZW-JZ+GAtg5aoTdOQ@mail.gmail.com
On 2/1/21 13:27, Jianxiong Gao wrote:
>> Why is this setting being done and undone on each IO? Wouldn't it be
>> more efficient to set it once during device initialization?
>>
>> And more importantly, this isn't thread safe: one CPU may be setting the
>> device's dma alignment mask to 0 while another CPU is expecting it to be
>> NVME_CTRL_PAGE_SIZE - 1.
> I was having trouble getting the OS booted when setting it once during
> initialization. However when I rebased to the latest rc6 this morning it
> seems to be working with setting the mask on probe. I am still testing out
> and will appreciate any idea what may cause the nvme driver to fail
> with a single mask.
Based on the Keith's comment it needs to be completely avoided in hot path.
Did you get a chance to bisect the problem in the rc6 ? We need to know the
root cause otherwise it might happen again after we add this patch.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-02-02 0:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 18:30 [PATCH V2 0/3] SWIOTLB: Preserve swiotlb map offset when needed Jianxiong Gao
2021-02-01 18:30 ` Jianxiong Gao via iommu
2021-02-01 18:30 ` Jianxiong Gao
2021-02-01 18:30 ` [PATCH V2 1/3] Adding page_offset_mask to device_dma_parameters Jianxiong Gao
2021-02-01 18:30 ` Jianxiong Gao via iommu
2021-02-01 18:30 ` Jianxiong Gao
2021-02-01 18:30 ` [PATCH V2 2/3] Add swiotlb offset preserving mapping when dma_dma_parameters->page_offset_mask is non zero Jianxiong Gao
2021-02-01 18:30 ` Jianxiong Gao via iommu
2021-02-01 18:30 ` Jianxiong Gao
2021-02-01 18:30 ` [PATCH V2 3/3] Adding device_dma_parameters->offset_preserve_mask to NVMe driver Jianxiong Gao
2021-02-01 18:30 ` Jianxiong Gao via iommu
2021-02-01 18:30 ` Jianxiong Gao
2021-02-01 18:55 ` Andy Shevchenko
2021-02-01 18:55 ` Andy Shevchenko
2021-02-01 18:55 ` Andy Shevchenko
2021-02-01 19:35 ` Jianxiong Gao
2021-02-01 19:35 ` Jianxiong Gao via iommu
2021-02-01 19:35 ` Jianxiong Gao
2021-02-01 20:57 ` Keith Busch
2021-02-01 20:57 ` Keith Busch
2021-02-01 20:57 ` Keith Busch
2021-02-01 21:16 ` Jianxiong Gao via iommu
2021-02-01 21:22 ` Jianxiong Gao
2021-02-01 21:22 ` Jianxiong Gao via iommu
2021-02-01 21:22 ` Jianxiong Gao
2021-02-01 23:59 ` Chaitanya Kulkarni [this message]
2021-02-01 23:59 ` Chaitanya Kulkarni
2021-02-01 23:59 ` Chaitanya Kulkarni
2021-02-02 0:25 ` Jianxiong Gao
2021-02-02 0:25 ` Jianxiong Gao via iommu
2021-02-02 0:25 ` Jianxiong Gao
2021-02-02 11:21 ` Andy Shevchenko
2021-02-02 11:21 ` Andy Shevchenko
2021-02-02 11:21 ` Andy Shevchenko
2021-02-02 12:07 ` Robin Murphy
2021-02-02 12:07 ` Robin Murphy
2021-02-02 12:07 ` Robin Murphy
2021-02-03 13:37 ` Christoph Hellwig
2021-02-03 13:37 ` Christoph Hellwig
2021-02-03 13:37 ` Christoph Hellwig
2021-02-03 16:47 ` Jianxiong Gao
2021-02-03 16:47 ` Jianxiong Gao via iommu
2021-02-03 16:47 ` Jianxiong Gao
2021-02-02 11:53 ` [PATCH V2 0/3] SWIOTLB: Preserve swiotlb map offset when needed Greg KH
2021-02-02 11:53 ` Greg KH
2021-02-02 11:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965AAC6C59013D475093D9486B69@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@fb.com \
--cc=bgolaszewski@baylibre.com \
--cc=dan.j.williams@intel.com \
--cc=erdemaktas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=heikki.krogerus@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=jxgao@google.com \
--cc=kbusch@kernel.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=marcorr@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robin.murphy@arm.com \
--cc=sagi@grimberg.me \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.