From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Roy Shterman <roys@lightbitslabs.com>,
Solganik Alexander <sashas@lightbitslabs.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] nvme-tcp: fix error codes in nvme_tcp_setup_ctrl()
Date: Sat, 5 Jun 2021 18:38:16 +0000 [thread overview]
Message-ID: <BYAPR04MB4965D9BCCF0AF010D283986E863A9@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: YLtykIn+Or0l08oV@mwanda
On 6/5/21 05:49, Dan Carpenter wrote:
> These error paths currently return success but they should return
> -EOPNOTSUPP.
>
> Fixes: 73ffcefcfca0 ("nvme-tcp: check sgl supported by target")
> Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Roy Shterman <roys@lightbitslabs.com>,
Solganik Alexander <sashas@lightbitslabs.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] nvme-tcp: fix error codes in nvme_tcp_setup_ctrl()
Date: Sat, 5 Jun 2021 18:38:16 +0000 [thread overview]
Message-ID: <BYAPR04MB4965D9BCCF0AF010D283986E863A9@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: YLtykIn+Or0l08oV@mwanda
On 6/5/21 05:49, Dan Carpenter wrote:
> These error paths currently return success but they should return
> -EOPNOTSUPP.
>
> Fixes: 73ffcefcfca0 ("nvme-tcp: check sgl supported by target")
> Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-06-05 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 12:48 [PATCH] nvme-tcp: fix error codes in nvme_tcp_setup_ctrl() Dan Carpenter
2021-06-05 12:48 ` Dan Carpenter
2021-06-05 18:38 ` Chaitanya Kulkarni [this message]
2021-06-05 18:38 ` Chaitanya Kulkarni
2021-06-08 16:43 ` Christoph Hellwig
2021-06-08 16:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965D9BCCF0AF010D283986E863A9@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=roys@lightbitslabs.com \
--cc=sagi@grimberg.me \
--cc=sashas@lightbitslabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.