[PATCH] nvme-cli: add default value for nsid of write-zeroes

[PATCH] nvme-cli: add default value for nsid of write-zeroes

[Minwoo Im]

-L 3772,3778 is doing the default value check and update the nsid if
it's not given by the input:

	if (!cfg.namespace_id) {
		cfg.namespace_id = get_nsid(fd);
		if (cfg.namespace_id == 0) {
			err = EINVAL;
			goto close_fd;
		}
	}

This patch adds nsid default value to zero for the case user does not
give the nsid input.

Cc: Keith Busch <kbusch at kernel.org>
Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
---
 nvme.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nvme.c b/nvme.c
index 9819fcb..a7a96a1 100644
--- a/nvme.c
+++ b/nvme.c
@@ -3731,6 +3731,7 @@ static int write_zeroes(int argc, char **argv, struct command *cmd, struct plugi
 
 	struct config cfg = {
 		.start_block     = 0,
+		.namespace_id    = 0,
 		.block_count     = 0,
 		.prinfo          = 0,
 		.ref_tag         = 0,
-- 
2.21.0

[PATCH] nvme-cli: add default value for nsid of write-zeroes

[Sagi Grimberg]

> diff --git a/nvme.c b/nvme.c
> index 9819fcb..a7a96a1 100644
> --- a/nvme.c
> +++ b/nvme.c
> @@ -3731,6 +3731,7 @@ static int write_zeroes(int argc, char **argv, struct command *cmd, struct plugi
>   
>   	struct config cfg = {
>   		.start_block     = 0,
> +		.namespace_id    = 0,

This is implicitly set to 0. You should mention that you add this just
for clarification, and its not fixing a bug.

[PATCH] nvme-cli: add default value for nsid of write-zeroes

[Chaitanya Kulkarni]

On 6/2/19 12:12 AM, Sagi Grimberg wrote:
>> diff --git a/nvme.c b/nvme.c
>> index 9819fcb..a7a96a1 100644
>> --- a/nvme.c
>> +++ b/nvme.c
>> @@ -3731,6 +3731,7 @@ static int write_zeroes(int argc, char **argv, struct command *cmd, struct plugi
>>   
>>   	struct config cfg = {
>>   		.start_block     = 0,
>> +		.namespace_id    = 0,
> This is implicitly set to 0. You should mention that you add this just
> for clarification, and its not fixing a bug.
Is this breaking any testcases or expected behavior ?
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
>

[PATCH] nvme-cli: add default value for nsid of write-zeroes

[Minwoo Im]

> This is implicitly set to 0. You should mention that you add this just
> for clarification, and its not fixing a bug.

Hi Sagi,

Thanks for pointing it out.  I should have made the commit more in detail.
As you mentioned, the ommitted field members are implicitly initialized to
zero by the C99.

I think it can be ignored here.

Thanks :)

[PATCH] nvme-cli: add default value for nsid of write-zeroes

[Minwoo Im]

> Is this breaking any testcases or expected behavior ?

Hi Chaitanya,

Thanks for your question.  As I replied to Sagi, This patch can be ignored.
Sorry for making confusions here.  This patch has never caused any
issues ever.

Thanks,