* [PATCH] block: mark zone-mgmt bios with REQ_SYNC
@ 2019-12-19 6:14 Chaitanya Kulkarni
2019-12-19 6:57 ` Damien Le Moal
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2019-12-19 6:14 UTC (permalink / raw)
To: linux-block; +Cc: damien.lamoal, axboe, Chaitanya Kulkarni, Damien Le Moal
This patch marks the zone-mgmt bios with REQ_SYNC flag.
Suggested-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
block/blk-zoned.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index d00fcfd71dfe..05741c6f618b 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -198,7 +198,7 @@ int blkdev_zone_mgmt(struct block_device *bdev, enum req_opf op,
break;
}
- bio->bi_opf = op;
+ bio->bi_opf = op | REQ_SYNC;
bio->bi_iter.bi_sector = sector;
sector += zone_sectors;
--
2.22.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] block: mark zone-mgmt bios with REQ_SYNC
2019-12-19 6:14 [PATCH] block: mark zone-mgmt bios with REQ_SYNC Chaitanya Kulkarni
@ 2019-12-19 6:57 ` Damien Le Moal
2019-12-19 8:27 ` Bob Liu
2019-12-19 12:47 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Damien Le Moal @ 2019-12-19 6:57 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-block; +Cc: damien.lamoal, axboe
On 2019/12/19 15:14, Chaitanya Kulkarni wrote:
> This patch marks the zone-mgmt bios with REQ_SYNC flag.
>
> Suggested-by: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> block/blk-zoned.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index d00fcfd71dfe..05741c6f618b 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -198,7 +198,7 @@ int blkdev_zone_mgmt(struct block_device *bdev, enum req_opf op,
> break;
> }
>
> - bio->bi_opf = op;
> + bio->bi_opf = op | REQ_SYNC;
> bio->bi_iter.bi_sector = sector;
> sector += zone_sectors;
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: mark zone-mgmt bios with REQ_SYNC
2019-12-19 6:14 [PATCH] block: mark zone-mgmt bios with REQ_SYNC Chaitanya Kulkarni
2019-12-19 6:57 ` Damien Le Moal
@ 2019-12-19 8:27 ` Bob Liu
2019-12-19 12:47 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Bob Liu @ 2019-12-19 8:27 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-block; +Cc: damien.lamoal, axboe, Damien Le Moal
On 12/19/19 2:14 PM, Chaitanya Kulkarni wrote:
> This patch marks the zone-mgmt bios with REQ_SYNC flag.
>
> Suggested-by: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
Reviewed-by: Bob Liu <bob.liu@oracle.com>
> block/blk-zoned.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index d00fcfd71dfe..05741c6f618b 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -198,7 +198,7 @@ int blkdev_zone_mgmt(struct block_device *bdev, enum req_opf op,
> break;
> }
>
> - bio->bi_opf = op;
> + bio->bi_opf = op | REQ_SYNC;
> bio->bi_iter.bi_sector = sector;
> sector += zone_sectors;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: mark zone-mgmt bios with REQ_SYNC
2019-12-19 6:14 [PATCH] block: mark zone-mgmt bios with REQ_SYNC Chaitanya Kulkarni
2019-12-19 6:57 ` Damien Le Moal
2019-12-19 8:27 ` Bob Liu
@ 2019-12-19 12:47 ` Jens Axboe
2020-01-08 22:38 ` Chaitanya Kulkarni
2 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2019-12-19 12:47 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-block; +Cc: damien.lamoal, Damien Le Moal
On 12/18/19 11:14 PM, Chaitanya Kulkarni wrote:
> This patch marks the zone-mgmt bios with REQ_SYNC flag.
This needs a much better commit message, you're not telling me
anything I can't see by reading the patch itself. A good commit
message contains the reason for the patch, there's no justification
right now.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: mark zone-mgmt bios with REQ_SYNC
2019-12-19 12:47 ` Jens Axboe
@ 2020-01-08 22:38 ` Chaitanya Kulkarni
0 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2020-01-08 22:38 UTC (permalink / raw)
To: Jens Axboe, linux-block
Jens,
I sent out a new version, can you please take a look and
let me know if you are happy with the commit log ?
On 12/19/2019 04:47 AM, Jens Axboe wrote:
> On 12/18/19 11:14 PM, Chaitanya Kulkarni wrote:
>> >This patch marks the zone-mgmt bios with REQ_SYNC flag.
> This needs a much better commit message, you're not telling me
> anything I can't see by reading the patch itself. A good commit
> message contains the reason for the patch, there's no justification
> right now.
>
> -- Jens Axboe
-ck
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-08 22:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 6:14 [PATCH] block: mark zone-mgmt bios with REQ_SYNC Chaitanya Kulkarni
2019-12-19 6:57 ` Damien Le Moal
2019-12-19 8:27 ` Bob Liu
2019-12-19 12:47 ` Jens Axboe
2020-01-08 22:38 ` Chaitanya Kulkarni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.