* [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow.
@ 2022-10-24 6:40 Lee Shawn C
2022-10-24 7:39 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
` (9 more replies)
0 siblings, 10 replies; 24+ messages in thread
From: Lee Shawn C @ 2022-10-24 6:40 UTC (permalink / raw)
To: intel-gfx
Driver always apply panel power off cycle delay before eDP enable.
If eDP display was enabled at pre-os stage, driver would always
trigger modeset to optimize cdclk setting after boot into kernel.
So last_power_on and last_backlight_off value will be updated.
We can check last_power_on and last_backlight_off before insert
panel power cycle delay. If these values are the same, it means eDP
was off until now and driver should bypass this delay to save
some times to speed up eDP power on sequence.
Cc: Shankar Uma <uma.shankar@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_pps.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
index 21944f5bf3a8..f3485a4fbfd0 100644
--- a/drivers/gpu/drm/i915/display/intel_pps.c
+++ b/drivers/gpu/drm/i915/display/intel_pps.c
@@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
ktime_t panel_power_on_time;
s64 panel_power_off_duration;
+ /* When last_power_on equal to last_backlight_off, it means driver did not
+ * turn on or off eDP panel so far. So we can bypass power cycle delay to
+ * save some times here.
+ */
+ if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
+ return;
+
drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
/* take the difference of current time and panel power off time
@@ -1098,9 +1105,11 @@ bool intel_pps_have_panel_power_or_vdd(struct intel_dp *intel_dp)
static void pps_init_timestamps(struct intel_dp *intel_dp)
{
+ unsigned long tmp_jiffies = jiffies;
+
intel_dp->pps.panel_power_off_time = ktime_get_boottime();
- intel_dp->pps.last_power_on = jiffies;
- intel_dp->pps.last_backlight_off = jiffies;
+ intel_dp->pps.last_power_on = tmp_jiffies;
+ intel_dp->pps.last_backlight_off = tmp_jiffies;
}
static void
--
2.17.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pps: improve eDP power on flow.
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
@ 2022-10-24 7:39 ` Patchwork
2022-10-24 13:16 ` [Intel-gfx] [PATCH] " Ville Syrjälä
` (8 subsequent siblings)
9 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2022-10-24 7:39 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11418 bytes --]
== Series Details ==
Series: drm/i915/pps: improve eDP power on flow.
URL : https://patchwork.freedesktop.org/series/110038/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12280 -> Patchwork_110038v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_110038v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_110038v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/index.html
Participating hosts (42 -> 38)
------------------------------
Missing (4): fi-ctg-p8600 fi-bdw-gvtdvm fi-bdw-samus fi-tgl-dsi
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_110038v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hugepages:
- fi-cfl-8109u: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-cfl-8109u/igt@i915_selftest@live@hugepages.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-cfl-8109u/igt@i915_selftest@live@hugepages.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@hugepages:
- {fi-ehl-2}: [PASS][3] -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-ehl-2/igt@i915_selftest@live@hugepages.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-ehl-2/igt@i915_selftest@live@hugepages.html
Known issues
------------
Here are the changes found in Patchwork_110038v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-bsw-nick: NOTRUN -> [SKIP][5] ([fdo#109271]) +32 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-bsw-nick/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-kbl-x1275: NOTRUN -> [SKIP][6] ([fdo#109271])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-kbl-x1275/igt@i915_suspend@basic-s3-without-i915.html
- fi-bdw-5557u: [PASS][7] -> [INCOMPLETE][8] ([i915#146])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-ivb-3770: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-ivb-3770/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-kbl-x1275: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-kbl-x1275/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-ilk-650: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-ilk-650/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-adl-ddr5: NOTRUN -> [SKIP][12] ([fdo#111827])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-adl-ddr5/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-rkl-guc: NOTRUN -> [SKIP][13] ([fdo#111827])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-rkl-guc/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-bsw-nick: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-bsw-nick/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [PASS][15] -> [FAIL][16] ([i915#6298])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
* igt@runner@aborted:
- fi-cfl-8109u: NOTRUN -> [FAIL][17] ([i915#4312])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-cfl-8109u/igt@runner@aborted.html
#### Possible fixes ####
* igt@fbdev@read:
- {bat-rpls-2}: [SKIP][18] ([i915#2582]) -> [PASS][19] +4 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/bat-rpls-2/igt@fbdev@read.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/bat-rpls-2/igt@fbdev@read.html
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][20] ([i915#7229]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_parallel@engines@contexts:
- fi-bsw-nick: [INCOMPLETE][22] -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-bsw-nick/igt@gem_exec_parallel@engines@contexts.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-bsw-nick/igt@gem_exec_parallel@engines@contexts.html
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][24] ([i915#2867]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_exec_suspend@basic-s3@smem:
- fi-ilk-650: [DMESG-WARN][26] -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-ilk-650/igt@gem_exec_suspend@basic-s3@smem.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-ilk-650/igt@gem_exec_suspend@basic-s3@smem.html
- fi-ivb-3770: [DMESG-WARN][28] -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-ivb-3770/igt@gem_exec_suspend@basic-s3@smem.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-ivb-3770/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_module_load@reload:
- {bat-rpls-2}: [DMESG-WARN][30] ([i915#5537]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/bat-rpls-2/igt@i915_module_load@reload.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/bat-rpls-2/igt@i915_module_load@reload.html
* igt@i915_selftest@live@gt_pm:
- {fi-jsl-1}: [DMESG-FAIL][32] ([i915#1886]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-jsl-1/igt@i915_selftest@live@gt_pm.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-jsl-1/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hugepages:
- fi-kbl-x1275: [DMESG-FAIL][34] -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-kbl-x1275/igt@i915_selftest@live@hugepages.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-kbl-x1275/igt@i915_selftest@live@hugepages.html
- {bat-adln-1}: [DMESG-FAIL][36] -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/bat-adln-1/igt@i915_selftest@live@hugepages.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/bat-adln-1/igt@i915_selftest@live@hugepages.html
- fi-adl-ddr5: [DMESG-FAIL][38] -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-adl-ddr5/igt@i915_selftest@live@hugepages.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-adl-ddr5/igt@i915_selftest@live@hugepages.html
- fi-rkl-guc: [DMESG-FAIL][40] -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/fi-rkl-guc/igt@i915_selftest@live@hugepages.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/fi-rkl-guc/igt@i915_selftest@live@hugepages.html
* igt@i915_selftest@live@mman:
- {bat-rpls-1}: [INCOMPLETE][42] ([i915#6794]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/bat-rpls-1/igt@i915_selftest@live@mman.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/bat-rpls-1/igt@i915_selftest@live@mman.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][44] ([i915#4983] / [i915#5828]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/bat-rpls-2/igt@i915_selftest@live@reset.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- {bat-rplp-1}: [DMESG-FAIL][46] ([i915#6367]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12280/bat-rplp-1/igt@i915_selftest@live@slpc.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/bat-rplp-1/igt@i915_selftest@live@slpc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6559]: https://gitlab.freedesktop.org/drm/intel/issues/6559
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
Build changes
-------------
* Linux: CI_DRM_12280 -> Patchwork_110038v1
CI-20190529: 20190529
CI_DRM_12280: 7bb7f55322b39b7e263adc6c76c1a34e292e4a8e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7022: d73b21e653555d2e0370789071799aa0037049c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110038v1: 7bb7f55322b39b7e263adc6c76c1a34e292e4a8e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
4a3b940bf904 drm/i915/pps: improve eDP power on flow.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v1/index.html
[-- Attachment #2: Type: text/html, Size: 13198 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow.
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
2022-10-24 7:39 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2022-10-24 13:16 ` Ville Syrjälä
2022-10-24 13:47 ` Lee, Shawn C
2022-10-24 14:06 ` [Intel-gfx] [v2] " Lee Shawn C
` (7 subsequent siblings)
9 siblings, 1 reply; 24+ messages in thread
From: Ville Syrjälä @ 2022-10-24 13:16 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
On Mon, Oct 24, 2022 at 02:40:04PM +0800, Lee Shawn C wrote:
> Driver always apply panel power off cycle delay before eDP enable.
> If eDP display was enabled at pre-os stage, driver would always
> trigger modeset to optimize cdclk setting after boot into kernel.
> So last_power_on and last_backlight_off value will be updated.
>
> We can check last_power_on and last_backlight_off before insert
> panel power cycle delay. If these values are the same, it means eDP
> was off until now and driver should bypass this delay to save
> some times to speed up eDP power on sequence.
>
> Cc: Shankar Uma <uma.shankar@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_pps.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
> index 21944f5bf3a8..f3485a4fbfd0 100644
> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
> ktime_t panel_power_on_time;
> s64 panel_power_off_duration;
>
> + /* When last_power_on equal to last_backlight_off, it means driver did not
> + * turn on or off eDP panel so far.
But someone else may have turned it off just before we were handed
control, we have no idea. The pessimistic estimate is the safe one.
Also I don't understand what this has to do with the story in
the comit message. In that story you say eDP was already on,
so the power cycle delay is not relevant at all. /me confused.
> So we can bypass power cycle delay to
> + * save some times here.
> + */
> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
> + return;
> +
> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
>
> /* take the difference of current time and panel power off time
> @@ -1098,9 +1105,11 @@ bool intel_pps_have_panel_power_or_vdd(struct intel_dp *intel_dp)
>
> static void pps_init_timestamps(struct intel_dp *intel_dp)
> {
> + unsigned long tmp_jiffies = jiffies;
> +
> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
> - intel_dp->pps.last_power_on = jiffies;
> - intel_dp->pps.last_backlight_off = jiffies;
> + intel_dp->pps.last_power_on = tmp_jiffies;
> + intel_dp->pps.last_backlight_off = tmp_jiffies;
> }
>
> static void
> --
> 2.17.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow.
2022-10-24 13:16 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2022-10-24 13:47 ` Lee, Shawn C
2022-10-24 14:21 ` Ville Syrjälä
0 siblings, 1 reply; 24+ messages in thread
From: Lee, Shawn C @ 2022-10-24 13:47 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Monday, October 24, 2022 9:17 PM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>On Mon, Oct 24, 2022 at 02:40:04PM +0800, Lee Shawn C wrote:
>> Driver always apply panel power off cycle delay before eDP enable.
>> If eDP display was enabled at pre-os stage, driver would always
>> trigger modeset to optimize cdclk setting after boot into kernel.
>> So last_power_on and last_backlight_off value will be updated.
>>
>> We can check last_power_on and last_backlight_off before insert panel
>> power cycle delay. If these values are the same, it means eDP was off
>> until now and driver should bypass this delay to save some times to
>> speed up eDP power on sequence.
>>
>> Cc: Shankar Uma <uma.shankar@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_pps.c | 13 +++++++++++--
>> 1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
>> b/drivers/gpu/drm/i915/display/intel_pps.c
>> index 21944f5bf3a8..f3485a4fbfd0 100644
>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
>> ktime_t panel_power_on_time;
>> s64 panel_power_off_duration;
>>
>> + /* When last_power_on equal to last_backlight_off, it means driver did not
>> + * turn on or off eDP panel so far.
>
>But someone else may have turned it off just before we were handed control, we have no idea. The pessimistic estimate is the safe one.
Thanks! It looks to me this situation should not be happpened. Right?
>
>Also I don't understand what this has to do with the story in the comit message. In that story you say eDP was already on, so the power cycle delay is not relevant at all. /me confused.
>
I will modify commit messages and send patch v2 later.
Best regards,
Shawn
>> So we can bypass power cycle delay to
>> + * save some times here.
>> + */
>> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
>> + return;
>> +
>> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
>>
>> /* take the difference of current time and panel power off time @@
>> -1098,9 +1105,11 @@ bool intel_pps_have_panel_power_or_vdd(struct
>> intel_dp *intel_dp)
>>
>> static void pps_init_timestamps(struct intel_dp *intel_dp) {
>> + unsigned long tmp_jiffies = jiffies;
>> +
>> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
>> - intel_dp->pps.last_power_on = jiffies;
>> - intel_dp->pps.last_backlight_off = jiffies;
>> + intel_dp->pps.last_power_on = tmp_jiffies;
>> + intel_dp->pps.last_backlight_off = tmp_jiffies;
>> }
>>
>> static void
>> --
>> 2.17.1
>
>--
>Ville Syrjälä
>Intel
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
2022-10-24 7:39 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-10-24 13:16 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2022-10-24 14:06 ` Lee Shawn C
2022-11-01 9:53 ` Jani Nikula
2022-10-24 17:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pps: improve eDP power on flow. (rev2) Patchwork
` (6 subsequent siblings)
9 siblings, 1 reply; 24+ messages in thread
From: Lee Shawn C @ 2022-10-24 14:06 UTC (permalink / raw)
To: intel-gfx
A panel power off cycle delay always append before turn eDP on.
Driver should check last_power_on and last_backlight_off before
insert this delay. If these values are the same, it means eDP
was off until now and driver can bypass power off cycle delay
to save some times to speed up eDP power on sequence.
v2: fix commit messages
Cc: Shankar Uma <uma.shankar@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_pps.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
index 21944f5bf3a8..290473ec70d5 100644
--- a/drivers/gpu/drm/i915/display/intel_pps.c
+++ b/drivers/gpu/drm/i915/display/intel_pps.c
@@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
ktime_t panel_power_on_time;
s64 panel_power_off_duration;
+ /* When last_power_on equal to last_backlight_off, it means driver did not
+ * turn on or off eDP panel so far. So we can bypass power cycle delay to
+ * save some times here.
+ */
+ if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
+ return;
+
drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
/* take the difference of current time and panel power off time
@@ -1100,7 +1107,7 @@ static void pps_init_timestamps(struct intel_dp *intel_dp)
{
intel_dp->pps.panel_power_off_time = ktime_get_boottime();
intel_dp->pps.last_power_on = jiffies;
- intel_dp->pps.last_backlight_off = jiffies;
+ intel_dp->pps.last_backlight_off = intel_dp->pps.last_power_on;
}
static void
--
2.17.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow.
2022-10-24 13:47 ` Lee, Shawn C
@ 2022-10-24 14:21 ` Ville Syrjälä
0 siblings, 0 replies; 24+ messages in thread
From: Ville Syrjälä @ 2022-10-24 14:21 UTC (permalink / raw)
To: 20221024064004.1879-1-shawn.c.lee; +Cc: intel-gfx
On Mon, Oct 24, 2022 at 01:47:56PM +0000, Lee, Shawn C wrote:
>
> On Monday, October 24, 2022 9:17 PM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> >On Mon, Oct 24, 2022 at 02:40:04PM +0800, Lee Shawn C wrote:
> >> Driver always apply panel power off cycle delay before eDP enable.
> >> If eDP display was enabled at pre-os stage, driver would always
> >> trigger modeset to optimize cdclk setting after boot into kernel.
> >> So last_power_on and last_backlight_off value will be updated.
> >>
> >> We can check last_power_on and last_backlight_off before insert panel
> >> power cycle delay. If these values are the same, it means eDP was off
> >> until now and driver should bypass this delay to save some times to
> >> speed up eDP power on sequence.
> >>
> >> Cc: Shankar Uma <uma.shankar@intel.com>
> >> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_pps.c | 13 +++++++++++--
> >> 1 file changed, 11 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
> >> b/drivers/gpu/drm/i915/display/intel_pps.c
> >> index 21944f5bf3a8..f3485a4fbfd0 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> >> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
> >> ktime_t panel_power_on_time;
> >> s64 panel_power_off_duration;
> >>
> >> + /* When last_power_on equal to last_backlight_off, it means driver did not
> >> + * turn on or off eDP panel so far.
> >
> >But someone else may have turned it off just before we were handed control, we have no idea. The pessimistic estimate is the safe one.
>
> Thanks! It looks to me this situation should not be happpened. Right?
What situation? We have no idea when the panel was powered off, so we
have to make a pessimistic estimate.
>
> >
> >Also I don't understand what this has to do with the story in the comit message. In that story you say eDP was already on, so the power cycle delay is not relevant at all. /me confused.
> >
>
> I will modify commit messages and send patch v2 later.
>
> Best regards,
> Shawn
>
> >> So we can bypass power cycle delay to
> >> + * save some times here.
> >> + */
> >> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
> >> + return;
> >> +
> >> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
> >>
> >> /* take the difference of current time and panel power off time @@
> >> -1098,9 +1105,11 @@ bool intel_pps_have_panel_power_or_vdd(struct
> >> intel_dp *intel_dp)
> >>
> >> static void pps_init_timestamps(struct intel_dp *intel_dp) {
> >> + unsigned long tmp_jiffies = jiffies;
> >> +
> >> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
> >> - intel_dp->pps.last_power_on = jiffies;
> >> - intel_dp->pps.last_backlight_off = jiffies;
> >> + intel_dp->pps.last_power_on = tmp_jiffies;
> >> + intel_dp->pps.last_backlight_off = tmp_jiffies;
> >> }
> >>
> >> static void
> >> --
> >> 2.17.1
> >
> >--
> >Ville Syrjälä
> >Intel
> >
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pps: improve eDP power on flow. (rev2)
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
` (2 preceding siblings ...)
2022-10-24 14:06 ` [Intel-gfx] [v2] " Lee Shawn C
@ 2022-10-24 17:33 ` Patchwork
2022-11-03 0:40 ` [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow Lee Shawn C
` (5 subsequent siblings)
9 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2022-10-24 17:33 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10794 bytes --]
== Series Details ==
Series: drm/i915/pps: improve eDP power on flow. (rev2)
URL : https://patchwork.freedesktop.org/series/110038/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12285 -> Patchwork_110038v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_110038v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_110038v2, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/index.html
Participating hosts (43 -> 38)
------------------------------
Missing (5): fi-rkl-11600 bat-dg1-5 fi-ctg-p8600 fi-kbl-8809g fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_110038v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hugepages:
- fi-adl-ddr5: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-adl-ddr5/igt@i915_selftest@live@hugepages.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-adl-ddr5/igt@i915_selftest@live@hugepages.html
- fi-rkl-guc: [PASS][3] -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-rkl-guc/igt@i915_selftest@live@hugepages.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-rkl-guc/igt@i915_selftest@live@hugepages.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@hugepages:
- {fi-ehl-2}: [PASS][5] -> [DMESG-FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-ehl-2/igt@i915_selftest@live@hugepages.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-ehl-2/igt@i915_selftest@live@hugepages.html
- {fi-jsl-1}: [PASS][7] -> [DMESG-FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-jsl-1/igt@i915_selftest@live@hugepages.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-jsl-1/igt@i915_selftest@live@hugepages.html
Known issues
------------
Here are the changes found in Patchwork_110038v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][9] -> [FAIL][10] ([i915#7229])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@gem_lmem_swapping@random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][11] ([i915#4613]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-icl-u2/igt@gem_lmem_swapping@random-engines.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-kbl-x1275: NOTRUN -> [SKIP][12] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-kbl-x1275/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-x1275: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-kbl-x1275/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-icl-u2: NOTRUN -> [SKIP][14] ([fdo#111827])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [PASS][15] -> [FAIL][16] ([i915#6298])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][17] ([fdo#109295] / [i915#3301])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-icl-u2/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-adl-ddr5: NOTRUN -> [FAIL][18] ([i915#4312])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-adl-ddr5/igt@runner@aborted.html
- fi-rkl-guc: NOTRUN -> [FAIL][19] ([i915#4312])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-rkl-guc/igt@runner@aborted.html
#### Possible fixes ####
* igt@fbdev@read:
- {bat-rpls-2}: [SKIP][20] ([i915#2582]) -> [PASS][21] +4 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/bat-rpls-2/igt@fbdev@read.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/bat-rpls-2/igt@fbdev@read.html
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][22] ([i915#2867]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-icl-u2: [DMESG-WARN][24] ([i915#4890]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-icl-u2/igt@i915_pm_rpm@basic-pci-d3-state.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-icl-u2/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [DMESG-FAIL][26] ([i915#62]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@guc_multi_lrc:
- fi-cfl-8109u: [DMESG-WARN][28] ([i915#5904] / [i915#7174]) -> [PASS][29] +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-cfl-8109u/igt@i915_selftest@live@guc_multi_lrc.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-cfl-8109u/igt@i915_selftest@live@guc_multi_lrc.html
* igt@i915_selftest@live@hugepages:
- fi-kbl-x1275: [DMESG-FAIL][30] -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-kbl-x1275/igt@i915_selftest@live@hugepages.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-kbl-x1275/igt@i915_selftest@live@hugepages.html
- {bat-adln-1}: [DMESG-FAIL][32] -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/bat-adln-1/igt@i915_selftest@live@hugepages.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/bat-adln-1/igt@i915_selftest@live@hugepages.html
- {bat-jsl-1}: [DMESG-FAIL][34] -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/bat-jsl-1/igt@i915_selftest@live@hugepages.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/bat-jsl-1/igt@i915_selftest@live@hugepages.html
- {bat-rpls-1}: [DMESG-FAIL][36] -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/bat-rpls-1/igt@i915_selftest@live@hugepages.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/bat-rpls-1/igt@i915_selftest@live@hugepages.html
* igt@i915_selftest@live@late_gt_pm:
- fi-cfl-8109u: [DMESG-WARN][38] ([i915#5904]) -> [PASS][39] +27 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8109u: [DMESG-WARN][40] ([i915#5904] / [i915#62]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-WARN][42] ([i915#62]) -> [PASS][43] +13 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12285/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4890]: https://gitlab.freedesktop.org/drm/intel/issues/4890
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7174]: https://gitlab.freedesktop.org/drm/intel/issues/7174
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
Build changes
-------------
* Linux: CI_DRM_12285 -> Patchwork_110038v2
CI-20190529: 20190529
CI_DRM_12285: 92b40b6e1d54d68a766c1545b9ace3e2eccad94a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7023: 229bb0accbb7c8cedcc8d9256ad2b6683c9f161a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110038v2: 92b40b6e1d54d68a766c1545b9ace3e2eccad94a @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
18a0718215e6 drm/i915/pps: improve eDP power on flow
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v2/index.html
[-- Attachment #2: Type: text/html, Size: 12286 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow
2022-10-24 14:06 ` [Intel-gfx] [v2] " Lee Shawn C
@ 2022-11-01 9:53 ` Jani Nikula
2022-11-01 10:50 ` Lee, Shawn C
0 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2022-11-01 9:53 UTC (permalink / raw)
To: Lee Shawn C, intel-gfx
On Mon, 24 Oct 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> A panel power off cycle delay always append before turn eDP on.
> Driver should check last_power_on and last_backlight_off before
> insert this delay. If these values are the same, it means eDP
> was off until now and driver can bypass power off cycle delay
> to save some times to speed up eDP power on sequence.
>
> v2: fix commit messages
There are more changes here than what the changelog says, but the
previous review comments were not answered [1].
BR,
Jani.
[1] https://lore.kernel.org/r/Y1afUdAwfVTACJoK@intel.com
>
> Cc: Shankar Uma <uma.shankar@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_pps.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
> index 21944f5bf3a8..290473ec70d5 100644
> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
> ktime_t panel_power_on_time;
> s64 panel_power_off_duration;
>
> + /* When last_power_on equal to last_backlight_off, it means driver did not
> + * turn on or off eDP panel so far. So we can bypass power cycle delay to
> + * save some times here.
> + */
> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
> + return;
> +
> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
>
> /* take the difference of current time and panel power off time
> @@ -1100,7 +1107,7 @@ static void pps_init_timestamps(struct intel_dp *intel_dp)
> {
> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
> intel_dp->pps.last_power_on = jiffies;
> - intel_dp->pps.last_backlight_off = jiffies;
> + intel_dp->pps.last_backlight_off = intel_dp->pps.last_power_on;
> }
>
> static void
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow
2022-11-01 9:53 ` Jani Nikula
@ 2022-11-01 10:50 ` Lee, Shawn C
2022-11-01 13:43 ` Jani Nikula
2022-11-01 14:40 ` Lee, Shawn C
0 siblings, 2 replies; 24+ messages in thread
From: Lee, Shawn C @ 2022-11-01 10:50 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On Tuesday, November 1, 2022 5:53 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>On Mon, 24 Oct 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>> A panel power off cycle delay always append before turn eDP on.
>> Driver should check last_power_on and last_backlight_off before insert
>> this delay. If these values are the same, it means eDP was off until
>> now and driver can bypass power off cycle delay to save some times to
>> speed up eDP power on sequence.
>>
>> v2: fix commit messages
>
>There are more changes here than what the changelog says, but the previous review comments were not answered [1].
>
I'm sorry that lose the question in [1].
"But someone else may have turned it off just before we were handed control, we have no idea."
This is the situation from Ville's comment. Agree that we don't know when panel will be powered off.
In my opinion, eDP panel should not be turned off before i915 take it over. If it was turned on or off by standard contorl (ex: modeset).
last_power_on and last_backlight_off would not be the same. So this change should be safe.
Best regards,
Shawn
>
>BR,
>Jani.
>
>
>[1] https://lore.kernel.org/r/Y1afUdAwfVTACJoK@intel.com
>
>>
>> Cc: Shankar Uma <uma.shankar@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_pps.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
>> b/drivers/gpu/drm/i915/display/intel_pps.c
>> index 21944f5bf3a8..290473ec70d5 100644
>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
>> ktime_t panel_power_on_time;
>> s64 panel_power_off_duration;
>>
>> + /* When last_power_on equal to last_backlight_off, it means driver did not
>> + * turn on or off eDP panel so far. So we can bypass power cycle delay to
>> + * save some times here.
>> + */
>> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
>> + return;
>> +
>> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
>>
>> /* take the difference of current time and panel power off time @@
>> -1100,7 +1107,7 @@ static void pps_init_timestamps(struct intel_dp
>> *intel_dp) {
>> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
>> intel_dp->pps.last_power_on = jiffies;
>> - intel_dp->pps.last_backlight_off = jiffies;
>> + intel_dp->pps.last_backlight_off = intel_dp->pps.last_power_on;
>> }
>>
>> static void
>
>--
>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow
2022-11-01 10:50 ` Lee, Shawn C
@ 2022-11-01 13:43 ` Jani Nikula
2022-11-01 14:40 ` Lee, Shawn C
1 sibling, 0 replies; 24+ messages in thread
From: Jani Nikula @ 2022-11-01 13:43 UTC (permalink / raw)
To: 20221024140607.25271-1-shawn.c.lee, intel-gfx
On Tue, 01 Nov 2022, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> On Tuesday, November 1, 2022 5:53 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>On Mon, 24 Oct 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>>> A panel power off cycle delay always append before turn eDP on.
>>> Driver should check last_power_on and last_backlight_off before insert
>>> this delay. If these values are the same, it means eDP was off until
>>> now and driver can bypass power off cycle delay to save some times to
>>> speed up eDP power on sequence.
>>>
>>> v2: fix commit messages
>>
>>There are more changes here than what the changelog says, but the previous review comments were not answered [1].
>>
>
> I'm sorry that lose the question in [1].
>
> "But someone else may have turned it off just before we were handed control, we have no idea."
> This is the situation from Ville's comment. Agree that we don't know when panel will be powered off.
> In my opinion, eDP panel should not be turned off before i915 take it over. If it was turned on or off by standard contorl (ex: modeset).
> last_power_on and last_backlight_off would not be the same. So this change should be safe.
I think it's pretty much a hard requirement we respect the panel delays
at i915 probe. If we don't know, we don't know, and we can't make
assumptions.
If the goal is to speed up boot, you should ensure 1) the pre-os enables
the display, and 2) i915 can take over the display without a modeset and
a panel power cycle.
BR,
Jani.
>
> Best regards,
> Shawn
>
>>
>>BR,
>>Jani.
>>
>>
>>[1] https://lore.kernel.org/r/Y1afUdAwfVTACJoK@intel.com
>>
>>>
>>> Cc: Shankar Uma <uma.shankar@intel.com>
>>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_pps.c | 9 ++++++++-
>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
>>> b/drivers/gpu/drm/i915/display/intel_pps.c
>>> index 21944f5bf3a8..290473ec70d5 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>>> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
>>> ktime_t panel_power_on_time;
>>> s64 panel_power_off_duration;
>>>
>>> + /* When last_power_on equal to last_backlight_off, it means driver did not
>>> + * turn on or off eDP panel so far. So we can bypass power cycle delay to
>>> + * save some times here.
>>> + */
>>> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
>>> + return;
>>> +
>>> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
>>>
>>> /* take the difference of current time and panel power off time @@
>>> -1100,7 +1107,7 @@ static void pps_init_timestamps(struct intel_dp
>>> *intel_dp) {
>>> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
>>> intel_dp->pps.last_power_on = jiffies;
>>> - intel_dp->pps.last_backlight_off = jiffies;
>>> + intel_dp->pps.last_backlight_off = intel_dp->pps.last_power_on;
>>> }
>>>
>>> static void
>>
>>--
>>Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow
2022-11-01 10:50 ` Lee, Shawn C
2022-11-01 13:43 ` Jani Nikula
@ 2022-11-01 14:40 ` Lee, Shawn C
2022-11-01 14:42 ` Lee, Shawn C
2022-11-02 10:19 ` Jani Nikula
1 sibling, 2 replies; 24+ messages in thread
From: Lee, Shawn C @ 2022-11-01 14:40 UTC (permalink / raw)
To: 20221024140607.25271-1-shawn.c.lee, Jani Nikula, intel-gfx
On Tue, Nov. 1, 2022, 1:43 p.m, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>On Tue, 01 Nov 2022, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
>> On Tuesday, November 1, 2022 5:53 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>>On Mon, 24 Oct 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>>>> A panel power off cycle delay always append before turn eDP on.
>>>> Driver should check last_power_on and last_backlight_off before insert
>>>> this delay. If these values are the same, it means eDP was off until
>>>> now and driver can bypass power off cycle delay to save some times to
>>>> speed up eDP power on sequence.
>>>>
>>>> v2: fix commit messages
>>>
>>>There are more changes here than what the changelog says, but the previous review comments were not answered [1].
>>>
>>
>> I'm sorry that lose the question in [1].
>>
>> "But someone else may have turned it off just before we were handed control, we have no idea."
>> This is the situation from Ville's comment. Agree that we don't know when panel will be powered off.
>> In my opinion, eDP panel should not be turned off before i915 take it over. If it was turned on or off by standard contorl (ex: modeset).
>> last_power_on and last_backlight_off would not be the same. So this change should be safe.
>
>I think it's pretty much a hard requirement we respect the panel delays
>at i915 probe. If we don't know, we don't know, and we can't make
>assumptions.
>
>If the goal is to speed up boot, you should ensure 1) the pre-os enables
>the display, and 2) i915 can take over the display without a modeset and
>a panel power cycle.
>
After boot into kernel. It seems there are two cases we will see.
1) If eDP display did not enable at pre-os stage, this patch can save power cycle time.
2) If eDP display was enabled at pre-os, because of cdclk was setting to max freq always.
i915 driver will trigger modeset to reduce cdclk freq and run power off/on cycle.
At this case power cycle delay will not be ignored.
So this patch can only benefit at case #1 (eDP did not enable at pre-os stage). And it is what we need. :)
Best regards,
Shawn
>
>BR,
>Jani.
>
>
>>
>> Best regards,
>> Shawn
>>
>>>
>>>BR,
>>>Jani.
>>>
>>>
>>>[1] https://lore.kernel.org/r/Y1afUdAwfVTACJoK@intel.com
>>>
>>>>
>>>> Cc: Shankar Uma <uma.shankar@intel.com>
>>>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/display/intel_pps.c | 9 ++++++++-
>>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
>>>> b/drivers/gpu/drm/i915/display/intel_pps.c
>>>> index 21944f5bf3a8..290473ec70d5 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>>>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>>>> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
>>>> ktime_t panel_power_on_time;
>>>> s64 panel_power_off_duration;
>>>>
>>>> + /* When last_power_on equal to last_backlight_off, it means driver did not
>>>> + * turn on or off eDP panel so far. So we can bypass power cycle delay to
>>>> + * save some times here.
>>>> + */
>>>> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
>>>> + return;
>>>> +
>>>> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
>>>>
>>>> /* take the difference of current time and panel power off time @@
>>>> -1100,7 +1107,7 @@ static void pps_init_timestamps(struct intel_dp
>>>> *intel_dp) {
>>>> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
>>>> intel_dp->pps.last_power_on = jiffies;
>>>> - intel_dp->pps.last_backlight_off = jiffies;
>>>> + intel_dp->pps.last_backlight_off = intel_dp->pps.last_power_on;
>>>> }
>>>>
>>>> static void
>>>
>>>--
>>>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow
2022-11-01 14:40 ` Lee, Shawn C
@ 2022-11-01 14:42 ` Lee, Shawn C
2022-11-02 10:19 ` Jani Nikula
1 sibling, 0 replies; 24+ messages in thread
From: Lee, Shawn C @ 2022-11-01 14:42 UTC (permalink / raw)
To: intel-gfx
On Tue, Nov. 1, 2022, 1:43 p.m, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>On Tue, 01 Nov 2022, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
>> On Tuesday, November 1, 2022 5:53 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>>On Mon, 24 Oct 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>>>> A panel power off cycle delay always append before turn eDP on.
>>>> Driver should check last_power_on and last_backlight_off before
>>>> insert this delay. If these values are the same, it means eDP was
>>>> off until now and driver can bypass power off cycle delay to save
>>>> some times to speed up eDP power on sequence.
>>>>
>>>> v2: fix commit messages
>>>
>>>There are more changes here than what the changelog says, but the previous review comments were not answered [1].
>>>
>>
>> I'm sorry that lose the question in [1].
>>
>> "But someone else may have turned it off just before we were handed control, we have no idea."
>> This is the situation from Ville's comment. Agree that we don't know when panel will be powered off.
>> In my opinion, eDP panel should not be turned off before i915 take it over. If it was turned on or off by standard contorl (ex: modeset).
>> last_power_on and last_backlight_off would not be the same. So this change should be safe.
>
>I think it's pretty much a hard requirement we respect the panel delays
>at i915 probe. If we don't know, we don't know, and we can't make
>assumptions.
>
>If the goal is to speed up boot, you should ensure 1) the pre-os
>enables the display, and 2) i915 can take over the display without a
>modeset and a panel power cycle.
>
After boot into kernel. It seems there are two cases we will see.
1) If eDP display did not enable at pre-os stage, this patch can save power cycle time.
2) If eDP display was enabled at pre-os, because of cdclk was setting to max freq always.
i915 driver will trigger modeset to reduce cdclk freq and run power off/on cycle.
At this case power cycle delay will not be ignored.
So this patch can only benefit at case #1 (eDP did not enable at pre-os stage). And it is what we need. :)
Best regards,
Shawn
>
>BR,
>Jani.
>
>
>>
>> Best regards,
>> Shawn
>>
>>>
>>>BR,
>>>Jani.
>>>
>>>
>>>[1] https://lore.kernel.org/r/Y1afUdAwfVTACJoK@intel.com
>>>
>>>>
>>>> Cc: Shankar Uma <uma.shankar@intel.com>
>>>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/display/intel_pps.c | 9 ++++++++-
>>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
>>>> b/drivers/gpu/drm/i915/display/intel_pps.c
>>>> index 21944f5bf3a8..290473ec70d5 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>>>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>>>> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
>>>> ktime_t panel_power_on_time;
>>>> s64 panel_power_off_duration;
>>>>
>>>> + /* When last_power_on equal to last_backlight_off, it means driver did not
>>>> + * turn on or off eDP panel so far. So we can bypass power cycle delay to
>>>> + * save some times here.
>>>> + */
>>>> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
>>>> + return;
>>>> +
>>>> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
>>>>
>>>> /* take the difference of current time and panel power off time
>>>> @@
>>>> -1100,7 +1107,7 @@ static void pps_init_timestamps(struct intel_dp
>>>> *intel_dp) {
>>>> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
>>>> intel_dp->pps.last_power_on = jiffies;
>>>> - intel_dp->pps.last_backlight_off = jiffies;
>>>> + intel_dp->pps.last_backlight_off = intel_dp->pps.last_power_on;
>>>> }
>>>>
>>>> static void
>>>
>>>--
>>>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow
2022-11-01 14:40 ` Lee, Shawn C
2022-11-01 14:42 ` Lee, Shawn C
@ 2022-11-02 10:19 ` Jani Nikula
2022-11-02 14:50 ` Lee, Shawn C
1 sibling, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2022-11-02 10:19 UTC (permalink / raw)
To: Lee, Shawn C, intel-gfx
On Tue, 01 Nov 2022, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> On Tue, Nov. 1, 2022, 1:43 p.m, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>On Tue, 01 Nov 2022, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
>>> On Tuesday, November 1, 2022 5:53 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>>>On Mon, 24 Oct 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>>>>> A panel power off cycle delay always append before turn eDP on.
>>>>> Driver should check last_power_on and last_backlight_off before insert
>>>>> this delay. If these values are the same, it means eDP was off until
>>>>> now and driver can bypass power off cycle delay to save some times to
>>>>> speed up eDP power on sequence.
>>>>>
>>>>> v2: fix commit messages
>>>>
>>>>There are more changes here than what the changelog says, but the previous review comments were not answered [1].
>>>>
>>>
>>> I'm sorry that lose the question in [1].
>>>
>>> "But someone else may have turned it off just before we were handed control, we have no idea."
>>> This is the situation from Ville's comment. Agree that we don't know when panel will be powered off.
>>> In my opinion, eDP panel should not be turned off before i915 take it over. If it was turned on or off by standard contorl (ex: modeset).
>>> last_power_on and last_backlight_off would not be the same. So this change should be safe.
>>
>>I think it's pretty much a hard requirement we respect the panel delays
>>at i915 probe. If we don't know, we don't know, and we can't make
>>assumptions.
>>
>>If the goal is to speed up boot, you should ensure 1) the pre-os enables
>>the display, and 2) i915 can take over the display without a modeset and
>>a panel power cycle.
>>
>
> After boot into kernel. It seems there are two cases we will see.
> 1) If eDP display did not enable at pre-os stage, this patch can save power cycle time.
> 2) If eDP display was enabled at pre-os, because of cdclk was setting to max freq always.
> i915 driver will trigger modeset to reduce cdclk freq and run power off/on cycle.
> At this case power cycle delay will not be ignored.
In case 2, the effort should probably be spent on hardware take over
using the same cdclk as it was. I thought this was already the case, but
maybe I'm wrong and/or there are corner cases.
> So this patch can only benefit at case #1 (eDP did not enable at pre-os stage). And it is what we need. :)
I understand a typical T12 min (i.e. from Vcc power down to up again)
could be, say, 500 ms and it's a long time to wait. Especially if the
wait happens in output init which is all serial and synchronous in
probe.
However, you're basically asking us to potentially violate panel
timings. It just doesn't strike me as an obviusly good idea.
It might be a good idea to file an issue at fdo gitlab [1] and attach a
dmesg with drm.debug=14 from boot to at least the first modeset so we
can actually see what the delays are and where the time is spent.
BR,
Jani.
[1] https://gitlab.freedesktop.org/drm/intel/issues/new
>
> Best regards,
> Shawn
>
>>
>>BR,
>>Jani.
>>
>>
>>>
>>> Best regards,
>>> Shawn
>>>
>>>>
>>>>BR,
>>>>Jani.
>>>>
>>>>
>>>>[1] https://lore.kernel.org/r/Y1afUdAwfVTACJoK@intel.com
>>>>
>>>>>
>>>>> Cc: Shankar Uma <uma.shankar@intel.com>
>>>>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>>>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>>>> ---
>>>>> drivers/gpu/drm/i915/display/intel_pps.c | 9 ++++++++-
>>>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
>>>>> b/drivers/gpu/drm/i915/display/intel_pps.c
>>>>> index 21944f5bf3a8..290473ec70d5 100644
>>>>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>>>>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>>>>> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
>>>>> ktime_t panel_power_on_time;
>>>>> s64 panel_power_off_duration;
>>>>>
>>>>> + /* When last_power_on equal to last_backlight_off, it means driver did not
>>>>> + * turn on or off eDP panel so far. So we can bypass power cycle delay to
>>>>> + * save some times here.
>>>>> + */
>>>>> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
>>>>> + return;
>>>>> +
>>>>> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
>>>>>
>>>>> /* take the difference of current time and panel power off time @@
>>>>> -1100,7 +1107,7 @@ static void pps_init_timestamps(struct intel_dp
>>>>> *intel_dp) {
>>>>> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
>>>>> intel_dp->pps.last_power_on = jiffies;
>>>>> - intel_dp->pps.last_backlight_off = jiffies;
>>>>> + intel_dp->pps.last_backlight_off = intel_dp->pps.last_power_on;
>>>>> }
>>>>>
>>>>> static void
>>>>
>>>>--
>>>>Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow
2022-11-02 10:19 ` Jani Nikula
@ 2022-11-02 14:50 ` Lee, Shawn C
0 siblings, 0 replies; 24+ messages in thread
From: Lee, Shawn C @ 2022-11-02 14:50 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On Wednesday, November 2, 2022 6:19 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>On Tue, 01 Nov 2022, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
>> On Tue, Nov. 1, 2022, 1:43 p.m, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>>On Tue, 01 Nov 2022, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
>>>> On Tuesday, November 1, 2022 5:53 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>>>>On Mon, 24 Oct 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>>>>>> A panel power off cycle delay always append before turn eDP on.
>>>>>> Driver should check last_power_on and last_backlight_off before
>>>>>> insert this delay. If these values are the same, it means eDP was
>>>>>> off until now and driver can bypass power off cycle delay to save
>>>>>> some times to speed up eDP power on sequence.
>>>>>>
>>>>>> v2: fix commit messages
>>>>>
>>>>>There are more changes here than what the changelog says, but the previous review comments were not answered [1].
>>>>>
>>>>
>>>> I'm sorry that lose the question in [1].
>>>>
>>>> "But someone else may have turned it off just before we were handed control, we have no idea."
>>>> This is the situation from Ville's comment. Agree that we don't know when panel will be powered off.
>>>> In my opinion, eDP panel should not be turned off before i915 take it over. If it was turned on or off by standard contorl (ex: modeset).
>>>> last_power_on and last_backlight_off would not be the same. So this change should be safe.
>>>
>>>I think it's pretty much a hard requirement we respect the panel
>>>delays at i915 probe. If we don't know, we don't know, and we can't
>>>make assumptions.
>>>
>>>If the goal is to speed up boot, you should ensure 1) the pre-os
>>>enables the display, and 2) i915 can take over the display without a
>>>modeset and a panel power cycle.
>>>
>>
>> After boot into kernel. It seems there are two cases we will see.
>> 1) If eDP display did not enable at pre-os stage, this patch can save power cycle time.
>> 2) If eDP display was enabled at pre-os, because of cdclk was setting to max freq always.
>> i915 driver will trigger modeset to reduce cdclk freq and run power off/on cycle.
>> At this case power cycle delay will not be ignored.
>
>In case 2, the effort should probably be spent on hardware take over using the same cdclk as it was.
>I thought this was already the case, but maybe I'm wrong and/or there are corner cases.
>
When cdclk was the same, it means driver will not trigger modeset and keep the setting from pre-os.
If so, this behavior sound like fastboot mode enabled.
>> So this patch can only benefit at case #1 (eDP did not enable at
>> pre-os stage). And it is what we need. :)
>
>I understand a typical T12 min (i.e. from Vcc power down to up again) could be, say, 500 ms and it's a long time to wait. Especially if the wait happens in output init which is all serial and synchronous in probe.
>
>However, you're basically asking us to potentially violate panel timings. It just doesn't strike me as an obviusly good idea.
>
From my point of view, pre-os initialization already take 2~3 seconds (panel power is off). Kernel log in below shows the first time driver try to enable eDP pwoer in case 1.
[ 0.957991] i915 0000:00:02.0: [drm:intel_pps_vdd_on_unlocked] Turning [ENCODER:235:DDI A/PHY A] VDD on
[ 0.958021] i915 0000:00:02.0: [drm:wait_panel_power_cycle] Wait for panel power cycle
eDP panel power never turn on before time [0.958021]. So the panel power already off over 2 (pre-os) + 1 (kernel) seconds at least.
In my opinion, 3 seconds already over the power cycle delay setting. That's why i'm thinking maybe we don't need this additional 600ms delay in this case.
>It might be a good idea to file an issue at fdo gitlab [1] and attach a dmesg with drm.debug=14 from boot to at least the first modeset so we can actually see what the delays are and where the time is spent.
Here is the gitlab issue and you can find kernel log in it. Thanks!
https://gitlab.freedesktop.org/drm/intel/-/issues/7417
Best regards,
Shawn
>
>
>BR,
>Jani.
>
>
>[1] https://gitlab.freedesktop.org/drm/intel/issues/new
>
>
>
>
>>
>> Best regards,
>> Shawn
>>
>>>
>>>BR,
>>>Jani.
>>>
>>>
>>>>
>>>> Best regards,
>>>> Shawn
>>>>
>>>>>
>>>>>BR,
>>>>>Jani.
>>>>>
>>>>>
>>>>>[1] https://lore.kernel.org/r/Y1afUdAwfVTACJoK@intel.com
>>>>>
>>>>>>
>>>>>> Cc: Shankar Uma <uma.shankar@intel.com>
>>>>>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>>>>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>>>>> ---
>>>>>> drivers/gpu/drm/i915/display/intel_pps.c | 9 ++++++++-
>>>>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
>>>>>> b/drivers/gpu/drm/i915/display/intel_pps.c
>>>>>> index 21944f5bf3a8..290473ec70d5 100644
>>>>>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>>>>>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>>>>>> @@ -509,6 +509,13 @@ static void wait_panel_power_cycle(struct intel_dp *intel_dp)
>>>>>> ktime_t panel_power_on_time;
>>>>>> s64 panel_power_off_duration;
>>>>>>
>>>>>> + /* When last_power_on equal to last_backlight_off, it means driver did not
>>>>>> + * turn on or off eDP panel so far. So we can bypass power cycle delay to
>>>>>> + * save some times here.
>>>>>> + */
>>>>>> + if (intel_dp->pps.last_power_on == intel_dp->pps.last_backlight_off)
>>>>>> + return;
>>>>>> +
>>>>>> drm_dbg_kms(&i915->drm, "Wait for panel power cycle\n");
>>>>>>
>>>>>> /* take the difference of current time and panel power off time
>>>>>> @@
>>>>>> -1100,7 +1107,7 @@ static void pps_init_timestamps(struct intel_dp
>>>>>> *intel_dp) {
>>>>>> intel_dp->pps.panel_power_off_time = ktime_get_boottime();
>>>>>> intel_dp->pps.last_power_on = jiffies;
>>>>>> - intel_dp->pps.last_backlight_off = jiffies;
>>>>>> + intel_dp->pps.last_backlight_off = intel_dp->pps.last_power_on;
>>>>>> }
>>>>>>
>>>>>> static void
>>>>>
>>>>>--
>>>>>Jani Nikula, Intel Open Source Graphics Center
>
>--
>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
` (3 preceding siblings ...)
2022-10-24 17:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pps: improve eDP power on flow. (rev2) Patchwork
@ 2022-11-03 0:40 ` Lee Shawn C
2022-11-03 11:00 ` Jani Nikula
2022-11-03 1:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pps: improve eDP power on flow. (rev3) Patchwork
` (4 subsequent siblings)
9 siblings, 1 reply; 24+ messages in thread
From: Lee Shawn C @ 2022-11-03 0:40 UTC (permalink / raw)
To: intel-gfx
After i915 dirver initialized, a panel power off cycle delay
always append before turn eDP on. If eDP display did not
power on before. With this change, power off duration might
longer than power cycle delay. So driver can save power cycle
delay to speed up driver initialization time.
v2: fix commit messages
v3: refine panel_power_off_time default value and modify
commit messages
Cc: Shankar Uma <uma.shankar@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
index 21944f5bf3a8..a394bb1c92d0 100644
--- a/drivers/gpu/drm/i915/display/intel_pps.c
+++ b/drivers/gpu/drm/i915/display/intel_pps.c
@@ -1098,7 +1098,7 @@ bool intel_pps_have_panel_power_or_vdd(struct intel_dp *intel_dp)
static void pps_init_timestamps(struct intel_dp *intel_dp)
{
- intel_dp->pps.panel_power_off_time = ktime_get_boottime();
+ intel_dp->pps.panel_power_off_time = 0;
intel_dp->pps.last_power_on = jiffies;
intel_dp->pps.last_backlight_off = jiffies;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pps: improve eDP power on flow. (rev3)
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
` (4 preceding siblings ...)
2022-11-03 0:40 ` [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow Lee Shawn C
@ 2022-11-03 1:32 ` Patchwork
2022-11-03 14:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (3 subsequent siblings)
9 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2022-11-03 1:32 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6041 bytes --]
== Series Details ==
Series: drm/i915/pps: improve eDP power on flow. (rev3)
URL : https://patchwork.freedesktop.org/series/110038/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12333 -> Patchwork_110038v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/index.html
Participating hosts (38 -> 26)
------------------------------
Additional (1): fi-kbl-soraka
Missing (13): fi-tgl-dsi bat-dg2-8 fi-icl-u2 bat-dg2-9 bat-adlp-6 fi-cfl-guc bat-adlp-4 bat-adln-1 bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-dg2-11 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_110038v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-apl-guc/igt@gem_lmem_swapping@basic.html
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#1886])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][6] -> [INCOMPLETE][7] ([i915#4785])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][8] ([i915#7352])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-kbl-soraka/igt@i915_selftest@live@requests.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-apl-guc: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-apl-guc/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +7 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-apl-guc: NOTRUN -> [SKIP][11] ([fdo#109271]) +11 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-apl-guc/igt@kms_force_connector_basic@force-connector-state.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][12] ([fdo#109271] / [i915#4312] / [i915#5594])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-hsw-4770/igt@runner@aborted.html
- fi-kbl-soraka: NOTRUN -> [FAIL][13] ([i915#4312] / [i915#4991])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-kbl-soraka/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][14] ([i915#7229]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@gem_render_tiled_blits@basic:
- fi-apl-guc: [INCOMPLETE][16] -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-apl-guc/igt@gem_render_tiled_blits@basic.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-apl-guc/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_blits@basic:
- fi-pnv-d510: [SKIP][18] ([fdo#109271]) -> [PASS][19] +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-pnv-d510/igt@gem_tiled_blits@basic.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/fi-pnv-d510/igt@gem_tiled_blits@basic.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7352]: https://gitlab.freedesktop.org/drm/intel/issues/7352
Build changes
-------------
* Linux: CI_DRM_12333 -> Patchwork_110038v3
CI-20190529: 20190529
CI_DRM_12333: e7d1d39c197e7f06cf4d1ee19cfd467d6b68e10e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7038: 5389b3f3b9b75df6bd8506e4aa3da357fd0c0ab1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110038v3: e7d1d39c197e7f06cf4d1ee19cfd467d6b68e10e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
add03237cdae drm/i915/pps: improve eDP power on flow
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/index.html
[-- Attachment #2: Type: text/html, Size: 7736 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow
2022-11-03 0:40 ` [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow Lee Shawn C
@ 2022-11-03 11:00 ` Jani Nikula
2022-11-03 11:23 ` Lee, Shawn C
0 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2022-11-03 11:00 UTC (permalink / raw)
To: Lee Shawn C, intel-gfx
On Thu, 03 Nov 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> After i915 dirver initialized, a panel power off cycle delay
> always append before turn eDP on. If eDP display did not
> power on before. With this change, power off duration might
> longer than power cycle delay. So driver can save power cycle
> delay to speed up driver initialization time.
>
> v2: fix commit messages
> v3: refine panel_power_off_time default value and modify
> commit messages
>
> Cc: Shankar Uma <uma.shankar@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
> index 21944f5bf3a8..a394bb1c92d0 100644
> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> @@ -1098,7 +1098,7 @@ bool intel_pps_have_panel_power_or_vdd(struct intel_dp *intel_dp)
>
> static void pps_init_timestamps(struct intel_dp *intel_dp)
> {
> - intel_dp->pps.panel_power_off_time = ktime_get_boottime();
> + intel_dp->pps.panel_power_off_time = 0;
So this is just copy-paste from [1] where we discuss the problems with
this approach, specifically module reload ignoring the power off
time. Why would you post this without even mentioning the problem?
BR,
Jani.
[1] https://gitlab.freedesktop.org/drm/intel/-/issues/7417#note_1619118
> intel_dp->pps.last_power_on = jiffies;
> intel_dp->pps.last_backlight_off = jiffies;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow
2022-11-03 11:00 ` Jani Nikula
@ 2022-11-03 11:23 ` Lee, Shawn C
0 siblings, 0 replies; 24+ messages in thread
From: Lee, Shawn C @ 2022-11-03 11:23 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On Thursday, November 3, 2022 7:00 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>On Thu, 03 Nov 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>> After i915 dirver initialized, a panel power off cycle delay always
>> append before turn eDP on. If eDP display did not power on before.
>> With this change, power off duration might longer than power cycle
>> delay. So driver can save power cycle delay to speed up driver
>> initialization time.
>>
>> v2: fix commit messages
>> v3: refine panel_power_off_time default value and modify
>> commit messages
>>
>> Cc: Shankar Uma <uma.shankar@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
>> b/drivers/gpu/drm/i915/display/intel_pps.c
>> index 21944f5bf3a8..a394bb1c92d0 100644
>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>> @@ -1098,7 +1098,7 @@ bool intel_pps_have_panel_power_or_vdd(struct
>> intel_dp *intel_dp)
>>
>> static void pps_init_timestamps(struct intel_dp *intel_dp) {
>> - intel_dp->pps.panel_power_off_time = ktime_get_boottime();
>> + intel_dp->pps.panel_power_off_time = 0;
>
>So this is just copy-paste from [1] where we discuss the problems with this approach, specifically module reload ignoring the power off time.
>Why would you post this without even mentioning the problem?
>
OK, we will stop commit any patch until we have proper solution. Could you please share your opinion about next step? Thanks!
Best regards,
Shawn
>
>BR,
>Jani.
>
>
>[1] https://gitlab.freedesktop.org/drm/intel/-/issues/7417#note_1619118
>
>> intel_dp->pps.last_power_on = jiffies;
>> intel_dp->pps.last_backlight_off = jiffies; }
>
>--
>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pps: improve eDP power on flow. (rev3)
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
` (5 preceding siblings ...)
2022-11-03 1:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pps: improve eDP power on flow. (rev3) Patchwork
@ 2022-11-03 14:04 ` Patchwork
2022-11-14 6:21 ` [Intel-gfx] [v4] drm/i915/pps: improve eDP power on flow Lee Shawn C
` (2 subsequent siblings)
9 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2022-11-03 14:04 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 40870 bytes --]
== Series Details ==
Series: drm/i915/pps: improve eDP power on flow. (rev3)
URL : https://patchwork.freedesktop.org/series/110038/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110038v3_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_110038v3_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_110038v3_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_110038v3_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb6/igt@gem_exec_whisper@basic-contexts-forked-all.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb8/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@kms_cursor_legacy@cursor-vs-flip@toggle:
- shard-skl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl4/igt@kms_cursor_legacy@cursor-vs-flip@toggle.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl1/igt@kms_cursor_legacy@cursor-vs-flip@toggle.html
New tests
---------
New tests have been introduced between CI_DRM_12333_full and Patchwork_110038v3_full:
### New IGT tests (1) ###
* igt@fbdev@pan:
- Statuses : 6 pass(s)
- Exec time: [0.03, 0.07] s
Known issues
------------
Here are the changes found in Patchwork_110038v3_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-glk: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) -> ([PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [FAIL][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54]) ([i915#4392])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk1/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk1/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk1/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk2/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk2/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk2/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk2/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk3/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk3/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk3/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk6/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk7/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk7/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk7/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk8/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk8/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk8/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk9/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk9/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk9/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk1/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk1/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk2/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk2/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk2/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk3/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk3/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk3/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk5/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk6/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk9/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk9/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk9/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk7/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk7/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk6/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk7/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk6/boot.html
#### Possible fixes ####
* boot:
- shard-apl: ([PASS][55], [PASS][56], [PASS][57], [FAIL][58], [PASS][59], [PASS][60], [PASS][61], [PASS][62], [PASS][63], [PASS][64], [PASS][65], [PASS][66], [PASS][67], [PASS][68], [PASS][69], [PASS][70], [PASS][71], [PASS][72], [PASS][73], [PASS][74], [PASS][75], [PASS][76], [PASS][77], [PASS][78], [PASS][79]) ([i915#4386]) -> ([PASS][80], [PASS][81], [PASS][82], [PASS][83], [PASS][84], [PASS][85], [PASS][86], [PASS][87], [PASS][88], [PASS][89], [PASS][90], [PASS][91], [PASS][92], [PASS][93], [PASS][94], [PASS][95], [PASS][96], [PASS][97], [PASS][98], [PASS][99], [PASS][100], [PASS][101], [PASS][102], [PASS][103], [PASS][104])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/boot.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/boot.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/boot.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/boot.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl3/boot.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl3/boot.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl3/boot.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl6/boot.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl6/boot.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl6/boot.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/boot.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/boot.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/boot.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/boot.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl1/boot.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl1/boot.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl1/boot.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl1/boot.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl2/boot.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl2/boot.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl2/boot.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl2/boot.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl3/boot.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl3/boot.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl3/boot.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl3/boot.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/boot.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/boot.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/boot.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/boot.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/boot.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl7/boot.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl7/boot.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl7/boot.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl7/boot.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl8/boot.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl8/boot.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl8/boot.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl8/boot.html
### IGT changes ###
#### Issues hit ####
* igt@fbdev@read:
- shard-apl: NOTRUN -> [FAIL][105] ([i915#6724])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/igt@fbdev@read.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][106] -> [SKIP][107] ([i915#4525]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb8/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][108] -> [FAIL][109] ([i915#2846])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk8/igt@gem_exec_fair@basic-deadline.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: NOTRUN -> [FAIL][110] ([i915#2842])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][111] ([i915#2842])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][112] -> [FAIL][113] ([i915#2842])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-tglb: [PASS][114] -> [FAIL][115] ([i915#2842])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-tglb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#4613])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl8/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_lmem_swapping@random-engines:
- shard-iclb: NOTRUN -> [SKIP][117] ([i915#4613])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb1/igt@gem_lmem_swapping@random-engines.html
* igt@gem_lmem_swapping@verify-random:
- shard-skl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#4613]) +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl7/igt@gem_lmem_swapping@verify-random.html
* igt@gem_media_vme:
- shard-tglb: NOTRUN -> [SKIP][119] ([i915#284])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb6/igt@gem_media_vme.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [INCOMPLETE][120] ([i915#7248])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl8/igt@gem_pread@exhaustion.html
- shard-skl: NOTRUN -> [INCOMPLETE][121] ([i915#7248])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl9/igt@gem_pread@exhaustion.html
* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-skl: NOTRUN -> [SKIP][122] ([fdo#109271]) +22 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl9/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html
* igt@gem_userptr_blits@input-checking:
- shard-iclb: NOTRUN -> [DMESG-WARN][123] ([i915#4991])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb1/igt@gem_userptr_blits@input-checking.html
* igt@gen7_exec_parse@basic-offset:
- shard-tglb: NOTRUN -> [SKIP][124] ([fdo#109289])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb6/igt@gen7_exec_parse@basic-offset.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][125] -> [DMESG-WARN][126] ([i915#5566] / [i915#716])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl6/igt@gen9_exec_parse@allowed-single.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl3/igt@gen9_exec_parse@allowed-single.html
* igt@i915_module_load@reload-no-display:
- shard-iclb: [PASS][127] -> [DMESG-WARN][128] ([i915#2867])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb1/igt@i915_module_load@reload-no-display.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb3/igt@i915_module_load@reload-no-display.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][129] -> [SKIP][130] ([i915#4281])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb6/igt@i915_pm_dc@dc9-dpms.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_sseu@full-enable:
- shard-iclb: NOTRUN -> [SKIP][131] ([i915#4387])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb1/igt@i915_pm_sseu@full-enable.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][132] ([i915#5286])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb6/igt@kms_big_fb@4-tiled-16bpp-rotate-270.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][133] ([i915#6095])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb6/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][134] ([fdo#109271] / [i915#3886]) +1 similar issue
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][135] ([fdo#109271] / [i915#3886]) +5 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-frame-dump:
- shard-apl: NOTRUN -> [SKIP][136] ([fdo#109271] / [fdo#111827]) +3 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/igt@kms_chamelium@dp-frame-dump.html
* igt@kms_chamelium@dp-hpd:
- shard-glk: NOTRUN -> [SKIP][137] ([fdo#109271] / [fdo#111827]) +1 similar issue
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/igt@kms_chamelium@dp-hpd.html
* igt@kms_chamelium@hdmi-crc-single:
- shard-skl: NOTRUN -> [SKIP][138] ([fdo#109271] / [fdo#111827])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl9/igt@kms_chamelium@hdmi-crc-single.html
* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-iclb: NOTRUN -> [SKIP][139] ([fdo#109284] / [fdo#111827])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb1/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html
* igt@kms_cursor_crc@cursor-onscreen-32x10:
- shard-tglb: NOTRUN -> [SKIP][140] ([i915#3555])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb6/igt@kms_cursor_crc@cursor-onscreen-32x10.html
* igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1:
- shard-apl: [PASS][141] -> [DMESG-WARN][142] ([i915#180]) +2 similar issues
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl1/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
* igt@kms_cursor_legacy@flip-vs-cursor@toggle:
- shard-iclb: [PASS][143] -> [FAIL][144] ([i915#2346])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][145] -> [FAIL][146] ([i915#2122])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk8/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk5/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-iclb: NOTRUN -> [SKIP][147] ([fdo#109274])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb1/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_flip@2x-flip-vs-panning-interruptible:
- shard-tglb: NOTRUN -> [SKIP][148] ([fdo#109274] / [fdo#111825] / [i915#3637])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb6/igt@kms_flip@2x-flip-vs-panning-interruptible.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@c-edp1:
- shard-skl: [PASS][149] -> [FAIL][150] ([i915#2122]) +1 similar issue
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl10/igt@kms_flip@flip-vs-blocking-wf-vblank@c-edp1.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl9/igt@kms_flip@flip-vs-blocking-wf-vblank@c-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][151] -> [FAIL][152] ([i915#79]) +1 similar issue
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [PASS][153] -> [FAIL][154] ([i915#79]) +1 similar issue
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][155] ([i915#6375])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][156] -> [SKIP][157] ([i915#3555])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][158] ([i915#3555])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][159] ([i915#2672]) +4 similar issues
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][160] ([i915#2587] / [i915#2672]) +2 similar issues
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-apl: NOTRUN -> [SKIP][161] ([fdo#109271]) +69 similar issues
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][162] ([fdo#109280] / [fdo#111825]) +3 similar issues
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw:
- shard-glk: NOTRUN -> [SKIP][163] ([fdo#109271]) +20 similar issues
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][164] ([fdo#109280]) +4 similar issues
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb1/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [SKIP][165] ([i915#5176]) +2 similar issues
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb1/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][166] -> [SKIP][167] ([i915#5235]) +2 similar issues
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: NOTRUN -> [SKIP][168] ([i915#658])
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb1/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][169] ([fdo#109271] / [i915#658]) +1 similar issue
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-p010@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][170] ([i915#5939]) +2 similar issues
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@kms_psr2_su@page_flip-p010@pipe-b-edp-1.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][171] -> [SKIP][172] ([fdo#109441]) +2 similar issues
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html
* igt@prime_vgem@fence-write-hang:
- shard-tglb: NOTRUN -> [SKIP][173] ([fdo#109295])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb6/igt@prime_vgem@fence-write-hang.html
* igt@sysfs_clients@split-10:
- shard-skl: NOTRUN -> [SKIP][174] ([fdo#109271] / [i915#2994])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl7/igt@sysfs_clients@split-10.html
* igt@sysfs_clients@split-25:
- shard-apl: NOTRUN -> [SKIP][175] ([fdo#109271] / [i915#2994])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][176] ([i915#6268]) -> [PASS][177]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-tglb2/igt@gem_ctx_exec@basic-nohangcheck.html
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb7/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][178] ([i915#4525]) -> [PASS][179] +1 similar issue
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@gem_exec_balancer@parallel-bb-first.html
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][180] ([i915#2842]) -> [PASS][181]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk3/igt@gem_exec_fair@basic-none@vcs0.html
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk3/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [FAIL][182] ([i915#2842]) -> [PASS][183]
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][184] ([i915#5566] / [i915#716]) -> [PASS][185]
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk2/igt@gen9_exec_parse@allowed-single.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk8/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][186] ([i915#6537]) -> [PASS][187]
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl6/igt@i915_pm_rps@engine-order.html
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl3/igt@i915_pm_rps@engine-order.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [DMESG-FAIL][188] ([i915#5334]) -> [PASS][189]
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-iclb: [FAIL][190] ([i915#2346]) -> [PASS][191]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_dp_aux_dev:
- shard-iclb: [DMESG-WARN][192] ([i915#4391]) -> [PASS][193]
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb7/igt@kms_dp_aux_dev.html
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb6/igt@kms_dp_aux_dev.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][194] ([i915#2122]) -> [PASS][195] +3 similar issues
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-tglb: [INCOMPLETE][196] -> [PASS][197]
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html
* igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1:
- shard-glk: [DMESG-FAIL][198] ([i915#118]) -> [PASS][199]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk6/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-glk1/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][200] ([fdo#109441]) -> [PASS][201] +2 similar issues
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][202] ([i915#180]) -> [PASS][203] +1 similar issue
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
- shard-skl: [INCOMPLETE][204] ([i915#7404]) -> [PASS][205]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl10/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-skl9/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_pread@exhaustion:
- shard-tglb: [INCOMPLETE][206] ([i915#7248]) -> [WARN][207] ([i915#2658])
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-tglb7/igt@gem_pread@exhaustion.html
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-tglb2/igt@gem_pread@exhaustion.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][208] ([i915#658]) -> [SKIP][209] ([i915#2920])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb1/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][210] ([fdo#111068] / [i915#658]) -> [SKIP][211] ([i915#2920])
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][212], [FAIL][213], [FAIL][214], [FAIL][215]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][216], [FAIL][217], [FAIL][218], [FAIL][219], [FAIL][220], [FAIL][221]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312])
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/igt@runner@aborted.html
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/igt@runner@aborted.html
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/igt@runner@aborted.html
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl3/igt@runner@aborted.html
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl8/igt@runner@aborted.html
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl3/igt@runner@aborted.html
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl1/igt@runner@aborted.html
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl2/igt@runner@aborted.html
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl6/igt@runner@aborted.html
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/shard-apl1/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6724]: https://gitlab.freedesktop.org/drm/intel/issues/6724
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7404]: https://gitlab.freedesktop.org/drm/intel/issues/7404
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12333 -> Patchwork_110038v3
CI-20190529: 20190529
CI_DRM_12333: e7d1d39c197e7f06cf4d1ee19cfd467d6b68e10e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7038: 5389b3f3b9b75df6bd8506e4aa3da357fd0c0ab1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110038v3: e7d1d39c197e7f06cf4d1ee19cfd467d6b68e10e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v3/index.html
[-- Attachment #2: Type: text/html, Size: 46985 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] [v4] drm/i915/pps: improve eDP power on flow
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
` (6 preceding siblings ...)
2022-11-03 14:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-11-14 6:21 ` Lee Shawn C
2022-11-16 15:44 ` Jani Nikula
2022-11-14 11:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pps: improve eDP power on flow. (rev4) Patchwork
2022-11-14 17:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
9 siblings, 1 reply; 24+ messages in thread
From: Lee Shawn C @ 2022-11-14 6:21 UTC (permalink / raw)
To: intel-gfx
After i915 dirver initialized, a panel power off cycle delay
always append before turn eDP on. If eDP display did not
power on before. With this change, power off duration might
longer than power cycle delay. So driver can save power cycle
delay to speed up driver initialization time.
v2: fix commit messages
v3: refine panel_power_off_time default value and modify
commit messages
v4: add eDP power off cycle delay at the path to unload i915 module
Cc: Shankar Uma <uma.shankar@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
drivers/gpu/drm/i915/i915_driver.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
index 81ee7f3aadf6..ab4118b38120 100644
--- a/drivers/gpu/drm/i915/display/intel_pps.c
+++ b/drivers/gpu/drm/i915/display/intel_pps.c
@@ -1100,7 +1100,7 @@ bool intel_pps_have_panel_power_or_vdd(struct intel_dp *intel_dp)
static void pps_init_timestamps(struct intel_dp *intel_dp)
{
- intel_dp->pps.panel_power_off_time = ktime_get_boottime();
+ intel_dp->pps.panel_power_off_time = 0;
intel_dp->pps.last_power_on = jiffies;
intel_dp->pps.last_backlight_off = jiffies;
}
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index c3d43f9b1e45..0e3cbd129055 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -107,6 +107,8 @@ static const char irst_name[] = "INT3392";
static const struct drm_driver i915_drm_driver;
+static void intel_shutdown_encoders(struct drm_i915_private *dev_priv);
+
static void i915_release_bridge_dev(struct drm_device *dev,
void *bridge)
{
@@ -796,6 +798,8 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)
intel_display_driver_unregister(dev_priv);
+ intel_shutdown_encoders(dev_priv);
+
for_each_gt(gt, dev_priv, i)
intel_gt_driver_unregister(gt);
--
2.17.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pps: improve eDP power on flow. (rev4)
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
` (7 preceding siblings ...)
2022-11-14 6:21 ` [Intel-gfx] [v4] drm/i915/pps: improve eDP power on flow Lee Shawn C
@ 2022-11-14 11:45 ` Patchwork
2022-11-14 17:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
9 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2022-11-14 11:45 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11798 bytes --]
== Series Details ==
Series: drm/i915/pps: improve eDP power on flow. (rev4)
URL : https://patchwork.freedesktop.org/series/110038/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12375 -> Patchwork_110038v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/index.html
Participating hosts (39 -> 39)
------------------------------
Additional (2): fi-kbl-soraka bat-dg1-5
Missing (2): fi-bdw-samus fi-tgl-dsi
Known issues
------------
Here are the changes found in Patchwork_110038v4 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][4] ([i915#4083])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@gem_mmap@basic.html
* igt@gem_tiled_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][5] ([i915#4077]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4079]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#1155])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg1-5: NOTRUN -> [SKIP][8] ([i915#6621])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gem_contexts:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][9] ([i915#7099])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-kbl-soraka/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][10] ([i915#5334])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][11] ([i915#1886])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][12] ([i915#4212]) +7 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][13] ([i915#4215])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
- bat-adlp-4: NOTRUN -> [SKIP][15] ([fdo#111827])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-adlp-4/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- bat-dg1-5: NOTRUN -> [SKIP][16] ([fdo#111827]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +7 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#4103] / [i915#4213])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-5: NOTRUN -> [SKIP][19] ([fdo#109285])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-adlp-4: NOTRUN -> [SKIP][20] ([i915#3546])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-adlp-4/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][21] ([i915#1072] / [i915#4078]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-5: NOTRUN -> [SKIP][22] ([i915#3555])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][23] ([i915#3708]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][24] ([i915#3708] / [i915#4077]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-userptr:
- bat-dg1-5: NOTRUN -> [SKIP][25] ([i915#3708] / [i915#4873])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-dg1-5/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@fbdev@read:
- {bat-rpls-2}: [SKIP][26] ([i915#2582]) -> [PASS][27] +4 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/bat-rpls-2/igt@fbdev@read.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-rpls-2/igt@fbdev@read.html
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-rpls-2}: [DMESG-WARN][28] ([i915#6687]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/bat-rpls-2/igt@gem_exec_suspend@basic-s3@smem.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-rpls-2/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][30] ([i915#4785]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@migrate:
- bat-adlp-4: [INCOMPLETE][32] ([i915#7308] / [i915#7348]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/bat-adlp-4/igt@i915_selftest@live@migrate.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-adlp-4/igt@i915_selftest@live@migrate.html
* igt@i915_suspend@basic-s3-without-i915:
- {bat-rpls-2}: [DMESG-WARN][34] ([i915#6434]) -> [PASS][35] +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/bat-rpls-2/igt@i915_suspend@basic-s3-without-i915.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/bat-rpls-2/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][36] ([i915#6298]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6559]: https://gitlab.freedesktop.org/drm/intel/issues/6559
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7099]: https://gitlab.freedesktop.org/drm/intel/issues/7099
[i915#7308]: https://gitlab.freedesktop.org/drm/intel/issues/7308
[i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348
[i915#7467]: https://gitlab.freedesktop.org/drm/intel/issues/7467
Build changes
-------------
* Linux: CI_DRM_12375 -> Patchwork_110038v4
CI-20190529: 20190529
CI_DRM_12375: 80e6b3384febc6243acf125fd5441732b1bdfe8d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7053: a9e73e6c48ab6632e2adb095cb809118b437fdfd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110038v4: 80e6b3384febc6243acf125fd5441732b1bdfe8d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
ee07fc874618 drm/i915/pps: improve eDP power on flow
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/index.html
[-- Attachment #2: Type: text/html, Size: 13510 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pps: improve eDP power on flow. (rev4)
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
` (8 preceding siblings ...)
2022-11-14 11:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pps: improve eDP power on flow. (rev4) Patchwork
@ 2022-11-14 17:22 ` Patchwork
9 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2022-11-14 17:22 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 38329 bytes --]
== Series Details ==
Series: drm/i915/pps: improve eDP power on flow. (rev4)
URL : https://patchwork.freedesktop.org/series/110038/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12375_full -> Patchwork_110038v4_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_110038v4_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_110038v4_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 11)
------------------------------
Additional (1): pig-skl-6260u
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_110038v4_full:
### IGT changes ###
#### Possible regressions ####
* igt@device_reset@unbind-reset-rebind:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-tglb3/igt@device_reset@unbind-reset-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-tglb6/igt@device_reset@unbind-reset-rebind.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl6/igt@kms_fbcon_fbt@psr-suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl7/igt@kms_fbcon_fbt@psr-suspend.html
#### Warnings ####
* igt@kms_color@ctm-0-75@pipe-b-edp-1:
- shard-tglb: [FAIL][5] ([i915#315] / [i915#6946]) -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-tglb5/igt@kms_color@ctm-0-75@pipe-b-edp-1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-tglb8/igt@kms_color@ctm-0-75@pipe-b-edp-1.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_eio@in-flight-contexts-1us:
- {shard-rkl}: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-2/igt@gem_eio@in-flight-contexts-1us.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-3/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_whisper@basic-fds-priority:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-5/igt@gem_exec_whisper@basic-fds-priority.html
Known issues
------------
Here are the changes found in Patchwork_110038v4_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-glk: ([PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34]) -> ([PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [FAIL][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58], [PASS][59]) ([i915#4392])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk5/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk7/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk7/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk7/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk8/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk8/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk8/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk9/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk9/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk9/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk9/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk5/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk5/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk3/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk3/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk3/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk2/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk1/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk1/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk2/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk2/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk3/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk3/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk3/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk7/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk7/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk8/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk8/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk8/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk8/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk9/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk9/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk6/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk6/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk6/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk5/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk1/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk1/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk1/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk2/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk2/boot.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk5/boot.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk7/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][60] ([i915#4991])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl1/igt@gem_create@create-massive.html
- shard-skl: NOTRUN -> [DMESG-WARN][61] ([i915#4991])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl1/igt@gem_create@create-massive.html
* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][62] -> [SKIP][63] ([i915#4525])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb2/igt@gem_exec_balancer@parallel.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb6/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][64] -> [FAIL][65] ([i915#2842])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk9/igt@gem_exec_fair@basic-none@vcs0.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk2/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][66] ([i915#2842])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [PASS][67] -> [FAIL][68] ([i915#2842])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb1/igt@gem_exec_fair@basic-pace@bcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb3/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_lmem_swapping@smem-oom:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#4613])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl1/igt@gem_lmem_swapping@smem-oom.html
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#4613]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl1/igt@gem_lmem_swapping@smem-oom.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [PASS][71] -> [FAIL][72] ([i915#6537])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-apl6/igt@i915_pm_rps@engine-order.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl1/igt@i915_pm_rps@engine-order.html
* igt@i915_pm_sseu@full-enable:
- shard-skl: [PASS][73] -> [FAIL][74] ([i915#6991])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl1/igt@i915_pm_sseu@full-enable.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl4/igt@i915_pm_sseu@full-enable.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#3886]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl3/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#3886]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl1/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271]) +53 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl7/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271] / [fdo#111827]) +3 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl3/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_color_chamelium@ctm-negative:
- shard-skl: NOTRUN -> [SKIP][79] ([fdo#109271] / [fdo#111827]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl1/igt@kms_color_chamelium@ctm-negative.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][80] -> [FAIL][81] ([i915#2346])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#6375])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#2672] / [i915#3555])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#2672]) +5 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#2587] / [i915#2672]) +8 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][86] ([i915#3555])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][87] ([fdo#109271]) +31 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#658]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl7/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][89] -> [SKIP][90] ([fdo#109441]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][91] -> [DMESG-WARN][92] ([i915#180])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [PASS][93] -> [INCOMPLETE][94] ([i915#7404])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@perf@blocking:
- shard-skl: [PASS][95] -> [FAIL][96] ([i915#1542]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl4/igt@perf@blocking.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl1/igt@perf@blocking.html
#### Possible fixes ####
* igt@gem_bad_reloc@negative-reloc-lut:
- {shard-rkl}: [SKIP][97] ([i915#3281]) -> [PASS][98] +4 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-2/igt@gem_bad_reloc@negative-reloc-lut.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-5/igt@gem_bad_reloc@negative-reloc-lut.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][99] ([i915#4525]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb1/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_capture@pi@vcs0:
- shard-skl: [INCOMPLETE][101] ([i915#3371]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl6/igt@gem_exec_capture@pi@vcs0.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl1/igt@gem_exec_capture@pi@vcs0.html
* igt@gem_partial_pwrite_pread@writes-after-reads:
- {shard-rkl}: [SKIP][103] ([i915#3282]) -> [PASS][104] +8 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-1/igt@gem_partial_pwrite_pread@writes-after-reads.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads.html
* igt@gen9_exec_parse@bb-start-out:
- {shard-rkl}: [SKIP][105] ([i915#2527]) -> [PASS][106] +3 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-1/igt@gen9_exec_parse@bb-start-out.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-5/igt@gen9_exec_parse@bb-start-out.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][107] ([i915#3989] / [i915#454]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb7/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-skl: [WARN][109] ([i915#1804]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl9/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl10/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- {shard-dg1}: [FAIL][111] ([i915#3591]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-dg1-12/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][113] ([i915#1397]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-2/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-6/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_pm_rpm@i2c:
- {shard-rkl}: [SKIP][115] ([fdo#109308]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-2/igt@i915_pm_rpm@i2c.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-6/igt@i915_pm_rpm@i2c.html
* igt@i915_pm_rps@engine-order:
- shard-tglb: [FAIL][117] ([i915#6537]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-tglb6/igt@i915_pm_rps@engine-order.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-tglb5/igt@i915_pm_rps@engine-order.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1:
- shard-skl: [FAIL][119] ([i915#2521]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl1/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl4/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1.html
* igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1:
- shard-apl: [DMESG-WARN][121] ([i915#180]) -> [PASS][122] +2 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [FAIL][123] ([i915#2346]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1:
- shard-skl: [FAIL][125] ([i915#2122]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl6/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl6/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render:
- {shard-rkl}: [SKIP][127] ([i915#1849] / [i915#4098]) -> [PASS][128] +11 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-skl: [DMESG-WARN][129] ([i915#1982]) -> [PASS][130] +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl4/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl1/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- {shard-rkl}: [SKIP][131] ([i915#1849] / [i915#3558]) -> [PASS][132] +1 similar issue
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
* igt@kms_plane_lowres@tiling-y@pipe-c-hdmi-a-1:
- shard-glk: [FAIL][133] ([i915#7307]) -> [PASS][134] +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-glk2/igt@kms_plane_lowres@tiling-y@pipe-c-hdmi-a-1.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-glk3/igt@kms_plane_lowres@tiling-y@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [SKIP][135] ([i915#5176]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb8/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [SKIP][137] ([i915#5235]) -> [PASS][138] +8 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb6/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][139] ([fdo#109441]) -> [PASS][140] +4 similar issues
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@sprite_plane_onoff:
- {shard-rkl}: [SKIP][141] ([i915#1072]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-4/igt@kms_psr@sprite_plane_onoff.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-6/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [SKIP][143] ([i915#5519]) -> [PASS][144]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-tglb6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-tglb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_vblank@pipe-b-query-idle:
- {shard-rkl}: [SKIP][145] ([i915#1845] / [i915#4098]) -> [PASS][146] +21 similar issues
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-2/igt@kms_vblank@pipe-b-query-idle.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-6/igt@kms_vblank@pipe-b-query-idle.html
* igt@perf_pmu@interrupts:
- shard-skl: [FAIL][147] ([i915#7318]) -> [PASS][148]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-skl9/igt@perf_pmu@interrupts.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-skl10/igt@perf_pmu@interrupts.html
* igt@prime_vgem@coherency-gtt:
- {shard-rkl}: [SKIP][149] ([fdo#109295] / [fdo#111656] / [i915#3708]) -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-rkl-2/igt@prime_vgem@coherency-gtt.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-rkl-5/igt@prime_vgem@coherency-gtt.html
* igt@sysfs_heartbeat_interval@precise@bcs0:
- {shard-dg1}: [FAIL][151] ([i915#1755]) -> [PASS][152]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-dg1-12/igt@sysfs_heartbeat_interval@precise@bcs0.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-dg1-13/igt@sysfs_heartbeat_interval@precise@bcs0.html
#### Warnings ####
* igt@gem_pread@exhaustion:
- shard-apl: [WARN][153] ([i915#2658]) -> [INCOMPLETE][154] ([i915#7248])
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-apl2/igt@gem_pread@exhaustion.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl6/igt@gem_pread@exhaustion.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1:
- shard-apl: [FAIL][155] ([i915#4573]) -> [DMESG-FAIL][156] ([IGT#6]) +1 similar issue
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-apl6/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl2/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][157] ([i915#658]) -> [SKIP][158] ([i915#2920]) +1 similar issue
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb5/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][159] ([i915#2920]) -> [SKIP][160] ([fdo#111068] / [i915#658])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-iclb6/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][161], [FAIL][162], [FAIL][163], [FAIL][164]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][165], [FAIL][166], [FAIL][167]) ([i915#3002] / [i915#4312])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-apl8/igt@runner@aborted.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-apl1/igt@runner@aborted.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-apl3/igt@runner@aborted.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12375/shard-apl1/igt@runner@aborted.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl1/igt@runner@aborted.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl1/igt@runner@aborted.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/shard-apl1/igt@runner@aborted.html
### Piglit changes ###
#### Issues hit ####
* spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2:
- pig-skl-6260u: NOTRUN -> [WARN][168] ([mesa#1797]) +1 similar issue
[168]: None
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3371]: https://gitlab.freedesktop.org/drm/intel/issues/3371
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6159]: https://gitlab.freedesktop.org/drm/intel/issues/6159
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6991]: https://gitlab.freedesktop.org/drm/intel/issues/6991
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7307]: https://gitlab.freedesktop.org/drm/intel/issues/7307
[i915#7318]: https://gitlab.freedesktop.org/drm/intel/issues/7318
[i915#7404]: https://gitlab.freedesktop.org/drm/intel/issues/7404
[mesa#1797]: https://gitlab.freedesktop.org/mesa/mesa/issues/1797
Build changes
-------------
* Linux: CI_DRM_12375 -> Patchwork_110038v4
CI-20190529: 20190529
CI_DRM_12375: 80e6b3384febc6243acf125fd5441732b1bdfe8d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7053: a9e73e6c48ab6632e2adb095cb809118b437fdfd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110038v4: 80e6b3384febc6243acf125fd5441732b1bdfe8d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110038v4/index.html
[-- Attachment #2: Type: text/html, Size: 39081 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v4] drm/i915/pps: improve eDP power on flow
2022-11-14 6:21 ` [Intel-gfx] [v4] drm/i915/pps: improve eDP power on flow Lee Shawn C
@ 2022-11-16 15:44 ` Jani Nikula
2022-11-16 15:57 ` Lee, Shawn C
0 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2022-11-16 15:44 UTC (permalink / raw)
To: Lee Shawn C, intel-gfx
On Mon, 14 Nov 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> After i915 dirver initialized, a panel power off cycle delay
> always append before turn eDP on. If eDP display did not
> power on before. With this change, power off duration might
> longer than power cycle delay. So driver can save power cycle
> delay to speed up driver initialization time.
>
> v2: fix commit messages
> v3: refine panel_power_off_time default value and modify
> commit messages
> v4: add eDP power off cycle delay at the path to unload i915 module
>
> Cc: Shankar Uma <uma.shankar@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
> drivers/gpu/drm/i915/i915_driver.c | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
> index 81ee7f3aadf6..ab4118b38120 100644
> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> @@ -1100,7 +1100,7 @@ bool intel_pps_have_panel_power_or_vdd(struct intel_dp *intel_dp)
>
> static void pps_init_timestamps(struct intel_dp *intel_dp)
> {
> - intel_dp->pps.panel_power_off_time = ktime_get_boottime();
> + intel_dp->pps.panel_power_off_time = 0;
> intel_dp->pps.last_power_on = jiffies;
> intel_dp->pps.last_backlight_off = jiffies;
> }
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index c3d43f9b1e45..0e3cbd129055 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -107,6 +107,8 @@ static const char irst_name[] = "INT3392";
>
> static const struct drm_driver i915_drm_driver;
>
> +static void intel_shutdown_encoders(struct drm_i915_private *dev_priv);
> +
> static void i915_release_bridge_dev(struct drm_device *dev,
> void *bridge)
> {
> @@ -796,6 +798,8 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)
>
> intel_display_driver_unregister(dev_priv);
>
> + intel_shutdown_encoders(dev_priv);
> +
Per Ville's comments on IRC, this is still too early. See [1] for
another approach.
BR,
Jani.
[1] https://patchwork.freedesktop.org/patch/msgid/20221116150657.1347504-1-jani.nikula@intel.com
> for_each_gt(gt, dev_priv, i)
> intel_gt_driver_unregister(gt);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [v4] drm/i915/pps: improve eDP power on flow
2022-11-16 15:44 ` Jani Nikula
@ 2022-11-16 15:57 ` Lee, Shawn C
0 siblings, 0 replies; 24+ messages in thread
From: Lee, Shawn C @ 2022-11-16 15:57 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On Wednesday, November 16, 2022 11:45 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>On Mon, 14 Nov 2022, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>> After i915 dirver initialized, a panel power off cycle delay always
>> append before turn eDP on. If eDP display did not power on before.
>> With this change, power off duration might longer than power cycle
>> delay. So driver can save power cycle delay to speed up driver
>> initialization time.
>>
>> v2: fix commit messages
>> v3: refine panel_power_off_time default value and modify
>> commit messages
>> v4: add eDP power off cycle delay at the path to unload i915 module
>>
>> Cc: Shankar Uma <uma.shankar@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
>> drivers/gpu/drm/i915/i915_driver.c | 4 ++++
>> 2 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
>> b/drivers/gpu/drm/i915/display/intel_pps.c
>> index 81ee7f3aadf6..ab4118b38120 100644
>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>> @@ -1100,7 +1100,7 @@ bool intel_pps_have_panel_power_or_vdd(struct
>> intel_dp *intel_dp)
>>
>> static void pps_init_timestamps(struct intel_dp *intel_dp) {
>> - intel_dp->pps.panel_power_off_time = ktime_get_boottime();
>> + intel_dp->pps.panel_power_off_time = 0;
>> intel_dp->pps.last_power_on = jiffies;
>> intel_dp->pps.last_backlight_off = jiffies; } diff --git
>> a/drivers/gpu/drm/i915/i915_driver.c
>> b/drivers/gpu/drm/i915/i915_driver.c
>> index c3d43f9b1e45..0e3cbd129055 100644
>> --- a/drivers/gpu/drm/i915/i915_driver.c
>> +++ b/drivers/gpu/drm/i915/i915_driver.c
>> @@ -107,6 +107,8 @@ static const char irst_name[] = "INT3392";
>>
>> static const struct drm_driver i915_drm_driver;
>>
>> +static void intel_shutdown_encoders(struct drm_i915_private
>> +*dev_priv);
>> +
>> static void i915_release_bridge_dev(struct drm_device *dev,
>> void *bridge)
>> {
>> @@ -796,6 +798,8 @@ static void i915_driver_unregister(struct
>> drm_i915_private *dev_priv)
>>
>> intel_display_driver_unregister(dev_priv);
>>
>> + intel_shutdown_encoders(dev_priv);
>> +
>
>Per Ville's comments on IRC, this is still too early. See [1] for another approach.
>
>BR,
>Jani.
>
Thank you! I've tested this patch and it works properly. Detail kernel log is attached on [2].
Please help to review and merge that patch ASAP.
Best regards,
Shawn
>
>[1] https://patchwork.freedesktop.org/patch/msgid/20221116150657.1347504-1-jani.nikula@intel.com
[2] https://gitlab.freedesktop.org/drm/intel/-/issues/7417#note_1643009
>
>
>> for_each_gt(gt, dev_priv, i)
>> intel_gt_driver_unregister(gt);
>
>--
>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2022-11-16 15:57 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 6:40 [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow Lee Shawn C
2022-10-24 7:39 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-10-24 13:16 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2022-10-24 13:47 ` Lee, Shawn C
2022-10-24 14:21 ` Ville Syrjälä
2022-10-24 14:06 ` [Intel-gfx] [v2] " Lee Shawn C
2022-11-01 9:53 ` Jani Nikula
2022-11-01 10:50 ` Lee, Shawn C
2022-11-01 13:43 ` Jani Nikula
2022-11-01 14:40 ` Lee, Shawn C
2022-11-01 14:42 ` Lee, Shawn C
2022-11-02 10:19 ` Jani Nikula
2022-11-02 14:50 ` Lee, Shawn C
2022-10-24 17:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pps: improve eDP power on flow. (rev2) Patchwork
2022-11-03 0:40 ` [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow Lee Shawn C
2022-11-03 11:00 ` Jani Nikula
2022-11-03 11:23 ` Lee, Shawn C
2022-11-03 1:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pps: improve eDP power on flow. (rev3) Patchwork
2022-11-03 14:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-14 6:21 ` [Intel-gfx] [v4] drm/i915/pps: improve eDP power on flow Lee Shawn C
2022-11-16 15:44 ` Jani Nikula
2022-11-16 15:57 ` Lee, Shawn C
2022-11-14 11:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pps: improve eDP power on flow. (rev4) Patchwork
2022-11-14 17:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.