Build error with dunfell release "yocto-3.1.24"

Build error with dunfell release "yocto-3.1.24"

[Gaurav Gupta (gauragup)]

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

Hello,

On latest “dunfell” branch, there’s a compiler warning/error when building QEMU.

The patch for CVE-2021-3929 applied on dunfell returns a value for a void function: https://github.com/openembedded/openembedded-core/blob/dunfell/meta/recipes-devtools/qemu/qemu/CVE-2021-3929.patch#L58

This results in the following warning/error:


<ws>/qemu/4.2.0-r0/qemu-4.2.0/hw/block/nvme.c:77:6: error: void function 'nvme_addr_read' should not return a value [-Wreturn-type]

return NVME_DATA_TRAS_ERROR;

^      ~~~~~~~~~~~~~~~~~~~~

In newer versions of qemu, the functions is changed to have a return value, but that is not present in the version of qemu used in “dunfell”.

Thanks,
Gaurav

[-- Attachment #2: Type: text/html, Size: 3893 bytes --]

Re: [OE-core] Build error with dunfell release "yocto-3.1.24"

[Khem Raj]

On Wed, Mar 29, 2023 at 9:51 AM Gaurav Gupta (gauragup) via
lists.openembedded.org <gauragup=cisco.com@lists.openembedded.org>
wrote:
>
> Hello,
>
>
>
> On latest “dunfell” branch, there’s a compiler warning/error when building QEMU.
>
>
>
> The patch for CVE-2021-3929 applied on dunfell returns a value for a void function: https://github.com/openembedded/openembedded-core/blob/dunfell/meta/recipes-devtools/qemu/qemu/CVE-2021-3929.patch#L58
>
>
>
> This results in the following warning/error:
>
>
>
> <ws>/qemu/4.2.0-r0/qemu-4.2.0/hw/block/nvme.c:77:6: error: void function 'nvme_addr_read' should not return a value [-Wreturn-type]
>
> return NVME_DATA_TRAS_ERROR;
>
> ^      ~~~~~~~~~~~~~~~~~~~~
>
>
>
> In newer versions of qemu, the functions is changed to have a return value, but that is not present in the version of qemu used in “dunfell”.
>
>

yeah perhaps we need to backport
https://github.com/qemu/qemu/commit/94cbcf530f9d9789b75ef1ae227ba4a4f702bf7d
as well.

https://github.com/openembedded/openembedded-core/blob/dunfell/meta/recipes-devtools/qemu/qemu/CVE-2021-3929.patch#L58

>
> Thanks,
>
> Gaurav
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#179292): https://lists.openembedded.org/g/openembedded-core/message/179292
> Mute This Topic: https://lists.openembedded.org/mt/97933015/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] Build error with dunfell release "yocto-3.1.24"

[Steve Sakoman]

On Wed, Mar 29, 2023 at 8:03 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Wed, Mar 29, 2023 at 9:51 AM Gaurav Gupta (gauragup) via
> lists.openembedded.org <gauragup=cisco.com@lists.openembedded.org>
> wrote:
> >
> > Hello,
> >
> >
> >
> > On latest “dunfell” branch, there’s a compiler warning/error when building QEMU.
> >
> >
> >
> > The patch for CVE-2021-3929 applied on dunfell returns a value for a void function: https://github.com/openembedded/openembedded-core/blob/dunfell/meta/recipes-devtools/qemu/qemu/CVE-2021-3929.patch#L58
> >
> >
> >
> > This results in the following warning/error:
> >
> >
> >
> > <ws>/qemu/4.2.0-r0/qemu-4.2.0/hw/block/nvme.c:77:6: error: void function 'nvme_addr_read' should not return a value [-Wreturn-type]
> >
> > return NVME_DATA_TRAS_ERROR;
> >
> > ^      ~~~~~~~~~~~~~~~~~~~~
> >
> >
> >
> > In newer versions of qemu, the functions is changed to have a return value, but that is not present in the version of qemu used in “dunfell”.
> >
> >
>
> yeah perhaps we need to backport
> https://github.com/qemu/qemu/commit/94cbcf530f9d9789b75ef1ae227ba4a4f702bf7d
> as well.
>
> https://github.com/openembedded/openembedded-core/blob/dunfell/meta/recipes-devtools/qemu/qemu/CVE-2021-3929.patch#L58

I haven't seen this error on the autobuilder!

Gaurav, could you try the patch that Khem suggested above and see if
that works for you?

If so please submit a patch!

Thanks,

Steve


> > Thanks,
> >
> > Gaurav
> >
> >
> >
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#179293): https://lists.openembedded.org/g/openembedded-core/message/179293
> Mute This Topic: https://lists.openembedded.org/mt/97933015/3620601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] Build error with dunfell release "yocto-3.1.24"

[Gaurav Gupta (gauragup)]

[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]

Yes, testing the build right now, will post the patch.

Thanks,
Gaurav

From: Steve Sakoman <steve@sakoman.com>
Date: Wednesday, March 29, 2023 at 12:18 PM
To: Gaurav Gupta (gauragup) <gauragup@cisco.com>
Cc: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>, Khem Raj <raj.khem@gmail.com>
Subject: Re: [OE-core] Build error with dunfell release "yocto-3.1.24"
On Wed, Mar 29, 2023 at 8:03 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Wed, Mar 29, 2023 at 9:51 AM Gaurav Gupta (gauragup) via
> lists.openembedded.org <gauragup=cisco.com@lists.openembedded.org>
> wrote:
> >
> > Hello,
> >
> >
> >
> > On latest “dunfell” branch, there’s a compiler warning/error when building QEMU.
> >
> >
> >
> > The patch for CVE-2021-3929 applied on dunfell returns a value for a void function: https://github.com/openembedded/openembedded-core/blob/dunfell/meta/recipes-devtools/qemu/qemu/CVE-2021-3929.patch#L58
> >
> >
> >
> > This results in the following warning/error:
> >
> >
> >
> > <ws>/qemu/4.2.0-r0/qemu-4.2.0/hw/block/nvme.c:77:6: error: void function 'nvme_addr_read' should not return a value [-Wreturn-type]
> >
> > return NVME_DATA_TRAS_ERROR;
> >
> > ^      ~~~~~~~~~~~~~~~~~~~~
> >
> >
> >
> > In newer versions of qemu, the functions is changed to have a return value, but that is not present in the version of qemu used in “dunfell”.
> >
> >
>
> yeah perhaps we need to backport
> https://github.com/qemu/qemu/commit/94cbcf530f9d9789b75ef1ae227ba4a4f702bf7d
> as well.
>
> https://github.com/openembedded/openembedded-core/blob/dunfell/meta/recipes-devtools/qemu/qemu/CVE-2021-3929.patch#L58

I haven't seen this error on the autobuilder!

Gaurav, could you try the patch that Khem suggested above and see if
that works for you?

If so please submit a patch!

Thanks,

Steve


> > Thanks,
> >
> > Gaurav
> >
> >
> >
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#179293): https://lists.openembedded.org/g/openembedded-core/message/179293
> Mute This Topic: https://lists.openembedded.org/mt/97933015/3620601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

[-- Attachment #2: Type: text/html, Size: 5323 bytes --]