From: "Moore, Robert" <robert.moore@intel.com> To: Garrit Franke <garritfranke@gmail.com>, "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>, "lenb@kernel.org" <lenb@kernel.org>, "trivial@kernel.org" <trivial@kernel.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "devel@acpica.org" <devel@acpica.org>, "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org> Subject: RE: [PATCH] trivial: acpi: replace some bitshifts with BIT macro Date: Fri, 24 Jul 2020 16:29:14 +0000 [thread overview] Message-ID: <BYAPR11MB325604ACC5F3BCCEB89A58AA87770@BYAPR11MB3256.namprd11.prod.outlook.com> (raw) In-Reply-To: <20200724162050.18077-2-garritfranke@gmail.com> Where is "BIT" defined? -----Original Message----- From: Garrit Franke <garritfranke@gmail.com> Sent: Friday, July 24, 2020 9:21 AM To: Moore, Robert <robert.moore@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; lenb@kernel.org; trivial@kernel.org; linux-acpi@vger.kernel.org; devel@acpica.org; kernel-janitors@vger.kernel.org Cc: Garrit Franke <garritfranke@gmail.com> Subject: [PATCH] trivial: acpi: replace some bitshifts with BIT macro Signed-off-by: Garrit Franke <garritfranke@gmail.com> --- drivers/acpi/acpica/exfldio.c | 2 +- drivers/acpi/acpica/utownerid.c | 6 +++--- drivers/acpi/bus.c | 2 +- drivers/acpi/sleep.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/acpica/exfldio.c b/drivers/acpi/acpica/exfldio.c index ade35ff1c7..92fc702456 100644 --- a/drivers/acpi/acpica/exfldio.c +++ b/drivers/acpi/acpica/exfldio.c @@ -298,7 +298,7 @@ acpi_ex_register_overflow(union acpi_operand_object *obj_desc, u64 value) return (FALSE); } - if (value >= ((u64) 1 << obj_desc->common_field.bit_length)) { + if (value >= ((u64) BIT(obj_desc->common_field.bit_length))) { /* * The Value is larger than the maximum value that can fit into * the register. diff --git a/drivers/acpi/acpica/utownerid.c b/drivers/acpi/acpica/utownerid.c index d3525ef8ed..c4e2db2f54 100644 --- a/drivers/acpi/acpica/utownerid.c +++ b/drivers/acpi/acpica/utownerid.c @@ -74,13 +74,13 @@ acpi_status acpi_ut_allocate_owner_id(acpi_owner_id *owner_id) * int. Some compilers or runtime error detection may flag this as * an error. */ - if (!(acpi_gbl_owner_id_mask[j] & ((u32)1 << k))) { + if (!(acpi_gbl_owner_id_mask[j] & (u32)BIT(k))) { /* * Found a free ID. The actual ID is the bit index plus one, * making zero an invalid Owner ID. Save this as the last ID * allocated and update the global ID mask. */ - acpi_gbl_owner_id_mask[j] |= ((u32)1 << k); + acpi_gbl_owner_id_mask[j] |= (u32)BIT(k); acpi_gbl_last_owner_id_index = (u8)j; acpi_gbl_next_owner_id_offset = (u8)(k + 1); @@ -171,7 +171,7 @@ void acpi_ut_release_owner_id(acpi_owner_id *owner_id_ptr) /* Decode ID to index/offset pair */ index = ACPI_DIV_32(owner_id); - bit = (u32)1 << ACPI_MOD_32(owner_id); + bit = (u32)BIT(ACPI_MOD_32(owner_id)); /* Free the owner ID only if it is valid */ diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 54002670cb..39ead80c45 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -233,7 +233,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context) goto out_kfree; } /* Need to ignore the bit0 in result code */ - errors = *((u32 *)out_obj->buffer.pointer) & ~(1 << 0); + errors = *((u32 *)out_obj->buffer.pointer) & BIT(0); if (errors) { if (errors & OSC_REQUEST_ERROR) acpi_print_osc_error(handle, context, diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index aff13bf4d9..38f5210313 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -880,7 +880,7 @@ static void acpi_sleep_run_lps0_dsm(unsigned int func) { union acpi_object *out_obj; - if (!(lps0_dsm_func_mask & (1 << func))) + if (!(lps0_dsm_func_mask & BIT(func))) return; out_obj = acpi_evaluate_dsm(lps0_device_handle, &lps0_dsm_guid, 1, func, NULL); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Moore, Robert <robert.moore at intel.com> To: devel@acpica.org Subject: [Devel] Re: [PATCH] trivial: acpi: replace some bitshifts with BIT macro Date: Fri, 24 Jul 2020 16:29:14 +0000 [thread overview] Message-ID: <BYAPR11MB325604ACC5F3BCCEB89A58AA87770@BYAPR11MB3256.namprd11.prod.outlook.com> (raw) In-Reply-To: 20200724162050.18077-2-garritfranke@gmail.com [-- Attachment #1: Type: text/plain, Size: 3469 bytes --] Where is "BIT" defined? -----Original Message----- From: Garrit Franke <garritfranke(a)gmail.com> Sent: Friday, July 24, 2020 9:21 AM To: Moore, Robert <robert.moore(a)intel.com>; Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>; lenb(a)kernel.org; trivial(a)kernel.org; linux-acpi(a)vger.kernel.org; devel(a)acpica.org; kernel-janitors(a)vger.kernel.org Cc: Garrit Franke <garritfranke(a)gmail.com> Subject: [PATCH] trivial: acpi: replace some bitshifts with BIT macro Signed-off-by: Garrit Franke <garritfranke(a)gmail.com> --- drivers/acpi/acpica/exfldio.c | 2 +- drivers/acpi/acpica/utownerid.c | 6 +++--- drivers/acpi/bus.c | 2 +- drivers/acpi/sleep.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/acpica/exfldio.c b/drivers/acpi/acpica/exfldio.c index ade35ff1c7..92fc702456 100644 --- a/drivers/acpi/acpica/exfldio.c +++ b/drivers/acpi/acpica/exfldio.c @@ -298,7 +298,7 @@ acpi_ex_register_overflow(union acpi_operand_object *obj_desc, u64 value) return (FALSE); } - if (value >= ((u64) 1 << obj_desc->common_field.bit_length)) { + if (value >= ((u64) BIT(obj_desc->common_field.bit_length))) { /* * The Value is larger than the maximum value that can fit into * the register. diff --git a/drivers/acpi/acpica/utownerid.c b/drivers/acpi/acpica/utownerid.c index d3525ef8ed..c4e2db2f54 100644 --- a/drivers/acpi/acpica/utownerid.c +++ b/drivers/acpi/acpica/utownerid.c @@ -74,13 +74,13 @@ acpi_status acpi_ut_allocate_owner_id(acpi_owner_id *owner_id) * int. Some compilers or runtime error detection may flag this as * an error. */ - if (!(acpi_gbl_owner_id_mask[j] & ((u32)1 << k))) { + if (!(acpi_gbl_owner_id_mask[j] & (u32)BIT(k))) { /* * Found a free ID. The actual ID is the bit index plus one, * making zero an invalid Owner ID. Save this as the last ID * allocated and update the global ID mask. */ - acpi_gbl_owner_id_mask[j] |= ((u32)1 << k); + acpi_gbl_owner_id_mask[j] |= (u32)BIT(k); acpi_gbl_last_owner_id_index = (u8)j; acpi_gbl_next_owner_id_offset = (u8)(k + 1); @@ -171,7 +171,7 @@ void acpi_ut_release_owner_id(acpi_owner_id *owner_id_ptr) /* Decode ID to index/offset pair */ index = ACPI_DIV_32(owner_id); - bit = (u32)1 << ACPI_MOD_32(owner_id); + bit = (u32)BIT(ACPI_MOD_32(owner_id)); /* Free the owner ID only if it is valid */ diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 54002670cb..39ead80c45 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -233,7 +233,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context) goto out_kfree; } /* Need to ignore the bit0 in result code */ - errors = *((u32 *)out_obj->buffer.pointer) & ~(1 << 0); + errors = *((u32 *)out_obj->buffer.pointer) & BIT(0); if (errors) { if (errors & OSC_REQUEST_ERROR) acpi_print_osc_error(handle, context, diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index aff13bf4d9..38f5210313 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -880,7 +880,7 @@ static void acpi_sleep_run_lps0_dsm(unsigned int func) { union acpi_object *out_obj; - if (!(lps0_dsm_func_mask & (1 << func))) + if (!(lps0_dsm_func_mask & BIT(func))) return; out_obj = acpi_evaluate_dsm(lps0_device_handle, &lps0_dsm_guid, 1, func, NULL); -- 2.25.1
next prev parent reply other threads:[~2020-07-24 16:29 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <alpine.DEB.2.21.2007241814450.2834@hadrien> 2020-07-24 16:20 ` [PATCH] trivial: acpi: replace some bitshifts with BIT macro Garrit Franke 2020-07-24 16:20 ` Garrit Franke 2020-07-24 16:29 ` Moore, Robert [this message] 2020-07-24 16:29 ` [Devel] " Moore, Robert 2020-07-24 16:40 ` Colin Ian King 2020-07-24 16:40 ` Colin Ian King 2020-07-24 16:40 ` Colin Ian King 2020-07-24 16:47 ` Garrit Franke 2020-07-24 16:47 ` Garrit Franke 2020-07-24 16:50 ` Moore, Robert 2020-07-24 16:50 ` [Devel] " Moore, Robert 2020-07-28 20:03 ` Moore, Robert 2020-07-28 20:03 ` [Devel] " Moore, Robert 2020-07-24 16:02 garritfra 2020-07-24 16:02 ` garritfra 2020-07-27 12:48 ` Dan Carpenter 2020-07-27 12:48 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BYAPR11MB325604ACC5F3BCCEB89A58AA87770@BYAPR11MB3256.namprd11.prod.outlook.com \ --to=robert.moore@intel.com \ --cc=devel@acpica.org \ --cc=garritfranke@gmail.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=rafael.j.wysocki@intel.com \ --cc=trivial@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.