From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Thomas Monjalon" <thomas@monjalon.net>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm
Date: Wed, 3 Jun 2020 10:23:10 +0000 [thread overview]
Message-ID: <BYAPR11MB33017E3A48467B7663A93B0A9A880@BYAPR11MB3301.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2931549.x8W8VkzX4A@thomas>
> > Directive #include <file> in gcc implementation searches for files
> > in a standard list of system directories, which leads to a sporadici
> > build error on Taishan arm machines:
> > /tmp/openvpp-testing/dpdk/lib/librte_ethdev/rte_ethdev.h:4287:10:
> > fatal error: rte_ethdev_core.h:
> > No such file or directory #include <rte_ethdev_core.h>
>
> Would be interesting to know why nobody else hit such error?
Same question.
Again why it happens for rte_ethdev library only?
We do have multiple headers in other libs too.
>
>
> > Fix this by replacing the directive with #include "file" which searches
> > for files first in the directory containing the current file and other
> > directories only after that.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
>
> What about #include <rte_ethdev_trace.h> ?
>
> Except this,
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
>
> I would change the title to be more generic (nothing specific to gcc or Arm here):
> ethdev: fix local include
>
> It needs to be backported, so these lines are required:
> Fixes: 7f0a669e7b04 ("ethdev: add allocation helper for virtual drivers")
> Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
> Fixes: ffc905f3b856 ("ethdev: separate driver APIs")
> Fixes: 331c447ad913 ("ethdev: separate internal structures into own header")
> Cc: stable@dpdk.org
>
>
next prev parent reply other threads:[~2020-06-03 10:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 9:48 [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm Juraj Linkeš
2020-06-03 10:16 ` Thomas Monjalon
2020-06-03 10:23 ` Ananyev, Konstantin [this message]
2020-06-03 10:47 ` Juraj Linkeš
2020-06-03 12:05 ` Thomas Monjalon
2020-06-03 11:40 ` Ferruh Yigit
2020-06-04 10:36 ` Juraj Linkeš
2020-06-04 12:22 ` Ferruh Yigit
2020-06-04 12:50 ` Ferruh Yigit
2020-06-04 12:55 ` Juraj Linkeš
2020-06-04 13:29 ` Ferruh Yigit
2020-06-05 11:59 ` Juraj Linkeš
2020-06-08 8:17 ` Juraj Linkeš
2020-06-08 11:38 ` Ferruh Yigit
2020-06-08 12:03 ` Juraj Linkeš
2020-06-08 12:39 ` Ferruh Yigit
2020-06-08 13:19 ` Juraj Linkeš
2020-06-08 13:46 ` Ferruh Yigit
2020-06-04 13:41 ` Bruce Richardson
2020-06-05 12:00 ` Juraj Linkeš
2020-06-05 12:55 ` Bruce Richardson
2020-06-03 13:58 ` Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB33017E3A48467B7663A93B0A9A880@BYAPR11MB3301.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=juraj.linkes@pantheon.tech \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.