Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

[Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>]

<snip>

> 
> 03/06/2020 11:48, Juraj Linkeš:
> > Directive #include <file> in gcc implementation searches for files in
> > a standard list of system directories, which leads to a sporadici
> > build error on Taishan arm machines:
> > /tmp/openvpp-testing/dpdk/lib/librte_ethdev/rte_ethdev.h:4287:10:
> > fatal error: rte_ethdev_core.h:
> > No such file or directory #include <rte_ethdev_core.h>
> 
> Would be interesting to know why nobody else hit such error?
I have hit this multiple times (after a fresh config) on other Arm machines, subsequent run of the compilation would fix this. Thanks for fixing.

> 
> 
> > Fix this by replacing the directive with #include "file" which
> > searches for files first in the directory containing the current file
> > and other directories only after that.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> 
> What about #include <rte_ethdev_trace.h> ?
> 
> Except this,
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
> 
> I would change the title to be more generic (nothing specific to gcc or Arm
> here):
> 	ethdev: fix local include
> 
> It needs to be backported, so these lines are required:
> 	Fixes: 7f0a669e7b04 ("ethdev: add allocation helper for virtual
> drivers")
> 	Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
> 	Fixes: ffc905f3b856 ("ethdev: separate driver APIs")
> 	Fixes: 331c447ad913 ("ethdev: separate internal structures into own
> header")
> 	Cc: stable@dpdk.org
> 
>