From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Feifei Wang <feifei.wang2@arm.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] ring: use element APIs to implement legacy APIs
Date: Tue, 7 Jul 2020 14:45:52 +0000 [thread overview]
Message-ID: <BYAPR11MB330195DA49CC844234B8B3E19A660@BYAPR11MB3301.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200703102651.8918-4-feifei.wang2@arm.com>
>
> Use rte_ring_xxx_elem_xxx APIs to replace legacy API implementation.
> This reduces code duplication and improves code maintenance.
>
> aarch64:
> HW:N1sdp, 1 socket, 4 cores, 1 thread/core, 2.6GHz
> OS:Ubuntu 18.04.1 LTS, Kernel: 5.4.0+
> DPDK: 20.05-rc3, Configuration: arm64-n1sdp-linux-gcc
> gcc:9.2.1
>
> $sudo ./arm64-n1sdp-linux-gcc/app/test -l 1-2
> RTE>>ring_perf_autotest
>
> test results on aarch64 in the case of esize 4:
>
> without this patch with this patch
> Testing burst enq/deq
> legacy APIs: SP/SC: burst (size: 8): 1.11 1.10
> legacy APIs: SP/SC: burst (size: 32): 1.95 1.97
> legacy APIs: MP/MC: burst (size: 8): 1.86 1.94
> legacy APIs: MP/MC: burst (size: 32): 2.65 2.69
> Testing bulk enq/deq
> legacy APIs: SP/SC: bulk (size: 8): 1.08 1.09
> legacy APIs: SP/SC: bulk (size: 32): 1.89 1.90
> legacy APIs: MP/MC: bulk (size: 8): 1.85 1.98
> legacy APIs: MP/MC: bulk (size: 32): 2.65 2.69
>
> x86:
> HW: dell, CPU Intel(R) Xeon(R) Gold 6240, 2 sockets, 18 cores/socket,
> 1 thread/core, 3.3GHz
> OS: Ubuntu 20.04 LTS, Kernel: 5.4.0-37-generic
> DPDK: 20.05-rc3, Configuration: x86_64-native-linuxapp-gcc
> gcc: 9.3.0
>
> $sudo ./x86_64-native-linuxapp-gcc/app/test -l 14,16
> RTE>>ring_perf_autotest
>
> test results on x86 in the case of esize 4:
>
> without this patch with this patch
> Testing burst enq/deq
> legacy APIs: SP/SC: burst (size: 8): 29.35 27.78
> legacy APIs: SP/SC: burst (size: 32): 73.11 73.39
> legacy APIs: MP/MC: burst (size: 8): 62.36 62.37
> legacy APIs: MP/MC: burst (size: 32): 101.01 101.03
> Testing bulk enq/deq
> legacy APIs: SP/SC: bulk (size: 8): 25.94 29.55
> legacy APIs: SP/SC: bulk (size: 32): 70.00 78.87
> legacy APIs: MP/MC: bulk (size: 8): 63.41 62.48
> legacy APIs: MP/MC: bulk (size: 32): 105.86 103.84
>
> Summary:
> In aarch64 server with this patch, there is almost no performance
> difference.
> In x86 server with this patch, in some cases, the performance slightly
> improve, in other cases, the performance slightly drop.
>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.17.1
next prev parent reply other threads:[~2020-07-07 14:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 10:26 [dpdk-dev] [PATCH 0/3] ring clean up Feifei Wang
2020-07-03 10:26 ` [dpdk-dev] [PATCH 1/3] ring: remove experimental tag for ring reset API Feifei Wang
2020-07-03 16:16 ` Kinsella, Ray
2020-07-03 18:46 ` Honnappa Nagarahalli
2020-07-06 6:23 ` Kinsella, Ray
2020-07-07 3:19 ` Feifei Wang
2020-07-07 7:40 ` Kinsella, Ray
2020-07-03 10:26 ` [dpdk-dev] [PATCH 2/3] ring: remove experimental tag for ring element APIs Feifei Wang
2020-07-03 16:17 ` Kinsella, Ray
2020-07-07 14:44 ` Ananyev, Konstantin
2020-07-03 10:26 ` [dpdk-dev] [PATCH 3/3] ring: use element APIs to implement legacy APIs Feifei Wang
2020-07-07 5:19 ` Feifei Wang
2020-07-07 14:04 ` Ananyev, Konstantin
2020-07-07 16:21 ` Honnappa Nagarahalli
2020-07-08 3:19 ` Feifei Wang
2020-07-07 20:07 ` David Christensen
2020-07-08 1:30 ` Feifei Wang
2020-07-08 1:21 ` Feifei Wang
2020-07-07 14:45 ` Ananyev, Konstantin [this message]
2020-07-08 14:51 ` [dpdk-dev] [PATCH 0/3] ring clean up David Marchand
2020-07-08 17:05 ` Ananyev, Konstantin
2020-07-08 20:33 ` Honnappa Nagarahalli
2020-07-09 2:27 ` Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB330195DA49CC844234B8B3E19A660@BYAPR11MB3301.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=feifei.wang2@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.