* [PATCH] ice: change "can't set link" message to dbg level
@ 2022-02-02 20:38 ` Jonathan Toppins
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Toppins @ 2022-02-02 20:38 UTC (permalink / raw)
To: netdev
Cc: intel-wired-lan, lihong.yang, Jesse Brandeburg, Tony Nguyen,
David S. Miller, Jakub Kicinski, linux-kernel
In the case where the link is owned by manageability, the firmware is
not allowed to set the link state, so an error code is returned.
This however is non-fatal and there is nothing the operator can do,
so instead of confusing the operator with messages they can do nothing
about hide this message behind the debug log level.
Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
---
drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 0c187cf04fcf..2c6dad56a48d 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -4117,7 +4117,7 @@ int ice_set_link(struct ice_vsi *vsi, bool ena)
*/
if (status == -EIO) {
if (hw->adminq.sq_last_status == ICE_AQ_RC_EMODE)
- dev_warn(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
+ dev_dbg(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
(ena ? "ON" : "OFF"), status,
ice_aq_str(hw->adminq.sq_last_status));
} else if (status) {
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH] ice: change "can't set link" message to dbg level
@ 2022-02-02 20:38 ` Jonathan Toppins
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Toppins @ 2022-02-02 20:38 UTC (permalink / raw)
To: intel-wired-lan
In the case where the link is owned by manageability, the firmware is
not allowed to set the link state, so an error code is returned.
This however is non-fatal and there is nothing the operator can do,
so instead of confusing the operator with messages they can do nothing
about hide this message behind the debug log level.
Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
---
drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 0c187cf04fcf..2c6dad56a48d 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -4117,7 +4117,7 @@ int ice_set_link(struct ice_vsi *vsi, bool ena)
*/
if (status == -EIO) {
if (hw->adminq.sq_last_status == ICE_AQ_RC_EMODE)
- dev_warn(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
+ dev_dbg(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
(ena ? "ON" : "OFF"), status,
ice_aq_str(hw->adminq.sq_last_status));
} else if (status) {
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ice: change "can't set link" message to dbg level
2022-02-02 20:38 ` [Intel-wired-lan] " Jonathan Toppins
@ 2022-02-03 0:06 ` Jakub Kicinski
-1 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2022-02-03 0:06 UTC (permalink / raw)
To: Jonathan Toppins
Cc: netdev, intel-wired-lan, lihong.yang, Jesse Brandeburg,
Tony Nguyen, David S. Miller, linux-kernel
On Wed, 2 Feb 2022 15:38:49 -0500 Jonathan Toppins wrote:
> - dev_warn(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
> + dev_dbg(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
> (ena ? "ON" : "OFF"), status,
> ice_aq_str(hw->adminq.sq_last_status));
Start of continuation lines needs to be adjusted.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH] ice: change "can't set link" message to dbg level
@ 2022-02-03 0:06 ` Jakub Kicinski
0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2022-02-03 0:06 UTC (permalink / raw)
To: intel-wired-lan
On Wed, 2 Feb 2022 15:38:49 -0500 Jonathan Toppins wrote:
> - dev_warn(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
> + dev_dbg(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
> (ena ? "ON" : "OFF"), status,
> ice_aq_str(hw->adminq.sq_last_status));
Start of continuation lines needs to be adjusted.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ice: change "can't set link" message to dbg level
2022-02-02 20:38 ` [Intel-wired-lan] " Jonathan Toppins
@ 2022-02-03 17:45 ` Jonathan Toppins
-1 siblings, 0 replies; 8+ messages in thread
From: Jonathan Toppins @ 2022-02-03 17:45 UTC (permalink / raw)
To: netdev
Cc: intel-wired-lan, lihong.yang, Jesse Brandeburg, Tony Nguyen,
David S. Miller, Jakub Kicinski, linux-kernel
In the case where the link is owned by manageability, the firmware is
not allowed to set the link state, so an error code is returned.
This however is non-fatal and there is nothing the operator can do,
so instead of confusing the operator with messages they can do nothing
about hide this message behind the debug log level.
Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
---
drivers/net/ethernet/intel/ice/ice_lib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 0c187cf04fcf..81b152133d11 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -4117,9 +4117,9 @@ int ice_set_link(struct ice_vsi *vsi, bool ena)
*/
if (status == -EIO) {
if (hw->adminq.sq_last_status == ICE_AQ_RC_EMODE)
- dev_warn(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
- (ena ? "ON" : "OFF"), status,
- ice_aq_str(hw->adminq.sq_last_status));
+ dev_dbg(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
+ (ena ? "ON" : "OFF"), status,
+ ice_aq_str(hw->adminq.sq_last_status));
} else if (status) {
dev_err(dev, "can't set link to %s, err %d aq_err %s\n",
(ena ? "ON" : "OFF"), status,
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH v2] ice: change "can't set link" message to dbg level
@ 2022-02-03 17:45 ` Jonathan Toppins
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Toppins @ 2022-02-03 17:45 UTC (permalink / raw)
To: intel-wired-lan
In the case where the link is owned by manageability, the firmware is
not allowed to set the link state, so an error code is returned.
This however is non-fatal and there is nothing the operator can do,
so instead of confusing the operator with messages they can do nothing
about hide this message behind the debug log level.
Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
---
drivers/net/ethernet/intel/ice/ice_lib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 0c187cf04fcf..81b152133d11 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -4117,9 +4117,9 @@ int ice_set_link(struct ice_vsi *vsi, bool ena)
*/
if (status == -EIO) {
if (hw->adminq.sq_last_status == ICE_AQ_RC_EMODE)
- dev_warn(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
- (ena ? "ON" : "OFF"), status,
- ice_aq_str(hw->adminq.sq_last_status));
+ dev_dbg(dev, "can't set link to %s, err %d aq_err %s. not fatal, continuing\n",
+ (ena ? "ON" : "OFF"), status,
+ ice_aq_str(hw->adminq.sq_last_status));
} else if (status) {
dev_err(dev, "can't set link to %s, err %d aq_err %s\n",
(ena ? "ON" : "OFF"), status,
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [Intel-wired-lan] [PATCH v2] ice: change "can't set link" message to dbg level
2022-02-03 17:45 ` [Intel-wired-lan] " Jonathan Toppins
@ 2022-02-10 5:29 ` G, GurucharanX
-1 siblings, 0 replies; 8+ messages in thread
From: G, GurucharanX @ 2022-02-10 5:29 UTC (permalink / raw)
To: Jonathan Toppins, netdev
Cc: linux-kernel, Jakub Kicinski, intel-wired-lan, David S. Miller
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jonathan Toppins
> Sent: Thursday, February 3, 2022 11:15 PM
> To: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; intel-
> wired-lan@lists.osuosl.org; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH v2] ice: change "can't set link" message to
> dbg level
>
> In the case where the link is owned by manageability, the firmware is not
> allowed to set the link state, so an error code is returned.
> This however is non-fatal and there is nothing the operator can do, so
> instead of confusing the operator with messages they can do nothing about
> hide this message behind the debug log level.
>
> Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH v2] ice: change "can't set link" message to dbg level
@ 2022-02-10 5:29 ` G, GurucharanX
0 siblings, 0 replies; 8+ messages in thread
From: G, GurucharanX @ 2022-02-10 5:29 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jonathan Toppins
> Sent: Thursday, February 3, 2022 11:15 PM
> To: netdev at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; intel-
> wired-lan at lists.osuosl.org; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH v2] ice: change "can't set link" message to
> dbg level
>
> In the case where the link is owned by manageability, the firmware is not
> allowed to set the link state, so an error code is returned.
> This however is non-fatal and there is nothing the operator can do, so
> instead of confusing the operator with messages they can do nothing about
> hide this message behind the debug log level.
>
> Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-02-10 5:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-02 20:38 [PATCH] ice: change "can't set link" message to dbg level Jonathan Toppins
2022-02-02 20:38 ` [Intel-wired-lan] " Jonathan Toppins
2022-02-03 0:06 ` Jakub Kicinski
2022-02-03 0:06 ` [Intel-wired-lan] " Jakub Kicinski
2022-02-03 17:45 ` [PATCH v2] " Jonathan Toppins
2022-02-03 17:45 ` [Intel-wired-lan] " Jonathan Toppins
2022-02-10 5:29 ` G, GurucharanX
2022-02-10 5:29 ` G, GurucharanX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.