From: "Raj, Victor" <victor.raj@intel.com> To: "G, GurucharanX" <gurucharanx.g@intel.com>, "Keller, Jacob E" <jacob.e.keller@intel.com>, Xiaomeng Tong <xiam0nd.tong@gmail.com>, "Brandeburg, Jesse" <jesse.brandeburg@intel.com> Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "stable@vger.kernel.org" <stable@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>, "kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>, "davem@davemloft.net" <davem@davemloft.net> Subject: RE: [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator Date: Tue, 3 May 2022 00:31:28 +0000 [thread overview] Message-ID: <BYAPR11MB339776DBFFC7F86EC7F4DD708DC09@BYAPR11MB3397.namprd11.prod.outlook.com> (raw) In-Reply-To: <BYAPR11MB336781C93921216983F8BE3CFCC19@BYAPR11MB3367.namprd11.prod.outlook.com> If the control comes down to the loop then surely the VSI is already part of an aggregator (old). The aggregator vsi list should have that VSI information. My understanding is that if control comes here then you always find a valid entry and matching handle here. If that doesn't happen then we need to debug. The fix is kind of masking this problem. -Victor -----Original Message----- From: G, GurucharanX <gurucharanx.g@intel.com> Sent: Monday, May 2, 2022 1:18 AM To: Keller, Jacob E <jacob.e.keller@intel.com>; Xiaomeng Tong <xiam0nd.tong@gmail.com>; Brandeburg, Jesse <jesse.brandeburg@intel.com> Cc: netdev@vger.kernel.org; Raj, Victor <victor.raj@intel.com>; stable@vger.kernel.org; linux-kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; kuba@kernel.org; pabeni@redhat.com; davem@davemloft.net Subject: RE: [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator -----Original Message----- > From: Xiaomeng Tong <xiam0nd.tong@gmail.com> > Sent: Saturday, March 26, 2022 11:44 PM > To: Brandeburg, Jesse <jesse.brandeburg@intel.com> > Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; > davem@davemloft.net; kuba@kernel.org; pabeni@redhat.com; Raj, Victor > <victor.raj@intel.com>; intel- wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; linux- kernel@vger.kernel.org; Xiaomeng Tong > <xiam0nd.tong@gmail.com>; stable@vger.kernel.org > Subject: [PATCH] ice: ice_sched: fix an incorrect NULL check on list > iterator > > The bugs are here: > if (old_agg_vsi_info) > if (old_agg_vsi_info && !old_agg_vsi_info->tc_bitmap[0]) { > > The list iterator value 'old_agg_vsi_info' will *always* be set and > non-NULL by list_for_each_entry_safe(), so it is incorrect to assume > that the iterator value will be NULL if the list is empty or no > element found (in this case, the check 'if (old_agg_vsi_info)' will > always be true unexpectly). > > To fix the bug, use a new variable 'iter' as the list iterator, while > use the original variable 'old_agg_vsi_info' as a dedicated pointer to > point to the found element. > Yep. This looks correct to me. > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > > Thanks, > Jake > Cc: stable@vger.kernel.org > Fixes: 37c592062b16d ("ice: remove the VSI info from previous agg") > Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com> > --- > drivers/net/ethernet/intel/ice/ice_sched.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
WARNING: multiple messages have this Message-ID (diff)
From: Raj, Victor <victor.raj@intel.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator Date: Tue, 3 May 2022 00:31:28 +0000 [thread overview] Message-ID: <BYAPR11MB339776DBFFC7F86EC7F4DD708DC09@BYAPR11MB3397.namprd11.prod.outlook.com> (raw) In-Reply-To: <BYAPR11MB336781C93921216983F8BE3CFCC19@BYAPR11MB3367.namprd11.prod.outlook.com> If the control comes down to the loop then surely the VSI is already part of an aggregator (old). The aggregator vsi list should have that VSI information. My understanding is that if control comes here then you always find a valid entry and matching handle here. If that doesn't happen then we need to debug. The fix is kind of masking this problem. -Victor -----Original Message----- From: G, GurucharanX <gurucharanx.g@intel.com> Sent: Monday, May 2, 2022 1:18 AM To: Keller, Jacob E <jacob.e.keller@intel.com>; Xiaomeng Tong <xiam0nd.tong@gmail.com>; Brandeburg, Jesse <jesse.brandeburg@intel.com> Cc: netdev at vger.kernel.org; Raj, Victor <victor.raj@intel.com>; stable at vger.kernel.org; linux-kernel at vger.kernel.org; intel-wired-lan at lists.osuosl.org; kuba at kernel.org; pabeni at redhat.com; davem at davemloft.net Subject: RE: [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator -----Original Message----- > From: Xiaomeng Tong <xiam0nd.tong@gmail.com> > Sent: Saturday, March 26, 2022 11:44 PM > To: Brandeburg, Jesse <jesse.brandeburg@intel.com> > Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; > davem at davemloft.net; kuba at kernel.org; pabeni at redhat.com; Raj, Victor > <victor.raj@intel.com>; intel- wired-lan at lists.osuosl.org; > netdev at vger.kernel.org; linux- kernel at vger.kernel.org; Xiaomeng Tong > <xiam0nd.tong@gmail.com>; stable at vger.kernel.org > Subject: [PATCH] ice: ice_sched: fix an incorrect NULL check on list > iterator > > The bugs are here: > if (old_agg_vsi_info) > if (old_agg_vsi_info && !old_agg_vsi_info->tc_bitmap[0]) { > > The list iterator value 'old_agg_vsi_info' will *always* be set and > non-NULL by list_for_each_entry_safe(), so it is incorrect to assume > that the iterator value will be NULL if the list is empty or no > element found (in this case, the check 'if (old_agg_vsi_info)' will > always be true unexpectly). > > To fix the bug, use a new variable 'iter' as the list iterator, while > use the original variable 'old_agg_vsi_info' as a dedicated pointer to > point to the found element. > Yep. This looks correct to me. > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > > Thanks, > Jake > Cc: stable at vger.kernel.org > Fixes: 37c592062b16d ("ice: remove the VSI info from previous agg") > Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com> > --- > drivers/net/ethernet/intel/ice/ice_sched.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
next prev parent reply other threads:[~2022-05-03 1:08 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-27 6:43 [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator Xiaomeng Tong 2022-03-27 6:43 ` [Intel-wired-lan] " Xiaomeng Tong 2022-03-28 17:59 ` Keller, Jacob E 2022-03-28 17:59 ` [Intel-wired-lan] " Keller, Jacob E 2022-05-02 8:17 ` G, GurucharanX 2022-05-02 8:17 ` [Intel-wired-lan] " G, GurucharanX 2022-05-03 0:31 ` Raj, Victor [this message] 2022-05-03 0:31 ` Raj, Victor
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BYAPR11MB339776DBFFC7F86EC7F4DD708DC09@BYAPR11MB3397.namprd11.prod.outlook.com \ --to=victor.raj@intel.com \ --cc=davem@davemloft.net \ --cc=gurucharanx.g@intel.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jacob.e.keller@intel.com \ --cc=jesse.brandeburg@intel.com \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=stable@vger.kernel.org \ --cc=xiam0nd.tong@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.