RE: [PATCH 00/18] usb: typec: API improvements

From: Ajay Gupta <ajayg@nvidia.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH 00/18] usb: typec: API improvements
Date: Mon, 21 Oct 2019 20:41:16 +0000	[thread overview]
Message-ID: <BYAPR12MB27275D13BB62F9120EBB9054DC690@BYAPR12MB2727.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20191021112524.79550-1-heikki.krogerus@linux.intel.com>

Hi Heikki,

> -----Original Message-----
> From: linux-usb-owner@vger.kernel.org <linux-usb-owner@vger.kernel.org>
> On Behalf Of Heikki Krogerus
> Sent: Monday, October 21, 2019 4:25 AM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Guenter Roeck <linux@roeck-us.net>; Ajay Gupta <ajayg@nvidia.com>;
> linux-usb@vger.kernel.org
> Subject: [PATCH 00/18] usb: typec: API improvements
> 
> Hi,
> 
> The first patches in this series (patches 1-8) introduce a small change to the
> USB Type-C Connector Class API. Guenter was kind enough to go over those
> already.
> 
> Patches 10-15 improve the ucsi driver API by introducing more traditional read
> and write routines, and the rest is more generic optimisations and
> improvements to the ucsi drivers.
> 
> Let me know if there is anything you want to be changed.
This patch set is not taking care of issues discussed at following thread.
https://marc.info/?l=linux-usb&m=156995500624107&w=2
https://marc.info/?l=linux-usb&m=157012261301682&w=2 

We need fixes for above issues so that we can easily manage ppms
which has multiple DP altmodes as discussed in below link.
https://marc.info/?l=linux-usb&m=156778906010780&w=2 

Thanks
> nvpublic 
> thanks,
> 
> Heikki Krogerus (18):
>   usb: typec: Copy everything from struct typec_capability during
>     registration
>   usb: typec: Introduce typec_get_drvdata()
>   usb: typec: Separate the operations vector
>   usb: typec: tcpm: Start using struct typec_operations
>   usb: typec: tps6598x: Start using struct typec_operations
>   usb: typec: ucsi: Start using struct typec_operations
>   usb: typec: hd3ss3220: Start using struct typec_operations
>   usb: typec: Remove the callback members from struct typec_capability
>   usb: typec: Remove unused members from struct typec_capability
>   usb: typec: hd3ss3220: Give the connector fwnode to the port device
>   usb: typec: ucsi: Simplified registration and I/O API
>   usb: typec: ucsi: acpi: Move to the new API
>   usb: typec: ucsi: ccg: Move to the new API
>   usb: typec: ucsi: Remove the old API
>   usb: typec: ucsi: Remove struct ucsi_control
>   usb: typec: ucsi: Remove all bit-fields
>   usb: typec: ucsi: New error codes
>   usb: typec: ucsi: Optimise ucsi_unregister()
> 
>  drivers/usb/typec/class.c            |  42 +-
>  drivers/usb/typec/hd3ss3220.c        |  36 +-
>  drivers/usb/typec/tcpm/tcpm.c        |  45 +-
>  drivers/usb/typec/tps6598x.c         |  49 ++-
>  drivers/usb/typec/ucsi/displayport.c |  40 +-
>  drivers/usb/typec/ucsi/trace.c       |  11 -
>  drivers/usb/typec/ucsi/trace.h       |  79 +---
>  drivers/usb/typec/ucsi/ucsi.c        | 606 ++++++++++++++-------------
>  drivers/usb/typec/ucsi/ucsi.h        | 417 +++++++-----------
>  drivers/usb/typec/ucsi/ucsi_acpi.c   |  94 ++++-
>  drivers/usb/typec/ucsi/ucsi_ccg.c    | 170 ++++----
>  include/linux/usb/typec.h            |  41 +-
>  12 files changed, 774 insertions(+), 856 deletions(-)
> 
> --
> 2.23.0