RE: [PATCH 00/18] usb: typec: API improvements

From: Ajay Gupta <ajayg@nvidia.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH 00/18] usb: typec: API improvements
Date: Tue, 12 Nov 2019 16:38:48 +0000	[thread overview]
Message-ID: <BYAPR12MB2727DF52EE646CA303CDFAEBDC770@BYAPR12MB2727.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20191112110707.GB4013@kuha.fi.intel.com>

Hi Heikki,

> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Sent: Tuesday, November 12, 2019 3:07 AM
> To: Ajay Gupta <ajayg@nvidia.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Guenter Roeck
> <linux@roeck-us.net>; linux-usb@vger.kernel.org
> Subject: Re: [PATCH 00/18] usb: typec: API improvements
> 
> On Tue, Nov 12, 2019 at 01:00:34PM +0200, Heikki Krogerus wrote:
> > Hi Ajay,
> >
> > On Mon, Nov 11, 2019 at 04:51:05PM +0000, Ajay Gupta wrote:
> > > Hi Heikki,
> > > > > > > > > The first patches in this series (patches 1-8) introduce
> > > > > > > > > a small change to the USB Type-C Connector Class API.
> > > > > > > > > Guenter was kind enough to go over those already.
> > > > > > > > >
> > > > > > > > > Patches 10-15 improve the ucsi driver API by introducing
> > > > > > > > > more traditional read and write routines, and the rest
> > > > > > > > > is more generic optimisations and improvements to the ucsi
> drivers.
> > > > > > > > >
> > > > > > > > > Let me know if there is anything you want to be changed.
> > > > > > > > This patch set is not taking care of issues discussed at following
> thread.
> > > > > > > > https://marc.info/?l=linux-usb&m=156995500624107&w=2
> > > > > > > > https://marc.info/?l=linux-usb&m=157012261301682&w=2
> > > > > > > >
> > > > > > > > We need fixes for above issues so that we can easily
> > > > > > > > manage ppms which has multiple DP altmodes as discussed in
> below link.
> > > > > > > > https://marc.info/?l=linux-usb&m=156778906010780&w=2
> > > > > > >
> > > > > > > The goal of this series is not to solve that "issue".
> > > > > > >
> > > > > > > This series is the base work that really has to be done in
> > > > > > > any case before we add any kind of solution for the multi DP alt
> mode case.
> > > > > > > Rest assured that we will have support for that soon enough,
> > > > > > > but let's just move one step at a time.
> > > Since this series is gone so what is the plan for updated changes as
> > > discussed at
> > > https://marc.info/?l=linux-usb&m=157079026214073&w=2
> > >
> > > This is needed to support ppms which has multiple DP altmodes as
> > > discussed at
> > > https://marc.info/?l=linux-usb&m=156778906010780&w=2
> >
> > Give me a few more weeks. I'm sorry for the delay, but I have to
> > finish some other tasks. Can you work on this in the mean time?
> 
> Actually, if you can prepare the proposal you had earlier, I think we can just go
> ahead with it now. 
My idea is proposed at 
https://marc.info/?l=linux-usb&m=156875897316318&w=2 

Are you referring to it? If yes, I can rebase the change and post it. 

Thanks
> nvpublic
> If I have some "better" idea how to handle the multi-DP alt
> modes, then I can prepare a separate proposal for it after we have your initial
> solution. I do have an idea for a solution, but I don't want to block this any
> longer.
> 
> 
> thanks,
> 
> --
> heikki