* Trace seen on target during iSER login
@ 2019-12-30 7:21 Rahul Kundu
2019-12-30 16:56 ` Bart Van Assche
0 siblings, 1 reply; 9+ messages in thread
From: Rahul Kundu @ 2019-12-30 7:21 UTC (permalink / raw)
To: bvanassche, linux-scsi, target-devel
Cc: Potnuri Bharat Teja, Nirranjan Kirubaharan
Hi,
I am trying to setup and run iSER with tot linux kernel installed(5.5.0-rc3) on both target and initiator.
Followed below steps:
1. Created 1 targets having ramdisk LUN of 1GB size.
2. Did discovery and login from the Initiator
Observed that everything worked fine at initiator and successfully logins.
But, after login, below warning was seen at Target:
target dmesg
-------------------
[ 237.850090] Rounding down aligned max_sectors from 4294967295 to 4294967288
[ 244.517357] iwpm_register_pid_cb: Down level iwpmd/pid 3060. Continuing...
[ 324.876992] ------------[ cut here ]------------
[ 324.877024] percpu_ref_kill_and_confirm called more than once on target_release_sess_cmd_refcnt [target_core_mod]!
[ 324.877047] WARNING: CPU: 0 PID: 3167 at lib/percpu-refcount.c:346 percpu_ref_kill_and_confirm+0x7e/0xa0
[ 324.877048] Modules linked in: target_core_user uio target_core_pscsi target_core_file target_core_iblock rpcrdma ib_isert iscsi_target_mod ib_iser libiscsi scsi_transport_iscsi ib_srpt target_core_mod ib_srp scsi_transport_srp ib_ipoib rdma_ucm dm_mirror dm_region_hash ib_umad dm_log iw_cxgb4 ib_uverbs snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio intel_powerclamp snd_hda_intel rdma_cm coretemp snd_intel_dspcfg iw_cm snd_hda_codec ib_cm ib_core snd_hda_core kvm snd_hwdep snd_seq libcxgb snd_seq_device snd_pcm irqbypass ipmi_si iTCO_wdt snd_timer iTCO_vendor_support gpio_ich ipmi_devintf pcspkr snd ipmi_msghandler sg ioatdma soundcore i2c_i801 lpc_ich i7core_edac acpi_cpufreq nfsd auth_rpcgss nfs_acl lockd grace sunrpc dm_multipath dm_mod ip_tables ext4 mbcache jbd2 sr_mod cdrom sd_mod mgag200 drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm_vram_helper drm_ttm_helper ttm drm ata_generic pata_acpi cxgb4 igb ata_piix pata_jmicron firewire_ohci libata
[ 324.877096] firewire_core dca crc32c_intel serio_raw i2c_algo_bit i2c_core ptp crc_itu_t pps_core
[ 324.877104] CPU: 0 PID: 3167 Comm: iscsi_ttx Kdump: loaded Not tainted 5.5.0-rc3+ #45
[ 324.877106] Hardware name: Supermicro X8DAH/X8DAH, BIOS 2.1 12/30/2011
[ 324.877109] RIP: 0010:percpu_ref_kill_and_confirm+0x7e/0xa0
[ 324.877114] Code: 00 80 3d bc 04 1e 01 00 75 c4 48 8b 53 10 48 c7 c6 80 fb 0a a4 48 c7 c7 78 ae 33 a4 31 c0 c6 05 9f 04 1e 01 01 e8 72 47 ca ff <0f> 0b 48 8b 53 08 eb 9c f0 48 83 2b 01 74 02 eb b3 48 89 df ff 53
[ 324.877115] RSP: 0018:ffffa1780d14bdf0 EFLAGS: 00010086
[ 324.877116] RAX: 0000000000000000 RBX: ffff947e1eb17430 RCX: 0000000000000000
[ 324.877116] RDX: 0000000000000006 RSI: ffffffffa4e49c06 RDI: 0000000000000046
[ 324.877117] RBP: 0000000000000246 R08: ffffffffa4e49ba0 R09: ffffffeb3fcd255c
[ 324.877117] R10: 0000000000000c5f R11: 0000000000000373 R12: 0000000000000000
[ 324.877118] R13: ffff947e10d12100 R14: ffffa1780d14be38 R15: ffffa1780d14bc58
[ 324.877119] FS: 0000000000000000(0000) GS:ffff94661fa00000(0000) knlGS:0000000000000000
[ 324.877119] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 324.877120] CR2: 00007fe88152e140 CR3: 0000002e8b00a003 CR4: 00000000000206f0
[ 324.877121] Call Trace:
[ 324.877137] iscsit_close_connection+0x272/0x8d0 [iscsi_target_mod]
[ 324.877141] ? __schedule+0x2d2/0x6c0
[ 324.877146] iscsit_take_action_for_connection_exit+0x7e/0x100 [iscsi_target_mod]
[ 324.877151] iscsi_target_tx_thread+0x153/0x1f0 [iscsi_target_mod]
[ 324.877155] ? remove_wait_queue+0x60/0x60
[ 324.877159] kthread+0xf5/0x130
[ 324.877164] ? iscsit_thread_get_cpumask+0xa0/0xa0 [iscsi_target_mod]
[ 324.877165] ? kthread_bind+0x10/0x10
[ 324.877168] ret_from_fork+0x1f/0x30
[ 324.877170] ---[ end trace bcc25f7aa321d702 ]---
The above error is seen from kernel 5.4.0-rc1 onwards.
Bisect points to the following commit:
----------------------------------------------------------------------------------------------------------------------------
e9d3009cb936bd0faf0719f68d98ad8afb1e613b is the first bad commit commit e9d3009cb936bd0faf0719f68d98ad8afb1e613b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Nov 13 14:05:08 2019 -0800
scsi: target: iscsi: Wait for all commands to finish before freeing a session
----------------------------------------------------------------------------------------------------------------------------
iscsit_close_connection() already calls target_sess_cmd_list_set_waiting() and
target_wait_for_sess_cmds() functions through iscsit_wait_conn() function.
Below is the patch diff which removes redundant function calls added by the above commit, but I am not sure whether this is the ideal fix:
=================================================================================================================
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 7251a87bb576..503a76e9cc62 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -4234,8 +4234,6 @@ int iscsit_close_connection(
* must wait until they have completed.
*/
iscsit_check_conn_usage_count(conn);
- target_sess_cmd_list_set_waiting(sess->se_sess);
- target_wait_for_sess_cmds(sess->se_sess);
ahash_request_free(conn->conn_tx_hash);
if (conn->conn_rx_hash) {
---
Please kindly let me know your thoughts on this subject. Any help appreciated.
Thanks,
Rahul Kundu
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: Trace seen on target during iSER login
2019-12-30 7:21 Trace seen on target during iSER login Rahul Kundu
@ 2019-12-30 16:56 ` Bart Van Assche
0 siblings, 0 replies; 9+ messages in thread
From: Bart Van Assche @ 2019-12-30 16:56 UTC (permalink / raw)
To: Rahul Kundu, linux-scsi, target-devel
Cc: Potnuri Bharat Teja, Nirranjan Kirubaharan, Sagi Grimberg
On 2019-12-29 23:21, Rahul Kundu wrote:
> Below is the patch diff which removes redundant function calls added by the above commit, but I am not sure whether this is the ideal fix:
> ========================================================> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 7251a87bb576..503a76e9cc62 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -4234,8 +4234,6 @@ int iscsit_close_connection(
> * must wait until they have completed.
> */
> iscsit_check_conn_usage_count(conn);
> - target_sess_cmd_list_set_waiting(sess->se_sess);
> - target_wait_for_sess_cmds(sess->se_sess);
>
> ahash_request_free(conn->conn_tx_hash);
> if (conn->conn_rx_hash) {
I don't like the above change because it would reintroduce the issue fixed by
commit e9d3009cb936. How about the patch below?
Thanks,
Bart.
From f25182525499b52db6be00b34dbfd3662d29e403 Mon Sep 17 00:00:00 2001
From: Bart Van Assche <bvanassche@acm.org>
Date: Mon, 30 Dec 2019 07:48:20 -0800
Subject: [PATCH] RDMA/isert: Fix a recently introduced regression related to
logout
iscsit_close_connection() calls isert_wait_conn(). Due to commit
e9d3009cb936 both functions call target_wait_for_sess_cmds() although
that last function should be called only once. Fix this by removing
the target_wait_for_sess_cmds() call from isert_wait_conn() and by
only calling isert_wait_conn() after target_wait_for_sess_cmds().
Reported-by: Rahul Kundu <rahul.kundu@chelsio.com>
Fixes: e9d3009cb936 ("scsi: target: iscsi: Wait for all commands to finish before freeing a session").
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/infiniband/ulp/isert/ib_isert.c | 12 ------------
drivers/target/iscsi/iscsi_target.c | 6 +++---
2 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index a1a035270cab..b273e421e910 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -2575,17 +2575,6 @@ isert_wait4logout(struct isert_conn *isert_conn)
}
}
-static void
-isert_wait4cmds(struct iscsi_conn *conn)
-{
- isert_info("iscsi_conn %p\n", conn);
-
- if (conn->sess) {
- target_sess_cmd_list_set_waiting(conn->sess->se_sess);
- target_wait_for_sess_cmds(conn->sess->se_sess);
- }
-}
-
/**
* isert_put_unsol_pending_cmds() - Drop commands waiting for
* unsolicitate dataout
@@ -2633,7 +2622,6 @@ static void isert_wait_conn(struct iscsi_conn *conn)
ib_drain_qp(isert_conn->qp);
isert_put_unsol_pending_cmds(conn);
- isert_wait4cmds(conn);
isert_wait4logout(isert_conn);
queue_work(isert_release_wq, &isert_conn->release_work);
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 7251a87bb576..b94ed4e30770 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -4149,9 +4149,6 @@ int iscsit_close_connection(
iscsit_stop_nopin_response_timer(conn);
iscsit_stop_nopin_timer(conn);
- if (conn->conn_transport->iscsit_wait_conn)
- conn->conn_transport->iscsit_wait_conn(conn);
-
/*
* During Connection recovery drop unacknowledged out of order
* commands for this connection, and prepare the other commands
@@ -4237,6 +4234,9 @@ int iscsit_close_connection(
target_sess_cmd_list_set_waiting(sess->se_sess);
target_wait_for_sess_cmds(sess->se_sess);
+ if (conn->conn_transport->iscsit_wait_conn)
+ conn->conn_transport->iscsit_wait_conn(conn);
+
ahash_request_free(conn->conn_tx_hash);
if (conn->conn_rx_hash) {
struct crypto_ahash *tfm;
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: Trace seen on target during iSER login
@ 2019-12-30 16:56 ` Bart Van Assche
0 siblings, 0 replies; 9+ messages in thread
From: Bart Van Assche @ 2019-12-30 16:56 UTC (permalink / raw)
To: Rahul Kundu, linux-scsi, target-devel
Cc: Potnuri Bharat Teja, Nirranjan Kirubaharan, Sagi Grimberg
On 2019-12-29 23:21, Rahul Kundu wrote:
> Below is the patch diff which removes redundant function calls added by the above commit, but I am not sure whether this is the ideal fix:
> =================================================================================================================
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 7251a87bb576..503a76e9cc62 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -4234,8 +4234,6 @@ int iscsit_close_connection(
> * must wait until they have completed.
> */
> iscsit_check_conn_usage_count(conn);
> - target_sess_cmd_list_set_waiting(sess->se_sess);
> - target_wait_for_sess_cmds(sess->se_sess);
>
> ahash_request_free(conn->conn_tx_hash);
> if (conn->conn_rx_hash) {
I don't like the above change because it would reintroduce the issue fixed by
commit e9d3009cb936. How about the patch below?
Thanks,
Bart.
From f25182525499b52db6be00b34dbfd3662d29e403 Mon Sep 17 00:00:00 2001
From: Bart Van Assche <bvanassche@acm.org>
Date: Mon, 30 Dec 2019 07:48:20 -0800
Subject: [PATCH] RDMA/isert: Fix a recently introduced regression related to
logout
iscsit_close_connection() calls isert_wait_conn(). Due to commit
e9d3009cb936 both functions call target_wait_for_sess_cmds() although
that last function should be called only once. Fix this by removing
the target_wait_for_sess_cmds() call from isert_wait_conn() and by
only calling isert_wait_conn() after target_wait_for_sess_cmds().
Reported-by: Rahul Kundu <rahul.kundu@chelsio.com>
Fixes: e9d3009cb936 ("scsi: target: iscsi: Wait for all commands to finish before freeing a session").
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/infiniband/ulp/isert/ib_isert.c | 12 ------------
drivers/target/iscsi/iscsi_target.c | 6 +++---
2 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index a1a035270cab..b273e421e910 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -2575,17 +2575,6 @@ isert_wait4logout(struct isert_conn *isert_conn)
}
}
-static void
-isert_wait4cmds(struct iscsi_conn *conn)
-{
- isert_info("iscsi_conn %p\n", conn);
-
- if (conn->sess) {
- target_sess_cmd_list_set_waiting(conn->sess->se_sess);
- target_wait_for_sess_cmds(conn->sess->se_sess);
- }
-}
-
/**
* isert_put_unsol_pending_cmds() - Drop commands waiting for
* unsolicitate dataout
@@ -2633,7 +2622,6 @@ static void isert_wait_conn(struct iscsi_conn *conn)
ib_drain_qp(isert_conn->qp);
isert_put_unsol_pending_cmds(conn);
- isert_wait4cmds(conn);
isert_wait4logout(isert_conn);
queue_work(isert_release_wq, &isert_conn->release_work);
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 7251a87bb576..b94ed4e30770 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -4149,9 +4149,6 @@ int iscsit_close_connection(
iscsit_stop_nopin_response_timer(conn);
iscsit_stop_nopin_timer(conn);
- if (conn->conn_transport->iscsit_wait_conn)
- conn->conn_transport->iscsit_wait_conn(conn);
-
/*
* During Connection recovery drop unacknowledged out of order
* commands for this connection, and prepare the other commands
@@ -4237,6 +4234,9 @@ int iscsit_close_connection(
target_sess_cmd_list_set_waiting(sess->se_sess);
target_wait_for_sess_cmds(sess->se_sess);
+ if (conn->conn_transport->iscsit_wait_conn)
+ conn->conn_transport->iscsit_wait_conn(conn);
+
ahash_request_free(conn->conn_tx_hash);
if (conn->conn_rx_hash) {
struct crypto_ahash *tfm;
^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: Trace seen on target during iSER login
2019-12-30 16:56 ` Bart Van Assche
@ 2020-01-07 7:53 ` Rahul Kundu
-1 siblings, 0 replies; 9+ messages in thread
From: Rahul Kundu @ 2020-01-07 7:53 UTC (permalink / raw)
To: Bart Van Assche, linux-scsi, target-devel
Cc: Potnuri Bharat Teja, Nirranjan Kirubaharan, Sagi Grimberg
PiBJIGRvbid0IGxpa2UgdGhlIGFib3ZlIGNoYW5nZSBiZWNhdXNlIGl0IHdvdWxkIHJlaW50cm9k
dWNlIHRoZSBpc3N1ZSBmaXhlZCBieSBjb21taXQgZTlkMzAwOWNiOTM2LiBIb3cgYWJvdXQgdGhl
IHBhdGNoIGJlbG93Pw0KDQpUaGUgcmVwb3J0ZWQgdHJhY2UgaXMgbm90IG9ic2VydmVkIHdpdGgg
dGhlIHBhdGNoIGFuZCBQYXRjaCBpcyB0ZXN0ZWQgZ29vZC4NClRoYW5rcyBCYXJ0LiAgDQoNClRo
YW5rcywNClJhaHVsLg0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogQmFydCBW
YW4gQXNzY2hlIDxidmFuYXNzY2hlQGFjbS5vcmc+IA0KU2VudDogTW9uZGF5LCBEZWNlbWJlciAz
MCwgMjAxOSAxMDoyNyBQTQ0KVG86IFJhaHVsIEt1bmR1IDxyYWh1bC5rdW5kdUBjaGVsc2lvLmNv
bT47IGxpbnV4LXNjc2lAdmdlci5rZXJuZWwub3JnOyB0YXJnZXQtZGV2ZWxAdmdlci5rZXJuZWwu
b3JnDQpDYzogUG90bnVyaSBCaGFyYXQgVGVqYSA8YmhhcmF0QGNoZWxzaW8uY29tPjsgTmlycmFu
amFuIEtpcnViYWhhcmFuIDxuaXJyYW5qYW5AY2hlbHNpby5jb20+OyBTYWdpIEdyaW1iZXJnIDxz
YWdpQGdyaW1iZXJnLm1lPg0KU3ViamVjdDogUmU6IFRyYWNlIHNlZW4gb24gdGFyZ2V0IGR1cmlu
ZyBpU0VSIGxvZ2luDQoNCk9uIDIwMTktMTItMjkgMjM6MjEsIFJhaHVsIEt1bmR1IHdyb3RlOg0K
PiBCZWxvdyBpcyB0aGUgcGF0Y2ggZGlmZiB3aGljaCByZW1vdmVzIHJlZHVuZGFudCBmdW5jdGlv
biBjYWxscyBhZGRlZCBieSB0aGUgYWJvdmUgY29tbWl0LCBidXQgSSBhbSBub3Qgc3VyZSB3aGV0
aGVyIHRoaXMgaXMgdGhlIGlkZWFsIGZpeDoNCj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPiA9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L3RhcmdldC9pc2NzaS9pc2NzaV90YXJnZXQuYyANCj4gYi9kcml2ZXJzL3RhcmdldC9pc2NzaS9p
c2NzaV90YXJnZXQuYw0KPiBpbmRleCA3MjUxYTg3YmI1NzYuLjUwM2E3NmU5Y2M2MiAxMDA2NDQN
Cj4gLS0tIGEvZHJpdmVycy90YXJnZXQvaXNjc2kvaXNjc2lfdGFyZ2V0LmMNCj4gKysrIGIvZHJp
dmVycy90YXJnZXQvaXNjc2kvaXNjc2lfdGFyZ2V0LmMNCj4gQEAgLTQyMzQsOCArNDIzNCw2IEBA
IGludCBpc2NzaXRfY2xvc2VfY29ubmVjdGlvbigNCj4gICAgICAgICAgKiBtdXN0IHdhaXQgdW50
aWwgdGhleSBoYXZlIGNvbXBsZXRlZC4NCj4gICAgICAgICAgKi8NCj4gICAgICAgICBpc2NzaXRf
Y2hlY2tfY29ubl91c2FnZV9jb3VudChjb25uKTsNCj4gLSAgICAgICB0YXJnZXRfc2Vzc19jbWRf
bGlzdF9zZXRfd2FpdGluZyhzZXNzLT5zZV9zZXNzKTsNCj4gLSAgICAgICB0YXJnZXRfd2FpdF9m
b3Jfc2Vzc19jbWRzKHNlc3MtPnNlX3Nlc3MpOw0KPiANCj4gICAgICAgICBhaGFzaF9yZXF1ZXN0
X2ZyZWUoY29ubi0+Y29ubl90eF9oYXNoKTsNCj4gICAgICAgICBpZiAoY29ubi0+Y29ubl9yeF9o
YXNoKSB7DQoNCkkgZG9uJ3QgbGlrZSB0aGUgYWJvdmUgY2hhbmdlIGJlY2F1c2UgaXQgd291bGQg
cmVpbnRyb2R1Y2UgdGhlIGlzc3VlIGZpeGVkIGJ5IGNvbW1pdCBlOWQzMDA5Y2I5MzYuIEhvdyBh
Ym91dCB0aGUgcGF0Y2ggYmVsb3c/DQoNClRoYW5rcywNCg0KQmFydC4NCg0KDQpGcm9tIGYyNTE4
MjUyNTQ5OWI1MmRiNmJlMDBiMzRkYmZkMzY2MmQyOWU0MDMgTW9uIFNlcCAxNyAwMDowMDowMCAy
MDAxDQpGcm9tOiBCYXJ0IFZhbiBBc3NjaGUgPGJ2YW5hc3NjaGVAYWNtLm9yZz4NCkRhdGU6IE1v
biwgMzAgRGVjIDIwMTkgMDc6NDg6MjAgLTA4MDANClN1YmplY3Q6IFtQQVRDSF0gUkRNQS9pc2Vy
dDogRml4IGEgcmVjZW50bHkgaW50cm9kdWNlZCByZWdyZXNzaW9uIHJlbGF0ZWQgdG8gIGxvZ291
dA0KDQppc2NzaXRfY2xvc2VfY29ubmVjdGlvbigpIGNhbGxzIGlzZXJ0X3dhaXRfY29ubigpLiBE
dWUgdG8gY29tbWl0DQplOWQzMDA5Y2I5MzYgYm90aCBmdW5jdGlvbnMgY2FsbCB0YXJnZXRfd2Fp
dF9mb3Jfc2Vzc19jbWRzKCkgYWx0aG91Z2ggdGhhdCBsYXN0IGZ1bmN0aW9uIHNob3VsZCBiZSBj
YWxsZWQgb25seSBvbmNlLiBGaXggdGhpcyBieSByZW1vdmluZyB0aGUgdGFyZ2V0X3dhaXRfZm9y
X3Nlc3NfY21kcygpIGNhbGwgZnJvbSBpc2VydF93YWl0X2Nvbm4oKSBhbmQgYnkgb25seSBjYWxs
aW5nIGlzZXJ0X3dhaXRfY29ubigpIGFmdGVyIHRhcmdldF93YWl0X2Zvcl9zZXNzX2NtZHMoKS4N
Cg0KUmVwb3J0ZWQtYnk6IFJhaHVsIEt1bmR1IDxyYWh1bC5rdW5kdUBjaGVsc2lvLmNvbT4NCkZp
eGVzOiBlOWQzMDA5Y2I5MzYgKCJzY3NpOiB0YXJnZXQ6IGlzY3NpOiBXYWl0IGZvciBhbGwgY29t
bWFuZHMgdG8gZmluaXNoIGJlZm9yZSBmcmVlaW5nIGEgc2Vzc2lvbiIpLg0KU2lnbmVkLW9mZi1i
eTogQmFydCBWYW4gQXNzY2hlIDxidmFuYXNzY2hlQGFjbS5vcmc+DQotLS0NCiBkcml2ZXJzL2lu
ZmluaWJhbmQvdWxwL2lzZXJ0L2liX2lzZXJ0LmMgfCAxMiAtLS0tLS0tLS0tLS0NCiBkcml2ZXJz
L3RhcmdldC9pc2NzaS9pc2NzaV90YXJnZXQuYyAgICAgfCAgNiArKystLS0NCiAyIGZpbGVzIGNo
YW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9k
cml2ZXJzL2luZmluaWJhbmQvdWxwL2lzZXJ0L2liX2lzZXJ0LmMgYi9kcml2ZXJzL2luZmluaWJh
bmQvdWxwL2lzZXJ0L2liX2lzZXJ0LmMNCmluZGV4IGExYTAzNTI3MGNhYi4uYjI3M2U0MjFlOTEw
IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3VscC9pc2VydC9pYl9pc2VydC5jDQor
KysgYi9kcml2ZXJzL2luZmluaWJhbmQvdWxwL2lzZXJ0L2liX2lzZXJ0LmMNCkBAIC0yNTc1LDE3
ICsyNTc1LDYgQEAgaXNlcnRfd2FpdDRsb2dvdXQoc3RydWN0IGlzZXJ0X2Nvbm4gKmlzZXJ0X2Nv
bm4pDQogCX0NCiB9DQoNCi1zdGF0aWMgdm9pZA0KLWlzZXJ0X3dhaXQ0Y21kcyhzdHJ1Y3QgaXNj
c2lfY29ubiAqY29ubikgLXsNCi0JaXNlcnRfaW5mbygiaXNjc2lfY29ubiAlcFxuIiwgY29ubik7
DQotDQotCWlmIChjb25uLT5zZXNzKSB7DQotCQl0YXJnZXRfc2Vzc19jbWRfbGlzdF9zZXRfd2Fp
dGluZyhjb25uLT5zZXNzLT5zZV9zZXNzKTsNCi0JCXRhcmdldF93YWl0X2Zvcl9zZXNzX2NtZHMo
Y29ubi0+c2Vzcy0+c2Vfc2Vzcyk7DQotCX0NCi19DQotDQogLyoqDQogICogaXNlcnRfcHV0X3Vu
c29sX3BlbmRpbmdfY21kcygpIC0gRHJvcCBjb21tYW5kcyB3YWl0aW5nIGZvcg0KICAqICAgICB1
bnNvbGljaXRhdGUgZGF0YW91dA0KQEAgLTI2MzMsNyArMjYyMiw2IEBAIHN0YXRpYyB2b2lkIGlz
ZXJ0X3dhaXRfY29ubihzdHJ1Y3QgaXNjc2lfY29ubiAqY29ubikNCg0KIAlpYl9kcmFpbl9xcChp
c2VydF9jb25uLT5xcCk7DQogCWlzZXJ0X3B1dF91bnNvbF9wZW5kaW5nX2NtZHMoY29ubik7DQot
CWlzZXJ0X3dhaXQ0Y21kcyhjb25uKTsNCiAJaXNlcnRfd2FpdDRsb2dvdXQoaXNlcnRfY29ubik7
DQoNCiAJcXVldWVfd29yayhpc2VydF9yZWxlYXNlX3dxLCAmaXNlcnRfY29ubi0+cmVsZWFzZV93
b3JrKTsgZGlmZiAtLWdpdCBhL2RyaXZlcnMvdGFyZ2V0L2lzY3NpL2lzY3NpX3RhcmdldC5jIGIv
ZHJpdmVycy90YXJnZXQvaXNjc2kvaXNjc2lfdGFyZ2V0LmMNCmluZGV4IDcyNTFhODdiYjU3Ni4u
Yjk0ZWQ0ZTMwNzcwIDEwMDY0NA0KLS0tIGEvZHJpdmVycy90YXJnZXQvaXNjc2kvaXNjc2lfdGFy
Z2V0LmMNCisrKyBiL2RyaXZlcnMvdGFyZ2V0L2lzY3NpL2lzY3NpX3RhcmdldC5jDQpAQCAtNDE0
OSw5ICs0MTQ5LDYgQEAgaW50IGlzY3NpdF9jbG9zZV9jb25uZWN0aW9uKA0KIAlpc2NzaXRfc3Rv
cF9ub3Bpbl9yZXNwb25zZV90aW1lcihjb25uKTsNCiAJaXNjc2l0X3N0b3Bfbm9waW5fdGltZXIo
Y29ubik7DQoNCi0JaWYgKGNvbm4tPmNvbm5fdHJhbnNwb3J0LT5pc2NzaXRfd2FpdF9jb25uKQ0K
LQkJY29ubi0+Y29ubl90cmFuc3BvcnQtPmlzY3NpdF93YWl0X2Nvbm4oY29ubik7DQotDQogCS8q
DQogCSAqIER1cmluZyBDb25uZWN0aW9uIHJlY292ZXJ5IGRyb3AgdW5hY2tub3dsZWRnZWQgb3V0
IG9mIG9yZGVyDQogCSAqIGNvbW1hbmRzIGZvciB0aGlzIGNvbm5lY3Rpb24sIGFuZCBwcmVwYXJl
IHRoZSBvdGhlciBjb21tYW5kcyBAQCAtNDIzNyw2ICs0MjM0LDkgQEAgaW50IGlzY3NpdF9jbG9z
ZV9jb25uZWN0aW9uKA0KIAl0YXJnZXRfc2Vzc19jbWRfbGlzdF9zZXRfd2FpdGluZyhzZXNzLT5z
ZV9zZXNzKTsNCiAJdGFyZ2V0X3dhaXRfZm9yX3Nlc3NfY21kcyhzZXNzLT5zZV9zZXNzKTsNCg0K
KwlpZiAoY29ubi0+Y29ubl90cmFuc3BvcnQtPmlzY3NpdF93YWl0X2Nvbm4pDQorCQljb25uLT5j
b25uX3RyYW5zcG9ydC0+aXNjc2l0X3dhaXRfY29ubihjb25uKTsNCisNCiAJYWhhc2hfcmVxdWVz
dF9mcmVlKGNvbm4tPmNvbm5fdHhfaGFzaCk7DQogCWlmIChjb25uLT5jb25uX3J4X2hhc2gpIHsN
CiAJCXN0cnVjdCBjcnlwdG9fYWhhc2ggKnRmbTsNCg=
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: Trace seen on target during iSER login
@ 2020-01-07 7:53 ` Rahul Kundu
0 siblings, 0 replies; 9+ messages in thread
From: Rahul Kundu @ 2020-01-07 7:53 UTC (permalink / raw)
To: Bart Van Assche, linux-scsi, target-devel
Cc: Potnuri Bharat Teja, Nirranjan Kirubaharan, Sagi Grimberg
> I don't like the above change because it would reintroduce the issue fixed by commit e9d3009cb936. How about the patch below?
The reported trace is not observed with the patch and Patch is tested good.
Thanks Bart.
Thanks,
Rahul.
-----Original Message-----
From: Bart Van Assche <bvanassche@acm.org>
Sent: Monday, December 30, 2019 10:27 PM
To: Rahul Kundu <rahul.kundu@chelsio.com>; linux-scsi@vger.kernel.org; target-devel@vger.kernel.org
Cc: Potnuri Bharat Teja <bharat@chelsio.com>; Nirranjan Kirubaharan <nirranjan@chelsio.com>; Sagi Grimberg <sagi@grimberg.me>
Subject: Re: Trace seen on target during iSER login
On 2019-12-29 23:21, Rahul Kundu wrote:
> Below is the patch diff which removes redundant function calls added by the above commit, but I am not sure whether this is the ideal fix:
> ======================================================================
> ===========================================
> diff --git a/drivers/target/iscsi/iscsi_target.c
> b/drivers/target/iscsi/iscsi_target.c
> index 7251a87bb576..503a76e9cc62 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -4234,8 +4234,6 @@ int iscsit_close_connection(
> * must wait until they have completed.
> */
> iscsit_check_conn_usage_count(conn);
> - target_sess_cmd_list_set_waiting(sess->se_sess);
> - target_wait_for_sess_cmds(sess->se_sess);
>
> ahash_request_free(conn->conn_tx_hash);
> if (conn->conn_rx_hash) {
I don't like the above change because it would reintroduce the issue fixed by commit e9d3009cb936. How about the patch below?
Thanks,
Bart.
From f25182525499b52db6be00b34dbfd3662d29e403 Mon Sep 17 00:00:00 2001
From: Bart Van Assche <bvanassche@acm.org>
Date: Mon, 30 Dec 2019 07:48:20 -0800
Subject: [PATCH] RDMA/isert: Fix a recently introduced regression related to logout
iscsit_close_connection() calls isert_wait_conn(). Due to commit
e9d3009cb936 both functions call target_wait_for_sess_cmds() although that last function should be called only once. Fix this by removing the target_wait_for_sess_cmds() call from isert_wait_conn() and by only calling isert_wait_conn() after target_wait_for_sess_cmds().
Reported-by: Rahul Kundu <rahul.kundu@chelsio.com>
Fixes: e9d3009cb936 ("scsi: target: iscsi: Wait for all commands to finish before freeing a session").
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/infiniband/ulp/isert/ib_isert.c | 12 ------------
drivers/target/iscsi/iscsi_target.c | 6 +++---
2 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index a1a035270cab..b273e421e910 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -2575,17 +2575,6 @@ isert_wait4logout(struct isert_conn *isert_conn)
}
}
-static void
-isert_wait4cmds(struct iscsi_conn *conn) -{
- isert_info("iscsi_conn %p\n", conn);
-
- if (conn->sess) {
- target_sess_cmd_list_set_waiting(conn->sess->se_sess);
- target_wait_for_sess_cmds(conn->sess->se_sess);
- }
-}
-
/**
* isert_put_unsol_pending_cmds() - Drop commands waiting for
* unsolicitate dataout
@@ -2633,7 +2622,6 @@ static void isert_wait_conn(struct iscsi_conn *conn)
ib_drain_qp(isert_conn->qp);
isert_put_unsol_pending_cmds(conn);
- isert_wait4cmds(conn);
isert_wait4logout(isert_conn);
queue_work(isert_release_wq, &isert_conn->release_work); diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 7251a87bb576..b94ed4e30770 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -4149,9 +4149,6 @@ int iscsit_close_connection(
iscsit_stop_nopin_response_timer(conn);
iscsit_stop_nopin_timer(conn);
- if (conn->conn_transport->iscsit_wait_conn)
- conn->conn_transport->iscsit_wait_conn(conn);
-
/*
* During Connection recovery drop unacknowledged out of order
* commands for this connection, and prepare the other commands @@ -4237,6 +4234,9 @@ int iscsit_close_connection(
target_sess_cmd_list_set_waiting(sess->se_sess);
target_wait_for_sess_cmds(sess->se_sess);
+ if (conn->conn_transport->iscsit_wait_conn)
+ conn->conn_transport->iscsit_wait_conn(conn);
+
ahash_request_free(conn->conn_tx_hash);
if (conn->conn_rx_hash) {
struct crypto_ahash *tfm;
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: Trace seen on target during iSER login
2020-01-07 7:53 ` Rahul Kundu
@ 2020-01-16 3:03 ` Martin K. Petersen
-1 siblings, 0 replies; 9+ messages in thread
From: Martin K. Petersen @ 2020-01-16 3:03 UTC (permalink / raw)
To: Bart Van Assche
Cc: Rahul Kundu, linux-scsi, target-devel, Potnuri Bharat Teja,
Nirranjan Kirubaharan, Sagi Grimberg
Hi Bart!
> The reported trace is not observed with the patch and Patch is tested
> good. Thanks Bart.
> From f25182525499b52db6be00b34dbfd3662d29e403 Mon Sep 17 00:00:00 2001
> From: Bart Van Assche <bvanassche@acm.org>
> Date: Mon, 30 Dec 2019 07:48:20 -0800
> Subject: [PATCH] RDMA/isert: Fix a recently introduced regression related to logout
Are you going to submit this?
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Trace seen on target during iSER login
@ 2020-01-16 3:03 ` Martin K. Petersen
0 siblings, 0 replies; 9+ messages in thread
From: Martin K. Petersen @ 2020-01-16 3:03 UTC (permalink / raw)
To: Bart Van Assche
Cc: Rahul Kundu, linux-scsi, target-devel, Potnuri Bharat Teja,
Nirranjan Kirubaharan, Sagi Grimberg
Hi Bart!
> The reported trace is not observed with the patch and Patch is tested
> good. Thanks Bart.
> From f25182525499b52db6be00b34dbfd3662d29e403 Mon Sep 17 00:00:00 2001
> From: Bart Van Assche <bvanassche@acm.org>
> Date: Mon, 30 Dec 2019 07:48:20 -0800
> Subject: [PATCH] RDMA/isert: Fix a recently introduced regression related to logout
Are you going to submit this?
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Trace seen on target during iSER login
2020-01-16 3:03 ` Martin K. Petersen
@ 2020-01-16 4:48 ` Bart Van Assche
-1 siblings, 0 replies; 9+ messages in thread
From: Bart Van Assche @ 2020-01-16 4:48 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Rahul Kundu, linux-scsi, target-devel, Potnuri Bharat Teja,
Nirranjan Kirubaharan, Sagi Grimberg
On 2020-01-15 19:03, Martin K. Petersen wrote:
> Are you going to submit this?
Yes, I just did that. Thanks for the reminder.
Bart.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Trace seen on target during iSER login
@ 2020-01-16 4:48 ` Bart Van Assche
0 siblings, 0 replies; 9+ messages in thread
From: Bart Van Assche @ 2020-01-16 4:48 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Rahul Kundu, linux-scsi, target-devel, Potnuri Bharat Teja,
Nirranjan Kirubaharan, Sagi Grimberg
On 2020-01-15 19:03, Martin K. Petersen wrote:
> Are you going to submit this?
Yes, I just did that. Thanks for the reminder.
Bart.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-16 4:48 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-30 7:21 Trace seen on target during iSER login Rahul Kundu
2019-12-30 16:56 ` Bart Van Assche
2019-12-30 16:56 ` Bart Van Assche
2020-01-07 7:53 ` Rahul Kundu
2020-01-07 7:53 ` Rahul Kundu
2020-01-16 3:03 ` Martin K. Petersen
2020-01-16 3:03 ` Martin K. Petersen
2020-01-16 4:48 ` Bart Van Assche
2020-01-16 4:48 ` Bart Van Assche
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.