All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: initialize reg_access_ctrl
@ 2022-01-29 14:53 ` trix
  0 siblings, 0 replies; 3+ messages in thread
From: trix @ 2022-01-29 14:53 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
	nathan, ndesaulniers, PengJu.Zhou, candice.li, Hawking.Zhang,
	john.clements, Jingwen.Chen2, bokun.zhang, victor.skvortsov,
	bernard, lijo.lazar
  Cc: amd-gfx, dri-devel, linux-kernel, llvm, Tom Rix

From: Tom Rix <trix@redhat.com>

clang build fails with
amdgpu_virt.c:878:51: error: variable 'reg_access_ctrl' is
  uninitialized when used here
  ... + 4 * reg_access_ctrl->scratch_reg0;
            ^~~~~~~~~~~~~~~

The reg_access_ctrl ptr is never initialized, so
initialize once we know it is supported.

Fixes: 5d447e296701 ("drm/amdgpu: add helper for rlcg indirect reg access")
Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 80c25176c9932..c137652189190 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -875,6 +875,7 @@ static u32 amdgpu_virt_rlcg_reg_rw(struct amdgpu_device *adev, u32 offset, u32 v
 		return 0;
 	}
 
+	reg_access_ctrl = &adev->gfx.rlc.reg_access_ctrl;
 	scratch_reg0 = (void __iomem *)adev->rmmio + 4 * reg_access_ctrl->scratch_reg0;
 	scratch_reg1 = (void __iomem *)adev->rmmio + 4 * reg_access_ctrl->scratch_reg1;
 	scratch_reg2 = (void __iomem *)adev->rmmio + 4 * reg_access_ctrl->scratch_reg2;
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] drm/amdgpu: initialize reg_access_ctrl
@ 2022-01-29 14:53 ` trix
  0 siblings, 0 replies; 3+ messages in thread
From: trix @ 2022-01-29 14:53 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
	nathan, ndesaulniers, PengJu.Zhou, candice.li, Hawking.Zhang,
	john.clements, Jingwen.Chen2, bokun.zhang, victor.skvortsov,
	bernard, lijo.lazar
  Cc: Tom Rix, llvm, dri-devel, amd-gfx, linux-kernel

From: Tom Rix <trix@redhat.com>

clang build fails with
amdgpu_virt.c:878:51: error: variable 'reg_access_ctrl' is
  uninitialized when used here
  ... + 4 * reg_access_ctrl->scratch_reg0;
            ^~~~~~~~~~~~~~~

The reg_access_ctrl ptr is never initialized, so
initialize once we know it is supported.

Fixes: 5d447e296701 ("drm/amdgpu: add helper for rlcg indirect reg access")
Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 80c25176c9932..c137652189190 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -875,6 +875,7 @@ static u32 amdgpu_virt_rlcg_reg_rw(struct amdgpu_device *adev, u32 offset, u32 v
 		return 0;
 	}
 
+	reg_access_ctrl = &adev->gfx.rlc.reg_access_ctrl;
 	scratch_reg0 = (void __iomem *)adev->rmmio + 4 * reg_access_ctrl->scratch_reg0;
 	scratch_reg1 = (void __iomem *)adev->rmmio + 4 * reg_access_ctrl->scratch_reg1;
 	scratch_reg2 = (void __iomem *)adev->rmmio + 4 * reg_access_ctrl->scratch_reg2;
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: initialize reg_access_ctrl
  2022-01-29 14:53 ` trix
  (?)
@ 2022-01-31  2:01 ` Lazar, Lijo
  -1 siblings, 0 replies; 3+ messages in thread
From: Lazar, Lijo @ 2022-01-31  2:01 UTC (permalink / raw)
  To: trix, Deucher, Alexander, Koenig, Christian, Pan, Xinhui,
	airlied, daniel, nathan, ndesaulniers, Zhou, Peng Ju, Li,
	Candice, Zhang, Hawking, Clements, John, Chen, JingWen, Zhang,
	Bokun, Skvortsov, Victor, bernard
  Cc: Tom Rix, llvm, dri-devel, amd-gfx, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

[Public]

Thanks, the patch is already submitted.

https://www.spinics.net/lists/amd-gfx/msg73613.html

Thanks,
Lijo

[-- Attachment #2: Type: text/html, Size: 814 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-31  2:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-29 14:53 [PATCH] drm/amdgpu: initialize reg_access_ctrl trix
2022-01-29 14:53 ` trix
2022-01-31  2:01 ` Lazar, Lijo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.