From: "Michael Kelley (LINUX)" <mikelley@microsoft.com> To: Saurabh Sengar <ssengar@linux.microsoft.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, KY Srinivasan <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, "wei.liu@kernel.org" <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>, "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>, "tglx@linutronix.de" <tglx@linutronix.de>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>, Saurabh Singh Sengar <ssengar@microsoft.com>, "dphadke@linux.microsoft.com" <dphadke@linux.microsoft.com> Subject: RE: [PATCH v4 2/6] Drivers: hv: allow non ACPI compilation for hv_is_hibernation_supported Date: Wed, 8 Feb 2023 01:35:05 +0000 [thread overview] Message-ID: <BYAPR21MB168807092CE34421EA96134DD7D89@BYAPR21MB1688.namprd21.prod.outlook.com> (raw) In-Reply-To: <1675756199-5917-3-git-send-email-ssengar@linux.microsoft.com> From: Saurabh Sengar <ssengar@linux.microsoft.com> Sent: Monday, February 6, 2023 11:50 PM > > acpi_sleep_state_supported API is only define for CONFIG_ACPI flag and > thus it can't be used for non-ACPI builds. Initially there won't be > hibernation support for non ACPI builds. > > This change will help adding device tree support in subsequent commits. In keeping with the guideline to avoid references like "this patch" or "this change" in commit messages, I'd suggest wording the commit message something like the following: acpi_sleep_state_supported() currently is defined only when CONFIG_ACPI=y. For future work to enable device tree builds, put this function under #ifdef CONFIG_ACPI. Otherwise, return 'false' from hv_is_hibernation_supported() as Hyper-V guest configs using device tree don't support hibernation. With that update, Reviewed-by: Michael Kelley I gave a Reviewed-by on Patch 1 of this series, but the same comment applies about "this change" in that commit message. Michael > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > --- > drivers/hv/hv_common.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index 52a6f89..370ec20 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -234,7 +234,11 @@ void hv_setup_dma_ops(struct device *dev, bool coherent) > > bool hv_is_hibernation_supported(void) > { > +#ifdef CONFIG_ACPI > return !hv_root_partition && acpi_sleep_state_supported(ACPI_STATE_S4); > +#else > + return false; > +#endif > } > EXPORT_SYMBOL_GPL(hv_is_hibernation_supported); > > -- > 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Kelley \(LINUX\) via Virtualization" <virtualization@lists.linux-foundation.org> To: Saurabh Sengar <ssengar@linux.microsoft.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, KY Srinivasan <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, "wei.liu@kernel.org" <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>, "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>, "tglx@linutronix.de" <tglx@linutronix.de>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>, Saurabh Singh Sengar <ssengar@microsoft.com>, "dphadke@linux.microsoft.com" <dphadke@linux.microsoft.com> Subject: RE: [PATCH v4 2/6] Drivers: hv: allow non ACPI compilation for hv_is_hibernation_supported Date: Wed, 8 Feb 2023 01:35:05 +0000 [thread overview] Message-ID: <BYAPR21MB168807092CE34421EA96134DD7D89@BYAPR21MB1688.namprd21.prod.outlook.com> (raw) In-Reply-To: <1675756199-5917-3-git-send-email-ssengar@linux.microsoft.com> From: Saurabh Sengar <ssengar@linux.microsoft.com> Sent: Monday, February 6, 2023 11:50 PM > > acpi_sleep_state_supported API is only define for CONFIG_ACPI flag and > thus it can't be used for non-ACPI builds. Initially there won't be > hibernation support for non ACPI builds. > > This change will help adding device tree support in subsequent commits. In keeping with the guideline to avoid references like "this patch" or "this change" in commit messages, I'd suggest wording the commit message something like the following: acpi_sleep_state_supported() currently is defined only when CONFIG_ACPI=y. For future work to enable device tree builds, put this function under #ifdef CONFIG_ACPI. Otherwise, return 'false' from hv_is_hibernation_supported() as Hyper-V guest configs using device tree don't support hibernation. With that update, Reviewed-by: Michael Kelley I gave a Reviewed-by on Patch 1 of this series, but the same comment applies about "this change" in that commit message. Michael > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > --- > drivers/hv/hv_common.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index 52a6f89..370ec20 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -234,7 +234,11 @@ void hv_setup_dma_ops(struct device *dev, bool coherent) > > bool hv_is_hibernation_supported(void) > { > +#ifdef CONFIG_ACPI > return !hv_root_partition && acpi_sleep_state_supported(ACPI_STATE_S4); > +#else > + return false; > +#endif > } > EXPORT_SYMBOL_GPL(hv_is_hibernation_supported); > > -- > 1.8.3.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-02-08 1:35 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-07 7:49 [PATCH v4 0/6] Device tree support for Hyper-V VMBus driver Saurabh Sengar 2023-02-07 7:49 ` [PATCH v4 1/6] drivers/clocksource/hyper-v: non ACPI support in hyperv clock Saurabh Sengar 2023-02-08 1:22 ` Michael Kelley (LINUX) 2023-02-08 1:22 ` Michael Kelley (LINUX) via Virtualization 2023-02-07 7:49 ` [PATCH v4 2/6] Drivers: hv: allow non ACPI compilation for hv_is_hibernation_supported Saurabh Sengar 2023-02-08 1:35 ` Michael Kelley (LINUX) [this message] 2023-02-08 1:35 ` Michael Kelley (LINUX) via Virtualization 2023-02-07 7:49 ` [PATCH v4 3/6] Drivers: hv: vmbus: Convert acpi_device to more generic platform_device Saurabh Sengar 2023-02-08 1:50 ` Michael Kelley (LINUX) 2023-02-08 1:50 ` Michael Kelley (LINUX) via Virtualization 2023-02-07 7:49 ` [PATCH v4 4/6] dt-bindings: hypervisor: Rename virtio to hypervisor Saurabh Sengar 2023-02-07 18:39 ` Rob Herring 2023-02-07 18:39 ` Rob Herring 2023-02-08 2:51 ` Saurabh Singh Sengar 2023-02-07 7:49 ` [PATCH v4 5/6] dt-bindings: hypervisor: VMBus Saurabh Sengar 2023-02-07 13:00 ` Rob Herring 2023-02-07 13:00 ` Rob Herring 2023-02-07 18:34 ` Rob Herring 2023-02-07 18:34 ` Rob Herring 2023-02-08 2:50 ` Saurabh Singh Sengar 2023-02-07 7:49 ` [PATCH v4 6/6] Driver: VMBus: Add device tree support Saurabh Sengar 2023-02-08 8:22 ` kernel test robot 2023-02-08 8:22 ` kernel test robot 2023-02-08 10:25 ` Krzysztof Kozlowski 2023-02-08 14:39 ` Nathan Chancellor 2023-02-08 15:36 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BYAPR21MB168807092CE34421EA96134DD7D89@BYAPR21MB1688.namprd21.prod.outlook.com \ --to=mikelley@microsoft.com \ --cc=daniel.lezcano@linaro.org \ --cc=decui@microsoft.com \ --cc=devicetree@vger.kernel.org \ --cc=dphadke@linux.microsoft.com \ --cc=haiyangz@microsoft.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kys@microsoft.com \ --cc=linux-hyperv@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=ssengar@linux.microsoft.com \ --cc=ssengar@microsoft.com \ --cc=tglx@linutronix.de \ --cc=virtualization@lists.linux-foundation.org \ --cc=wei.liu@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.