Re: [daisy][PATCH 1/3] layer.conf: Add in useradd dependencies as ABISAFE dependencies

From: Koen Kooi <koen@dominion.thruhere.net>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [daisy][PATCH 1/3] layer.conf: Add in useradd dependencies as ABISAFE dependencies
Date: Wed, 1 Oct 2014 13:02:37 +0200	[thread overview]
Message-ID: <C023D4F6-0FD5-490B-B5E9-8619CB8202DE@dominion.thruhere.net> (raw)
In-Reply-To: <1412151136.17658.10.camel@ted>

Op 1 okt. 2014, om 10:12 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven:

> On Wed, 2014-10-01 at 06:10 +0200, Martin Jansa wrote:
>> On Tue, Sep 30, 2014 at 08:55:53PM -0700, Khem Raj wrote:
>>> On Tue, Sep 30, 2014 at 6:32 PM, Denys Dmytriyenko <denis@denix.org> wrote:
>>>> On Tue, Sep 30, 2014 at 06:25:57PM -0700, Khem Raj wrote:
>>>>> On Tue, Sep 30, 2014 at 5:55 PM, Denys Dmytriyenko <denis@denix.org> wrote:
>>>>>> This line above ^^^^ has a very long trail of whitespaces and it got commited
>>>>>> that way, unfortunately :(
>>>>> 
>>>>> Better was if you commented before it went in.
>>>> 
>>>> And how would you suggest I was supposed to see it?? Nobody saw it. My email
>>>> client is no different than others - it doesn't mark trailing whitespaces. The
>>>> reason I saw it is because I ran "git log -p" on the file and that explicitly
>>>> highlights trailing whitespaces in BRIGHT RED... :)
>>> 
>>> just for that may be we should start using gerrit ;)
>> 
>> I'm all for it, it would make my e-mail - review - patchwork -
>> master-next workflow a lot easier and reliable.
> 
> And I am not. Why? I've actually tried using the thing and I absolutely
> *despise* its interface. This isn't just a mild dislike, I simply cannot
> do the things I want/need to do with it.

I use gerrit at work and I despise the interface as well, but it does address a number is issues plaguing OE-core:

1) pull-request doesn't match emailed patches
2) Patches are forgotten
3) Wrong version of patch gets applied
4) Review comments aren't tracked

But patchwork can be used to address the above problems as well. Anyway, this isn't a purely technical problem, see below.

> I believe I should have some kind of a say in this since it will
> directly affect my workflow and general life (since I spend a lot of my
> time dealing with this). Its appears to be very easy for other people to
> tell me how I should work though :(.

I think the real solution doesn't involve extra layers of tools, but a move to a kernel style environment where subsystem maintainers collect and vet patches and send pull requests to RP. But that would require formalizing the commit and review rules which I suspect will be controversial.

--
Koen