All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Denys Dmytriyenko <denis@denix.org>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [daisy][PATCH 1/3] layer.conf: Add in useradd dependencies as ABISAFE dependencies
Date: Tue, 30 Sep 2014 20:55:53 -0700	[thread overview]
Message-ID: <CAMKF1sqa2JtVOhv7f0P=_HfSnrL2kfd2QmP+GM_FsM3zb-xq=g@mail.gmail.com> (raw)
In-Reply-To: <20141001013231.GQ2480@denix.org>

On Tue, Sep 30, 2014 at 6:32 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Tue, Sep 30, 2014 at 06:25:57PM -0700, Khem Raj wrote:
>> On Tue, Sep 30, 2014 at 5:55 PM, Denys Dmytriyenko <denis@denix.org> wrote:
>> > This line above ^^^^ has a very long trail of whitespaces and it got commited
>> > that way, unfortunately :(
>>
>> Better was if you commented before it went in.
>
> And how would you suggest I was supposed to see it?? Nobody saw it. My email
> client is no different than others - it doesn't mark trailing whitespaces. The
> reason I saw it is because I ran "git log -p" on the file and that explicitly
> highlights trailing whitespaces in BRIGHT RED... :)

just for that may be we should start using gerrit ;)

>
> --
> Denys


  reply	other threads:[~2014-10-01  3:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 12:17 [daisy][PATCH 1/3] layer.conf: Add in useradd dependencies as ABISAFE dependencies Steffen Sledz
2014-09-25 12:17 ` [daisy][PATCH 2/3] update-rc.d/systemd: Remove OVERRIDES dependency Steffen Sledz
2014-09-25 12:17 ` [daisy][PATCH 3/3] layer.conf: Mark opkg-utils as ABISAFE for update-alternatives usage Steffen Sledz
2014-10-01  0:55 ` [daisy][PATCH 1/3] layer.conf: Add in useradd dependencies as ABISAFE dependencies Denys Dmytriyenko
2014-10-01  1:25   ` Khem Raj
2014-10-01  1:32     ` Denys Dmytriyenko
2014-10-01  3:55       ` Khem Raj [this message]
2014-10-01  4:10         ` Martin Jansa
2014-10-01  8:12           ` Richard Purdie
2014-10-01 11:02             ` Koen Kooi
2014-10-01 15:34             ` Martin Jansa
2014-10-03  8:24               ` Koen Kooi
2014-10-03 14:03                 ` Trevor Woerner
2014-10-03 16:46                 ` Khem Raj
2014-10-01 13:12   ` Peter A. Bigot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMKF1sqa2JtVOhv7f0P=_HfSnrL2kfd2QmP+GM_FsM3zb-xq=g@mail.gmail.com' \
    --to=raj.khem@gmail.com \
    --cc=denis@denix.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.