From: Paolo Valente <paolo.valente@linaro.org> To: Jens Axboe <axboe@fb.com> Cc: Linux-Kernal <linux-kernel@vger.kernel.org>, linux-block@vger.kernel.org, Omar Sandoval <osandov@osandov.com>, bart.vanassche@sandisk.com Subject: Re: [PATCHSET v6] blk-mq scheduling framework Date: Sun, 15 Jan 2017 11:12:01 +0100 [thread overview] Message-ID: <C14FF2E2-886B-4EFD-8FBB-7DC528B02373@linaro.org> (raw) In-Reply-To: <1484170803-9311-1-git-send-email-axboe@fb.com> > Il giorno 11 gen 2017, alle ore 22:39, Jens Axboe <axboe@fb.com> ha = scritto: >=20 > Another year, another posting of this patchset. The previous posting > was here: >=20 > https://www.spinics.net/lists/kernel/msg2406106.html >=20 > (yes, I've skipped v5, it was fixes on top of v4, not the rework). >=20 > I've reworked bits of this to get rid of the shadow requests, thanks > to Bart for the inspiration. The missing piece, for me, was the fact > that we have the tags->rqs[] indirection array already. I've done this > somewhat differently, though, by having the internal scheduler tag > map be allocated/torn down when an IO scheduler is attached or > detached. This also means that when we run without a scheduler, we > don't have to do double tag allocations, it'll work like before. >=20 > The patchset applies on top of 4.10-rc3, or can be pulled here: >=20 > git://git.kernel.dk/linux-block blk-mq-sched.6 >=20 >=20 Hi Jens, I have checked this new version to find solutions to the apparent errors, mistakes or just unclear parts (to me) that I have pointed out before Christmas last year. But I have found no changes related to these problems. As I have already written, I'm willing to try to fix those errors myself, if they really are errors, but I would first need at least some minimal initial feedback and guidance. If needed, tell me how I can help you get in sync again with these issues (sending my reports again, sending a digest of them, ...). Thanks, Paolo > block/Kconfig.iosched | 50 ++++ > block/Makefile | 3=20 > block/blk-core.c | 19 - > block/blk-exec.c | 3=20 > block/blk-flush.c | 15 - > block/blk-ioc.c | 12=20 > block/blk-merge.c | 4=20 > block/blk-mq-sched.c | 354 +++++++++++++++++++++++++++++ > block/blk-mq-sched.h | 157 ++++++++++++ > block/blk-mq-sysfs.c | 13 + > block/blk-mq-tag.c | 58 ++-- > block/blk-mq-tag.h | 4=20 > block/blk-mq.c | 413 +++++++++++++++++++--------------- > block/blk-mq.h | 40 +++ > block/blk-tag.c | 1=20 > block/blk.h | 26 +- > block/cfq-iosched.c | 2=20 > block/deadline-iosched.c | 2=20 > block/elevator.c | 247 +++++++++++++++----- > block/mq-deadline.c | 569 = +++++++++++++++++++++++++++++++++++++++++++++++ > block/noop-iosched.c | 2=20 > drivers/nvme/host/pci.c | 1=20 > include/linux/blk-mq.h | 9=20 > include/linux/blkdev.h | 6=20 > include/linux/elevator.h | 36 ++ > 25 files changed, 1732 insertions(+), 314 deletions(-) >=20 > --=20 > Jens Axboe >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-block" = in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Valente <paolo.valente@linaro.org> To: Jens Axboe <axboe@fb.com> Cc: Linux-Kernal <linux-kernel@vger.kernel.org>, linux-block@vger.kernel.org, Omar Sandoval <osandov@osandov.com>, bart.vanassche@sandisk.com Subject: Re: [PATCHSET v6] blk-mq scheduling framework Date: Sun, 15 Jan 2017 11:12:01 +0100 [thread overview] Message-ID: <C14FF2E2-886B-4EFD-8FBB-7DC528B02373@linaro.org> (raw) In-Reply-To: <1484170803-9311-1-git-send-email-axboe@fb.com> > Il giorno 11 gen 2017, alle ore 22:39, Jens Axboe <axboe@fb.com> ha scritto: > > Another year, another posting of this patchset. The previous posting > was here: > > https://www.spinics.net/lists/kernel/msg2406106.html > > (yes, I've skipped v5, it was fixes on top of v4, not the rework). > > I've reworked bits of this to get rid of the shadow requests, thanks > to Bart for the inspiration. The missing piece, for me, was the fact > that we have the tags->rqs[] indirection array already. I've done this > somewhat differently, though, by having the internal scheduler tag > map be allocated/torn down when an IO scheduler is attached or > detached. This also means that when we run without a scheduler, we > don't have to do double tag allocations, it'll work like before. > > The patchset applies on top of 4.10-rc3, or can be pulled here: > > git://git.kernel.dk/linux-block blk-mq-sched.6 > > Hi Jens, I have checked this new version to find solutions to the apparent errors, mistakes or just unclear parts (to me) that I have pointed out before Christmas last year. But I have found no changes related to these problems. As I have already written, I'm willing to try to fix those errors myself, if they really are errors, but I would first need at least some minimal initial feedback and guidance. If needed, tell me how I can help you get in sync again with these issues (sending my reports again, sending a digest of them, ...). Thanks, Paolo > block/Kconfig.iosched | 50 ++++ > block/Makefile | 3 > block/blk-core.c | 19 - > block/blk-exec.c | 3 > block/blk-flush.c | 15 - > block/blk-ioc.c | 12 > block/blk-merge.c | 4 > block/blk-mq-sched.c | 354 +++++++++++++++++++++++++++++ > block/blk-mq-sched.h | 157 ++++++++++++ > block/blk-mq-sysfs.c | 13 + > block/blk-mq-tag.c | 58 ++-- > block/blk-mq-tag.h | 4 > block/blk-mq.c | 413 +++++++++++++++++++--------------- > block/blk-mq.h | 40 +++ > block/blk-tag.c | 1 > block/blk.h | 26 +- > block/cfq-iosched.c | 2 > block/deadline-iosched.c | 2 > block/elevator.c | 247 +++++++++++++++----- > block/mq-deadline.c | 569 +++++++++++++++++++++++++++++++++++++++++++++++ > block/noop-iosched.c | 2 > drivers/nvme/host/pci.c | 1 > include/linux/blk-mq.h | 9 > include/linux/blkdev.h | 6 > include/linux/elevator.h | 36 ++ > 25 files changed, 1732 insertions(+), 314 deletions(-) > > -- > Jens Axboe > > -- > To unsubscribe from this list: send the line "unsubscribe linux-block" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-15 10:12 UTC|newest] Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-11 21:39 [PATCHSET v6] blk-mq scheduling framework Jens Axboe 2017-01-11 21:39 ` [PATCH 01/10] block: move existing elevator ops to union Jens Axboe 2017-01-12 10:15 ` Johannes Thumshirn 2017-01-12 10:15 ` Johannes Thumshirn 2017-01-12 21:17 ` Bart Van Assche 2017-01-12 21:17 ` Bart Van Assche 2017-01-13 8:34 ` Christoph Hellwig 2017-01-13 15:00 ` Jens Axboe 2017-01-11 21:39 ` [PATCH 02/10] blk-mq: make mq_ops a const pointer Jens Axboe 2017-01-12 10:14 ` Johannes Thumshirn 2017-01-12 10:14 ` Johannes Thumshirn 2017-01-13 8:16 ` Christoph Hellwig 2017-01-11 21:39 ` [PATCH 03/10] block: move rq_ioc() to blk.h Jens Axboe 2017-01-12 10:14 ` Johannes Thumshirn 2017-01-12 10:14 ` Johannes Thumshirn 2017-01-12 21:18 ` Bart Van Assche 2017-01-12 21:18 ` Bart Van Assche 2017-01-13 8:33 ` Christoph Hellwig 2017-01-11 21:39 ` [PATCH 04/10] blk-mq: un-export blk_mq_free_hctx_request() Jens Axboe 2017-01-12 10:13 ` Johannes Thumshirn 2017-01-12 10:13 ` Johannes Thumshirn 2017-01-12 21:18 ` Bart Van Assche 2017-01-12 21:18 ` Bart Van Assche 2017-01-13 8:16 ` Christoph Hellwig 2017-01-11 21:39 ` [PATCH 05/10] blk-mq: export some helpers we need to the scheduling framework Jens Axboe 2017-01-12 10:17 ` Johannes Thumshirn 2017-01-12 10:17 ` Johannes Thumshirn 2017-01-12 21:20 ` Bart Van Assche 2017-01-12 21:20 ` Bart Van Assche 2017-01-13 8:17 ` Christoph Hellwig 2017-01-13 15:01 ` Jens Axboe 2017-01-11 21:39 ` [PATCH 06/10] blk-mq-tag: cleanup the normal/reserved tag allocation Jens Axboe 2017-01-12 21:22 ` Bart Van Assche 2017-01-12 21:22 ` Bart Van Assche 2017-01-12 22:07 ` Jens Axboe 2017-01-13 8:30 ` Christoph Hellwig 2017-01-13 15:06 ` Jens Axboe 2017-01-11 21:40 ` [PATCH 07/10] blk-mq: abstract out helpers for allocating/freeing tag maps Jens Axboe 2017-01-12 21:29 ` Bart Van Assche 2017-01-12 21:29 ` Bart Van Assche 2017-01-12 21:54 ` Jens Axboe 2017-01-13 8:25 ` Johannes Thumshirn 2017-01-13 8:25 ` Johannes Thumshirn 2017-01-11 21:40 ` [PATCH 08/10] blk-mq-sched: add framework for MQ capable IO schedulers Jens Axboe 2017-01-12 21:45 ` Bart Van Assche 2017-01-12 21:45 ` Bart Van Assche 2017-01-12 21:59 ` Jens Axboe 2017-01-13 11:15 ` Hannes Reinecke 2017-01-13 11:15 ` Hannes Reinecke 2017-01-13 16:39 ` Bart Van Assche 2017-01-13 16:39 ` Bart Van Assche 2017-01-13 16:41 ` Omar Sandoval 2017-01-13 17:43 ` Hannes Reinecke 2017-01-13 17:43 ` Hannes Reinecke 2017-01-11 21:40 ` [PATCH 09/10] mq-deadline: add blk-mq adaptation of the deadline IO scheduler Jens Axboe 2017-01-12 21:53 ` Bart Van Assche 2017-01-12 21:53 ` Bart Van Assche 2017-01-11 21:40 ` [PATCH 10/10] blk-mq-sched: allow setting of default " Jens Axboe 2017-01-12 21:54 ` Bart Van Assche 2017-01-12 21:54 ` Bart Van Assche 2017-01-12 21:16 ` [PATCHSET v6] blk-mq scheduling framework Bart Van Assche 2017-01-12 21:16 ` Bart Van Assche 2017-01-13 8:15 ` Hannes Reinecke 2017-01-13 8:15 ` Hannes Reinecke 2017-01-13 11:04 ` Hannes Reinecke 2017-01-13 11:04 ` Hannes Reinecke 2017-01-13 12:10 ` Hannes Reinecke 2017-01-13 12:10 ` Hannes Reinecke 2017-01-13 15:05 ` Jens Axboe 2017-01-13 15:03 ` Jens Axboe 2017-01-13 15:23 ` Jens Axboe 2017-01-13 15:23 ` Jens Axboe 2017-01-13 15:33 ` Hannes Reinecke 2017-01-13 15:33 ` Hannes Reinecke 2017-01-13 15:34 ` Jens Axboe 2017-01-13 15:34 ` Jens Axboe 2017-01-13 15:59 ` Hannes Reinecke 2017-01-13 15:59 ` Hannes Reinecke 2017-01-13 16:00 ` Jens Axboe 2017-01-13 16:00 ` Jens Axboe 2017-01-13 16:02 ` Jens Axboe 2017-01-13 21:45 ` Jens Axboe 2017-01-16 8:11 ` Hannes Reinecke 2017-01-16 8:11 ` Hannes Reinecke 2017-01-16 15:12 ` Jens Axboe 2017-01-16 15:16 ` Jens Axboe 2017-01-16 15:47 ` Jens Axboe 2017-01-13 10:09 ` Hannes Reinecke 2017-01-13 10:09 ` Hannes Reinecke 2017-01-15 10:12 ` Paolo Valente [this message] 2017-01-15 10:12 ` Paolo Valente 2017-01-15 15:55 ` Jens Axboe 2017-01-15 15:55 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=C14FF2E2-886B-4EFD-8FBB-7DC528B02373@linaro.org \ --to=paolo.valente@linaro.org \ --cc=axboe@fb.com \ --cc=bart.vanassche@sandisk.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=osandov@osandov.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.