[PATCH] Fix vncdisplay option for HVM domains

[PATCH] Fix vncdisplay option for HVM domains

[Kasai Takanori]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

Hi All,

When vncdisplay is specified for the configuration file, 
HVM domain cannot be started. (xen-unstable.hg: cs13835)

Configuration file:
vncdisplay=7

[root@dom0 conf]# xm cre -f domVTx-100.conf
Using config file "./domVTx-100.conf".
Error: an integer is required

The issue added as follows. 
- xen-unstable.hg : cs13778
  Fix SDL option for HVM domains.

This patch is a correction of this issue. 

Signed-off-by: Takanori Kasai <kasai.takanori@jp.fujitsu.com>

Best Regards,

--
Takanori Kasai

[-- Attachment #2: fix-python-vncdisplay.patch --]
[-- Type: application/octet-stream, Size: 839 bytes --]

# HG changeset patch
# User kasai.takanori@jp.fujitsu.com
# Date 1170996646 -32400
# Node ID f650b8721b68e6eda6edc4210561a180838aa2e4
# Parent  d609929f140809ec1c9a059f2eeaffb7ce56c891
Fix vncdisplay option for HVM domains

Signed-off-by: Takanori Kasai <kasai.takanori@jp.fujitsu.com>

diff -r d609929f1408 -r f650b8721b68 tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py	Thu Feb 08 16:52:05 2007 +0000
+++ b/tools/python/xen/xend/image.py	Fri Feb 09 13:50:46 2007 +0900
@@ -467,6 +467,7 @@ class HVMImageHandler(ImageHandler):
 
             if not vnc_config.get('vncunused', 0) and \
                    vnc_config.get('vncdisplay', 0):
+                vncdisplay = vnc_config.get('vncdisplay')
                 ret.append('-vnc')
                 ret.append(str(vncdisplay))
             else:

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] Fix vncdisplay option for HVM domains

[Kasai Takanori]

Hi All,

I send the following patche before.
However, the patch has not been applied yet.
Could you apply this patch? Or, please give the comment to me.

Best regards,

--
Takanori Kasai


----- Original Message ----- 
From: "Kasai Takanori" <kasai.takanori@jp.fujitsu.com>
To: "xen-devel" <xen-devel@lists.xensource.com>
Sent: Friday, February 09, 2007 2:12 PM
Subject: [Xen-devel] [PATCH] Fix vncdisplay option for HVM domains


> Hi All,
>
> When vncdisplay is specified for the configuration file,
> HVM domain cannot be started. (xen-unstable.hg: cs13835)
>
> Configuration file:
> vncdisplay=7
>
> [root@dom0 conf]# xm cre -f domVTx-100.conf
> Using config file "./domVTx-100.conf".
> Error: an integer is required
>
> The issue added as follows.
> - xen-unstable.hg : cs13778
>  Fix SDL option for HVM domains.
>
> This patch is a correction of this issue.
>
> Signed-off-by: Takanori Kasai <kasai.takanori@jp.fujitsu.com>
>
> Best Regards,
>
> --
> Takanori Kasai


--------------------------------------------------------------------------------


> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 

Re: [PATCH] Fix vncdisplay option for HVM domains

[Keir Fraser]

On 16/2/07 05:48, "Kasai Takanori" <kasai.takanori@jp.fujitsu.com> wrote:

> Hi All,
> 
> I send the following patche before.
> However, the patch has not been applied yet.
> Could you apply this patch? Or, please give the comment to me.

Applied, thanks.

 -- Keir