[PATCH] Fix broken peer recv check

[PATCH] Fix broken peer recv check

[Chad Hanson]

Fix a broken networking check. Return an error if peer recv fails. If secmark is active
and the packet recv succeeds the peer recv error is ignored.

Signed-off-by: Chad Hanson <chanson@trustedcs.com>
---
 hooks.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index d85b793..64826a0 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -4215,8 +4215,10 @@ static int selinux_socket_sock_rcv_skb(struct sock *sk, struct sk_buff *skb)
 		}
 		err = avc_has_perm(sk_sid, peer_sid, SECCLASS_PEER,
 				   PEER__RECV, &ad);
-		if (err)
+		if (err) {
 			selinux_netlbl_err(skb, err, 0);
+			return err;
+		}
 	}
 
 	if (secmark_active) {


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH] Fix broken peer recv check

[Paul Moore]

On Friday, July 20, 2012 09:42:59 PM Chad Hanson wrote:
> Fix a broken networking check. Return an error if peer recv fails. If
> secmark is active and the packet recv succeeds the peer recv error is
> ignored.
> 
> Signed-off-by: Chad Hanson <chanson@trustedcs.com>

I would also consider this as reasonable for stable once it it merged.

Acked-by: Paul Moore <paul@paul-moore.com>

> ---
>  hooks.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index d85b793..64826a0 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -4215,8 +4215,10 @@ static int selinux_socket_sock_rcv_skb(struct sock
> *sk, struct sk_buff *skb) }
>  		err = avc_has_perm(sk_sid, peer_sid, SECCLASS_PEER,
>  				   PEER__RECV, &ad);
> -		if (err)
> +		if (err) {
>  			selinux_netlbl_err(skb, err, 0);
> +			return err;
> +		}
>  	}
> 
>  	if (secmark_active) {

-- 
paul moore
www.paul-moore.com


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.