From: "H. Nikolaus Schaller" <hns@goldelico.com> To: Maxime Ripard <maxime@cerno.tech>, Sam Ravnborg <sam@ravnborg.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Paul Cercueil <paul@crapouillou.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Geert Uytterhoeven <geert+renesas@glider.be>, Kees Cook <keescook@chromium.org>, "Eric W. Biederman" <ebiederm@xmission.com>, Miquel Raynal <miquel.raynal@bootlin.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Robert Foss <robert.foss@linaro.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Ezequiel Garcia <ezequiel@collabora.com>, Harry Wentland <harry.wentland@amd.com>, Sam Ravnborg <sam@ravnborg.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Paul Boddie <paul@boddie.org.uk>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-mips <linux-mips@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, Discussions about the Letux Kernel <letux-kernel@openphoenux.org>, Jonas Karlman <jonas@kwiboo.se>, dri-devel <dri-devel@lists.freedesktop.org>, Rob Herring <robh@kernel.org> Subject: Re: [PATCH v4 03/10] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema Date: Tue, 28 Sep 2021 10:59:45 +0200 [thread overview] Message-ID: <C529DB99-709A-4C24-B647-3A2004CBFE18@goldelico.com> (raw) In-Reply-To: <20210927170702.on243lp24fcfdhbj@gilmour> Hi, > Am 27.09.2021 um 19:07 schrieb maxime@cerno.tech: > > Hi, > > On Mon, Sep 27, 2021 at 06:44:21PM +0200, H. Nikolaus Schaller wrote: >> From: Sam Ravnborg <sam@ravnborg.org> >> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutfullah Kakakhel >> >> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: devicetree@vger.kernel.org >> --- >> .../bindings/display/ingenic-jz4780-hdmi.yaml | 85 +++++++++++++++++++ >> 1 file changed, 85 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml >> new file mode 100644 >> index 000000000000..5e60cdac4f63 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml >> @@ -0,0 +1,85 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/ingenic-jz4780-hdmi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bindings for Ingenic JZ4780 HDMI Transmitter >> + >> +maintainers: >> + - H. Nikolaus Schaller <hns@goldelico.com> >> + >> +description: | >> + The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys DesignWare HDMI 1.4 >> + TX controller IP with accompanying PHY IP. >> + >> +allOf: >> + - $ref: panel/panel-common.yaml# > > Is it a panel though? Good question. Appears to have to be changed to - $ref: bridge/synopsys,dw-hdmi.yaml# > >> +properties: >> + compatible: >> + items: >> + - const: ingenic,jz4780-dw-hdmi > > This can just be a const, there's no need for the items Maybe starting with an enum is better if more compatible strings are to be added. > >> + >> + reg: >> + maxItems: 1 >> + description: the address & size of the LCD controller registers > > There's no need for that description, it's obvious enough Indeed. > >> + reg-io-width: >> + const: 4 > > If it's fixed, why do you need it in the first place? There is a fixed default of 1 if not specified. > >> + interrupts: >> + maxItems: 1 >> + description: Specifies the interrupt provided by parent > > There's no need for that description, it's obvious enough Indeed. > >> + clocks: >> + maxItems: 2 >> + description: Clock specifiers for isrf and iahb clocks > > This can be defined as > > clocks: > items: > - description: isrf > - description: iahb > > A better description about what these clocks are would be nice as well Generally I see that this all is nowadays not independent of Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml where there is already a description. On the other hand every SoC specialization runs its own copy. e.g. Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yam > >> + clock-names: >> + items: >> + - const: isfr > > Is it isfr or isrf? isfr. Seems to be a typo in the description. See bridge/synopsys,dw-hdmi.yaml# One question to the yaml specialists: since ../bridge/synopsys,dw-hdmi.yaml# already defines this, do we have to repeat? Or can we reduce to just the changes? [I am still not familiar enough with the yaml stuff to understand if it has sort of inheritance like device tree include files, so that you just have to change relevant properties] > >> + - const: iahb would it make sense to add additionalItems: false here? In the jz4780 case there are just two clocks while other specializations use more and synopsys,dw-hdmi.yaml# defines additionalItems: true. >> + >> + hdmi-regulator: true >> + description: Optional regulator to provide +5V at the connector > > regulators need to be suffixed by -supply My omission... And, it should be "hdmi-5v-supply" to match driver and device tree. > > You also can just provide the description, you don't need the true there > >> + ddc-i2c-bus: true > > ditto Ok > >> + description: An I2C interface if the internal DDC I2C driver is not to be used >> + ports: true > > If there's a single port, you don't need ports There can be two ports - one for input from LCDC and one for output (HDMI connector). But explicitly defining an output port is optional to some extent (depending on driver structure). > > You should also include /schemas/graph.yaml#/$defs/port-base Ok. BR and thanks, Nikolaus
WARNING: multiple messages have this Message-ID (diff)
From: "H. Nikolaus Schaller" <hns@goldelico.com> To: Maxime Ripard <maxime@cerno.tech>, Sam Ravnborg <sam@ravnborg.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Paul Cercueil <paul@crapouillou.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Geert Uytterhoeven <geert+renesas@glider.be>, Kees Cook <keescook@chromium.org>, "Eric W. Biederman" <ebiederm@xmission.com>, Miquel Raynal <miquel.raynal@bootlin.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Robert Foss <robert.foss@linaro.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Ezequiel Garcia <ezequiel@collabora.com>, Harry Wentland <harry.wentland@amd.com>, Sam Ravnborg <sam@ravnborg.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Paul Boddie <paul@boddie.org.uk>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-mips <linux-mips@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, Discussions about the Letux Kernel <letux-kernel@openphoenux.org>, Jonas Karlman <jonas@kwiboo.se>, dri-devel <dri-devel@lists.freedesktop.org>, Rob Herring <robh@kernel.org> Subject: Re: [PATCH v4 03/10] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema Date: Tue, 28 Sep 2021 10:59:45 +0200 [thread overview] Message-ID: <C529DB99-709A-4C24-B647-3A2004CBFE18@goldelico.com> (raw) In-Reply-To: <20210927170702.on243lp24fcfdhbj@gilmour> Hi, > Am 27.09.2021 um 19:07 schrieb maxime@cerno.tech: > > Hi, > > On Mon, Sep 27, 2021 at 06:44:21PM +0200, H. Nikolaus Schaller wrote: >> From: Sam Ravnborg <sam@ravnborg.org> >> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutfullah Kakakhel >> >> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: devicetree@vger.kernel.org >> --- >> .../bindings/display/ingenic-jz4780-hdmi.yaml | 85 +++++++++++++++++++ >> 1 file changed, 85 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml >> new file mode 100644 >> index 000000000000..5e60cdac4f63 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml >> @@ -0,0 +1,85 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/ingenic-jz4780-hdmi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bindings for Ingenic JZ4780 HDMI Transmitter >> + >> +maintainers: >> + - H. Nikolaus Schaller <hns@goldelico.com> >> + >> +description: | >> + The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys DesignWare HDMI 1.4 >> + TX controller IP with accompanying PHY IP. >> + >> +allOf: >> + - $ref: panel/panel-common.yaml# > > Is it a panel though? Good question. Appears to have to be changed to - $ref: bridge/synopsys,dw-hdmi.yaml# > >> +properties: >> + compatible: >> + items: >> + - const: ingenic,jz4780-dw-hdmi > > This can just be a const, there's no need for the items Maybe starting with an enum is better if more compatible strings are to be added. > >> + >> + reg: >> + maxItems: 1 >> + description: the address & size of the LCD controller registers > > There's no need for that description, it's obvious enough Indeed. > >> + reg-io-width: >> + const: 4 > > If it's fixed, why do you need it in the first place? There is a fixed default of 1 if not specified. > >> + interrupts: >> + maxItems: 1 >> + description: Specifies the interrupt provided by parent > > There's no need for that description, it's obvious enough Indeed. > >> + clocks: >> + maxItems: 2 >> + description: Clock specifiers for isrf and iahb clocks > > This can be defined as > > clocks: > items: > - description: isrf > - description: iahb > > A better description about what these clocks are would be nice as well Generally I see that this all is nowadays not independent of Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml where there is already a description. On the other hand every SoC specialization runs its own copy. e.g. Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yam > >> + clock-names: >> + items: >> + - const: isfr > > Is it isfr or isrf? isfr. Seems to be a typo in the description. See bridge/synopsys,dw-hdmi.yaml# One question to the yaml specialists: since ../bridge/synopsys,dw-hdmi.yaml# already defines this, do we have to repeat? Or can we reduce to just the changes? [I am still not familiar enough with the yaml stuff to understand if it has sort of inheritance like device tree include files, so that you just have to change relevant properties] > >> + - const: iahb would it make sense to add additionalItems: false here? In the jz4780 case there are just two clocks while other specializations use more and synopsys,dw-hdmi.yaml# defines additionalItems: true. >> + >> + hdmi-regulator: true >> + description: Optional regulator to provide +5V at the connector > > regulators need to be suffixed by -supply My omission... And, it should be "hdmi-5v-supply" to match driver and device tree. > > You also can just provide the description, you don't need the true there > >> + ddc-i2c-bus: true > > ditto Ok > >> + description: An I2C interface if the internal DDC I2C driver is not to be used >> + ports: true > > If there's a single port, you don't need ports There can be two ports - one for input from LCDC and one for output (HDMI connector). But explicitly defining an output port is optional to some extent (depending on driver structure). > > You should also include /schemas/graph.yaml#/$defs/port-base Ok. BR and thanks, Nikolaus
next prev parent reply other threads:[~2021-09-28 9:00 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-27 16:44 [PATCH v4 00/10] MIPS: JZ4780 and CI20 HDMI H. Nikolaus Schaller 2021-09-27 16:44 ` [PATCH v4 01/10] drm/ingenic: Fix drm_init error path if IPU was registered H. Nikolaus Schaller 2021-09-27 16:44 ` [PATCH v4 02/10] drm/ingenic: Add support for JZ4780 and HDMI output H. Nikolaus Schaller 2021-09-28 9:35 ` Paul Cercueil 2021-09-28 10:21 ` H. Nikolaus Schaller 2021-09-28 12:06 ` H. Nikolaus Schaller 2021-09-29 13:25 ` H. Nikolaus Schaller 2021-09-29 14:30 ` Paul Cercueil 2021-09-29 14:42 ` H. Nikolaus Schaller 2021-09-27 16:44 ` [PATCH v4 03/10] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema H. Nikolaus Schaller 2021-09-27 16:44 ` [PATCH v4 03/10] dt-bindings: display: Add ingenic, jz4780-dw-hdmi " H. Nikolaus Schaller 2021-09-27 17:07 ` [PATCH v4 03/10] dt-bindings: display: Add ingenic,jz4780-dw-hdmi " maxime 2021-09-27 17:07 ` maxime 2021-09-28 8:59 ` H. Nikolaus Schaller [this message] 2021-09-28 8:59 ` [PATCH v4 03/10] dt-bindings: display: Add ingenic, jz4780-dw-hdmi " H. Nikolaus Schaller 2021-09-28 9:18 ` [PATCH v4 03/10] dt-bindings: display: Add ingenic,jz4780-dw-hdmi " Maxime Ripard 2021-09-28 9:18 ` Maxime Ripard 2021-09-28 9:34 ` H. Nikolaus Schaller 2021-09-28 9:34 ` [PATCH v4 03/10] dt-bindings: display: Add ingenic, jz4780-dw-hdmi " H. Nikolaus Schaller 2021-09-28 2:01 ` [PATCH v4 03/10] dt-bindings: display: Add ingenic,jz4780-dw-hdmi " Rob Herring 2021-09-28 2:01 ` Rob Herring 2021-09-27 16:44 ` [PATCH v4 04/10] drm/bridge: synopsis: Add mode_fixup and bridge timings support H. Nikolaus Schaller 2021-09-27 16:44 ` [PATCH v4 05/10] drm/bridge: synopsis: Fix to properly handle HPD H. Nikolaus Schaller 2021-09-27 17:00 ` Maxime Ripard 2021-09-27 17:00 ` Maxime Ripard 2021-09-27 17:53 ` H. Nikolaus Schaller 2021-09-27 16:44 ` [PATCH v4 06/10] drm/ingenic: Add dw-hdmi driver for jz4780 H. Nikolaus Schaller 2021-09-27 17:08 ` Maxime Ripard 2021-09-27 17:08 ` Maxime Ripard 2021-09-27 17:54 ` H. Nikolaus Schaller 2021-09-28 13:02 ` Neil Armstrong 2021-09-28 13:35 ` H. Nikolaus Schaller 2021-09-28 14:10 ` Paul Cercueil 2021-09-27 16:44 ` [PATCH v4 07/10] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers H. Nikolaus Schaller 2021-09-27 16:44 ` [PATCH v4 08/10] MIPS: DTS: CI20: Add DT nodes for HDMI setup H. Nikolaus Schaller 2021-09-27 16:44 ` [PATCH v4 09/10] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780 H. Nikolaus Schaller 2021-09-27 16:44 ` [PATCH v4 10/10] drm/ingenic: add some jz4780 specific features H. Nikolaus Schaller 2021-09-28 9:58 ` Paul Cercueil 2021-09-28 10:06 ` H. Nikolaus Schaller 2021-09-28 11:50 ` H. Nikolaus Schaller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=C529DB99-709A-4C24-B647-3A2004CBFE18@goldelico.com \ --to=hns@goldelico.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=broonie@kernel.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=ebiederm@xmission.com \ --cc=ezequiel@collabora.com \ --cc=geert+renesas@glider.be \ --cc=harry.wentland@amd.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=keescook@chromium.org \ --cc=letux-kernel@openphoenux.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime@cerno.tech \ --cc=miquel.raynal@bootlin.com \ --cc=narmstrong@baylibre.com \ --cc=paul@boddie.org.uk \ --cc=paul@crapouillou.net \ --cc=robert.foss@linaro.org \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=sam@ravnborg.org \ --cc=tsbogend@alpha.franken.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.