All of lore.kernel.org
 help / color / mirror / Atom feed
* ip addr add command generates error
@ 2015-03-23 22:43 Rose, Gregory V
  2015-03-24  0:13 ` roopa
  0 siblings, 1 reply; 4+ messages in thread
From: Rose, Gregory V @ 2015-03-23 22:43 UTC (permalink / raw)
  To: stephen.hemminger, netdev, vadim4j, Brandeburg, Jesse

The 'ip addr add' command used to use the following syntax:

# ip addr add 10.0.0.2/24 brd 10.0.0.255 dev <eth>

However, attempts to use that same command syntax with the current iproute2 tip gives the following error:

Error: an inet prefix is expected rather than "20.0.0.2/24"

This seems like a bug.  The commit that introduces the issue is f3a2ddc124e09d3990b836e322ed39c76c35546e by Vadim Kochan.  Reverting this commit fixes the problem.

Is this change deliberate?  It would break a lot of scripts if so.

Thanks,

- Greg

----------
 
Any man who afflicts the human race with ideas must be prepared to see them misunderstood.
 
- H. L. Mencken

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ip addr add command generates error
  2015-03-23 22:43 ip addr add command generates error Rose, Gregory V
@ 2015-03-24  0:13 ` roopa
  2015-03-24  0:33   ` Rose, Gregory V
  2015-03-24  8:09   ` Vadim Kochan
  0 siblings, 2 replies; 4+ messages in thread
From: roopa @ 2015-03-24  0:13 UTC (permalink / raw)
  To: Rose, Gregory V; +Cc: stephen.hemminger, netdev, vadim4j, Brandeburg, Jesse

On 3/23/15, 3:43 PM, Rose, Gregory V wrote:
> The 'ip addr add' command used to use the following syntax:
>
> # ip addr add 10.0.0.2/24 brd 10.0.0.255 dev <eth>
>
> However, attempts to use that same command syntax with the current iproute2 tip gives the following error:
>
> Error: an inet prefix is expected rather than "20.0.0.2/24"
>
> This seems like a bug.  The commit that introduces the issue is f3a2ddc124e09d3990b836e322ed39c76c35546e by Vadim Kochan.  Reverting this commit fixes the problem.
>
> Is this change deliberate?  It would break a lot of scripts if so.
>

looked like an unintended change. This was reported a few days back and 
I hit this too in another context and a patch 
https://patchwork.ozlabs.org/patch/451210/ is in the queue.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: ip addr add command generates error
  2015-03-24  0:13 ` roopa
@ 2015-03-24  0:33   ` Rose, Gregory V
  2015-03-24  8:09   ` Vadim Kochan
  1 sibling, 0 replies; 4+ messages in thread
From: Rose, Gregory V @ 2015-03-24  0:33 UTC (permalink / raw)
  To: roopa; +Cc: stephen.hemminger, netdev, vadim4j, Brandeburg, Jesse


> -----Original Message-----
> From: roopa [mailto:roopa@cumulusnetworks.com]
> Sent: Monday, March 23, 2015 5:13 PM
> To: Rose, Gregory V
> Cc: stephen.hemminger@vyatta.com; netdev@vger.kernel.org;
> vadim4j@gmail.com; Brandeburg, Jesse
> Subject: Re: ip addr add command generates error
> 
> On 3/23/15, 3:43 PM, Rose, Gregory V wrote:
> > The 'ip addr add' command used to use the following syntax:
> >
> > # ip addr add 10.0.0.2/24 brd 10.0.0.255 dev <eth>
> >
> > However, attempts to use that same command syntax with the current
> iproute2 tip gives the following error:
> >
> > Error: an inet prefix is expected rather than "20.0.0.2/24"
> >
> > This seems like a bug.  The commit that introduces the issue is
> f3a2ddc124e09d3990b836e322ed39c76c35546e by Vadim Kochan.  Reverting this
> commit fixes the problem.
> >
> > Is this change deliberate?  It would break a lot of scripts if so.
> >
> 
> looked like an unintended change. This was reported a few days back and I
> hit this too in another context and a patch
> https://patchwork.ozlabs.org/patch/451210/ is in the queue.

Patch looks good.

Thanks!

- Greg

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ip addr add command generates error
  2015-03-24  0:13 ` roopa
  2015-03-24  0:33   ` Rose, Gregory V
@ 2015-03-24  8:09   ` Vadim Kochan
  1 sibling, 0 replies; 4+ messages in thread
From: Vadim Kochan @ 2015-03-24  8:09 UTC (permalink / raw)
  To: roopa
  Cc: Rose, Gregory V, stephen.hemminger, netdev, vadim4j, Brandeburg, Jesse

On Mon, Mar 23, 2015 at 05:13:14PM -0700, roopa wrote:
> On 3/23/15, 3:43 PM, Rose, Gregory V wrote:
> >The 'ip addr add' command used to use the following syntax:
> >
> ># ip addr add 10.0.0.2/24 brd 10.0.0.255 dev <eth>
> >
> >However, attempts to use that same command syntax with the current iproute2 tip gives the following error:
> >
> >Error: an inet prefix is expected rather than "20.0.0.2/24"
> >
> >This seems like a bug.  The commit that introduces the issue is f3a2ddc124e09d3990b836e322ed39c76c35546e by Vadim Kochan.  Reverting this commit fixes the problem.
> >
> >Is this change deliberate?  It would break a lot of scripts if so.
> >
> 
> looked like an unintended change. This was reported a few days back and I
> hit this too in another context and a patch
> https://patchwork.ozlabs.org/patch/451210/ is in the queue.

I apologize for this stupid mistake!

Regards,

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-03-24  8:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-23 22:43 ip addr add command generates error Rose, Gregory V
2015-03-24  0:13 ` roopa
2015-03-24  0:33   ` Rose, Gregory V
2015-03-24  8:09   ` Vadim Kochan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.