* [PATCH] drm: i915: Fix audio issue on BXT
@ 2018-01-03 19:18 Gaurav K Singh
2018-01-03 19:47 ` ✓ Fi.CI.BAT: success for " Patchwork
` (7 more replies)
0 siblings, 8 replies; 28+ messages in thread
From: Gaurav K Singh @ 2018-01-03 19:18 UTC (permalink / raw)
To: intel-gfx
From: Gaurav Singh <gaurav.k.singh@intel.com>
On Apollolake, with stress test warm reboot, audio card
was not getting enumerated after reboot. This was a
spurious issue happening on Apollolake. HW codec and
HD audio controller link was going out of sync for which
there was a fix in i915 driver but was not getting invoked
for BXT. Extending this fix to BXT as well.
Tested on apollolake chromebook by stress test warm reboot
with 2500 iterations.
Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index f1502a0188eb..c71c04e1c3f6 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
u32 tmp;
- if (!IS_GEN9_BC(dev_priv))
+ if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
return;
i915_audio_component_get_power(kdev);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 28+ messages in thread
* ✓ Fi.CI.BAT: success for drm: i915: Fix audio issue on BXT
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
@ 2018-01-03 19:47 ` Patchwork
2018-01-03 20:31 ` [PATCH] " Pandiyan, Dhinakaran
` (6 subsequent siblings)
7 siblings, 0 replies; 28+ messages in thread
From: Patchwork @ 2018-01-03 19:47 UTC (permalink / raw)
To: Gaurav K Singh; +Cc: intel-gfx
== Series Details ==
Series: drm: i915: Fix audio issue on BXT
URL : https://patchwork.freedesktop.org/series/35955/
State : success
== Summary ==
Series 35955v1 drm: i915: Fix audio issue on BXT
https://patchwork.freedesktop.org/api/1.0/series/35955/revisions/1/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989
Test gem_exec_reloc:
Subgroup basic-write-cpu:
incomplete -> PASS (fi-byt-j1900)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-kbl-r) fdo#104172
Test kms_psr_sink_crc:
Subgroup psr_basic:
pass -> DMESG-WARN (fi-skl-6700hq) fdo#101144
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:434s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:380s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:499s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:278s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:494s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:493s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:478s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:464s
fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:520s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:403s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:413s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:425s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:470s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:425s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:482s
fi-kbl-7560u total:288 pass:268 dwarn:1 dfail:0 fail:0 skip:19 time:511s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:467s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:513s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:445s
fi-skl-6600u total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:524s
fi-skl-6700hq total:288 pass:261 dwarn:1 dfail:0 fail:0 skip:26 time:539s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:501s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:490s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:445s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:542s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:412s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:571s
fi-glk-dsi total:63 pass:55 dwarn:0 dfail:0 fail:0 skip:7
fi-bdw-gvtdvm failed to collect. IGT log at Patchwork_7599/fi-bdw-gvtdvm/igt.log
fi-pnv-d510 failed to collect. IGT log at Patchwork_7599/fi-pnv-d510/igt.log
d26e7804b83cf7d3754323d02afa5ff04326d33d drm-tip: 2018y-01m-03d-17h-48m-30s UTC integration manifest
0e0a40f84c3d drm: i915: Fix audio issue on BXT
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7599/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
2018-01-03 19:47 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-01-03 20:31 ` Pandiyan, Dhinakaran
2018-01-03 21:18 ` Rodrigo Vivi
2018-01-03 21:19 ` ✓ Fi.CI.IGT: success for " Patchwork
` (5 subsequent siblings)
7 siblings, 1 reply; 28+ messages in thread
From: Pandiyan, Dhinakaran @ 2018-01-03 20:31 UTC (permalink / raw)
To: Singh, Gaurav K; +Cc: intel-gfx, subransu.s.prusty
On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
> From: Gaurav Singh <gaurav.k.singh@intel.com>
>
> On Apollolake, with stress test warm reboot, audio card
> was not getting enumerated after reboot. This was a
The problem looks similar to
https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html
although the proposed solutions are vastly different. I have Cc'd some
more people.
> spurious issue happening on Apollolake. HW codec and
> HD audio controller link was going out of sync for which
> there was a fix in i915 driver but was not getting invoked
> for BXT. Extending this fix to BXT as well.
>
> Tested on apollolake chromebook by stress test warm reboot
> with 2500 iterations.
>
> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index f1502a0188eb..c71c04e1c3f6 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> u32 tmp;
>
> - if (!IS_GEN9_BC(dev_priv))
> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
IS_GEN9()? GLK might need this too.
> return;
>
> i915_audio_component_get_power(kdev);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-01-03 20:31 ` [PATCH] " Pandiyan, Dhinakaran
@ 2018-01-03 21:18 ` Rodrigo Vivi
[not found] ` <FF3DDC77922A8A4BB08A3BC48A1EA8CB8DA78F44@BGSMSX101.gar.corp.intel.com>
2018-01-04 16:43 ` Singh, Gaurav K
0 siblings, 2 replies; 28+ messages in thread
From: Rodrigo Vivi @ 2018-01-03 21:18 UTC (permalink / raw)
To: Pandiyan, Dhinakaran; +Cc: intel-gfx, subransu.s.prusty
On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran wrote:
>
> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
> > From: Gaurav Singh <gaurav.k.singh@intel.com>
> >
> > On Apollolake, with stress test warm reboot, audio card
> > was not getting enumerated after reboot. This was a
>
> The problem looks similar to
> https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html
>
> although the proposed solutions are vastly different. I have Cc'd some
> more people.
>
> > spurious issue happening on Apollolake. HW codec and
> > HD audio controller link was going out of sync for which
> > there was a fix in i915 driver but was not getting invoked
> > for BXT. Extending this fix to BXT as well.
> >
> > Tested on apollolake chromebook by stress test warm reboot
> > with 2500 iterations.
> >
> > Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_audio.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> > index f1502a0188eb..c71c04e1c3f6 100644
> > --- a/drivers/gpu/drm/i915/intel_audio.c
> > +++ b/drivers/gpu/drm/i915/intel_audio.c
> > @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> > struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> > u32 tmp;
> >
> > - if (!IS_GEN9_BC(dev_priv))
> > + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>
> IS_GEN9()? GLK might need this too.
if GLK need there is the possibility of CNL also needing it...
So not sure where to stop.
Also looking to the original patch that introduced this function,
commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override
enabled/disable callback")'
it tells that the reason was:
"In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$
wells, so it's necessary to reset display audio codecs when power we$
otherwise display audio codecs will disappear when resume from low p$
state."
Is this the case here on BXT?
Another interesting thing I noticed on Spec when searching for this bit
was that this bit is related to an workaround on SKL/KBL/CFL... no mention
to BXT.
"This workaround is needed for an HW issue in SKL and KBL in which HW codec
and HD audio controller link was going out of sync."
Thanks,
Rodrigo.
>
>
> > return;
> >
> > i915_audio_component_get_power(kdev);
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* ✓ Fi.CI.IGT: success for drm: i915: Fix audio issue on BXT
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
2018-01-03 19:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-03 20:31 ` [PATCH] " Pandiyan, Dhinakaran
@ 2018-01-03 21:19 ` Patchwork
2018-03-05 18:21 ` [PATCH] " Pandiyan, Dhinakaran
` (4 subsequent siblings)
7 siblings, 0 replies; 28+ messages in thread
From: Patchwork @ 2018-01-03 21:19 UTC (permalink / raw)
To: Gaurav K Singh; +Cc: intel-gfx
== Series Details ==
Series: drm: i915: Fix audio issue on BXT
URL : https://patchwork.freedesktop.org/series/35955/
State : success
== Summary ==
Warning: bzip CI_DRM_3595/shard-glkb2/results3.json.bz2 wasn't in correct JSON format
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
pass -> FAIL (shard-snb) fdo#101623 +1
Test gem_softpin:
Subgroup noreloc-s4:
skip -> FAIL (shard-snb) fdo#103375 +1
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
shard-hsw total:2713 pass:1538 dwarn:1 dfail:0 fail:10 skip:1164 time:9386s
shard-snb total:2713 pass:1309 dwarn:1 dfail:0 fail:12 skip:1391 time:8067s
Blacklisted hosts:
shard-apl total:2713 pass:1687 dwarn:1 dfail:0 fail:24 skip:1001 time:13759s
shard-kbl total:2712 pass:1798 dwarn:9 dfail:1 fail:26 skip:877 time:10676s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7599/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: FW: [PATCH] drm: i915: Fix audio issue on BXT
[not found] ` <FF3DDC77922A8A4BB08A3BC48A1EA8CB8DA78F44@BGSMSX101.gar.corp.intel.com>
@ 2018-01-04 6:23 ` Sharma, Shashank
0 siblings, 0 replies; 28+ messages in thread
From: Sharma, Shashank @ 2018-01-04 6:23 UTC (permalink / raw)
To: Vivi, Rodrigo, Pandiyan, Dhinakaran, gaurav.k.singh,
Intel Graphics Development
Regards
Shashank
On 1/4/2018 11:40 AM, Sharma, Shashank wrote:
> On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran wrote:
>> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
>>> From: Gaurav Singh <gaurav.k.singh@intel.com>
>>>
>>> On Apollolake, with stress test warm reboot, audio card was not
>>> getting enumerated after reboot. This was a
>> The problem looks similar to
>> https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.h
>> tml
>>
>> although the proposed solutions are vastly different. I have Cc'd some
>> more people.
>>
>>> spurious issue happening on Apollolake. HW codec and HD audio
>>> controller link was going out of sync for which there was a fix in
>>> i915 driver but was not getting invoked for BXT. Extending this fix
>>> to BXT as well.
>>>
>>> Tested on apollolake chromebook by stress test warm reboot with 2500
>>> iterations.
>>>
>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
>>> b/drivers/gpu/drm/i915/intel_audio.c
>>> index f1502a0188eb..c71c04e1c3f6 100644
>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>> u32 tmp;
>>>
>>> - if (!IS_GEN9_BC(dev_priv))
>>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>> IS_GEN9()? GLK might need this too.
> if GLK need there is the possibility of CNL also needing it...
> So not sure where to stop.
>
> Also looking to the original patch that introduced this function, commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override enabled/disable callback")'
>
> it tells that the reason was:
> "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$ wells, so it's necessary to reset display audio codecs when power we$ otherwise display audio codecs will disappear when resume from low p$ state."
>
> Is this the case here on BXT?
I think this is valid for all GEN9 displays, because HW codec's power
control is with display engine only.
The scenario which this patch is going to cover is a possible race
during boot-up:
- display probe happens, first (or second) display modeset is in progress.
- meanwhile audio probe happens in parallel, audio driver is trying to
probe HDMI audio codec.
- codec's power well is under display's control, and there is a chance
that while modeset, display would have disabled power wells during
disable sequence, so the codec can't be probed.
- now audio driver needs a way, to enable power using I915 driver, so
that it can probe and enable codec
IIRC component framework was added to solve this problem only, so this
situation is valid for any platform where HD audio codec depends on
display power well, so I guess this should go for GLK too.
Acked-by: Shashank Sharma <shashank.sharma@intel.com>
- Shashank
> Another interesting thing I noticed on Spec when searching for this bit was that this bit is related to an workaround on SKL/KBL/CFL... no mention to BXT.
>
> "This workaround is needed for an HW issue in SKL and KBL in which HW codec and HD audio controller link was going out of sync."
>
> Thanks,
> Rodrigo.
>
>>
>>> return;
>>>
>>> i915_audio_component_get_power(kdev);
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-01-03 21:18 ` Rodrigo Vivi
[not found] ` <FF3DDC77922A8A4BB08A3BC48A1EA8CB8DA78F44@BGSMSX101.gar.corp.intel.com>
@ 2018-01-04 16:43 ` Singh, Gaurav K
2018-01-04 21:59 ` Pandiyan, Dhinakaran
1 sibling, 1 reply; 28+ messages in thread
From: Singh, Gaurav K @ 2018-01-04 16:43 UTC (permalink / raw)
To: Rodrigo Vivi, Pandiyan, Dhinakaran; +Cc: intel-gfx, subransu.s.prusty
On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
> On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran wrote:
>> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
>>> From: Gaurav Singh <gaurav.k.singh@intel.com>
>>>
>>> On Apollolake, with stress test warm reboot, audio card
>>> was not getting enumerated after reboot. This was a
>> The problem looks similar to
>> https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html
>>
>> although the proposed solutions are vastly different. I have Cc'd some
>> more people.
>>
>>> spurious issue happening on Apollolake. HW codec and
>>> HD audio controller link was going out of sync for which
>>> there was a fix in i915 driver but was not getting invoked
>>> for BXT. Extending this fix to BXT as well.
>>>
>>> Tested on apollolake chromebook by stress test warm reboot
>>> with 2500 iterations.
>>>
>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>>> index f1502a0188eb..c71c04e1c3f6 100644
>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>> u32 tmp;
>>>
>>> - if (!IS_GEN9_BC(dev_priv))
>>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>> IS_GEN9()? GLK might need this too.
> I think this is applicable for all Gen9 platforms.
> if GLK need there is the possibility of CNL also needing it...
> So not sure where to stop.
>
> Also looking to the original patch that introduced this function,
> commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override
> enabled/disable callback")'
>
> it tells that the reason was:
> "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$
> wells, so it's necessary to reset display audio codecs when power we$
> otherwise display audio codecs will disappear when resume from low p$
> state."
>
> Is this the case here on BXT?
Yes, its the same case with BXT.
>
> Another interesting thing I noticed on Spec when searching for this bit
> was that this bit is related to an workaround on SKL/KBL/CFL... no mention
> to BXT.
>
> "This workaround is needed for an HW issue in SKL and KBL in which HW codec
> and HD audio controller link was going out of sync."
Yes, in Bspec it has been mentioned only for SKL and KBL. But without
this fix, sound card was not getting enumerated for BXT.
>
> Thanks,
> Rodrigo.
>
>>
>>> return;
>>>
>>> i915_audio_component_get_power(kdev);
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-01-04 16:43 ` Singh, Gaurav K
@ 2018-01-04 21:59 ` Pandiyan, Dhinakaran
2018-01-09 19:54 ` Runyan, Arthur J
0 siblings, 1 reply; 28+ messages in thread
From: Pandiyan, Dhinakaran @ 2018-01-04 21:59 UTC (permalink / raw)
To: Singh, Gaurav K
Cc: Runyan, Arthur J, intel-gfx, subransu.s.prusty, Vivi, Rodrigo
+Art
On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote:
>
> On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
> > On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran wrote:
> >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
> >>> From: Gaurav Singh <gaurav.k.singh@intel.com>
> >>>
> >>> On Apollolake, with stress test warm reboot, audio card
> >>> was not getting enumerated after reboot. This was a
> >> The problem looks similar to
> >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html
> >>
> >> although the proposed solutions are vastly different. I have Cc'd some
> >> more people.
> >>
> >>> spurious issue happening on Apollolake. HW codec and
> >>> HD audio controller link was going out of sync for which
> >>> there was a fix in i915 driver but was not getting invoked
> >>> for BXT. Extending this fix to BXT as well.
> >>>
> >>> Tested on apollolake chromebook by stress test warm reboot
> >>> with 2500 iterations.
> >>>
> >>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> >>> ---
> >>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> >>> index f1502a0188eb..c71c04e1c3f6 100644
> >>> --- a/drivers/gpu/drm/i915/intel_audio.c
> >>> +++ b/drivers/gpu/drm/i915/intel_audio.c
> >>> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> >>> u32 tmp;
> >>>
> >>> - if (!IS_GEN9_BC(dev_priv))
> >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> >> IS_GEN9()? GLK might need this too.
> > I think this is applicable for all Gen9 platforms.
>
> > if GLK need there is the possibility of CNL also needing it...
> > So not sure where to stop.
> >
> > Also looking to the original patch that introduced this function,
> > commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override
> > enabled/disable callback")'
> >
> > it tells that the reason was:
> > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$
> > wells, so it's necessary to reset display audio codecs when power we$
> > otherwise display audio codecs will disappear when resume from low p$
> > state."
> >
> > Is this the case here on BXT?
> Yes, its the same case with BXT.
> >
> > Another interesting thing I noticed on Spec when searching for this bit
> > was that this bit is related to an workaround on SKL/KBL/CFL... no mention
> > to BXT.
> >
> > "This workaround is needed for an HW issue in SKL and KBL in which HW codec
> > and HD audio controller link was going out of sync."
> Yes, in Bspec it has been mentioned only for SKL and KBL. But without
> this fix, sound card was not getting enumerated for BXT.
Art,
Can you please help us here? To summarize, the question is what
platforms need the AUD_CHICKENBIT_REG:15 bit to be set to avoid code
enumeration failures?
-DK
> >
> > Thanks,
> > Rodrigo.
> >
> >>
> >>> return;
> >>>
> >>> i915_audio_component_get_power(kdev);
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-01-04 21:59 ` Pandiyan, Dhinakaran
@ 2018-01-09 19:54 ` Runyan, Arthur J
2018-02-27 2:03 ` Pandiyan, Dhinakaran
0 siblings, 1 reply; 28+ messages in thread
From: Runyan, Arthur J @ 2018-01-09 19:54 UTC (permalink / raw)
To: Pandiyan, Dhinakaran, Singh, Gaurav K; +Cc: intel-gfx, Vivi, Rodrigo
Sorry, I've been out. I'm checking on this.
-----Original Message-----
From: Pandiyan, Dhinakaran
Sent: Thursday, 4 January, 2018 2:00 PM
To: Singh, Gaurav K <gaurav.k.singh@intel.com>
Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>; subransu.s.prusty@intel.com; Runyan, Arthur J <arthur.j.runyan@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
+Art
On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote:
>
> On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
> > On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran wrote:
> >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
> >>> From: Gaurav Singh <gaurav.k.singh@intel.com>
> >>>
> >>> On Apollolake, with stress test warm reboot, audio card
> >>> was not getting enumerated after reboot. This was a
> >> The problem looks similar to
> >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html
> >>
> >> although the proposed solutions are vastly different. I have Cc'd some
> >> more people.
> >>
> >>> spurious issue happening on Apollolake. HW codec and
> >>> HD audio controller link was going out of sync for which
> >>> there was a fix in i915 driver but was not getting invoked
> >>> for BXT. Extending this fix to BXT as well.
> >>>
> >>> Tested on apollolake chromebook by stress test warm reboot
> >>> with 2500 iterations.
> >>>
> >>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> >>> ---
> >>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> >>> index f1502a0188eb..c71c04e1c3f6 100644
> >>> --- a/drivers/gpu/drm/i915/intel_audio.c
> >>> +++ b/drivers/gpu/drm/i915/intel_audio.c
> >>> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> >>> u32 tmp;
> >>>
> >>> - if (!IS_GEN9_BC(dev_priv))
> >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> >> IS_GEN9()? GLK might need this too.
> > I think this is applicable for all Gen9 platforms.
>
> > if GLK need there is the possibility of CNL also needing it...
> > So not sure where to stop.
> >
> > Also looking to the original patch that introduced this function,
> > commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override
> > enabled/disable callback")'
> >
> > it tells that the reason was:
> > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$
> > wells, so it's necessary to reset display audio codecs when power we$
> > otherwise display audio codecs will disappear when resume from low p$
> > state."
> >
> > Is this the case here on BXT?
> Yes, its the same case with BXT.
> >
> > Another interesting thing I noticed on Spec when searching for this bit
> > was that this bit is related to an workaround on SKL/KBL/CFL... no mention
> > to BXT.
> >
> > "This workaround is needed for an HW issue in SKL and KBL in which HW codec
> > and HD audio controller link was going out of sync."
> Yes, in Bspec it has been mentioned only for SKL and KBL. But without
> this fix, sound card was not getting enumerated for BXT.
Art,
Can you please help us here? To summarize, the question is what
platforms need the AUD_CHICKENBIT_REG:15 bit to be set to avoid code
enumeration failures?
-DK
> >
> > Thanks,
> > Rodrigo.
> >
> >>
> >>> return;
> >>>
> >>> i915_audio_component_get_power(kdev);
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-01-09 19:54 ` Runyan, Arthur J
@ 2018-02-27 2:03 ` Pandiyan, Dhinakaran
2018-02-27 16:48 ` Runyan, Arthur J
0 siblings, 1 reply; 28+ messages in thread
From: Pandiyan, Dhinakaran @ 2018-02-27 2:03 UTC (permalink / raw)
To: Runyan, Arthur J, Singh, Gaurav K; +Cc: Nikula, Jani, intel-gfx, Vivi, Rodrigo
> -----Original Message-----
> From: Runyan, Arthur J
> Sent: Tuesday, January 9, 2018 11:55 AM
> To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh, Gaurav K
> <gaurav.k.singh@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>
> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>
> Sorry, I've been out. I'm checking on this.
Hi Art,
Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration issues?
-DK
>
> -----Original Message-----
> From: Pandiyan, Dhinakaran
> Sent: Thursday, 4 January, 2018 2:00 PM
> To: Singh, Gaurav K <gaurav.k.singh@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> subransu.s.prusty@intel.com; Runyan, Arthur J <arthur.j.runyan@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>
> +Art
>
> On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote:
> >
> > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
> > > On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran wrote:
> > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
> > >>> From: Gaurav Singh <gaurav.k.singh@intel.com>
> > >>>
> > >>> On Apollolake, with stress test warm reboot, audio card was not
> > >>> getting enumerated after reboot. This was a
> > >> The problem looks similar to
> > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/14449
> > >> 5.html
> > >>
> > >> although the proposed solutions are vastly different. I have Cc'd
> > >> some more people.
> > >>
> > >>> spurious issue happening on Apollolake. HW codec and HD audio
> > >>> controller link was going out of sync for which there was a fix in
> > >>> i915 driver but was not getting invoked for BXT. Extending this
> > >>> fix to BXT as well.
> > >>>
> > >>> Tested on apollolake chromebook by stress test warm reboot with
> > >>> 2500 iterations.
> > >>>
> > >>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> > >>> ---
> > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> > >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
> > >>> b/drivers/gpu/drm/i915/intel_audio.c
> > >>> index f1502a0188eb..c71c04e1c3f6 100644
> > >>> --- a/drivers/gpu/drm/i915/intel_audio.c
> > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c
> > >>> @@ -729,7 +729,7 @@ static void
> i915_audio_component_codec_wake_override(struct device *kdev,
> > >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> > >>> u32 tmp;
> > >>>
> > >>> - if (!IS_GEN9_BC(dev_priv))
> > >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> > >> IS_GEN9()? GLK might need this too.
> > > I think this is applicable for all Gen9 platforms.
> >
> > > if GLK need there is the possibility of CNL also needing it...
> > > So not sure where to stop.
> > >
> > > Also looking to the original patch that introduced this function,
> > > commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override
> > > enabled/disable callback")'
> > >
> > > it tells that the reason was:
> > > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different
> > > p$ wells, so it's necessary to reset display audio codecs when power
> > > we$ otherwise display audio codecs will disappear when resume from
> > > low p$ state."
> > >
> > > Is this the case here on BXT?
> > Yes, its the same case with BXT.
> > >
> > > Another interesting thing I noticed on Spec when searching for this
> > > bit was that this bit is related to an workaround on SKL/KBL/CFL...
> > > no mention to BXT.
> > >
> > > "This workaround is needed for an HW issue in SKL and KBL in which
> > > HW codec and HD audio controller link was going out of sync."
> > Yes, in Bspec it has been mentioned only for SKL and KBL. But without
> > this fix, sound card was not getting enumerated for BXT.
>
>
> Art,
>
> Can you please help us here? To summarize, the question is what platforms need
> the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration failures?
>
> -DK
>
> > >
> > > Thanks,
> > > Rodrigo.
> > >
> > >>
> > >>> return;
> > >>>
> > >>> i915_audio_component_get_power(kdev);
> > >> _______________________________________________
> > >> Intel-gfx mailing list
> > >> Intel-gfx@lists.freedesktop.org
> > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-02-27 2:03 ` Pandiyan, Dhinakaran
@ 2018-02-27 16:48 ` Runyan, Arthur J
2018-02-27 16:52 ` Mullah, Abid A
0 siblings, 1 reply; 28+ messages in thread
From: Runyan, Arthur J @ 2018-02-27 16:48 UTC (permalink / raw)
To: Pandiyan, Dhinakaran, Singh, Gaurav K, Mullah, Abid A,
Neelagandan, Harigaran
Cc: Nikula, Jani, intel-gfx, Vivi, Rodrigo
Abid or Hari, please check. There was a workaround to set AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL and KBL. Does it apply to BXT also?
> -----Original Message-----
> From: Pandiyan, Dhinakaran
> Sent: Monday, 26 February, 2018 6:04 PM
> To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Singh, Gaurav K
> <gaurav.k.singh@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> Nikula, Jani <jani.nikula@intel.com>
> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>
>
> > -----Original Message-----
> > From: Runyan, Arthur J
> > Sent: Tuesday, January 9, 2018 11:55 AM
> > To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh,
> Gaurav K
> > <gaurav.k.singh@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
> >
> > Sorry, I've been out. I'm checking on this.
>
>
> Hi Art,
>
> Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration issues?
>
> -DK
>
> >
> > -----Original Message-----
> > From: Pandiyan, Dhinakaran
> > Sent: Thursday, 4 January, 2018 2:00 PM
> > To: Singh, Gaurav K <gaurav.k.singh@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> > subransu.s.prusty@intel.com; Runyan, Arthur J
> <arthur.j.runyan@intel.com>
> > Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
> >
> > +Art
> >
> > On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote:
> > >
> > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
> > > > On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran
> wrote:
> > > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
> > > >>> From: Gaurav Singh <gaurav.k.singh@intel.com>
> > > >>>
> > > >>> On Apollolake, with stress test warm reboot, audio card was not
> > > >>> getting enumerated after reboot. This was a
> > > >> The problem looks similar to
> > > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/14449
> > > >> 5.html
> > > >>
> > > >> although the proposed solutions are vastly different. I have Cc'd
> > > >> some more people.
> > > >>
> > > >>> spurious issue happening on Apollolake. HW codec and HD audio
> > > >>> controller link was going out of sync for which there was a fix in
> > > >>> i915 driver but was not getting invoked for BXT. Extending this
> > > >>> fix to BXT as well.
> > > >>>
> > > >>> Tested on apollolake chromebook by stress test warm reboot with
> > > >>> 2500 iterations.
> > > >>>
> > > >>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> > > >>> ---
> > > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> > > >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>>
> > > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
> > > >>> b/drivers/gpu/drm/i915/intel_audio.c
> > > >>> index f1502a0188eb..c71c04e1c3f6 100644
> > > >>> --- a/drivers/gpu/drm/i915/intel_audio.c
> > > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c
> > > >>> @@ -729,7 +729,7 @@ static void
> > i915_audio_component_codec_wake_override(struct device *kdev,
> > > >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> > > >>> u32 tmp;
> > > >>>
> > > >>> - if (!IS_GEN9_BC(dev_priv))
> > > >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> > > >> IS_GEN9()? GLK might need this too.
> > > > I think this is applicable for all Gen9 platforms.
> > >
> > > > if GLK need there is the possibility of CNL also needing it...
> > > > So not sure where to stop.
> > > >
> > > > Also looking to the original patch that introduced this function,
> > > > commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override
> > > > enabled/disable callback")'
> > > >
> > > > it tells that the reason was:
> > > > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different
> > > > p$ wells, so it's necessary to reset display audio codecs when power
> > > > we$ otherwise display audio codecs will disappear when resume from
> > > > low p$ state."
> > > >
> > > > Is this the case here on BXT?
> > > Yes, its the same case with BXT.
> > > >
> > > > Another interesting thing I noticed on Spec when searching for this
> > > > bit was that this bit is related to an workaround on SKL/KBL/CFL...
> > > > no mention to BXT.
> > > >
> > > > "This workaround is needed for an HW issue in SKL and KBL in which
> > > > HW codec and HD audio controller link was going out of sync."
> > > Yes, in Bspec it has been mentioned only for SKL and KBL. But without
> > > this fix, sound card was not getting enumerated for BXT.
> >
> >
> > Art,
> >
> > Can you please help us here? To summarize, the question is what platforms
> need
> > the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration
> failures?
> >
> > -DK
> >
> > > >
> > > > Thanks,
> > > > Rodrigo.
> > > >
> > > >>
> > > >>> return;
> > > >>>
> > > >>> i915_audio_component_get_power(kdev);
> > > >> _______________________________________________
> > > >> Intel-gfx mailing list
> > > >> Intel-gfx@lists.freedesktop.org
> > > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-02-27 16:48 ` Runyan, Arthur J
@ 2018-02-27 16:52 ` Mullah, Abid A
2018-02-27 17:30 ` Runyan, Arthur J
0 siblings, 1 reply; 28+ messages in thread
From: Mullah, Abid A @ 2018-02-27 16:52 UTC (permalink / raw)
To: Runyan, Arthur J, Pandiyan, Dhinakaran, Singh, Gaurav K,
Neelagandan, Harigaran
Cc: Nikula, Jani, intel-gfx, Vivi, Rodrigo
Yes. It will be needed for BXT also.
-----Original Message-----
From: Runyan, Arthur J
Sent: Tuesday, February 27, 2018 8:49 AM
To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh, Gaurav K <gaurav.k.singh@intel.com>; Mullah, Abid A <abid.a.mullah@intel.com>; Neelagandan, Harigaran <harigaran.neelagandan@intel.com>
Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>; Nikula, Jani <jani.nikula@intel.com>
Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
Abid or Hari, please check. There was a workaround to set AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL and KBL. Does it apply to BXT also?
> -----Original Message-----
> From: Pandiyan, Dhinakaran
> Sent: Monday, 26 February, 2018 6:04 PM
> To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Singh, Gaurav K
> <gaurav.k.singh@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
> <rodrigo.vivi@intel.com>; Nikula, Jani <jani.nikula@intel.com>
> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>
>
> > -----Original Message-----
> > From: Runyan, Arthur J
> > Sent: Tuesday, January 9, 2018 11:55 AM
> > To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh,
> Gaurav K
> > <gaurav.k.singh@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
> > <rodrigo.vivi@intel.com>
> > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
> >
> > Sorry, I've been out. I'm checking on this.
>
>
> Hi Art,
>
> Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration issues?
>
> -DK
>
> >
> > -----Original Message-----
> > From: Pandiyan, Dhinakaran
> > Sent: Thursday, 4 January, 2018 2:00 PM
> > To: Singh, Gaurav K <gaurav.k.singh@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
> > <rodrigo.vivi@intel.com>; subransu.s.prusty@intel.com; Runyan,
> > Arthur J
> <arthur.j.runyan@intel.com>
> > Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
> >
> > +Art
> >
> > On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote:
> > >
> > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
> > > > On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran
> wrote:
> > > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
> > > >>> From: Gaurav Singh <gaurav.k.singh@intel.com>
> > > >>>
> > > >>> On Apollolake, with stress test warm reboot, audio card was
> > > >>> not getting enumerated after reboot. This was a
> > > >> The problem looks similar to
> > > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/1
> > > >> 4449
> > > >> 5.html
> > > >>
> > > >> although the proposed solutions are vastly different. I have
> > > >> Cc'd some more people.
> > > >>
> > > >>> spurious issue happening on Apollolake. HW codec and HD audio
> > > >>> controller link was going out of sync for which there was a
> > > >>> fix in
> > > >>> i915 driver but was not getting invoked for BXT. Extending
> > > >>> this fix to BXT as well.
> > > >>>
> > > >>> Tested on apollolake chromebook by stress test warm reboot
> > > >>> with
> > > >>> 2500 iterations.
> > > >>>
> > > >>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> > > >>> ---
> > > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> > > >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>>
> > > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
> > > >>> b/drivers/gpu/drm/i915/intel_audio.c
> > > >>> index f1502a0188eb..c71c04e1c3f6 100644
> > > >>> --- a/drivers/gpu/drm/i915/intel_audio.c
> > > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c
> > > >>> @@ -729,7 +729,7 @@ static void
> > i915_audio_component_codec_wake_override(struct device *kdev,
> > > >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> > > >>> u32 tmp;
> > > >>>
> > > >>> - if (!IS_GEN9_BC(dev_priv))
> > > >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> > > >> IS_GEN9()? GLK might need this too.
> > > > I think this is applicable for all Gen9 platforms.
> > >
> > > > if GLK need there is the possibility of CNL also needing it...
> > > > So not sure where to stop.
> > > >
> > > > Also looking to the original patch that introduced this
> > > > function, commit '632f3ab95fe2 ("drm/i915/audio: add codec
> > > > wakeup override enabled/disable callback")'
> > > >
> > > > it tells that the reason was:
> > > > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in
> > > > different p$ wells, so it's necessary to reset display audio
> > > > codecs when power we$ otherwise display audio codecs will
> > > > disappear when resume from low p$ state."
> > > >
> > > > Is this the case here on BXT?
> > > Yes, its the same case with BXT.
> > > >
> > > > Another interesting thing I noticed on Spec when searching for
> > > > this bit was that this bit is related to an workaround on SKL/KBL/CFL...
> > > > no mention to BXT.
> > > >
> > > > "This workaround is needed for an HW issue in SKL and KBL in
> > > > which HW codec and HD audio controller link was going out of sync."
> > > Yes, in Bspec it has been mentioned only for SKL and KBL. But
> > > without this fix, sound card was not getting enumerated for BXT.
> >
> >
> > Art,
> >
> > Can you please help us here? To summarize, the question is what
> > platforms
> need
> > the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration
> failures?
> >
> > -DK
> >
> > > >
> > > > Thanks,
> > > > Rodrigo.
> > > >
> > > >>
> > > >>> return;
> > > >>>
> > > >>> i915_audio_component_get_power(kdev);
> > > >> _______________________________________________
> > > >> Intel-gfx mailing list
> > > >> Intel-gfx@lists.freedesktop.org
> > > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-02-27 16:52 ` Mullah, Abid A
@ 2018-02-27 17:30 ` Runyan, Arthur J
2018-03-05 6:09 ` Singh, Gaurav K
0 siblings, 1 reply; 28+ messages in thread
From: Runyan, Arthur J @ 2018-02-27 17:30 UTC (permalink / raw)
To: Mullah, Abid A, Pandiyan, Dhinakaran, Singh, Gaurav K,
Neelagandan, Harigaran
Cc: Nikula, Jani, intel-gfx, Vivi, Rodrigo
Ok, please update the workaround page to show all the impacted projects
https://gfxspecs.intel.com/Predator/Home/Index/21829
> -----Original Message-----
> From: Mullah, Abid A
> Sent: Tuesday, 27 February, 2018 8:52 AM
> To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Pandiyan, Dhinakaran
> <dhinakaran.pandiyan@intel.com>; Singh, Gaurav K
> <gaurav.k.singh@intel.com>; Neelagandan, Harigaran
> <harigaran.neelagandan@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> Nikula, Jani <jani.nikula@intel.com>
> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>
> Yes. It will be needed for BXT also.
>
> -----Original Message-----
> From: Runyan, Arthur J
> Sent: Tuesday, February 27, 2018 8:49 AM
> To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh, Gaurav
> K <gaurav.k.singh@intel.com>; Mullah, Abid A <abid.a.mullah@intel.com>;
> Neelagandan, Harigaran <harigaran.neelagandan@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> Nikula, Jani <jani.nikula@intel.com>
> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>
> Abid or Hari, please check. There was a workaround to set
> AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL
> and KBL. Does it apply to BXT also?
>
> > -----Original Message-----
> > From: Pandiyan, Dhinakaran
> > Sent: Monday, 26 February, 2018 6:04 PM
> > To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Singh, Gaurav K
> > <gaurav.k.singh@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
> > <rodrigo.vivi@intel.com>; Nikula, Jani <jani.nikula@intel.com>
> > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
> >
> >
> > > -----Original Message-----
> > > From: Runyan, Arthur J
> > > Sent: Tuesday, January 9, 2018 11:55 AM
> > > To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh,
> > Gaurav K
> > > <gaurav.k.singh@intel.com>
> > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
> > > <rodrigo.vivi@intel.com>
> > > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
> > >
> > > Sorry, I've been out. I'm checking on this.
> >
> >
> > Hi Art,
> >
> > Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration
> issues?
> >
> > -DK
> >
> > >
> > > -----Original Message-----
> > > From: Pandiyan, Dhinakaran
> > > Sent: Thursday, 4 January, 2018 2:00 PM
> > > To: Singh, Gaurav K <gaurav.k.singh@intel.com>
> > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
> > > <rodrigo.vivi@intel.com>; subransu.s.prusty@intel.com; Runyan,
> > > Arthur J
> > <arthur.j.runyan@intel.com>
> > > Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
> > >
> > > +Art
> > >
> > > On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote:
> > > >
> > > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
> > > > > On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran
> > wrote:
> > > > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
> > > > >>> From: Gaurav Singh <gaurav.k.singh@intel.com>
> > > > >>>
> > > > >>> On Apollolake, with stress test warm reboot, audio card was
> > > > >>> not getting enumerated after reboot. This was a
> > > > >> The problem looks similar to
> > > > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/1
> > > > >> 4449
> > > > >> 5.html
> > > > >>
> > > > >> although the proposed solutions are vastly different. I have
> > > > >> Cc'd some more people.
> > > > >>
> > > > >>> spurious issue happening on Apollolake. HW codec and HD audio
> > > > >>> controller link was going out of sync for which there was a
> > > > >>> fix in
> > > > >>> i915 driver but was not getting invoked for BXT. Extending
> > > > >>> this fix to BXT as well.
> > > > >>>
> > > > >>> Tested on apollolake chromebook by stress test warm reboot
> > > > >>> with
> > > > >>> 2500 iterations.
> > > > >>>
> > > > >>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> > > > >>> ---
> > > > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> > > > >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >>>
> > > > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
> > > > >>> b/drivers/gpu/drm/i915/intel_audio.c
> > > > >>> index f1502a0188eb..c71c04e1c3f6 100644
> > > > >>> --- a/drivers/gpu/drm/i915/intel_audio.c
> > > > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c
> > > > >>> @@ -729,7 +729,7 @@ static void
> > > i915_audio_component_codec_wake_override(struct device *kdev,
> > > > >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> > > > >>> u32 tmp;
> > > > >>>
> > > > >>> - if (!IS_GEN9_BC(dev_priv))
> > > > >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> > > > >> IS_GEN9()? GLK might need this too.
> > > > > I think this is applicable for all Gen9 platforms.
> > > >
> > > > > if GLK need there is the possibility of CNL also needing it...
> > > > > So not sure where to stop.
> > > > >
> > > > > Also looking to the original patch that introduced this
> > > > > function, commit '632f3ab95fe2 ("drm/i915/audio: add codec
> > > > > wakeup override enabled/disable callback")'
> > > > >
> > > > > it tells that the reason was:
> > > > > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in
> > > > > different p$ wells, so it's necessary to reset display audio
> > > > > codecs when power we$ otherwise display audio codecs will
> > > > > disappear when resume from low p$ state."
> > > > >
> > > > > Is this the case here on BXT?
> > > > Yes, its the same case with BXT.
> > > > >
> > > > > Another interesting thing I noticed on Spec when searching for
> > > > > this bit was that this bit is related to an workaround on SKL/KBL/CFL...
> > > > > no mention to BXT.
> > > > >
> > > > > "This workaround is needed for an HW issue in SKL and KBL in
> > > > > which HW codec and HD audio controller link was going out of sync."
> > > > Yes, in Bspec it has been mentioned only for SKL and KBL. But
> > > > without this fix, sound card was not getting enumerated for BXT.
> > >
> > >
> > > Art,
> > >
> > > Can you please help us here? To summarize, the question is what
> > > platforms
> > need
> > > the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration
> > failures?
> > >
> > > -DK
> > >
> > > > >
> > > > > Thanks,
> > > > > Rodrigo.
> > > > >
> > > > >>
> > > > >>> return;
> > > > >>>
> > > > >>> i915_audio_component_get_power(kdev);
> > > > >> _______________________________________________
> > > > >> Intel-gfx mailing list
> > > > >> Intel-gfx@lists.freedesktop.org
> > > > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-02-27 17:30 ` Runyan, Arthur J
@ 2018-03-05 6:09 ` Singh, Gaurav K
2018-03-05 6:43 ` Mullah, Abid A
0 siblings, 1 reply; 28+ messages in thread
From: Singh, Gaurav K @ 2018-03-05 6:09 UTC (permalink / raw)
To: Runyan, Arthur J, Dhinakaran,, Gaurav K,, Harigaran,, Abid A
Cc: Nikula, Jani, intel-gfx, Rodrigo
On 2/27/2018 11:00 PM, Runyan, Arthur J wrote:
> Ok, please update the workaround page to show all the impacted projects
> https://gfxspecs.intel.com/Predator/Home/Index/21829
Hi,
Should we wait for Bspec to get updated or we can go ahead with the
merge. Please advise.
With regards,
Gaurav
>
>
>> -----Original Message-----
>> From: Mullah, Abid A
>> Sent: Tuesday, 27 February, 2018 8:52 AM
>> To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Pandiyan, Dhinakaran
>> <dhinakaran.pandiyan@intel.com>; Singh, Gaurav K
>> <gaurav.k.singh@intel.com>; Neelagandan, Harigaran
>> <harigaran.neelagandan@intel.com>
>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
>> Nikula, Jani <jani.nikula@intel.com>
>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>
>> Yes. It will be needed for BXT also.
>>
>> -----Original Message-----
>> From: Runyan, Arthur J
>> Sent: Tuesday, February 27, 2018 8:49 AM
>> To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh, Gaurav
>> K <gaurav.k.singh@intel.com>; Mullah, Abid A <abid.a.mullah@intel.com>;
>> Neelagandan, Harigaran <harigaran.neelagandan@intel.com>
>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
>> Nikula, Jani <jani.nikula@intel.com>
>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>
>> Abid or Hari, please check. There was a workaround to set
>> AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL
>> and KBL. Does it apply to BXT also?
>>
>>> -----Original Message-----
>>> From: Pandiyan, Dhinakaran
>>> Sent: Monday, 26 February, 2018 6:04 PM
>>> To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Singh, Gaurav K
>>> <gaurav.k.singh@intel.com>
>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>>> <rodrigo.vivi@intel.com>; Nikula, Jani <jani.nikula@intel.com>
>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>
>>>
>>>> -----Original Message-----
>>>> From: Runyan, Arthur J
>>>> Sent: Tuesday, January 9, 2018 11:55 AM
>>>> To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh,
>>> Gaurav K
>>>> <gaurav.k.singh@intel.com>
>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>>>> <rodrigo.vivi@intel.com>
>>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>
>>>> Sorry, I've been out. I'm checking on this.
>>>
>>> Hi Art,
>>>
>>> Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration
>> issues?
>>> -DK
>>>
>>>> -----Original Message-----
>>>> From: Pandiyan, Dhinakaran
>>>> Sent: Thursday, 4 January, 2018 2:00 PM
>>>> To: Singh, Gaurav K <gaurav.k.singh@intel.com>
>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>>>> <rodrigo.vivi@intel.com>; subransu.s.prusty@intel.com; Runyan,
>>>> Arthur J
>>> <arthur.j.runyan@intel.com>
>>>> Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>
>>>> +Art
>>>>
>>>> On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote:
>>>>> On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
>>>>>> On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran
>>> wrote:
>>>>>>> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
>>>>>>>> From: Gaurav Singh <gaurav.k.singh@intel.com>
>>>>>>>>
>>>>>>>> On Apollolake, with stress test warm reboot, audio card was
>>>>>>>> not getting enumerated after reboot. This was a
>>>>>>> The problem looks similar to
>>>>>>> https://lists.freedesktop.org/archives/intel-gfx/2017-October/1
>>>>>>> 4449
>>>>>>> 5.html
>>>>>>>
>>>>>>> although the proposed solutions are vastly different. I have
>>>>>>> Cc'd some more people.
>>>>>>>
>>>>>>>> spurious issue happening on Apollolake. HW codec and HD audio
>>>>>>>> controller link was going out of sync for which there was a
>>>>>>>> fix in
>>>>>>>> i915 driver but was not getting invoked for BXT. Extending
>>>>>>>> this fix to BXT as well.
>>>>>>>>
>>>>>>>> Tested on apollolake chromebook by stress test warm reboot
>>>>>>>> with
>>>>>>>> 2500 iterations.
>>>>>>>>
>>>>>>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>>>>>>> ---
>>>>>>>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
>>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>>
>>>>>>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>> b/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>> index f1502a0188eb..c71c04e1c3f6 100644
>>>>>>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>> @@ -729,7 +729,7 @@ static void
>>>> i915_audio_component_codec_wake_override(struct device *kdev,
>>>>>>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>>>>>>> u32 tmp;
>>>>>>>>
>>>>>>>> - if (!IS_GEN9_BC(dev_priv))
>>>>>>>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>>>>>>> IS_GEN9()? GLK might need this too.
>>>>>> I think this is applicable for all Gen9 platforms.
>>>>>> if GLK need there is the possibility of CNL also needing it...
>>>>>> So not sure where to stop.
>>>>>>
>>>>>> Also looking to the original patch that introduced this
>>>>>> function, commit '632f3ab95fe2 ("drm/i915/audio: add codec
>>>>>> wakeup override enabled/disable callback")'
>>>>>>
>>>>>> it tells that the reason was:
>>>>>> "In SKL, HDMI/DP codec and PCH HD Audio Controller are in
>>>>>> different p$ wells, so it's necessary to reset display audio
>>>>>> codecs when power we$ otherwise display audio codecs will
>>>>>> disappear when resume from low p$ state."
>>>>>>
>>>>>> Is this the case here on BXT?
>>>>> Yes, its the same case with BXT.
>>>>>> Another interesting thing I noticed on Spec when searching for
>>>>>> this bit was that this bit is related to an workaround on SKL/KBL/CFL...
>>>>>> no mention to BXT.
>>>>>>
>>>>>> "This workaround is needed for an HW issue in SKL and KBL in
>>>>>> which HW codec and HD audio controller link was going out of sync."
>>>>> Yes, in Bspec it has been mentioned only for SKL and KBL. But
>>>>> without this fix, sound card was not getting enumerated for BXT.
>>>>
>>>> Art,
>>>>
>>>> Can you please help us here? To summarize, the question is what
>>>> platforms
>>> need
>>>> the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration
>>> failures?
>>>> -DK
>>>>
>>>>>> Thanks,
>>>>>> Rodrigo.
>>>>>>
>>>>>>>> return;
>>>>>>>>
>>>>>>>> i915_audio_component_get_power(kdev);
>>>>>>> _______________________________________________
>>>>>>> Intel-gfx mailing list
>>>>>>> Intel-gfx@lists.freedesktop.org
>>>>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-03-05 6:09 ` Singh, Gaurav K
@ 2018-03-05 6:43 ` Mullah, Abid A
2018-03-05 6:48 ` Singh, Gaurav K
0 siblings, 1 reply; 28+ messages in thread
From: Mullah, Abid A @ 2018-03-05 6:43 UTC (permalink / raw)
To: Singh, Gaurav K
Cc: Neelagandan, Harigaran, Nikula, Jani, intel-gfx, Runyan,
Arthur J, Pandiyan, Dhinakaran, Vivi, Rodrigo
Did u check the fix on bxt and if u didnt see any issue then u can go ahead. I will update bspec tomorrow
Sent from my iPhone
> On Mar 4, 2018, at 10:09 PM, Singh, Gaurav K <gaurav.k.singh@intel.com> wrote:
>
>
>
>> On 2/27/2018 11:00 PM, Runyan, Arthur J wrote:
>> Ok, please update the workaround page to show all the impacted projects
>> https://gfxspecs.intel.com/Predator/Home/Index/21829
> Hi,
>
> Should we wait for Bspec to get updated or we can go ahead with the merge. Please advise.
>
> With regards,
> Gaurav
>>
>>
>>> -----Original Message-----
>>> From: Mullah, Abid A
>>> Sent: Tuesday, 27 February, 2018 8:52 AM
>>> To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Pandiyan, Dhinakaran
>>> <dhinakaran.pandiyan@intel.com>; Singh, Gaurav K
>>> <gaurav.k.singh@intel.com>; Neelagandan, Harigaran
>>> <harigaran.neelagandan@intel.com>
>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
>>> Nikula, Jani <jani.nikula@intel.com>
>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>
>>> Yes. It will be needed for BXT also.
>>>
>>> -----Original Message-----
>>> From: Runyan, Arthur J
>>> Sent: Tuesday, February 27, 2018 8:49 AM
>>> To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh, Gaurav
>>> K <gaurav.k.singh@intel.com>; Mullah, Abid A <abid.a.mullah@intel.com>;
>>> Neelagandan, Harigaran <harigaran.neelagandan@intel.com>
>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
>>> Nikula, Jani <jani.nikula@intel.com>
>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>
>>> Abid or Hari, please check. There was a workaround to set
>>> AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL
>>> and KBL. Does it apply to BXT also?
>>>
>>>> -----Original Message-----
>>>> From: Pandiyan, Dhinakaran
>>>> Sent: Monday, 26 February, 2018 6:04 PM
>>>> To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Singh, Gaurav K
>>>> <gaurav.k.singh@intel.com>
>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>>>> <rodrigo.vivi@intel.com>; Nikula, Jani <jani.nikula@intel.com>
>>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Runyan, Arthur J
>>>>> Sent: Tuesday, January 9, 2018 11:55 AM
>>>>> To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh,
>>>> Gaurav K
>>>>> <gaurav.k.singh@intel.com>
>>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>>>>> <rodrigo.vivi@intel.com>
>>>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>>
>>>>> Sorry, I've been out. I'm checking on this.
>>>>
>>>> Hi Art,
>>>>
>>>> Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration
>>> issues?
>>>> -DK
>>>>
>>>>> -----Original Message-----
>>>>> From: Pandiyan, Dhinakaran
>>>>> Sent: Thursday, 4 January, 2018 2:00 PM
>>>>> To: Singh, Gaurav K <gaurav.k.singh@intel.com>
>>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>>>>> <rodrigo.vivi@intel.com>; subransu.s.prusty@intel.com; Runyan,
>>>>> Arthur J
>>>> <arthur.j.runyan@intel.com>
>>>>> Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>>
>>>>> +Art
>>>>>
>>>>>> On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote:
>>>>>>> On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
>>>>>>> On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran
>>>> wrote:
>>>>>>>> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
>>>>>>>>> From: Gaurav Singh <gaurav.k.singh@intel.com>
>>>>>>>>>
>>>>>>>>> On Apollolake, with stress test warm reboot, audio card was
>>>>>>>>> not getting enumerated after reboot. This was a
>>>>>>>> The problem looks similar to
>>>>>>>> https://lists.freedesktop.org/archives/intel-gfx/2017-October/1
>>>>>>>> 4449
>>>>>>>> 5.html
>>>>>>>>
>>>>>>>> although the proposed solutions are vastly different. I have
>>>>>>>> Cc'd some more people.
>>>>>>>>
>>>>>>>>> spurious issue happening on Apollolake. HW codec and HD audio
>>>>>>>>> controller link was going out of sync for which there was a
>>>>>>>>> fix in
>>>>>>>>> i915 driver but was not getting invoked for BXT. Extending
>>>>>>>>> this fix to BXT as well.
>>>>>>>>>
>>>>>>>>> Tested on apollolake chromebook by stress test warm reboot
>>>>>>>>> with
>>>>>>>>> 2500 iterations.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>>>>>>>> ---
>>>>>>>>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
>>>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>>>
>>>>>>>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>>> b/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>>> index f1502a0188eb..c71c04e1c3f6 100644
>>>>>>>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>>> @@ -729,7 +729,7 @@ static void
>>>>> i915_audio_component_codec_wake_override(struct device *kdev,
>>>>>>>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>>>>>>>> u32 tmp;
>>>>>>>>>
>>>>>>>>> - if (!IS_GEN9_BC(dev_priv))
>>>>>>>>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>>>>>>>> IS_GEN9()? GLK might need this too.
>>>>>>> I think this is applicable for all Gen9 platforms.
>>>>>>> if GLK need there is the possibility of CNL also needing it...
>>>>>>> So not sure where to stop.
>>>>>>>
>>>>>>> Also looking to the original patch that introduced this
>>>>>>> function, commit '632f3ab95fe2 ("drm/i915/audio: add codec
>>>>>>> wakeup override enabled/disable callback")'
>>>>>>>
>>>>>>> it tells that the reason was:
>>>>>>> "In SKL, HDMI/DP codec and PCH HD Audio Controller are in
>>>>>>> different p$ wells, so it's necessary to reset display audio
>>>>>>> codecs when power we$ otherwise display audio codecs will
>>>>>>> disappear when resume from low p$ state."
>>>>>>>
>>>>>>> Is this the case here on BXT?
>>>>>> Yes, its the same case with BXT.
>>>>>>> Another interesting thing I noticed on Spec when searching for
>>>>>>> this bit was that this bit is related to an workaround on SKL/KBL/CFL...
>>>>>>> no mention to BXT.
>>>>>>>
>>>>>>> "This workaround is needed for an HW issue in SKL and KBL in
>>>>>>> which HW codec and HD audio controller link was going out of sync."
>>>>>> Yes, in Bspec it has been mentioned only for SKL and KBL. But
>>>>>> without this fix, sound card was not getting enumerated for BXT.
>>>>>
>>>>> Art,
>>>>>
>>>>> Can you please help us here? To summarize, the question is what
>>>>> platforms
>>>> need
>>>>> the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration
>>>> failures?
>>>>> -DK
>>>>>
>>>>>>> Thanks,
>>>>>>> Rodrigo.
>>>>>>>
>>>>>>>>> return;
>>>>>>>>>
>>>>>>>>> i915_audio_component_get_power(kdev);
>>>>>>>> _______________________________________________
>>>>>>>> Intel-gfx mailing list
>>>>>>>> Intel-gfx@lists.freedesktop.org
>>>>>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-03-05 6:43 ` Mullah, Abid A
@ 2018-03-05 6:48 ` Singh, Gaurav K
0 siblings, 0 replies; 28+ messages in thread
From: Singh, Gaurav K @ 2018-03-05 6:48 UTC (permalink / raw)
To: Mullah, Abid A
Cc: Neelagandan, Harigaran, Nikula, Jani, intel-gfx, Runyan,
Arthur J, Pandiyan, Dhinakaran, Vivi, Rodrigo
On 3/5/2018 12:13 PM, Mullah, Abid A wrote:
> Did u check the fix on bxt and if u didnt see any issue then u can go ahead. I will update bspec tomorrow
>
> Sent from my iPhone
Tested on apollolake chromebook by stress test warm reboot with 2500
iterations and did not see any issue.
With regards,
Gaurav
>
>> On Mar 4, 2018, at 10:09 PM, Singh, Gaurav K <gaurav.k.singh@intel.com> wrote:
>>
>>
>>
>>> On 2/27/2018 11:00 PM, Runyan, Arthur J wrote:
>>> Ok, please update the workaround page to show all the impacted projects
>>> https://gfxspecs.intel.com/Predator/Home/Index/21829
>> Hi,
>>
>> Should we wait for Bspec to get updated or we can go ahead with the merge. Please advise.
>>
>> With regards,
>> Gaurav
>>>
>>>> -----Original Message-----
>>>> From: Mullah, Abid A
>>>> Sent: Tuesday, 27 February, 2018 8:52 AM
>>>> To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Pandiyan, Dhinakaran
>>>> <dhinakaran.pandiyan@intel.com>; Singh, Gaurav K
>>>> <gaurav.k.singh@intel.com>; Neelagandan, Harigaran
>>>> <harigaran.neelagandan@intel.com>
>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
>>>> Nikula, Jani <jani.nikula@intel.com>
>>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>
>>>> Yes. It will be needed for BXT also.
>>>>
>>>> -----Original Message-----
>>>> From: Runyan, Arthur J
>>>> Sent: Tuesday, February 27, 2018 8:49 AM
>>>> To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh, Gaurav
>>>> K <gaurav.k.singh@intel.com>; Mullah, Abid A <abid.a.mullah@intel.com>;
>>>> Neelagandan, Harigaran <harigaran.neelagandan@intel.com>
>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
>>>> Nikula, Jani <jani.nikula@intel.com>
>>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>
>>>> Abid or Hari, please check. There was a workaround to set
>>>> AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL
>>>> and KBL. Does it apply to BXT also?
>>>>
>>>>> -----Original Message-----
>>>>> From: Pandiyan, Dhinakaran
>>>>> Sent: Monday, 26 February, 2018 6:04 PM
>>>>> To: Runyan, Arthur J <arthur.j.runyan@intel.com>; Singh, Gaurav K
>>>>> <gaurav.k.singh@intel.com>
>>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>>>>> <rodrigo.vivi@intel.com>; Nikula, Jani <jani.nikula@intel.com>
>>>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Runyan, Arthur J
>>>>>> Sent: Tuesday, January 9, 2018 11:55 AM
>>>>>> To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Singh,
>>>>> Gaurav K
>>>>>> <gaurav.k.singh@intel.com>
>>>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>>>>>> <rodrigo.vivi@intel.com>
>>>>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>>>
>>>>>> Sorry, I've been out. I'm checking on this.
>>>>> Hi Art,
>>>>>
>>>>> Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration
>>>> issues?
>>>>> -DK
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Pandiyan, Dhinakaran
>>>>>> Sent: Thursday, 4 January, 2018 2:00 PM
>>>>>> To: Singh, Gaurav K <gaurav.k.singh@intel.com>
>>>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo
>>>>>> <rodrigo.vivi@intel.com>; subransu.s.prusty@intel.com; Runyan,
>>>>>> Arthur J
>>>>> <arthur.j.runyan@intel.com>
>>>>>> Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
>>>>>>
>>>>>> +Art
>>>>>>
>>>>>>> On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote:
>>>>>>>> On 1/4/2018 2:48 AM, Rodrigo Vivi wrote:
>>>>>>>> On Wed, Jan 03, 2018 at 08:31:10PM +0000, Pandiyan, Dhinakaran
>>>>> wrote:
>>>>>>>>> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
>>>>>>>>>> From: Gaurav Singh <gaurav.k.singh@intel.com>
>>>>>>>>>>
>>>>>>>>>> On Apollolake, with stress test warm reboot, audio card was
>>>>>>>>>> not getting enumerated after reboot. This was a
>>>>>>>>> The problem looks similar to
>>>>>>>>> https://lists.freedesktop.org/archives/intel-gfx/2017-October/1
>>>>>>>>> 4449
>>>>>>>>> 5.html
>>>>>>>>>
>>>>>>>>> although the proposed solutions are vastly different. I have
>>>>>>>>> Cc'd some more people.
>>>>>>>>>
>>>>>>>>>> spurious issue happening on Apollolake. HW codec and HD audio
>>>>>>>>>> controller link was going out of sync for which there was a
>>>>>>>>>> fix in
>>>>>>>>>> i915 driver but was not getting invoked for BXT. Extending
>>>>>>>>>> this fix to BXT as well.
>>>>>>>>>>
>>>>>>>>>> Tested on apollolake chromebook by stress test warm reboot
>>>>>>>>>> with
>>>>>>>>>> 2500 iterations.
>>>>>>>>>>
>>>>>>>>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>>>>>>>>> ---
>>>>>>>>>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
>>>>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>>>>
>>>>>>>>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>>>> b/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>>>> index f1502a0188eb..c71c04e1c3f6 100644
>>>>>>>>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>>>>>>>>> @@ -729,7 +729,7 @@ static void
>>>>>> i915_audio_component_codec_wake_override(struct device *kdev,
>>>>>>>>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>>>>>>>>> u32 tmp;
>>>>>>>>>>
>>>>>>>>>> - if (!IS_GEN9_BC(dev_priv))
>>>>>>>>>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>>>>>>>>> IS_GEN9()? GLK might need this too.
>>>>>>>> I think this is applicable for all Gen9 platforms.
>>>>>>>> if GLK need there is the possibility of CNL also needing it...
>>>>>>>> So not sure where to stop.
>>>>>>>>
>>>>>>>> Also looking to the original patch that introduced this
>>>>>>>> function, commit '632f3ab95fe2 ("drm/i915/audio: add codec
>>>>>>>> wakeup override enabled/disable callback")'
>>>>>>>>
>>>>>>>> it tells that the reason was:
>>>>>>>> "In SKL, HDMI/DP codec and PCH HD Audio Controller are in
>>>>>>>> different p$ wells, so it's necessary to reset display audio
>>>>>>>> codecs when power we$ otherwise display audio codecs will
>>>>>>>> disappear when resume from low p$ state."
>>>>>>>>
>>>>>>>> Is this the case here on BXT?
>>>>>>> Yes, its the same case with BXT.
>>>>>>>> Another interesting thing I noticed on Spec when searching for
>>>>>>>> this bit was that this bit is related to an workaround on SKL/KBL/CFL...
>>>>>>>> no mention to BXT.
>>>>>>>>
>>>>>>>> "This workaround is needed for an HW issue in SKL and KBL in
>>>>>>>> which HW codec and HD audio controller link was going out of sync."
>>>>>>> Yes, in Bspec it has been mentioned only for SKL and KBL. But
>>>>>>> without this fix, sound card was not getting enumerated for BXT.
>>>>>> Art,
>>>>>>
>>>>>> Can you please help us here? To summarize, the question is what
>>>>>> platforms
>>>>> need
>>>>>> the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration
>>>>> failures?
>>>>>> -DK
>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Rodrigo.
>>>>>>>>
>>>>>>>>>> return;
>>>>>>>>>>
>>>>>>>>>> i915_audio_component_get_power(kdev);
>>>>>>>>> _______________________________________________
>>>>>>>>> Intel-gfx mailing list
>>>>>>>>> Intel-gfx@lists.freedesktop.org
>>>>>>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
` (2 preceding siblings ...)
2018-01-03 21:19 ` ✓ Fi.CI.IGT: success for " Patchwork
@ 2018-03-05 18:21 ` Pandiyan, Dhinakaran
2018-03-09 15:54 ` Gaurav K Singh
` (3 more replies)
2018-03-09 16:17 ` ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev2) Patchwork
` (3 subsequent siblings)
7 siblings, 4 replies; 28+ messages in thread
From: Pandiyan, Dhinakaran @ 2018-03-05 18:21 UTC (permalink / raw)
To: Singh, Gaurav K; +Cc: intel-gfx
On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
> From: Gaurav Singh <gaurav.k.singh@intel.com>
>
> On Apollolake, with stress test warm reboot, audio card
> was not getting enumerated after reboot. This was a
> spurious issue happening on Apollolake. HW codec and
> HD audio controller link was going out of sync for which
> there was a fix in i915 driver but was not getting invoked
> for BXT. Extending this fix to BXT as well.
>
> Tested on apollolake chromebook by stress test warm reboot
> with 2500 iterations.
>
> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
Might be worth adding
Bspec: 21829
to the commit message.
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Please rebase and send this patch to the list to CI it.
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index f1502a0188eb..c71c04e1c3f6 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> u32 tmp;
>
> - if (!IS_GEN9_BC(dev_priv))
> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> return;
>
> i915_audio_component_get_power(kdev);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH] drm: i915: Fix audio issue on BXT
2018-03-05 18:21 ` [PATCH] " Pandiyan, Dhinakaran
@ 2018-03-09 15:54 ` Gaurav K Singh
2018-04-05 8:17 ` Gaurav K Singh
` (2 subsequent siblings)
3 siblings, 0 replies; 28+ messages in thread
From: Gaurav K Singh @ 2018-03-09 15:54 UTC (permalink / raw)
To: intel-gfx; +Cc: dhinakaran.pandiyan
On Apollolake, with stress test warm reboot, audio card
was not getting enumerated after reboot. This was a
spurious issue happening on Apollolake. HW codec and
HD audio controller link was going out of sync for which
there was a fix in i915 driver but was not getting invoked
for BXT. Extending this fix to BXT as well.
Bspec: 21829
Tested on apollolake chromebook by stress test warm reboot
with 2500 iterations.
v2:
* Mention Bspec Index in commit message(Dhinakaran Pandiyan)
Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 709d6ca68074..656f6c931341 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
u32 tmp;
- if (!IS_GEN9_BC(dev_priv))
+ if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
return;
i915_audio_component_get_power(kdev);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 28+ messages in thread
* ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev2)
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
` (3 preceding siblings ...)
2018-03-05 18:21 ` [PATCH] " Pandiyan, Dhinakaran
@ 2018-03-09 16:17 ` Patchwork
2018-04-05 9:18 ` ✓ Fi.CI.BAT: success for drm: i915: Fix audio issue on BXT (rev3) Patchwork
` (2 subsequent siblings)
7 siblings, 0 replies; 28+ messages in thread
From: Patchwork @ 2018-03-09 16:17 UTC (permalink / raw)
To: Gaurav K Singh; +Cc: intel-gfx
== Series Details ==
Series: drm: i915: Fix audio issue on BXT (rev2)
URL : https://patchwork.freedesktop.org/series/35955/
State : failure
== Summary ==
Series 35955v2 drm: i915: Fix audio issue on BXT
https://patchwork.freedesktop.org/api/1.0/series/35955/revisions/2/mbox/
---- Possible new issues:
Test kms_frontbuffer_tracking:
Subgroup basic:
pass -> INCOMPLETE (fi-bsw-n3050)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-hsw-4770)
---- Known issues:
Test debugfs_test:
Subgroup read_all_entries:
incomplete -> PASS (fi-snb-2520m) fdo#103713
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:425s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:424s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:380s
fi-bsw-n3050 total:224 pass:194 dwarn:0 dfail:0 fail:0 skip:29
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:279s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:501s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:485s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:473s
fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:408s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:576s
fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:581s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:415s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:289s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:516s
fi-hsw-4770 total:245 pass:221 dwarn:0 dfail:0 fail:0 skip:23
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:416s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:469s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:422s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:470s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:464s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:509s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:583s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:440s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:524s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:537s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:498s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:488s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:422s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:433s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:516s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:395s
Blacklisted hosts:
fi-cfl-u total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:508s
fi-cnl-drrs total:288 pass:257 dwarn:3 dfail:0 fail:0 skip:19 time:518s
fi-bxt-dsi failed to collect. IGT log at Patchwork_8292/fi-bxt-dsi/run0.log
2e2ef5a5221a7469ecd72c68ed15dd8b94e2e0c6 drm-tip: 2018y-03m-09d-14h-28m-10s UTC integration manifest
c90b8bf68afb drm: i915: Fix audio issue on BXT
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8292/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH] drm: i915: Fix audio issue on BXT
2018-03-05 18:21 ` [PATCH] " Pandiyan, Dhinakaran
2018-03-09 15:54 ` Gaurav K Singh
@ 2018-04-05 8:17 ` Gaurav K Singh
2018-04-05 8:22 ` Singh, Gaurav K
2018-04-05 16:42 ` [PATCH] drm/i915: " Gaurav K Singh
3 siblings, 0 replies; 28+ messages in thread
From: Gaurav K Singh @ 2018-04-05 8:17 UTC (permalink / raw)
To: intel-gfx; +Cc: dhinakaran.pandiyan
On Apollolake, with stress test warm reboot, audio card
was not getting enumerated after reboot. This was a
spurious issue happening on Apollolake. HW codec and
HD audio controller link was going out of sync for which
there was a fix in i915 driver but was not getting invoked
for BXT. Extending this fix to BXT as well.
Tested on apollolake chromebook by stress test warm reboot
with 2500 iterations.
Bspec: 21829
Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 709d6ca68074..656f6c931341 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
u32 tmp;
- if (!IS_GEN9_BC(dev_priv))
+ if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
return;
i915_audio_component_get_power(kdev);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH] drm: i915: Fix audio issue on BXT
2018-03-05 18:21 ` [PATCH] " Pandiyan, Dhinakaran
2018-03-09 15:54 ` Gaurav K Singh
2018-04-05 8:17 ` Gaurav K Singh
@ 2018-04-05 8:22 ` Singh, Gaurav K
2018-04-05 16:42 ` [PATCH] drm/i915: " Gaurav K Singh
3 siblings, 0 replies; 28+ messages in thread
From: Singh, Gaurav K @ 2018-04-05 8:22 UTC (permalink / raw)
To: Pandiyan, Dhinakaran; +Cc: intel-gfx
On 3/5/2018 11:51 PM, Pandiyan, Dhinakaran wrote:
> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
>> From: Gaurav Singh <gaurav.k.singh@intel.com>
>>
>> On Apollolake, with stress test warm reboot, audio card
>> was not getting enumerated after reboot. This was a
>> spurious issue happening on Apollolake. HW codec and
>> HD audio controller link was going out of sync for which
>> there was a fix in i915 driver but was not getting invoked
>> for BXT. Extending this fix to BXT as well.
>>
>> Tested on apollolake chromebook by stress test warm reboot
>> with 2500 iterations.
>>
>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> Might be worth adding
>
> Bspec: 21829
>
> to the commit message.
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> Please rebase and send this patch to the list to CI it.
Hi DK,
Sure, i have added Bspec index and sent the updated patch.
https://patchwork.freedesktop.org/patch/215067/
With regards,
Gaurav
>
>
>> ---
>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>> index f1502a0188eb..c71c04e1c3f6 100644
>> --- a/drivers/gpu/drm/i915/intel_audio.c
>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>> u32 tmp;
>>
>> - if (!IS_GEN9_BC(dev_priv))
>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>> return;
>>
>> i915_audio_component_get_power(kdev);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* ✓ Fi.CI.BAT: success for drm: i915: Fix audio issue on BXT (rev3)
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
` (4 preceding siblings ...)
2018-03-09 16:17 ` ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev2) Patchwork
@ 2018-04-05 9:18 ` Patchwork
2018-04-05 12:32 ` ✗ Fi.CI.IGT: warning " Patchwork
2018-04-05 17:16 ` ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev4) Patchwork
7 siblings, 0 replies; 28+ messages in thread
From: Patchwork @ 2018-04-05 9:18 UTC (permalink / raw)
To: Singh, Gaurav K; +Cc: intel-gfx
== Series Details ==
Series: drm: i915: Fix audio issue on BXT (rev3)
URL : https://patchwork.freedesktop.org/series/35955/
State : success
== Summary ==
Series 35955v3 drm: i915: Fix audio issue on BXT
https://patchwork.freedesktop.org/api/1.0/series/35955/revisions/3/mbox/
---- Known issues:
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-warn -> PASS (fi-glk-j4005) fdo#103359
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bxt-dsi) fdo#103927
Test prime_vgem:
Subgroup basic-fence-flip:
pass -> FAIL (fi-ilk-650) fdo#104008
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:430s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:443s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:383s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:533s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:299s
fi-bxt-dsi total:243 pass:216 dwarn:0 dfail:0 fail:0 skip:26
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:513s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:523s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:514s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:410s
fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:560s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:511s
fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:592s
fi-elk-e7500 total:285 pass:226 dwarn:0 dfail:0 fail:0 skip:59 time:425s
fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:313s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:539s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:487s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:407s
fi-ilk-650 total:285 pass:224 dwarn:0 dfail:0 fail:1 skip:60 time:422s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:477s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:435s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:476s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:462s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:509s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:443s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:549s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:509s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:515s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:429s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:444s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:573s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:399s
Blacklisted hosts:
fi-cnl-psr total:285 pass:256 dwarn:3 dfail:0 fail:0 skip:26 time:519s
e29a10513429cca404e9847a399efbdbb4bdd4bf drm-tip: 2018y-04m-04d-20h-47m-24s UTC integration manifest
82b14188ae00 drm: i915: Fix audio issue on BXT
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8587/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* ✗ Fi.CI.IGT: warning for drm: i915: Fix audio issue on BXT (rev3)
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
` (5 preceding siblings ...)
2018-04-05 9:18 ` ✓ Fi.CI.BAT: success for drm: i915: Fix audio issue on BXT (rev3) Patchwork
@ 2018-04-05 12:32 ` Patchwork
2018-04-06 8:43 ` Jani Nikula
2018-04-05 17:16 ` ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev4) Patchwork
7 siblings, 1 reply; 28+ messages in thread
From: Patchwork @ 2018-04-05 12:32 UTC (permalink / raw)
To: Singh, Gaurav K; +Cc: intel-gfx
== Series Details ==
Series: drm: i915: Fix audio issue on BXT (rev3)
URL : https://patchwork.freedesktop.org/series/35955/
State : warning
== Summary ==
---- Possible new issues:
Test kms_flip:
Subgroup flip-vs-modeset-interruptible:
pass -> DMESG-WARN (shard-hsw)
---- Known issues:
Test kms_flip:
Subgroup 2x-dpms-vs-vblank-race:
pass -> FAIL (shard-hsw) fdo#103060 +1
Subgroup 2x-flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887 +1
Subgroup flip-vs-blocking-wf-vblank:
fail -> PASS (shard-hsw) fdo#100368 +2
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-pwrite:
dmesg-fail -> PASS (shard-apl) fdo#105685
Test kms_plane_multiple:
Subgroup atomic-pipe-a-tiling-x:
pass -> FAIL (shard-snb) fdo#103166
Test kms_rotation_crc:
Subgroup sprite-rotation-180:
pass -> FAIL (shard-snb) fdo#103925
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#105685 https://bugs.freedesktop.org/show_bug.cgi?id=105685
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
shard-apl total:3499 pass:1835 dwarn:1 dfail:0 fail:7 skip:1655 time:12904s
shard-hsw total:3499 pass:1782 dwarn:2 dfail:0 fail:4 skip:1710 time:11565s
shard-snb total:3499 pass:1376 dwarn:1 dfail:0 fail:4 skip:2118 time:7029s
Blacklisted hosts:
shard-kbl total:3499 pass:1931 dwarn:8 dfail:0 fail:26 skip:1534 time:9235s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8587/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH] drm/i915: Fix audio issue on BXT
2018-03-05 18:21 ` [PATCH] " Pandiyan, Dhinakaran
` (2 preceding siblings ...)
2018-04-05 8:22 ` Singh, Gaurav K
@ 2018-04-05 16:42 ` Gaurav K Singh
2018-04-05 17:58 ` Pandiyan, Dhinakaran
3 siblings, 1 reply; 28+ messages in thread
From: Gaurav K Singh @ 2018-04-05 16:42 UTC (permalink / raw)
To: intel-gfx; +Cc: dhinakaran.pandiyan
On Apollolake, with stress test warm reboot, audio card
was not getting enumerated after reboot. This was a
spurious issue happening on Apollolake. HW codec and
HD audio controller link was going out of sync for which
there was a fix in i915 driver but was not getting invoked
for BXT. Extending this fix to BXT as well.
Tested on apollolake chromebook by stress test warm reboot
with 2500 iterations.
Bspec: 21829
Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 709d6ca68074..656f6c931341 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
u32 tmp;
- if (!IS_GEN9_BC(dev_priv))
+ if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
return;
i915_audio_component_get_power(kdev);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 28+ messages in thread
* ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev4)
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
` (6 preceding siblings ...)
2018-04-05 12:32 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2018-04-05 17:16 ` Patchwork
7 siblings, 0 replies; 28+ messages in thread
From: Patchwork @ 2018-04-05 17:16 UTC (permalink / raw)
To: Gaurav K Singh; +Cc: intel-gfx
== Series Details ==
Series: drm: i915: Fix audio issue on BXT (rev4)
URL : https://patchwork.freedesktop.org/series/35955/
State : failure
== Summary ==
Series 35955v4 drm: i915: Fix audio issue on BXT
https://patchwork.freedesktop.org/api/1.0/series/35955/revisions/4/mbox/
---- Possible new issues:
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a:
pass -> INCOMPLETE (fi-cnl-y3)
---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test prime_vgem:
Subgroup basic-fence-flip:
fail -> PASS (fi-ilk-650) fdo#104008
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:437s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:443s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:386s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:537s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:299s
fi-bxt-dsi total:285 pass:255 dwarn:0 dfail:0 fail:0 skip:30 time:521s
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:515s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:523s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:507s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:414s
fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:559s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:513s
fi-cnl-y3 total:229 pass:204 dwarn:0 dfail:0 fail:0 skip:24
fi-elk-e7500 total:285 pass:226 dwarn:0 dfail:0 fail:0 skip:59 time:424s
fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:316s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:539s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:483s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:405s
fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:429s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:471s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:430s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:476s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:467s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:511s
fi-pnv-d510 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:662s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:440s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:535s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:504s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:494s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:430s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:445s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:576s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:399s
Blacklisted hosts:
fi-cnl-psr total:285 pass:255 dwarn:3 dfail:0 fail:1 skip:26 time:513s
fcaf73c13c14d6bfd64c4f37089bf5437fb32221 drm-tip: 2018y-04m-05d-15h-53m-18s UTC integration manifest
2df45b21af1b drm/i915: Fix audio issue on BXT
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8601/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm/i915: Fix audio issue on BXT
2018-04-05 16:42 ` [PATCH] drm/i915: " Gaurav K Singh
@ 2018-04-05 17:58 ` Pandiyan, Dhinakaran
2018-04-06 8:41 ` Jani Nikula
0 siblings, 1 reply; 28+ messages in thread
From: Pandiyan, Dhinakaran @ 2018-04-05 17:58 UTC (permalink / raw)
To: Singh, Gaurav K; +Cc: intel-gfx, Vivi, Rodrigo
On Thu, 2018-04-05 at 22:12 +0530, Gaurav K Singh wrote:
> On Apollolake, with stress test warm reboot, audio card
> was not getting enumerated after reboot. This was a
> spurious issue happening on Apollolake. HW codec and
> HD audio controller link was going out of sync for which
> there was a fix in i915 driver but was not getting invoked
> for BXT. Extending this fix to BXT as well.
>
> Tested on apollolake chromebook by stress test warm reboot
> with 2500 iterations.
>
> Bspec: 21829
>
R-B stands.
Btw, it would be easier to spot this patch and pick this up for merging
if you did not send this as a reply. I guess that's okay this time?
Also, a minor nitpick, "drm/i915/audio" would have been a more
appropriate prefix for the patch subject.
> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 709d6ca68074..656f6c931341 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> u32 tmp;
>
> - if (!IS_GEN9_BC(dev_priv))
> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> return;
>
> i915_audio_component_get_power(kdev);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] drm/i915: Fix audio issue on BXT
2018-04-05 17:58 ` Pandiyan, Dhinakaran
@ 2018-04-06 8:41 ` Jani Nikula
0 siblings, 0 replies; 28+ messages in thread
From: Jani Nikula @ 2018-04-06 8:41 UTC (permalink / raw)
To: Pandiyan, Dhinakaran, Singh, Gaurav K; +Cc: intel-gfx, Vivi, Rodrigo
On Thu, 05 Apr 2018, "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com> wrote:
> On Thu, 2018-04-05 at 22:12 +0530, Gaurav K Singh wrote:
>> On Apollolake, with stress test warm reboot, audio card
>> was not getting enumerated after reboot. This was a
>> spurious issue happening on Apollolake. HW codec and
>> HD audio controller link was going out of sync for which
>> there was a fix in i915 driver but was not getting invoked
>> for BXT. Extending this fix to BXT as well.
>>
>> Tested on apollolake chromebook by stress test warm reboot
>> with 2500 iterations.
>>
>> Bspec: 21829
>>
>
> R-B stands.
>
> Btw, it would be easier to spot this patch and pick this up for merging
> if you did not send this as a reply. I guess that's okay this time?
> Also, a minor nitpick, "drm/i915/audio" would have been a more
> appropriate prefix for the patch subject.
Thanks for the patch and review, pushed to dinq, with the patch title
amended.
Immediately after pushing I realized that this should have been Cc:
stable. Joonas, after v4.17-rc1 is out and you've rebased
drm-intel-fixes on it, please cherry-pick this one with Cc: stable
added.
Thanks,
Jani.
>
>
>
>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>> index 709d6ca68074..656f6c931341 100644
>> --- a/drivers/gpu/drm/i915/intel_audio.c
>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>> u32 tmp;
>>
>> - if (!IS_GEN9_BC(dev_priv))
>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>> return;
>>
>> i915_audio_component_get_power(kdev);
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: ✗ Fi.CI.IGT: warning for drm: i915: Fix audio issue on BXT (rev3)
2018-04-05 12:32 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2018-04-06 8:43 ` Jani Nikula
0 siblings, 0 replies; 28+ messages in thread
From: Jani Nikula @ 2018-04-06 8:43 UTC (permalink / raw)
To: Patchwork, Singh, Gaurav K; +Cc: intel-gfx
On Thu, 05 Apr 2018, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm: i915: Fix audio issue on BXT (rev3)
> URL : https://patchwork.freedesktop.org/series/35955/
> State : warning
>
> == Summary ==
>
> ---- Possible new issues:
>
> Test kms_flip:
> Subgroup flip-vs-modeset-interruptible:
> pass -> DMESG-WARN (shard-hsw)
This is unrelated.
Jani.
>
> ---- Known issues:
>
> Test kms_flip:
> Subgroup 2x-dpms-vs-vblank-race:
> pass -> FAIL (shard-hsw) fdo#103060 +1
> Subgroup 2x-flip-vs-expired-vblank-interruptible:
> fail -> PASS (shard-hsw) fdo#102887 +1
> Subgroup flip-vs-blocking-wf-vblank:
> fail -> PASS (shard-hsw) fdo#100368 +2
> Test kms_frontbuffer_tracking:
> Subgroup fbc-1p-offscren-pri-shrfb-draw-pwrite:
> dmesg-fail -> PASS (shard-apl) fdo#105685
> Test kms_plane_multiple:
> Subgroup atomic-pipe-a-tiling-x:
> pass -> FAIL (shard-snb) fdo#103166
> Test kms_rotation_crc:
> Subgroup sprite-rotation-180:
> pass -> FAIL (shard-snb) fdo#103925
>
> fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
> fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
> fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
> fdo#105685 https://bugs.freedesktop.org/show_bug.cgi?id=105685
> fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
> fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
>
> shard-apl total:3499 pass:1835 dwarn:1 dfail:0 fail:7 skip:1655 time:12904s
> shard-hsw total:3499 pass:1782 dwarn:2 dfail:0 fail:4 skip:1710 time:11565s
> shard-snb total:3499 pass:1376 dwarn:1 dfail:0 fail:4 skip:2118 time:7029s
> Blacklisted hosts:
> shard-kbl total:3499 pass:1931 dwarn:8 dfail:0 fail:26 skip:1534 time:9235s
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8587/shards.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2018-04-06 8:42 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
2018-01-03 19:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-03 20:31 ` [PATCH] " Pandiyan, Dhinakaran
2018-01-03 21:18 ` Rodrigo Vivi
[not found] ` <FF3DDC77922A8A4BB08A3BC48A1EA8CB8DA78F44@BGSMSX101.gar.corp.intel.com>
2018-01-04 6:23 ` FW: " Sharma, Shashank
2018-01-04 16:43 ` Singh, Gaurav K
2018-01-04 21:59 ` Pandiyan, Dhinakaran
2018-01-09 19:54 ` Runyan, Arthur J
2018-02-27 2:03 ` Pandiyan, Dhinakaran
2018-02-27 16:48 ` Runyan, Arthur J
2018-02-27 16:52 ` Mullah, Abid A
2018-02-27 17:30 ` Runyan, Arthur J
2018-03-05 6:09 ` Singh, Gaurav K
2018-03-05 6:43 ` Mullah, Abid A
2018-03-05 6:48 ` Singh, Gaurav K
2018-01-03 21:19 ` ✓ Fi.CI.IGT: success for " Patchwork
2018-03-05 18:21 ` [PATCH] " Pandiyan, Dhinakaran
2018-03-09 15:54 ` Gaurav K Singh
2018-04-05 8:17 ` Gaurav K Singh
2018-04-05 8:22 ` Singh, Gaurav K
2018-04-05 16:42 ` [PATCH] drm/i915: " Gaurav K Singh
2018-04-05 17:58 ` Pandiyan, Dhinakaran
2018-04-06 8:41 ` Jani Nikula
2018-03-09 16:17 ` ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev2) Patchwork
2018-04-05 9:18 ` ✓ Fi.CI.BAT: success for drm: i915: Fix audio issue on BXT (rev3) Patchwork
2018-04-05 12:32 ` ✗ Fi.CI.IGT: warning " Patchwork
2018-04-06 8:43 ` Jani Nikula
2018-04-05 17:16 ` ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev4) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.