Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform

Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On Thu, Mar 12, 2015 at 10:28:28PM +0800, qipeng.zha wrote:
> From: "qipeng.zha" <qipeng.zha@intel.com>
> 
> Add pci device id for Broxton platform.

For reference, this should be "PCI" and "ID", but I can fix those up
while applying.

Also, it's customary to include a changelog in subsequent versions of a
patch, as well as change the subject prefix to include the patch version
number. That makes it easier for other people to track things.

You can do so using:

	$ git format-patch --subject-prefix='PATCH v2' ...

The changelog typically goes below the --- marker (the one below the
Signed-off-by line) and would look something like this:

---
Changes in v2:
- keep board information table sorted by device ID
- reuse Braswell board information

Again, no need to resend this time, but something to keep in mind for
future patches.

> Signed-off-by: qipeng.zha <qipeng.zha@intel.com>

I'd prefer a proper spelling of your name. Would "Qipeng Zha" be
correct?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform

[Mika Westerberg]

On Thu, Mar 12, 2015 at 10:28:28PM +0800, qipeng.zha wrote:
> From: "qipeng.zha" <qipeng.zha@intel.com>
> 
> Add pci device id for Broxton platform.
> 
> Signed-off-by: qipeng.zha <qipeng.zha@intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

[PATCH] pwm: update lpss pwm driver to support Broxton platform

[qipeng.zha]

From: "qipeng.zha" <qipeng.zha@intel.com>

Add pci device id for Broxton platform.

Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
---
 drivers/pwm/pwm-lpss-pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pwm/pwm-lpss-pci.c b/drivers/pwm/pwm-lpss-pci.c
index cf20d2b..45042c1 100644
--- a/drivers/pwm/pwm-lpss-pci.c
+++ b/drivers/pwm/pwm-lpss-pci.c
@@ -44,8 +44,10 @@ static void pwm_lpss_remove_pci(struct pci_dev *pdev)
 }
 
 static const struct pci_device_id pwm_lpss_pci_ids[] = {
+	{ PCI_VDEVICE(INTEL, 0x0ac8), (unsigned long)&pwm_lpss_bsw_info},
 	{ PCI_VDEVICE(INTEL, 0x0f08), (unsigned long)&pwm_lpss_byt_info},
 	{ PCI_VDEVICE(INTEL, 0x0f09), (unsigned long)&pwm_lpss_byt_info},
+	{ PCI_VDEVICE(INTEL, 0x1ac8), (unsigned long)&pwm_lpss_bsw_info},
 	{ PCI_VDEVICE(INTEL, 0x2288), (unsigned long)&pwm_lpss_bsw_info},
 	{ PCI_VDEVICE(INTEL, 0x2289), (unsigned long)&pwm_lpss_bsw_info},
 	{ },
-- 
1.8.3.2

RE: [PATCH] pwm: update lpss pwm driver to support Broxton platform

[Zha, Qipeng]

Thierry

Thank you very much:)


Best wishes
Qipeng

-----Original Message-----
From: linux-pwm-owner@vger.kernel.org [mailto:linux-pwm-owner@vger.kernel.org] On Behalf Of Thierry Reding
Sent: Thursday, March 12, 2015 3:59 PM
To: Zha, Qipeng
Cc: linux-pwm@vger.kernel.org; Westerberg, Mika
Subject: Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform

On Thu, Mar 12, 2015 at 10:28:28PM +0800, qipeng.zha wrote:
> From: "qipeng.zha" <qipeng.zha@intel.com>
> 
> Add pci device id for Broxton platform.

For reference, this should be "PCI" and "ID", but I can fix those up while applying.

Also, it's customary to include a changelog in subsequent versions of a patch, as well as change the subject prefix to include the patch version number. That makes it easier for other people to track things.

You can do so using:

	$ git format-patch --subject-prefix='PATCH v2' ...

The changelog typically goes below the --- marker (the one below the Signed-off-by line) and would look something like this:

---
Changes in v2:
- keep board information table sorted by device ID
- reuse Braswell board information

Again, no need to resend this time, but something to keep in mind for future patches.

> Signed-off-by: qipeng.zha <qipeng.zha@intel.com>

I'd prefer a proper spelling of your name. Would "Qipeng Zha" be correct?

Thierry

Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

Looks like I never got around to applying this. Done now.

Thierry

On Fri, Mar 13, 2015 at 12:51:35AM +0000, Zha, Qipeng wrote:
> Thierry
> 
> Thank you very much:)
> 
> 
> Best wishes
> Qipeng
> 
> -----Original Message-----
> From: linux-pwm-owner@vger.kernel.org [mailto:linux-pwm-owner@vger.kernel.org] On Behalf Of Thierry Reding
> Sent: Thursday, March 12, 2015 3:59 PM
> To: Zha, Qipeng
> Cc: linux-pwm@vger.kernel.org; Westerberg, Mika
> Subject: Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform
> 
> On Thu, Mar 12, 2015 at 10:28:28PM +0800, qipeng.zha wrote:
> > From: "qipeng.zha" <qipeng.zha@intel.com>
> > 
> > Add pci device id for Broxton platform.
> 
> For reference, this should be "PCI" and "ID", but I can fix those up while applying.
> 
> Also, it's customary to include a changelog in subsequent versions of a patch, as well as change the subject prefix to include the patch version number. That makes it easier for other people to track things.
> 
> You can do so using:
> 
> 	$ git format-patch --subject-prefix='PATCH v2' ...
> 
> The changelog typically goes below the --- marker (the one below the Signed-off-by line) and would look something like this:
> 
> ---
> Changes in v2:
> - keep board information table sorted by device ID
> - reuse Braswell board information
> 
> Again, no need to resend this time, but something to keep in mind for future patches.
> 
> > Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
> 
> I'd prefer a proper spelling of your name. Would "Qipeng Zha" be correct?
> 
> Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

[PATCH] pwm: update lpss pwm driver to support Broxton platform

[qipeng.zha]

From: "qipeng.zha" <qipeng.zha@intel.com>

Add pci device id for Broxton platform.

Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
---
 drivers/pwm/pwm-lpss-pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pwm/pwm-lpss-pci.c b/drivers/pwm/pwm-lpss-pci.c
index cf20d2b..3ae3e7b1 100644
--- a/drivers/pwm/pwm-lpss-pci.c
+++ b/drivers/pwm/pwm-lpss-pci.c
@@ -44,8 +44,10 @@ static void pwm_lpss_remove_pci(struct pci_dev *pdev)
 }
 
 static const struct pci_device_id pwm_lpss_pci_ids[] = {
+	{ PCI_VDEVICE(INTEL, 0x0AC8), (unsigned long)&pwm_lpss_bsw_info},
 	{ PCI_VDEVICE(INTEL, 0x0f08), (unsigned long)&pwm_lpss_byt_info},
 	{ PCI_VDEVICE(INTEL, 0x0f09), (unsigned long)&pwm_lpss_byt_info},
+	{ PCI_VDEVICE(INTEL, 0x1AC8), (unsigned long)&pwm_lpss_bsw_info},
 	{ PCI_VDEVICE(INTEL, 0x2288), (unsigned long)&pwm_lpss_bsw_info},
 	{ PCI_VDEVICE(INTEL, 0x2289), (unsigned long)&pwm_lpss_bsw_info},
 	{ },
-- 
1.8.3.2

[PATCH] pwm: update lpss pwm driver to support Broxton platform

[qipeng.zha]

From: "qipeng.zha" <qipeng.zha@intel.com>

Add pci device id for Broxton platform.

Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
---
 drivers/pwm/pwm-lpss-pci.c | 2 ++
 drivers/pwm/pwm-lpss.c     | 6 ++++++
 drivers/pwm/pwm-lpss.h     | 1 +
 3 files changed, 9 insertions(+)

diff --git a/drivers/pwm/pwm-lpss-pci.c b/drivers/pwm/pwm-lpss-pci.c
index cf20d2b..ab6c84e 100644
--- a/drivers/pwm/pwm-lpss-pci.c
+++ b/drivers/pwm/pwm-lpss-pci.c
@@ -48,6 +48,8 @@ static const struct pci_device_id pwm_lpss_pci_ids[] = {
 	{ PCI_VDEVICE(INTEL, 0x0f09), (unsigned long)&pwm_lpss_byt_info},
 	{ PCI_VDEVICE(INTEL, 0x2288), (unsigned long)&pwm_lpss_bsw_info},
 	{ PCI_VDEVICE(INTEL, 0x2289), (unsigned long)&pwm_lpss_bsw_info},
+	{ PCI_VDEVICE(INTEL, 0x0AC8), (unsigned long)&pwm_lpss_bxt_info},
+	{ PCI_VDEVICE(INTEL, 0x1AC8), (unsigned long)&pwm_lpss_bxt_info},
 	{ },
 };
 MODULE_DEVICE_TABLE(pci, pwm_lpss_pci_ids);
diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c
index e979825..0d37592 100644
--- a/drivers/pwm/pwm-lpss.c
+++ b/drivers/pwm/pwm-lpss.c
@@ -47,6 +47,12 @@ const struct pwm_lpss_boardinfo pwm_lpss_bsw_info = {
 };
 EXPORT_SYMBOL_GPL(pwm_lpss_bsw_info);
 
+/* Broxton */
+const struct pwm_lpss_boardinfo pwm_lpss_bxt_info = {
+	.clk_rate = 19200000
+};
+EXPORT_SYMBOL_GPL(pwm_lpss_bxt_info);
+
 static inline struct pwm_lpss_chip *to_lpwm(struct pwm_chip *chip)
 {
 	return container_of(chip, struct pwm_lpss_chip, chip);
diff --git a/drivers/pwm/pwm-lpss.h b/drivers/pwm/pwm-lpss.h
index aa041bb..af78137 100644
--- a/drivers/pwm/pwm-lpss.h
+++ b/drivers/pwm/pwm-lpss.h
@@ -24,6 +24,7 @@ struct pwm_lpss_boardinfo {
 
 extern const struct pwm_lpss_boardinfo pwm_lpss_byt_info;
 extern const struct pwm_lpss_boardinfo pwm_lpss_bsw_info;
+extern const struct pwm_lpss_boardinfo pwm_lpss_bxt_info;
 
 struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, struct resource *r,
 				     const struct pwm_lpss_boardinfo *info);
-- 
1.8.3.2

Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform

[Mika Westerberg]

On Thu, Mar 12, 2015 at 01:17:31AM +0800, qipeng.zha wrote:
> From: "qipeng.zha" <qipeng.zha@intel.com>
> 
> Add pci device id for Broxton platform.
> 
> Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
> ---
>  drivers/pwm/pwm-lpss-pci.c | 2 ++
>  drivers/pwm/pwm-lpss.c     | 6 ++++++
>  drivers/pwm/pwm-lpss.h     | 1 +
>  3 files changed, 9 insertions(+)
> 
> diff --git a/drivers/pwm/pwm-lpss-pci.c b/drivers/pwm/pwm-lpss-pci.c
> index cf20d2b..ab6c84e 100644
> --- a/drivers/pwm/pwm-lpss-pci.c
> +++ b/drivers/pwm/pwm-lpss-pci.c
> @@ -48,6 +48,8 @@ static const struct pci_device_id pwm_lpss_pci_ids[] = {
>  	{ PCI_VDEVICE(INTEL, 0x0f09), (unsigned long)&pwm_lpss_byt_info},
>  	{ PCI_VDEVICE(INTEL, 0x2288), (unsigned long)&pwm_lpss_bsw_info},
>  	{ PCI_VDEVICE(INTEL, 0x2289), (unsigned long)&pwm_lpss_bsw_info},
> +	{ PCI_VDEVICE(INTEL, 0x0AC8), (unsigned long)&pwm_lpss_bxt_info},
> +	{ PCI_VDEVICE(INTEL, 0x1AC8), (unsigned long)&pwm_lpss_bxt_info},

Please keep these sorted by device id.

>  	{ },
>  };
>  MODULE_DEVICE_TABLE(pci, pwm_lpss_pci_ids);
> diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c
> index e979825..0d37592 100644
> --- a/drivers/pwm/pwm-lpss.c
> +++ b/drivers/pwm/pwm-lpss.c
> @@ -47,6 +47,12 @@ const struct pwm_lpss_boardinfo pwm_lpss_bsw_info = {
>  };
>  EXPORT_SYMBOL_GPL(pwm_lpss_bsw_info);
>  
> +/* Broxton */
> +const struct pwm_lpss_boardinfo pwm_lpss_bxt_info = {
> +	.clk_rate = 19200000
> +};
> +EXPORT_SYMBOL_GPL(pwm_lpss_bxt_info);

I wonder if we can just reuse pwm_lpss_bsw_info for now as the clock
rate is the same, no?

> +
>  static inline struct pwm_lpss_chip *to_lpwm(struct pwm_chip *chip)
>  {
>  	return container_of(chip, struct pwm_lpss_chip, chip);
> diff --git a/drivers/pwm/pwm-lpss.h b/drivers/pwm/pwm-lpss.h
> index aa041bb..af78137 100644
> --- a/drivers/pwm/pwm-lpss.h
> +++ b/drivers/pwm/pwm-lpss.h
> @@ -24,6 +24,7 @@ struct pwm_lpss_boardinfo {
>  
>  extern const struct pwm_lpss_boardinfo pwm_lpss_byt_info;
>  extern const struct pwm_lpss_boardinfo pwm_lpss_bsw_info;
> +extern const struct pwm_lpss_boardinfo pwm_lpss_bxt_info;
>  
>  struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, struct resource *r,
>  				     const struct pwm_lpss_boardinfo *info);
> -- 
> 1.8.3.2