All of lore.kernel.org
 help / color / mirror / Atom feed
From: Billy Tsai <billy_tsai@aspeedtech.com>
To: Biju Das <biju.das.jz@bp.renesas.com>,
	"jdelvare@suse.com" <jdelvare@suse.com>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"andrew@aj.id.au" <andrew@aj.id.au>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
	BMC-SW <BMC-SW@aspeedtech.com>,
	"garnermic@meta.com" <garnermic@meta.com>
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [v3 2/3] pwm: Add Aspeed ast2600 PWM support
Date: Mon, 7 Nov 2022 08:47:35 +0000	[thread overview]
Message-ID: <C7224BE1-D81E-4FE0-8B7C-5A3CA69898D2@aspeedtech.com> (raw)
In-Reply-To: <OS0PR01MB5922014A7D74A884D2E7BDC286399@OS0PR01MB5922.jpnprd01.prod.outlook.com>

On 2022/11/2, 11:56 PM, "Biju Das" <biju.das.jz@bp.renesas.com> wrote:

    > > +	parent_dev = of_find_device_by_node(np);
    > > +	priv->clk = devm_clk_get_enabled(&parent_dev->dev, NULL);
    > > +	if (IS_ERR(priv->clk))
    > > +		return dev_err_probe(dev, PTR_ERR(priv->clk),
    > > +				     "Couldn't get clock\n");

    > What is the use case?

    > Is pwm configured by boot loader initially ?

    > Or

    > pwm configured by Linux, not by the bootloader initially?

    > Or

    > Driver needs to handle both cases?

    > Just asking, because you are turning on the clock unnecessarily here,
    > If you need to address all the use cases. If it is just first one, then
    > It is ok.

Hi Biju,

The driver want to handle all of the use cases. Can you tell me why turning on the clock
is unnecessarily here?

Thanks

Best Regards,
Billy Tsai




WARNING: multiple messages have this Message-ID (diff)
From: Billy Tsai <billy_tsai@aspeedtech.com>
To: Biju Das <biju.das.jz@bp.renesas.com>,
	"jdelvare@suse.com" <jdelvare@suse.com>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"andrew@aj.id.au" <andrew@aj.id.au>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
	BMC-SW <BMC-SW@aspeedtech.com>,
	"garnermic@meta.com" <garnermic@meta.com>
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [v3 2/3] pwm: Add Aspeed ast2600 PWM support
Date: Mon, 7 Nov 2022 08:47:35 +0000	[thread overview]
Message-ID: <C7224BE1-D81E-4FE0-8B7C-5A3CA69898D2@aspeedtech.com> (raw)
In-Reply-To: <OS0PR01MB5922014A7D74A884D2E7BDC286399@OS0PR01MB5922.jpnprd01.prod.outlook.com>

On 2022/11/2, 11:56 PM, "Biju Das" <biju.das.jz@bp.renesas.com> wrote:

    > > +	parent_dev = of_find_device_by_node(np);
    > > +	priv->clk = devm_clk_get_enabled(&parent_dev->dev, NULL);
    > > +	if (IS_ERR(priv->clk))
    > > +		return dev_err_probe(dev, PTR_ERR(priv->clk),
    > > +				     "Couldn't get clock\n");

    > What is the use case?

    > Is pwm configured by boot loader initially ?

    > Or

    > pwm configured by Linux, not by the bootloader initially?

    > Or

    > Driver needs to handle both cases?

    > Just asking, because you are turning on the clock unnecessarily here,
    > If you need to address all the use cases. If it is just first one, then
    > It is ok.

Hi Biju,

The driver want to handle all of the use cases. Can you tell me why turning on the clock
is unnecessarily here?

Thanks

Best Regards,
Billy Tsai



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-11-07  8:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02  8:35 [v3 0/3] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2022-11-02  8:35 ` Billy Tsai
2022-11-02  8:35 ` [v3 1/3] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai
2022-11-02  8:35   ` Billy Tsai
2022-11-02 17:43   ` Rob Herring
2022-11-02 17:43     ` Rob Herring
2022-11-02 21:31   ` Krzysztof Kozlowski
2022-11-02 21:31     ` Krzysztof Kozlowski
2022-11-02  8:36 ` [v3 2/3] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2022-11-02  8:36   ` Billy Tsai
2022-11-02 15:56   ` Biju Das
2022-11-02 15:56     ` Biju Das
2022-11-07  8:47     ` Billy Tsai [this message]
2022-11-07  8:47       ` Billy Tsai
2022-11-07  8:55       ` Biju Das
2022-11-07  8:55         ` Biju Das
2022-11-07  9:25         ` Billy Tsai
2022-11-07  9:25           ` Billy Tsai
2022-11-07  9:31           ` Biju Das
2022-11-07  9:31             ` Biju Das
2022-11-07  9:38             ` Biju Das
2022-11-07  9:38               ` Biju Das
2022-11-02  8:36 ` [v3 3/3] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2022-11-02  8:36   ` Billy Tsai
2022-11-02  9:37   ` Christophe JAILLET
2022-11-02  9:37     ` Christophe JAILLET
2022-11-02  9:42     ` Billy Tsai
2022-11-02  9:42       ` Billy Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C7224BE1-D81E-4FE0-8B7C-5A3CA69898D2@aspeedtech.com \
    --to=billy_tsai@aspeedtech.com \
    --cc=BMC-SW@aspeedtech.com \
    --cc=andrew@aj.id.au \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=garnermic@meta.com \
    --cc=jdelvare@suse.com \
    --cc=joel@jms.id.au \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkp@intel.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.