All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mohammed, Afzal" <afzal@ti.com>
To: "Hunter, Jon" <jon-hunter@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Hiremath, Vaibhav" <hvaibhav@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion
Date: Wed, 28 Mar 2012 05:04:51 +0000	[thread overview]
Message-ID: <C8443D0743D26F4388EA172BF4E2A7A9317BFECE@DBDE01.ent.ti.com> (raw)
In-Reply-To: <4F71DD6C.5010305@ti.com>

Hi Jon,

On Tue, Mar 27, 2012 at 21:01:56, Hunter, Jon wrote:
> > These are for the peripheral resources not in control of GPMC, like
> > gpio irq. These are copied in gpmc_create_child.
> 
> Right, I see they are copied during gpmc_create_child. However, I don't 
> see where they are initialised before that. The function 
> gpmc_setup_child is only initialising gpmc_res and gpmc_num_res and not 
> res and num_res. So I still don't see who is initialising these before 
> they are copied.

These are to be initialized by platform code, NAND have none so is
not currently seen, but devices like ethernet have to.

 
> I see you did not incorporate any clean-up in v2. Do you want me to send 
> you some patches to include?

Thanks for offering to help.

Cleanup is being deferred to be done once driver is finalized, I may
need your help later.

Regards
Afzal

WARNING: multiple messages have this Message-ID (diff)
From: afzal@ti.com (Mohammed, Afzal)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion
Date: Wed, 28 Mar 2012 05:04:51 +0000	[thread overview]
Message-ID: <C8443D0743D26F4388EA172BF4E2A7A9317BFECE@DBDE01.ent.ti.com> (raw)
In-Reply-To: <4F71DD6C.5010305@ti.com>

Hi Jon,

On Tue, Mar 27, 2012 at 21:01:56, Hunter, Jon wrote:
> > These are for the peripheral resources not in control of GPMC, like
> > gpio irq. These are copied in gpmc_create_child.
> 
> Right, I see they are copied during gpmc_create_child. However, I don't 
> see where they are initialised before that. The function 
> gpmc_setup_child is only initialising gpmc_res and gpmc_num_res and not 
> res and num_res. So I still don't see who is initialising these before 
> they are copied.

These are to be initialized by platform code, NAND have none so is
not currently seen, but devices like ethernet have to.

 
> I see you did not incorporate any clean-up in v2. Do you want me to send 
> you some patches to include?

Thanks for offering to help.

Cleanup is being deferred to be done once driver is finalized, I may
need your help later.

Regards
Afzal

  reply	other threads:[~2012-03-28  5:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23  6:36 [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion Afzal Mohammed
2012-03-23  6:36 ` Afzal Mohammed
2012-03-23  9:37 ` Cousson, Benoit
2012-03-23  9:37   ` Cousson, Benoit
2012-03-23 10:20   ` Mohammed, Afzal
2012-03-23 10:20     ` Mohammed, Afzal
2012-03-23 15:39     ` Cousson, Benoit
2012-03-23 15:39       ` Cousson, Benoit
2012-03-23 16:29       ` Felipe Balbi
2012-03-23 16:29         ` Felipe Balbi
2012-03-26  6:14         ` Mohammed, Afzal
2012-03-26  6:14           ` Mohammed, Afzal
2012-03-26  6:03       ` Mohammed, Afzal
2012-03-26  6:03         ` Mohammed, Afzal
2012-03-23 23:21 ` Jon Hunter
2012-03-23 23:21   ` Jon Hunter
2012-03-26  8:04   ` Mohammed, Afzal
2012-03-26  8:04     ` Mohammed, Afzal
2012-03-26 17:42     ` Jon Hunter
2012-03-26 17:42       ` Jon Hunter
2012-03-27  5:12       ` Mohammed, Afzal
2012-03-27  5:12         ` Mohammed, Afzal
2012-03-27 15:31         ` Jon Hunter
2012-03-27 15:31           ` Jon Hunter
2012-03-28  5:04           ` Mohammed, Afzal [this message]
2012-03-28  5:04             ` Mohammed, Afzal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C8443D0743D26F4388EA172BF4E2A7A9317BFECE@DBDE01.ent.ti.com \
    --to=afzal@ti.com \
    --cc=hvaibhav@ti.com \
    --cc=jon-hunter@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.