[PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects

[PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects

[David Heidelberg]

IPA v4.5 interconnects was missing from dt-schema, which was trigering
warnings while validation.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index b8a0b392b24e..a2835ed52076 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -95,6 +95,11 @@ properties:
           - description: Path leading to system memory
           - description: Path leading to internal memory
           - description: Path between the AP and IPA config space
+      - items: # IPA v4.5
+          - description: Path leading to system memory region A
+          - description: Path leading to system memory region B
+          - description: Path leading to internal memory
+          - description: Path between the AP and IPA config space
 
   interconnect-names:
     oneOf:
@@ -105,6 +110,11 @@ properties:
           - const: memory
           - const: imem
           - const: config
+      - items: # IPA v4.5
+          - const: memory-a
+          - const: memory-b
+          - const: imem
+          - const: config
 
   qcom,smem-states:
     $ref: /schemas/types.yaml#/definitions/phandle-array
-- 
2.33.0

[PATCH 2/2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus

[David Heidelberg]

Fix warnings as:
arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@1e40000: iommus: [[21, 1504, 0], [21, 1506, 0]] is too long
	From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index a2835ed52076..775b0f94504a 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -64,7 +64,7 @@ properties:
       - const: gsi
 
   iommus:
-    maxItems: 1
+    maxItems: 2
 
   clocks:
     maxItems: 1
-- 
2.33.0

Re: [PATCH 2/2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus

[Rob Herring]

On Thu, 21 Oct 2021 00:54:35 +0200, David Heidelberg wrote:
> Fix warnings as:
> arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@1e40000: iommus: [[21, 1504, 0], [21, 1506, 0]] is too long
> 	From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipa.example.dt.yaml: ipa@1e40000: iommus: [[4294967295, 1824, 3]] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipa.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1544063

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

Re: [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects

[Alex Elder]

On 10/20/21 5:54 PM, David Heidelberg wrote:
> IPA v4.5 interconnects was missing from dt-schema, which was trigering
> warnings while validation.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>

Sorry about that.  This is actually not correct, because
the DTS file is not correct.  I've been meaning to fix it
but didn't want to commit the change until I had actually
tested it.

The DTS file was sent out before I had a better understanding
of what it was supposed to represent.

I will put a priority on fixing the DTS file soon.

					-Alex

> ---
>   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index b8a0b392b24e..a2835ed52076 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -95,6 +95,11 @@ properties:
>             - description: Path leading to system memory
>             - description: Path leading to internal memory
>             - description: Path between the AP and IPA config space
> +      - items: # IPA v4.5
> +          - description: Path leading to system memory region A
> +          - description: Path leading to system memory region B
> +          - description: Path leading to internal memory
> +          - description: Path between the AP and IPA config space
>   
>     interconnect-names:
>       oneOf:
> @@ -105,6 +110,11 @@ properties:
>             - const: memory
>             - const: imem
>             - const: config
> +      - items: # IPA v4.5
> +          - const: memory-a
> +          - const: memory-b
> +          - const: imem
> +          - const: config
>   
>     qcom,smem-states:
>       $ref: /schemas/types.yaml#/definitions/phandle-array
> 

Re: [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects

[Alex Elder]

On 10/20/21 5:54 PM, David Heidelberg wrote:
> IPA v4.5 interconnects was missing from dt-schema, which was trigering
> warnings while validation.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>

Can you please tell me a command to use to trigger
the warnings you are seeing?  I don't see an error
when building "dtbs" or doing "dt_binding_check".

Thanks.

					-Alex

> ---
>   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index b8a0b392b24e..a2835ed52076 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -95,6 +95,11 @@ properties:
>             - description: Path leading to system memory
>             - description: Path leading to internal memory
>             - description: Path between the AP and IPA config space
> +      - items: # IPA v4.5
> +          - description: Path leading to system memory region A
> +          - description: Path leading to system memory region B
> +          - description: Path leading to internal memory
> +          - description: Path between the AP and IPA config space
>   
>     interconnect-names:
>       oneOf:
> @@ -105,6 +110,11 @@ properties:
>             - const: memory
>             - const: imem
>             - const: config
> +      - items: # IPA v4.5
> +          - const: memory-a
> +          - const: memory-b
> +          - const: imem
> +          - const: config
>   
>     qcom,smem-states:
>       $ref: /schemas/types.yaml#/definitions/phandle-array
> 

Re: [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects

[Alex Elder]

On 10/20/21 5:54 PM, David Heidelberg wrote:
> IPA v4.5 interconnects was missing from dt-schema, which was trigering
> warnings while validation.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>

Can you please tell me a command to use to trigger
the warnings you are seeing?  I don't see an error
when building "dtbs" or doing "dt_binding_check".

Thanks.

					-Alex

> ---
>   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index b8a0b392b24e..a2835ed52076 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -95,6 +95,11 @@ properties:
>             - description: Path leading to system memory
>             - description: Path leading to internal memory
>             - description: Path between the AP and IPA config space
> +      - items: # IPA v4.5
> +          - description: Path leading to system memory region A
> +          - description: Path leading to system memory region B
> +          - description: Path leading to internal memory
> +          - description: Path between the AP and IPA config space
>   
>     interconnect-names:
>       oneOf:
> @@ -105,6 +110,11 @@ properties:
>             - const: memory
>             - const: imem
>             - const: config
> +      - items: # IPA v4.5
> +          - const: memory-a
> +          - const: memory-b
> +          - const: imem
> +          - const: config
>   
>     qcom,smem-states:
>       $ref: /schemas/types.yaml#/definitions/phandle-array
> 

Re: [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects

[David Heidelberg]

Hello Alex,

it's make dtbs_check (for me with ARCH=arm)

David


-------- Původní zpráva --------
Odesílatel: Alex Elder <elder@ieee.org>
Odesláno: 21. října 2021 20:35:14 UTC
Komu: David Heidelberg <david@ixit.cz>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Rob Herring <robh+dt@kernel.org>, Alex Elder <elder@kernel.org>
Kopie: ~okias/devicetree@lists.sr.ht, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Předmět: Re: [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects

On 10/20/21 5:54 PM, David Heidelberg wrote:
> IPA v4.5 interconnects was missing from dt-schema, which was trigering
> warnings while validation.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>

Can you please tell me a command to use to trigger
the warnings you are seeing?  I don't see an error
when building "dtbs" or doing "dt_binding_check".

Thanks.

					-Alex

> ---
>   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index b8a0b392b24e..a2835ed52076 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -95,6 +95,11 @@ properties:
>             - description: Path leading to system memory
>             - description: Path leading to internal memory
>             - description: Path between the AP and IPA config space
> +      - items: # IPA v4.5
> +          - description: Path leading to system memory region A
> +          - description: Path leading to system memory region B
> +          - description: Path leading to internal memory
> +          - description: Path between the AP and IPA config space
>       interconnect-names:
>       oneOf:
> @@ -105,6 +110,11 @@ properties:
>             - const: memory
>             - const: imem
>             - const: config
> +      - items: # IPA v4.5
> +          - const: memory-a
> +          - const: memory-b
> +          - const: imem
> +          - const: config
>       qcom,smem-states:
>       $ref: /schemas/types.yaml#/definitions/phandle-array
> 

Re: [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects

[Alex Elder]

On 10/21/21 5:11 PM, David Heidelberg wrote:
> Hello Alex,
> 
> it's make dtbs_check (for me with ARCH=arm)
> 
> David

Thank you, I see the errors now.  I am gathering information
so I can fix the interconnect issue for IPA v4.5 (SDX55).

Your other suggested change (increasing the allowed number of
iommus) is the right thing to do, but it seems you need to
specify "minItems = 1" as well to avoid the error Rob pointed
out.  You should post version two of that patch (only), or if
you would prefer I do that, say so.

Another error that shows up is that no "qcom,smp2p" schema
matches.  I'm pretty sure that's simply because the binding
"soc/qcom/qcom,smp2p.txt" has not bee converted to YAML.

					-Alex

Re: [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects

[David Heidelberg]

Hello,

sent fixed version "[PATCH v2] dt-bindings: net: qcom,ipa: IPA does 
support up to two iommus".

Thank you Alex

David

P.S. I have some basic structure for qcom,smp2p.yaml, but to make it 
right take some effort. If someone want to, I can send it as WIP or 
just into private email.
Best regards
David Heidelberg

On Tue, Oct 26 2021 at 09:17:43 -0500, Alex Elder <elder@ieee.org> 
wrote:
> On 10/21/21 5:11 PM, David Heidelberg wrote:
>> Hello Alex,
>> 
>> it's make dtbs_check (for me with ARCH=arm)
>> 
>> David
> 
> Thank you, I see the errors now.  I am gathering information
> so I can fix the interconnect issue for IPA v4.5 (SDX55).
> 
> Your other suggested change (increasing the allowed number of
> iommus) is the right thing to do, but it seems you need to
> specify "minItems = 1" as well to avoid the error Rob pointed
> out.  You should post version two of that patch (only), or if
> you would prefer I do that, say so.
> 
> Another error that shows up is that no "qcom,smp2p" schema
> matches.  I'm pretty sure that's simply because the binding
> "soc/qcom/qcom,smp2p.txt" has not bee converted to YAML.
> 
> 					-Alex