* [PATCH] add placeholder for packet extension to block interface
@ 2010-12-22 10:10 Jan Beulich
2010-12-22 11:19 ` Keir Fraser
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2010-12-22 10:10 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
While the corresponding implementation has been in our trees for quite
a while, it's in a state that doesn't make it suitable for submission,
and the original author having left the company leaves open to find
someone to complete this work. Yet to prevent problems with other
interface extensions we'd like to keep the slot in the number space
reserved for the purpose it has been serving here.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- a/xen/include/public/io/blkif.h
+++ b/xen/include/public/io/blkif.h
@@ -76,6 +76,10 @@
* "feature-flush-cache" node!
*/
#define BLKIF_OP_FLUSH_DISKCACHE 3
+/*
+ * Device specific command packet contained within the request
+ */
+#define BLKIF_OP_PACKET 4
/*
* Maximum scatter/gather segments per request.
[-- Attachment #2: xen-blkif-op-packet-placeholder.patch --]
[-- Type: text/plain, Size: 800 bytes --]
While the corresponding implementation has been in our trees for quite
a while, it's in a state that doesn't make it suitable for submission,
and the original author having left the company leaves open to find
someone to complete this work. Yet to prevent problems with other
interface extensions we'd like to keep the slot in the number space
reserved for the purpose it has been serving here.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- a/xen/include/public/io/blkif.h
+++ b/xen/include/public/io/blkif.h
@@ -76,6 +76,10 @@
* "feature-flush-cache" node!
*/
#define BLKIF_OP_FLUSH_DISKCACHE 3
+/*
+ * Device specific command packet contained within the request
+ */
+#define BLKIF_OP_PACKET 4
/*
* Maximum scatter/gather segments per request.
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] add placeholder for packet extension to block interface
2010-12-22 10:10 [PATCH] add placeholder for packet extension to block interface Jan Beulich
@ 2010-12-22 11:19 ` Keir Fraser
2010-12-22 11:55 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Keir Fraser @ 2010-12-22 11:19 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 22/12/2010 10:10, "Jan Beulich" <JBeulich@novell.com> wrote:
> While the corresponding implementation has been in our trees for quite
> a while, it's in a state that doesn't make it suitable for submission,
> and the original author having left the company leaves open to find
> someone to complete this work. Yet to prevent problems with other
> interface extensions we'd like to keep the slot in the number space
> reserved for the purpose it has been serving here.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -76,6 +76,10 @@
> * "feature-flush-cache" node!
> */
> #define BLKIF_OP_FLUSH_DISKCACHE 3
> +/*
> + * Device specific command packet contained within the request
> + */
> +#define BLKIF_OP_PACKET 4
Without more details, perhaps it would be better to call this
BLKIF_OP_RESERVED_1 or BLKIF_OP_RESERVED_NOVELL. It makes it clearer what is
going on (used internally by Novell for feature not yet submitted upstream),
and the name can be changed to BLKIF_OP_PACKET if the support ever gets
cleaned up and accepted.
-- Keir
> /*
> * Maximum scatter/gather segments per request.
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] add placeholder for packet extension to block interface
2010-12-22 11:19 ` Keir Fraser
@ 2010-12-22 11:55 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2010-12-22 11:55 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel
[-- Attachment #1: Type: text/plain, Size: 2157 bytes --]
>>> On 22.12.10 at 12:19, Keir Fraser <keir@xen.org> wrote:
> On 22/12/2010 10:10, "Jan Beulich" <JBeulich@novell.com> wrote:
>
>> While the corresponding implementation has been in our trees for quite
>> a while, it's in a state that doesn't make it suitable for submission,
>> and the original author having left the company leaves open to find
>> someone to complete this work. Yet to prevent problems with other
>> interface extensions we'd like to keep the slot in the number space
>> reserved for the purpose it has been serving here.
>>
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>>
>> --- a/xen/include/public/io/blkif.h
>> +++ b/xen/include/public/io/blkif.h
>> @@ -76,6 +76,10 @@
>> * "feature-flush-cache" node!
>> */
>> #define BLKIF_OP_FLUSH_DISKCACHE 3
>> +/*
>> + * Device specific command packet contained within the request
>> + */
>> +#define BLKIF_OP_PACKET 4
>
> Without more details, perhaps it would be better to call this
> BLKIF_OP_RESERVED_1 or BLKIF_OP_RESERVED_NOVELL. It makes it clearer what is
> going on (used internally by Novell for feature not yet submitted upstream),
> and the name can be changed to BLKIF_OP_PACKET if the support ever gets
> cleaned up and accepted.
How about this one then?
While the corresponding implementation has been in our trees for quite
a while, it's in a state that doesn't make it suitable for submission,
and the original author having left the company leaves open to find
someone to complete this work. Yet to prevent problems with other
interface extensions we'd like to keep the slot in the number space
reserved for the purpose it has been serving here.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- a/xen/include/public/io/blkif.h
+++ b/xen/include/public/io/blkif.h
@@ -76,6 +76,11 @@
* "feature-flush-cache" node!
*/
#define BLKIF_OP_FLUSH_DISKCACHE 3
+/*
+ * Used in SLES sources for device specific command packet
+ * contained within the request. Reserved for that purpose.
+ */
+#define BLKIF_OP_RESERVED_1 4
/*
* Maximum scatter/gather segments per request.
[-- Attachment #2: xen-blkif-op-packet-placeholder.patch --]
[-- Type: text/plain, Size: 858 bytes --]
While the corresponding implementation has been in our trees for quite
a while, it's in a state that doesn't make it suitable for submission,
and the original author having left the company leaves open to find
someone to complete this work. Yet to prevent problems with other
interface extensions we'd like to keep the slot in the number space
reserved for the purpose it has been serving here.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- a/xen/include/public/io/blkif.h
+++ b/xen/include/public/io/blkif.h
@@ -76,6 +76,11 @@
* "feature-flush-cache" node!
*/
#define BLKIF_OP_FLUSH_DISKCACHE 3
+/*
+ * Used in SLES sources for device specific command packet
+ * contained within the request. Reserved for that purpose.
+ */
+#define BLKIF_OP_RESERVED_1 4
/*
* Maximum scatter/gather segments per request.
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-22 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-22 10:10 [PATCH] add placeholder for packet extension to block interface Jan Beulich
2010-12-22 11:19 ` Keir Fraser
2010-12-22 11:55 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.