From: Jim Quinlan <james.quinlan@broadcom.com> To: Bjorn Helgaas <helgaas@kernel.org> Cc: "Jim Quinlan" <jim2101024@gmail.com>, "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" <linux-pci@vger.kernel.org>, "Nicolas Saenz Julienne" <nsaenz@kernel.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Cyril Brulebois" <kibi@debian.org>, "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" <bcm-kernel-feedback-list@broadcom.com>, "Krzysztof Wilczyński" <kw@linux.com>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, "open list" <linux-kernel@vger.kernel.org>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@lists.infradead.org>, "Rob Herring" <robh@kernel.org> Subject: Re: [PATCH v1 0/4] PCI: brcmstb: Re-submit reverted patchset Date: Fri, 15 Jul 2022 14:30:27 -0400 [thread overview] Message-ID: <CA+-6iNxb=QAUFb=sYLetQTGzYu8zkPRSdA1tWutE90tt6KhzzA@mail.gmail.com> (raw) In-Reply-To: <20220715182715.GA1145359@bhelgaas> [-- Attachment #1: Type: text/plain, Size: 1405 bytes --] On Fri, Jul 15, 2022 at 2:27 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > On Fri, Jul 01, 2022 at 12:27:21PM -0400, Jim Quinlan wrote: > > A submission [1] was made to enable a PCIe root port to turn on regulators > > for downstream devices. It was accepted. Months later, a regression was > > discovered on an RPi CM4 [2]. The patchset was reverted [3] as the fix > > came too late in the release cycle. The regression in question is > > triggered only when the PCIe RC DT node has no root port subnode, which is > > a perfectly reasonsable configuration. > > ... > > > Jim Quinlan (4): > > PCI: brcmstb: Split brcm_pcie_setup() into two funcs > > PCI: brcmstb: Add mechanism to turn on subdev regulators > > PCI: brcmstb: oAdd control of subdevice voltage regulators > > PCI: brcmstb: Do not turn off WOL regulators on suspend > > > > drivers/pci/controller/pcie-brcmstb.c | 257 +++++++++++++++++++++++--- > > 1 file changed, 227 insertions(+), 30 deletions(-) > > I'm assuming there's a v2 coming soonish? We should see -rc7 this > weekend and likely a final v5.19 release on July 24, so v5.20 material > should be tidied up by then. Hi Bjorn, Yes, it has been ready for a few days but I am bumping into unrelated issues while trying to do suspend/resume tests with the latest upstream. Hopefully I will send it out tonight or this WE. Regards, Jim Quinlan Broadcom STB > > Bjorn [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4210 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jim Quinlan <james.quinlan@broadcom.com> To: Bjorn Helgaas <helgaas@kernel.org> Cc: "Jim Quinlan" <jim2101024@gmail.com>, "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" <linux-pci@vger.kernel.org>, "Nicolas Saenz Julienne" <nsaenz@kernel.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Cyril Brulebois" <kibi@debian.org>, "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" <bcm-kernel-feedback-list@broadcom.com>, "Krzysztof Wilczyński" <kw@linux.com>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, "open list" <linux-kernel@vger.kernel.org>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@lists.infradead.org>, "Rob Herring" <robh@kernel.org> Subject: Re: [PATCH v1 0/4] PCI: brcmstb: Re-submit reverted patchset Date: Fri, 15 Jul 2022 14:30:27 -0400 [thread overview] Message-ID: <CA+-6iNxb=QAUFb=sYLetQTGzYu8zkPRSdA1tWutE90tt6KhzzA@mail.gmail.com> (raw) In-Reply-To: <20220715182715.GA1145359@bhelgaas> [-- Attachment #1.1: Type: text/plain, Size: 1405 bytes --] On Fri, Jul 15, 2022 at 2:27 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > On Fri, Jul 01, 2022 at 12:27:21PM -0400, Jim Quinlan wrote: > > A submission [1] was made to enable a PCIe root port to turn on regulators > > for downstream devices. It was accepted. Months later, a regression was > > discovered on an RPi CM4 [2]. The patchset was reverted [3] as the fix > > came too late in the release cycle. The regression in question is > > triggered only when the PCIe RC DT node has no root port subnode, which is > > a perfectly reasonsable configuration. > > ... > > > Jim Quinlan (4): > > PCI: brcmstb: Split brcm_pcie_setup() into two funcs > > PCI: brcmstb: Add mechanism to turn on subdev regulators > > PCI: brcmstb: oAdd control of subdevice voltage regulators > > PCI: brcmstb: Do not turn off WOL regulators on suspend > > > > drivers/pci/controller/pcie-brcmstb.c | 257 +++++++++++++++++++++++--- > > 1 file changed, 227 insertions(+), 30 deletions(-) > > I'm assuming there's a v2 coming soonish? We should see -rc7 this > weekend and likely a final v5.19 release on July 24, so v5.20 material > should be tidied up by then. Hi Bjorn, Yes, it has been ready for a few days but I am bumping into unrelated issues while trying to do suspend/resume tests with the latest upstream. Hopefully I will send it out tonight or this WE. Regards, Jim Quinlan Broadcom STB > > Bjorn [-- Attachment #1.2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4210 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-15 18:30 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-01 16:27 [PATCH v1 0/4] PCI: brcmstb: Re-submit reverted patchset Jim Quinlan 2022-07-01 16:27 ` Jim Quinlan 2022-07-01 16:27 ` [PATCH v1 1/4] PCI: brcmstb: Split brcm_pcie_setup() into two funcs Jim Quinlan 2022-07-01 16:27 ` Jim Quinlan 2022-07-06 21:56 ` Bjorn Helgaas 2022-07-06 21:56 ` Bjorn Helgaas 2022-07-08 13:29 ` Jim Quinlan 2022-07-08 13:29 ` Jim Quinlan 2022-07-08 19:04 ` Bjorn Helgaas 2022-07-08 19:04 ` Bjorn Helgaas 2022-07-08 19:40 ` Jim Quinlan 2022-07-08 19:40 ` Jim Quinlan 2022-07-08 19:59 ` Bjorn Helgaas 2022-07-08 19:59 ` Bjorn Helgaas 2022-07-08 20:38 ` Jim Quinlan 2022-07-08 20:38 ` Jim Quinlan 2022-07-08 22:27 ` Bjorn Helgaas 2022-07-08 22:27 ` Bjorn Helgaas 2022-07-01 16:27 ` [PATCH v1 2/4] PCI: brcmstb: Add mechanism to turn on subdev regulators Jim Quinlan 2022-07-01 16:27 ` Jim Quinlan 2022-07-06 23:12 ` Bjorn Helgaas 2022-07-06 23:12 ` Bjorn Helgaas 2022-07-08 14:14 ` Jim Quinlan 2022-07-08 14:14 ` Jim Quinlan 2022-07-08 19:07 ` Bjorn Helgaas 2022-07-08 19:07 ` Bjorn Helgaas 2022-07-01 16:27 ` [PATCH v1 3/4] PCI: brcmstb: Add control of subdevice voltage regulators Jim Quinlan 2022-07-01 16:27 ` Jim Quinlan 2022-07-06 23:13 ` Bjorn Helgaas 2022-07-06 23:13 ` Bjorn Helgaas 2022-07-08 15:16 ` Jim Quinlan 2022-07-08 15:16 ` Jim Quinlan 2022-07-08 19:09 ` Bjorn Helgaas 2022-07-08 19:09 ` Bjorn Helgaas 2022-07-01 16:27 ` [PATCH v1 4/4] PCI: brcmstb: Do not turn off WOL regulators on suspend Jim Quinlan 2022-07-01 16:27 ` Jim Quinlan 2022-07-01 20:58 ` [PATCH v1 0/4] PCI: brcmstb: Re-submit reverted patchset Florian Fainelli 2022-07-01 20:58 ` Florian Fainelli 2022-07-05 20:55 ` Cyril Brulebois 2022-07-05 20:55 ` Cyril Brulebois 2022-07-05 21:00 ` Florian Fainelli 2022-07-05 21:00 ` Florian Fainelli 2022-07-05 21:28 ` Cyril Brulebois 2022-07-05 21:28 ` Cyril Brulebois 2022-07-05 22:06 ` Jim Quinlan 2022-07-05 22:06 ` Jim Quinlan 2022-07-15 18:27 ` Bjorn Helgaas 2022-07-15 18:27 ` Bjorn Helgaas 2022-07-15 18:30 ` Jim Quinlan [this message] 2022-07-15 18:30 ` Jim Quinlan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+-6iNxb=QAUFb=sYLetQTGzYu8zkPRSdA1tWutE90tt6KhzzA@mail.gmail.com' \ --to=james.quinlan@broadcom.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=bhelgaas@google.com \ --cc=helgaas@kernel.org \ --cc=jim2101024@gmail.com \ --cc=kibi@debian.org \ --cc=kw@linux.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=nsaenz@kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.