[Buildroot] [PATCH 1/1] fwup: blanked out MANS to avoid running help2man

[Buildroot] [PATCH 1/1] fwup: blanked out MANS to avoid running help2man

[Jordan Yelloz]

If you have help2man installed, the build system will try to run
help2man on the target fwup binary which should not be expected to work.

Signed-off-by: Jordan Yelloz <jordan@yelloz.me>
---
 package/fwup/fwup.mk | 2 ++
 1 file changed, 2 insertions(+)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fwup-blanked-out-MANS-to-avoid-running-help2man.patch
Type: text/x-patch
Size: 395 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160612/26a6b41a/attachment.bin>

[Buildroot] [PATCH v2 1/1] fwup: blanked out MANS to avoid running help2man

[Jordan Yelloz]

If you have help2man installed, the build system will try to run
help2man on the target fwup binary which should not be expected to work.

Signed-off-by: Jordan Yelloz <jordan@yelloz.me>
---
 package/fwup/fwup.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk
index 0f857fc..f960e36 100644
--- a/package/fwup/fwup.mk
+++ b/package/fwup/fwup.mk
@@ -10,6 +10,8 @@ FWUP_LICENSE = Apache-2.0
 FWUP_LICENSE_FILES = LICENSE
 FWUP_DEPENDENCIES = libconfuse libarchive libsodium
 FWUP_AUTORECONF = YES
+FWUP_MAKE_OPTS = MANS=
+FWUP_INSTALL_TARGET_OPTS = MANS=
 
 define FWUP_ADD_M4_DIR
 	mkdir -p $(@D)/m4
-- 
2.8.4

[Buildroot] [PATCH v3 1/1] fwup: blanked out MANS to avoid running help2man

[Jordan Yelloz]

If you have help2man installed, the build system will try to run
help2man on the target fwup binary which should not be expected to work.

Also, prevented anything but the fwup binary from being installed.

Signed-off-by: Jordan Yelloz <jordan@yelloz.me>
---
 package/fwup/fwup.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk
index 0f857fc..26463e2 100644
--- a/package/fwup/fwup.mk
+++ b/package/fwup/fwup.mk
@@ -10,6 +10,8 @@ FWUP_LICENSE = Apache-2.0
 FWUP_LICENSE_FILES = LICENSE
 FWUP_DEPENDENCIES = libconfuse libarchive libsodium
 FWUP_AUTORECONF = YES
+FWUP_MAKE_OPTS = MANS=
+FWUP_INSTALL_TARGET_OPTS = install-exec DESTDIR=$(TARGET_DIR)
 
 define FWUP_ADD_M4_DIR
 	mkdir -p $(@D)/m4
-- 
2.8.4

[Buildroot] [PATCH v3 1/1] fwup: blanked out MANS to avoid running help2man

[Frank Hunleth]

Hi Jordan,

On Mon, Jun 13, 2016 at 1:26 AM, Jordan Yelloz <jordan@yelloz.me> wrote:
> If you have help2man installed, the build system will try to run
> help2man on the target fwup binary which should not be expected to work.
>
> Also, prevented anything but the fwup binary from being installed.
>
> Signed-off-by: Jordan Yelloz <jordan@yelloz.me>
> ---
>  package/fwup/fwup.mk | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk
> index 0f857fc..26463e2 100644
> --- a/package/fwup/fwup.mk
> +++ b/package/fwup/fwup.mk
> @@ -10,6 +10,8 @@ FWUP_LICENSE = Apache-2.0
>  FWUP_LICENSE_FILES = LICENSE
>  FWUP_DEPENDENCIES = libconfuse libarchive libsodium
>  FWUP_AUTORECONF = YES
> +FWUP_MAKE_OPTS = MANS=

How about the following for disabling 'help2man'?

# help2man doesn't work when cross compiling
FWUP_CONF_ENV = ac_cv_path_HELP2MAN=''

This is similar to what's done for the torsmo package, and it seems a
little more obvious in purpose.

> +FWUP_INSTALL_TARGET_OPTS = install-exec DESTDIR=$(TARGET_DIR)

The only other file that should be installed is the bash completions
file. That's automatically removed from the target unless you have
bash enabled.

>
>  define FWUP_ADD_M4_DIR
>         mkdir -p $(@D)/m4
> --
> 2.8.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 1/1] fwup: blanked out MANS to avoid running help2man

[Jordan Yelloz]

On 06/13/2016 02:51 PM, Frank Hunleth wrote:
> Hi Jordan,
> 
> How about the following for disabling 'help2man'?
> 
> # help2man doesn't work when cross compiling
> FWUP_CONF_ENV = ac_cv_path_HELP2MAN=''
> 
> This is similar to what's done for the torsmo package, and it seems a
> little more obvious in purpose.
> 

Good point, I will post a new patch with this change instead.

>> +FWUP_INSTALL_TARGET_OPTS = install-exec DESTDIR=$(TARGET_DIR)
> 
> The only other file that should be installed is the bash completions
> file. That's automatically removed from the target unless you have
> bash enabled.
> 

This was actually necessary with my inferior patch because help2man was
still needed to produce the man page which was part of the `install'
target but with your approach it's no longer needed.

--
Jordan

[Buildroot] [PATCH v4 1/1] fwup: blanked out HELP2MAN_PATH autoconf value

[Jordan Yelloz]

If you have help2man installed, the build system will try to run
help2man on the target fwup binary which should not be expected to work.

Signed-off-by: Jordan Yelloz <jordan@yelloz.me>
---
 package/fwup/fwup.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk
index 0f857fc..814ca00 100644
--- a/package/fwup/fwup.mk
+++ b/package/fwup/fwup.mk
@@ -10,6 +10,7 @@ FWUP_LICENSE = Apache-2.0
 FWUP_LICENSE_FILES = LICENSE
 FWUP_DEPENDENCIES = libconfuse libarchive libsodium
 FWUP_AUTORECONF = YES
+FWUP_CONF_ENV = ac_cv_path_HELP2MAN=
 
 define FWUP_ADD_M4_DIR
 	mkdir -p $(@D)/m4
-- 
2.8.4

[Buildroot] [PATCH v4 1/1] fwup: blanked out HELP2MAN_PATH autoconf value

[Frank Hunleth]

On Mon, Jun 13, 2016 at 6:15 PM, Jordan Yelloz <jordan@yelloz.me> wrote:
> If you have help2man installed, the build system will try to run
> help2man on the target fwup binary which should not be expected to work.
>
> Signed-off-by: Jordan Yelloz <jordan@yelloz.me>
> ---
>  package/fwup/fwup.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk
> index 0f857fc..814ca00 100644
> --- a/package/fwup/fwup.mk
> +++ b/package/fwup/fwup.mk
> @@ -10,6 +10,7 @@ FWUP_LICENSE = Apache-2.0
>  FWUP_LICENSE_FILES = LICENSE
>  FWUP_DEPENDENCIES = libconfuse libarchive libsodium
>  FWUP_AUTORECONF = YES
> +FWUP_CONF_ENV = ac_cv_path_HELP2MAN=

This change fixes the issue with help2man being installed on the host for me.

Tested-by: Frank Hunleth <fhunleth@troodon-software.com>

>
>  define FWUP_ADD_M4_DIR
>         mkdir -p $(@D)/m4
> --
> 2.8.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 1/1] iptables: exported AR=$(TARGET_AR) to make

[Jordan Yelloz]

This ensures the correct AR is used for some of the iptables build
process. This is the same fix as
<https://bugs.gentoo.org/show_bug.cgi?id=444282>

Signed-off-by: Jordan Yelloz <jordan@yelloz.me>
---
 package/iptables/iptables.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/iptables/iptables.mk b/package/iptables/iptables.mk
index 12e00f2..b9feaf5 100644
--- a/package/iptables/iptables.mk
+++ b/package/iptables/iptables.mk
@@ -17,6 +17,7 @@ IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr \
 	$(if $(BR2_STATIC_LIBS),,--disable-static)
 # For 0002-iptables-add-xtables-config-parser.h-to-BUILT_SOURCES.patch
 IPTABLES_AUTORECONF = YES
+IPTABLES_MAKE_ENV = AR=$(TARGET_AR)
 
 # For connlabel match
 ifeq ($(BR2_PACKAGE_LIBNETFILTER_CONNTRACK),y)
-- 
2.8.4

[Buildroot] [PATCH v2 1/1] iptables: exported AR=$(TARGET_AR) to make

[Thomas Petazzoni]

Hello,

On Sun, 12 Jun 2016 20:13:40 -0700, Jordan Yelloz wrote:
> This ensures the correct AR is used for some of the iptables build
> process. This is the same fix as
> <https://bugs.gentoo.org/show_bug.cgi?id=444282>
> 
> Signed-off-by: Jordan Yelloz <jordan@yelloz.me>
> ---
>  package/iptables/iptables.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/iptables/iptables.mk b/package/iptables/iptables.mk
> index 12e00f2..b9feaf5 100644
> --- a/package/iptables/iptables.mk
> +++ b/package/iptables/iptables.mk
> @@ -17,6 +17,7 @@ IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr \
>  	$(if $(BR2_STATIC_LIBS),,--disable-static)
>  # For 0002-iptables-add-xtables-config-parser.h-to-BUILT_SOURCES.patch
>  IPTABLES_AUTORECONF = YES
> +IPTABLES_MAKE_ENV = AR=$(TARGET_AR)

Instead of this fix, I've backported the patch you have submitted
upstream and which has been merged. See:

   https://git.buildroot.org/buildroot/commit/?id=bcfe05a7e9ce49bcc447fd956f52da0032f534e6

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com