Review required for addition of imagefs types (#7828)

Review required for addition of imagefs types (#7828)

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

Hi,

I have created a branch for addition of new imagefs types:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828
( reference: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The
top commit of this branch needs review. Thanks a bunch to Michael and Belen
for helping me figure out the issue of disabling of save button in firefox.

-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c

[-- Attachment #2: Type: text/html, Size: 1151 bytes --]

Re: Review required for addition of imagefs types (#7828)

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 3684 bytes --]

Forgot to add the test case I followed:
1) Added cpio into the imgaefs types along with the default ones. And
triggered the build for core-image-minimal.
2) After the build I could see the below output in
tmp/deploy/images/qemux86 of the build folder:
[sujith@sujith test-poky]$ ls build-toaster-2/tmp/deploy/images/qemux86/ -l
total 76580
lrwxrwxrwx. 1 sujith sujith       71 May 13 04:05 bzImage ->
bzImage--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.bin
-rw-r--r--. 2 sujith sujith  6720720 May 13 04:05
bzImage--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.bin
lrwxrwxrwx. 1 sujith sujith       71 May 13 04:05 bzImage-qemux86.bin ->
bzImage--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.bin
-rw-r--r--. 1 sujith sujith 18093568 May 13 04:23
core-image-minimal-qemux86-20160513032205.rootfs.cpio
-rw-r--r--. 1 sujith sujith 25059328 May 13 04:23
core-image-minimal-qemux86-20160513032205.rootfs.ext3
-rw-r--r--. 1 sujith sujith 25059328 May 13 04:23
core-image-minimal-qemux86-20160513032205.rootfs.ext4
-rw-r--r--. 1 sujith sujith  6553600 May 13 04:23
core-image-minimal-qemux86-20160513032205.rootfs.jffs2
-rw-r--r--. 1 sujith sujith      811 May 13 04:23
core-image-minimal-qemux86-20160513032205.rootfs.manifest
-rw-r--r--. 1 sujith sujith  4370125 May 13 04:23
core-image-minimal-qemux86-20160513032205.rootfs.tar.bz2
lrwxrwxrwx. 1 sujith sujith       53 May 13 04:23
core-image-minimal-qemux86.cpio ->
core-image-minimal-qemux86-20160513032205.rootfs.cpio
lrwxrwxrwx. 1 sujith sujith       53 May 13 04:23
core-image-minimal-qemux86.ext3 ->
core-image-minimal-qemux86-20160513032205.rootfs.ext3
lrwxrwxrwx. 1 sujith sujith       53 May 13 04:23
core-image-minimal-qemux86.ext4 ->
core-image-minimal-qemux86-20160513032205.rootfs.ext4
lrwxrwxrwx. 1 sujith sujith       54 May 13 04:23
core-image-minimal-qemux86.jffs2 ->
core-image-minimal-qemux86-20160513032205.rootfs.jffs2
lrwxrwxrwx. 1 sujith sujith       57 May 13 04:23
core-image-minimal-qemux86.manifest ->
core-image-minimal-qemux86-20160513032205.rootfs.manifest
lrwxrwxrwx. 1 sujith sujith       56 May 13 04:23
core-image-minimal-qemux86.tar.bz2 ->
core-image-minimal-qemux86-20160513032205.rootfs.tar.bz2
-rw-rw-r--. 2 sujith sujith  4401740 May 13 04:05
modules--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.tgz
lrwxrwxrwx. 1 sujith sujith       71 May 13 04:05 modules-qemux86.tgz ->
modules--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.tgz
-rw-r--r--. 2 sujith sujith      294 May 13 04:22
README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
[sujith@sujith test-poky]$

If any other tests needs to be done let me know.

Thanks,
Sujith H

On Fri, May 13, 2016 at 12:41 PM, sujith h <sujith.h@gmail.com> wrote:

> Hi,
>
> I have created a branch for addition of new imagefs types:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828
> ( reference: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The
> top commit of this branch needs review. Thanks a bunch to Michael and Belen
> for helping me figure out the issue of disabling of save button in firefox.
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> <Project>Contributor to Yocto project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
> C-x C-c
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c

[-- Attachment #2: Type: text/html, Size: 5117 bytes --]

Re: Review required for addition of imagefs types (#7828)

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 11905 bytes --]

HI,

I added meta-raspberrypi layer and configured IMAGE_FSTYPES by adding
rpi-sdimg.
Triggered the build build for rpi-basic-image. Below is the output of
tmp/deploy/images folder of the build:

[sujith@sujith test-poky]$ ls
build-toaster-3/tmp/deploy/images/raspberrypi/ -lt
total 261500
lrwxrwxrwx. 1 sujith sujith        59 May 14 06:43
rpi-basic-image-raspberrypi.rpi-sdimg ->
rpi-basic-image-raspberrypi-20160514054241.rootfs.rpi-sdimg
-rw-r--r--. 1 sujith sujith 146800640 May 14 06:43
rpi-basic-image-raspberrypi-20160514054241.rootfs.rpi-sdimg
lrwxrwxrwx. 1 sujith sujith        57 May 14 06:43
rpi-basic-image-raspberrypi.tar.bz2 ->
rpi-basic-image-raspberrypi-20160514054241.rootfs.tar.bz2
lrwxrwxrwx. 1 sujith sujith        54 May 14 06:43
rpi-basic-image-raspberrypi.ext3 ->
rpi-basic-image-raspberrypi-20160514054241.rootfs.ext3
-rw-r--r--. 1 sujith sujith 100663296 May 14 06:43
rpi-basic-image-raspberrypi-20160514054241.rootfs.ext3
-rw-r--r--. 1 sujith sujith  22040200 May 14 06:43
rpi-basic-image-raspberrypi-20160514054241.rootfs.tar.bz2
lrwxrwxrwx. 1 sujith sujith        58 May 14 06:43
rpi-basic-image-raspberrypi.manifest ->
rpi-basic-image-raspberrypi-20160514054241.rootfs.manifest
-rw-r--r--. 1 sujith sujith     88301 May 14 06:43
rpi-basic-image-raspberrypi-20160514054241.rootfs.manifest
-rw-r--r--. 2 sujith sujith       294 May 14 06:41
README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
drwxr-xr-x. 2 sujith sujith       255 May 14 06:25 bcm2835-bootfiles
lrwxrwxrwx. 1 sujith sujith        76 May 14 06:25
Image-pi3-miniuart-bt-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-pi3-miniuart-bt-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        71 May 14 06:25
Image-rpi-ft5406-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-rpi-ft5406-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        68 May 14 06:25
Image-w1-gpio-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-w1-gpio-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        75 May 14 06:25
Image-w1-gpio-pullup-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-w1-gpio-pullup-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        76 May 14 06:25
Image-iqaudio-dacplus-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-iqaudio-dacplus-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        69 May 14 06:25
Image-lirc-rpi-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-lirc-rpi-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        68 May 14 06:25
Image-pitft22-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-pitft22-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        78 May 14 06:25
Image-pitft28-resistive-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-pitft28-resistive-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        69 May 14 06:25
Image-pps-gpio-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-pps-gpio-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        74 May 14 06:25
Image-hifiberry-amp-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-hifiberry-amp-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        74 May 14 06:25
Image-hifiberry-dac-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-hifiberry-dac-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        78 May 14 06:25
Image-hifiberry-dacplus-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-hifiberry-dacplus-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        75 May 14 06:25
Image-hifiberry-digi-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-hifiberry-digi-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        68 May 14 06:25
Image-i2c-rtc-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-i2c-rtc-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        72 May 14 06:25
Image-iqaudio-dac-overlay.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-iqaudio-dac-overlay-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        64 May 14 06:25 Image ->
Image-1-4.1.21+git0+ff45bc0e89-r0-raspberrypi-20160514054241.bin
lrwxrwxrwx. 1 sujith sujith        66 May 14 06:25 Image-bcm2708-rpi-b.dtb
-> Image-1-4.1.21+git0+ff45bc0e89-r0-bcm2708-rpi-b-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        71 May 14 06:25
Image-bcm2708-rpi-b-plus.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-bcm2708-rpi-b-plus-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        68 May 14 06:25
Image-bcm2709-rpi-2-b.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-bcm2709-rpi-2-b-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        68 May 14 06:25
Image-bcm2710-rpi-3-b.dtb ->
Image-1-4.1.21+git0+ff45bc0e89-r0-bcm2710-rpi-3-b-20160514054241.dtb
lrwxrwxrwx. 1 sujith sujith        64 May 14 06:25 Image-raspberrypi.bin ->
Image-1-4.1.21+git0+ff45bc0e89-r0-raspberrypi-20160514054241.bin
lrwxrwxrwx. 1 sujith sujith        66 May 14 06:25 modules-raspberrypi.tgz
-> modules-1-4.1.21+git0+ff45bc0e89-r0-raspberrypi-20160514054241.tgz
-rw-r--r--. 2 sujith sujith      1097 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-pi3-miniuart-bt-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith      1291 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-w1-gpio-pullup-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith      1124 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-w1-gpio-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith       484 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-rpi-ft5406-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith      1003 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-pps-gpio-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith      2658 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-pitft28-resistive-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith      1576 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-pitft22-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith      1428 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-lirc-rpi-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith      1051 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-iqaudio-dacplus-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith       775 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-iqaudio-dac-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith      2313 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-i2c-rtc-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith       783 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-hifiberry-digi-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith      1378 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-hifiberry-dacplus-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith       655 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-hifiberry-dac-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith       779 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-hifiberry-amp-overlay-20160514054241.dtb
-rw-r--r--. 2 sujith sujith     12870 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-bcm2710-rpi-3-b-20160514054241.dtb
-rw-r--r--. 2 sujith sujith     12116 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-bcm2709-rpi-2-b-20160514054241.dtb
-rw-r--r--. 2 sujith sujith     11128 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-bcm2708-rpi-b-plus-20160514054241.dtb
-rw-r--r--. 2 sujith sujith     10849 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-bcm2708-rpi-b-20160514054241.dtb
-rw-rw-r--. 2 sujith sujith  15623938 May 14 06:25
modules-1-4.1.21+git0+ff45bc0e89-r0-raspberrypi-20160514054241.tgz
-rw-r--r--. 2 sujith sujith   8692536 May 14 06:25
Image-1-4.1.21+git0+ff45bc0e89-r0-raspberrypi-20160514054241.bin
[sujith@sujith test-poky]$


We can see rpi-sdimg listed in the output.

Thanks,
Sujith H
<http://sujith.yocto.systems:8000/toastergui/project/3/layer/27>

On Fri, May 13, 2016 at 5:02 PM, sujith h <sujith.h@gmail.com> wrote:

> Forgot to add the test case I followed:
> 1) Added cpio into the imgaefs types along with the default ones. And
> triggered the build for core-image-minimal.
> 2) After the build I could see the below output in
> tmp/deploy/images/qemux86 of the build folder:
> [sujith@sujith test-poky]$ ls build-toaster-2/tmp/deploy/images/qemux86/
> -l
> total 76580
> lrwxrwxrwx. 1 sujith sujith       71 May 13 04:05 bzImage ->
> bzImage--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.bin
> -rw-r--r--. 2 sujith sujith  6720720 May 13 04:05
> bzImage--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.bin
> lrwxrwxrwx. 1 sujith sujith       71 May 13 04:05 bzImage-qemux86.bin ->
> bzImage--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.bin
> -rw-r--r--. 1 sujith sujith 18093568 May 13 04:23
> core-image-minimal-qemux86-20160513032205.rootfs.cpio
> -rw-r--r--. 1 sujith sujith 25059328 May 13 04:23
> core-image-minimal-qemux86-20160513032205.rootfs.ext3
> -rw-r--r--. 1 sujith sujith 25059328 May 13 04:23
> core-image-minimal-qemux86-20160513032205.rootfs.ext4
> -rw-r--r--. 1 sujith sujith  6553600 May 13 04:23
> core-image-minimal-qemux86-20160513032205.rootfs.jffs2
> -rw-r--r--. 1 sujith sujith      811 May 13 04:23
> core-image-minimal-qemux86-20160513032205.rootfs.manifest
> -rw-r--r--. 1 sujith sujith  4370125 May 13 04:23
> core-image-minimal-qemux86-20160513032205.rootfs.tar.bz2
> lrwxrwxrwx. 1 sujith sujith       53 May 13 04:23
> core-image-minimal-qemux86.cpio ->
> core-image-minimal-qemux86-20160513032205.rootfs.cpio
> lrwxrwxrwx. 1 sujith sujith       53 May 13 04:23
> core-image-minimal-qemux86.ext3 ->
> core-image-minimal-qemux86-20160513032205.rootfs.ext3
> lrwxrwxrwx. 1 sujith sujith       53 May 13 04:23
> core-image-minimal-qemux86.ext4 ->
> core-image-minimal-qemux86-20160513032205.rootfs.ext4
> lrwxrwxrwx. 1 sujith sujith       54 May 13 04:23
> core-image-minimal-qemux86.jffs2 ->
> core-image-minimal-qemux86-20160513032205.rootfs.jffs2
> lrwxrwxrwx. 1 sujith sujith       57 May 13 04:23
> core-image-minimal-qemux86.manifest ->
> core-image-minimal-qemux86-20160513032205.rootfs.manifest
> lrwxrwxrwx. 1 sujith sujith       56 May 13 04:23
> core-image-minimal-qemux86.tar.bz2 ->
> core-image-minimal-qemux86-20160513032205.rootfs.tar.bz2
> -rw-rw-r--. 2 sujith sujith  4401740 May 13 04:05
> modules--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.tgz
> lrwxrwxrwx. 1 sujith sujith       71 May 13 04:05 modules-qemux86.tgz ->
> modules--4.4.3+git0+9ab4787fe2_b18090556c-r0-qemux86-20160513032205.tgz
> -rw-r--r--. 2 sujith sujith      294 May 13 04:22
> README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
> [sujith@sujith test-poky]$
>
> If any other tests needs to be done let me know.
>
> Thanks,
> Sujith H
>
>
> On Fri, May 13, 2016 at 12:41 PM, sujith h <sujith.h@gmail.com> wrote:
>
>> Hi,
>>
>> I have created a branch for addition of new imagefs types:
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828
>> ( reference: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828).
>> The top commit of this branch needs review. Thanks a bunch to Michael and
>> Belen for helping me figure out the issue of disabling of save button in
>> firefox.
>>
>> --
>> സുജിത് ഹരിദാസന്
>> Bangalore
>> <Project>Contributor to KDE project
>> <Project>Contributor to Yocto project
>> http://fci.wikia.com/wiki/Anti-DRM-Campaign
>> <Blog> http://sujithh.info
>> C-x C-c
>>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> <Project>Contributor to Yocto project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
> C-x C-c
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c

[-- Attachment #2: Type: text/html, Size: 14432 bytes --]

Re: Review required for addition of imagefs types (#7828)

[Barros Pena, Belen]

On 13/05/2016 08:11, "toaster-bounces@yoctoproject.org on behalf of sujith
h" <toaster-bounces@yoctoproject.org on behalf of sujith.h@gmail.com>
wrote:

>Hi,
>
>
>I have created a branch for addition of new imagefs types:
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-n
>ew-image-type-7828
><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-
>new-image-type-7828> ( reference:
>https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The top commit
>of this branch needs review. Thanks a bunch to Michael and Belen for
>helping me figure out the issue of disabling of
> save button in firefox.

This seems to be working for me, both setting up the IMAGE_FSTYPES value
and building with a custom value (I tried building rpi-basic-image from
meta-raspberrypi adding rpi-sdimg as an image type).

I've pushed a small patch to the branch to fix a couple of tiny
presentation issues and to add a label:

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add
-new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1


With that in, I am good with it. Code should be reviewed though.

Thanks!

Belén

>
>-- 
>സുജിത് ഹരിദാസന്
>Bangalore
><Project>Contributor to KDE project
>
><Project>Contributor to Yocto project
>
>http://fci.wikia.com/wiki/Anti-DRM-Campaign
><Blog> http://sujithh.info
>
>C-x C-c
>
>
>
>
>
>
>
>

Re: Review required for addition of imagefs types (#7828)

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 2886 bytes --]

On 16 May 2016 at 13:32, Barros Pena, Belen <belen.barros.pena@intel.com>
wrote:

> On 13/05/2016 08:11, "toaster-bounces@yoctoproject.org on behalf of sujith
> h" <toaster-bounces@yoctoproject.org on behalf of sujith.h@gmail.com>
> wrote:
>
> >I have created a branch for addition of new imagefs types:
> >
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-n
> >ew-image-type-7828
> ><
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-
> >new-image-type-7828> ( reference:
> >https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The top commit
> >of this branch needs review. Thanks a bunch to Michael and Belen for
> >helping me figure out the issue of disabling of
> > save button in firefox.
>

Hello Sujith.

Thanks for your patches. They generally look good, but I have a couple of
comments:

1. While Toaster JS code doesn't always adhere to its own style guides
(something we will hopefully address eventually), it will help us if new
code *is* consistent with our guide where possible. You can find it at:
https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Javascript In
particular, please note how we prefer to lay out if...then blocks.

2. Toaster's test coverage isn't anywhere near as complete as we'd like,
but we do try to provide tests for UI code where possible now that we have
a framework for that in place. Your patch covers a case where a UI test
would make sense. Would it be possible for you to write some tests to cover
your code, please? You can find the existing tests in
bitbake/lib/toaster/tests/browser/, along with a sample test template.

If you need any help with either, please get in touch with me.

Thanks.
Elliot




>
> This seems to be working for me, both setting up the IMAGE_FSTYPES value
> and building with a custom value (I tried building rpi-basic-image from
> meta-raspberrypi adding rpi-sdimg as an image type).
>
> I've pushed a small patch to the branch to fix a couple of tiny
> presentation issues and to add a label:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add
> -new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1
>
>
> With that in, I am good with it. Code should be reviewed though.
>
> Thanks!
>
> Belén
>
> >
> >--
> >സുജിത് ഹരിദാസന്
> >Bangalore
> ><Project>Contributor to KDE project
> >
> ><Project>Contributor to Yocto project
> >
> >http://fci.wikia.com/wiki/Anti-DRM-Campaign
> ><Blog> http://sujithh.info
> >
> >C-x C-c
> >
> >
> >
> >
> >
> >
> >
> >
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 5169 bytes --]

Re: Review required for addition of imagefs types (#7828)

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 3894 bytes --]

On Mon, May 16, 2016 at 6:25 PM, Smith, Elliot <elliot.smith@intel.com>
wrote:

> On 16 May 2016 at 13:32, Barros Pena, Belen <belen.barros.pena@intel.com>
> wrote:
>
>> On 13/05/2016 08:11, "toaster-bounces@yoctoproject.org on behalf of
>> sujith
>> h" <toaster-bounces@yoctoproject.org on behalf of sujith.h@gmail.com>
>> wrote:
>>
>> >I have created a branch for addition of new imagefs types:
>> >
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-n
>> >ew-image-type-7828
>> ><
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-
>> >new-image-type-7828> ( reference:
>> >https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The top commit
>> >of this branch needs review. Thanks a bunch to Michael and Belen for
>> >helping me figure out the issue of disabling of
>> > save button in firefox.
>>
>
> Hi Elliot,


> Hello Sujith.
>
> Thanks for your patches. They generally look good, but I have a couple of
> comments:
>
> 1. While Toaster JS code doesn't always adhere to its own style guides
> (something we will hopefully address eventually), it will help us if new
> code *is* consistent with our guide where possible. You can find it at:
> https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Javascript In
> particular, please note how we prefer to lay out if...then blocks.
>

I have pushed new changes at
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=be85f177959bafddbdbaefe0cf57f02a74adf78a
Hope this looks much better and cleaner.


>
> 2. Toaster's test coverage isn't anywhere near as complete as we'd like,
> but we do try to provide tests for UI code where possible now that we have
> a framework for that in place. Your patch covers a case where a UI test
> would make sense. Would it be possible for you to write some tests to cover
> your code, please? You can find the existing tests in
> bitbake/lib/toaster/tests/browser/, along with a sample test template.
>

Sure I would like to write the tests. Let me go through the path shared by
you. In case of any queries of help required I will get back to you.

Thanks for the feedback.


>
> If you need any help with either, please get in touch with me.
>
> Thanks.
> Elliot
>
>
>
>
>>
>> This seems to be working for me, both setting up the IMAGE_FSTYPES value
>> and building with a custom value (I tried building rpi-basic-image from
>> meta-raspberrypi adding rpi-sdimg as an image type).
>>
>> I've pushed a small patch to the branch to fix a couple of tiny
>> presentation issues and to add a label:
>>
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add
>> -new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1
>> <http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1>
>>
>>
>> With that in, I am good with it. Code should be reviewed though.
>>
>> Thanks!
>>
>> Belén
>>
>> >
>> >--
>> >സുജിത് ഹരിദാസന്
>> >Bangalore
>> ><Project>Contributor to KDE project
>> >
>> ><Project>Contributor to Yocto project
>> >
>> >http://fci.wikia.com/wiki/Anti-DRM-Campaign
>> ><Blog> http://sujithh.info
>> >
>> >C-x C-c
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>>
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>>
>
>
>
> --
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c

[-- Attachment #2: Type: text/html, Size: 7532 bytes --]

Re: Review required for addition of imagefs types (#7828)

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 4622 bytes --]

Hi Elliot,

I have updated
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828
The top most commit comprises of a test case which you have suggested.
Kindly let me know if you are ok
with the changes.

Thanks,
Sujith H

On Mon, May 16, 2016 at 6:57 PM, sujith h <sujith.h@gmail.com> wrote:

>
>
> On Mon, May 16, 2016 at 6:25 PM, Smith, Elliot <elliot.smith@intel.com>
> wrote:
>
>> On 16 May 2016 at 13:32, Barros Pena, Belen <belen.barros.pena@intel.com>
>> wrote:
>>
>>> On 13/05/2016 08:11, "toaster-bounces@yoctoproject.org on behalf of
>>> sujith
>>> h" <toaster-bounces@yoctoproject.org on behalf of sujith.h@gmail.com>
>>> wrote:
>>>
>>> >I have created a branch for addition of new imagefs types:
>>> >
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-n
>>> >ew-image-type-7828
>>> ><
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-
>>> >new-image-type-7828> ( reference:
>>> >https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The top commit
>>> >of this branch needs review. Thanks a bunch to Michael and Belen for
>>> >helping me figure out the issue of disabling of
>>> > save button in firefox.
>>>
>>
>> Hi Elliot,
>
>
>> Hello Sujith.
>>
>> Thanks for your patches. They generally look good, but I have a couple of
>> comments:
>>
>> 1. While Toaster JS code doesn't always adhere to its own style guides
>> (something we will hopefully address eventually), it will help us if new
>> code *is* consistent with our guide where possible. You can find it at:
>> https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Javascript In
>> particular, please note how we prefer to lay out if...then blocks.
>>
>
> I have pushed new changes at
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=be85f177959bafddbdbaefe0cf57f02a74adf78a
> Hope this looks much better and cleaner.
>
>
>>
>> 2. Toaster's test coverage isn't anywhere near as complete as we'd like,
>> but we do try to provide tests for UI code where possible now that we have
>> a framework for that in place. Your patch covers a case where a UI test
>> would make sense. Would it be possible for you to write some tests to cover
>> your code, please? You can find the existing tests in
>> bitbake/lib/toaster/tests/browser/, along with a sample test template.
>>
>
> Sure I would like to write the tests. Let me go through the path shared by
> you. In case of any queries of help required I will get back to you.
>
> Thanks for the feedback.
>
>
>>
>> If you need any help with either, please get in touch with me.
>>
>> Thanks.
>> Elliot
>>
>>
>>
>>
>>>
>>> This seems to be working for me, both setting up the IMAGE_FSTYPES value
>>> and building with a custom value (I tried building rpi-basic-image from
>>> meta-raspberrypi adding rpi-sdimg as an image type).
>>>
>>> I've pushed a small patch to the branch to fix a couple of tiny
>>> presentation issues and to add a label:
>>>
>>>
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add
>>> -new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1
>>> <http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1>
>>>
>>>
>>> With that in, I am good with it. Code should be reviewed though.
>>>
>>> Thanks!
>>>
>>> Belén
>>>
>>> >
>>> >--
>>> >സുജിത് ഹരിദാസന്
>>> >Bangalore
>>> ><Project>Contributor to KDE project
>>> >
>>> ><Project>Contributor to Yocto project
>>> >
>>> >http://fci.wikia.com/wiki/Anti-DRM-Campaign
>>> ><Blog> http://sujithh.info
>>> >
>>> >C-x C-c
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>>
>>> --
>>> _______________________________________________
>>> toaster mailing list
>>> toaster@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/toaster
>>>
>>
>>
>>
>> --
>> Elliot Smith
>> Software Engineer
>> Intel Open Source Technology Centre
>>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> <Project>Contributor to Yocto project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
> C-x C-c
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c

[-- Attachment #2: Type: text/html, Size: 9030 bytes --]

Re: Review required for addition of imagefs types (#7828)

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 5530 bytes --]

On 17 May 2016 at 15:02, sujith h <sujith.h@gmail.com> wrote:

> Hi Elliot,
>
> I have updated
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828
> The top most commit comprises of a test case which you have suggested.
> Kindly let me know if you are ok
> with the changes.
>

These look good, and very quickly done, too, thanks.

I think there is another case which isn't covered by the tests, however (if
I read the code correctly): if the user deletes the text from the textbox
(with backspace or delete), and removes a file type, the corresponding
checkbox should be unchecked. That case isn't covered as far as I can see.

Also, the test_checkbox_verification() test you do have doesn't test the
values of the checkboxes after you enter "btrfs" in the text box.

It would be good to get those changes in.

Thanks.
Elliot


>
> Thanks,
> Sujith H
>
>
> On Mon, May 16, 2016 at 6:57 PM, sujith h <sujith.h@gmail.com> wrote:
>
>>
>>
>> On Mon, May 16, 2016 at 6:25 PM, Smith, Elliot <elliot.smith@intel.com>
>> wrote:
>>
>>> On 16 May 2016 at 13:32, Barros Pena, Belen <belen.barros.pena@intel.com
>>> > wrote:
>>>
>>>> On 13/05/2016 08:11, "toaster-bounces@yoctoproject.org on behalf of
>>>> sujith
>>>> h" <toaster-bounces@yoctoproject.org on behalf of sujith.h@gmail.com>
>>>> wrote:
>>>>
>>>> >I have created a branch for addition of new imagefs types:
>>>> >
>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-n
>>>> >ew-image-type-7828
>>>> ><
>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-
>>>> >new-image-type-7828> ( reference:
>>>> >https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The top
>>>> commit
>>>> >of this branch needs review. Thanks a bunch to Michael and Belen for
>>>> >helping me figure out the issue of disabling of
>>>> > save button in firefox.
>>>>
>>>
>>> Hi Elliot,
>>
>>
>>> Hello Sujith.
>>>
>>> Thanks for your patches. They generally look good, but I have a couple
>>> of comments:
>>>
>>> 1. While Toaster JS code doesn't always adhere to its own style guides
>>> (something we will hopefully address eventually), it will help us if new
>>> code *is* consistent with our guide where possible. You can find it at:
>>> https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Javascript In
>>> particular, please note how we prefer to lay out if...then blocks.
>>>
>>
>> I have pushed new changes at
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=be85f177959bafddbdbaefe0cf57f02a74adf78a
>> Hope this looks much better and cleaner.
>>
>>
>>>
>>> 2. Toaster's test coverage isn't anywhere near as complete as we'd like,
>>> but we do try to provide tests for UI code where possible now that we have
>>> a framework for that in place. Your patch covers a case where a UI test
>>> would make sense. Would it be possible for you to write some tests to cover
>>> your code, please? You can find the existing tests in
>>> bitbake/lib/toaster/tests/browser/, along with a sample test template.
>>>
>>
>> Sure I would like to write the tests. Let me go through the path shared
>> by you. In case of any queries of help required I will get back to you.
>>
>> Thanks for the feedback.
>>
>>
>>>
>>> If you need any help with either, please get in touch with me.
>>>
>>> Thanks.
>>> Elliot
>>>
>>>
>>>
>>>
>>>>
>>>> This seems to be working for me, both setting up the IMAGE_FSTYPES value
>>>> and building with a custom value (I tried building rpi-basic-image from
>>>> meta-raspberrypi adding rpi-sdimg as an image type).
>>>>
>>>> I've pushed a small patch to the branch to fix a couple of tiny
>>>> presentation issues and to add a label:
>>>>
>>>>
>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add
>>>> -new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1
>>>> <http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1>
>>>>
>>>>
>>>> With that in, I am good with it. Code should be reviewed though.
>>>>
>>>> Thanks!
>>>>
>>>> Belén
>>>>
>>>> >
>>>> >--
>>>> >സുജിത് ഹരിദാസന്
>>>> >Bangalore
>>>> ><Project>Contributor to KDE project
>>>> >
>>>> ><Project>Contributor to Yocto project
>>>> >
>>>> >http://fci.wikia.com/wiki/Anti-DRM-Campaign
>>>> ><Blog> http://sujithh.info
>>>> >
>>>> >C-x C-c
>>>> >
>>>> >
>>>> >
>>>> >
>>>> >
>>>> >
>>>> >
>>>> >
>>>>
>>>> --
>>>> _______________________________________________
>>>> toaster mailing list
>>>> toaster@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/toaster
>>>>
>>>
>>>
>>>
>>> --
>>> Elliot Smith
>>> Software Engineer
>>> Intel Open Source Technology Centre
>>>
>>
>>
>>
>> --
>> സുജിത് ഹരിദാസന്
>> Bangalore
>> <Project>Contributor to KDE project
>> <Project>Contributor to Yocto project
>> http://fci.wikia.com/wiki/Anti-DRM-Campaign
>> <Blog> http://sujithh.info
>> C-x C-c
>>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> <Project>Contributor to Yocto project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
> C-x C-c
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 10829 bytes --]

Re: Review required for addition of imagefs types (#7828)

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 6278 bytes --]

On Tue, May 17, 2016 at 9:50 PM, Smith, Elliot <elliot.smith@intel.com>
wrote:

> On 17 May 2016 at 15:02, sujith h <sujith.h@gmail.com> wrote:
>
>> Hi Elliot,
>>
>> I have updated
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828
>> The top most commit comprises of a test case which you have suggested.
>> Kindly let me know if you are ok
>> with the changes.
>>
>
> These look good, and very quickly done, too, thanks.
>
> I think there is another case which isn't covered by the tests, however
> (if I read the code correctly): if the user deletes the text from the
> textbox (with backspace or delete), and removes a file type, the
> corresponding checkbox should be unchecked. That case isn't covered as far
> as I can see.
>
> Also, the test_checkbox_verification() test you do have doesn't test the
> values of the checkboxes after you enter "btrfs" in the text box.
>
> It would be good to get those changes in.
>

I have added those changes also in
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828
. Let me know how the current state of the patch looks. Thanks for the
feedback.


>
> Thanks.
> Elliot
>
>
>>
>> Thanks,
>> Sujith H
>>
>>
>> On Mon, May 16, 2016 at 6:57 PM, sujith h <sujith.h@gmail.com> wrote:
>>
>>>
>>>
>>> On Mon, May 16, 2016 at 6:25 PM, Smith, Elliot <elliot.smith@intel.com>
>>> wrote:
>>>
>>>> On 16 May 2016 at 13:32, Barros Pena, Belen <
>>>> belen.barros.pena@intel.com> wrote:
>>>>
>>>>> On 13/05/2016 08:11, "toaster-bounces@yoctoproject.org on behalf of
>>>>> sujith
>>>>> h" <toaster-bounces@yoctoproject.org on behalf of sujith.h@gmail.com>
>>>>> wrote:
>>>>>
>>>>> >I have created a branch for addition of new imagefs types:
>>>>> >
>>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-n
>>>>> >ew-image-type-7828
>>>>> ><
>>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-
>>>>> >new-image-type-7828> ( reference:
>>>>> >https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The top
>>>>> commit
>>>>> >of this branch needs review. Thanks a bunch to Michael and Belen for
>>>>> >helping me figure out the issue of disabling of
>>>>> > save button in firefox.
>>>>>
>>>>
>>>> Hi Elliot,
>>>
>>>
>>>> Hello Sujith.
>>>>
>>>> Thanks for your patches. They generally look good, but I have a couple
>>>> of comments:
>>>>
>>>> 1. While Toaster JS code doesn't always adhere to its own style guides
>>>> (something we will hopefully address eventually), it will help us if new
>>>> code *is* consistent with our guide where possible. You can find it at:
>>>> https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Javascript In
>>>> particular, please note how we prefer to lay out if...then blocks.
>>>>
>>>
>>> I have pushed new changes at
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=be85f177959bafddbdbaefe0cf57f02a74adf78a
>>> Hope this looks much better and cleaner.
>>>
>>>
>>>>
>>>> 2. Toaster's test coverage isn't anywhere near as complete as we'd
>>>> like, but we do try to provide tests for UI code where possible now that we
>>>> have a framework for that in place. Your patch covers a case where a UI
>>>> test would make sense. Would it be possible for you to write some tests to
>>>> cover your code, please? You can find the existing tests in
>>>> bitbake/lib/toaster/tests/browser/, along with a sample test template.
>>>>
>>>
>>> Sure I would like to write the tests. Let me go through the path shared
>>> by you. In case of any queries of help required I will get back to you.
>>>
>>> Thanks for the feedback.
>>>
>>>
>>>>
>>>> If you need any help with either, please get in touch with me.
>>>>
>>>> Thanks.
>>>> Elliot
>>>>
>>>>
>>>>
>>>>
>>>>>
>>>>> This seems to be working for me, both setting up the IMAGE_FSTYPES
>>>>> value
>>>>> and building with a custom value (I tried building rpi-basic-image from
>>>>> meta-raspberrypi adding rpi-sdimg as an image type).
>>>>>
>>>>> I've pushed a small patch to the branch to fix a couple of tiny
>>>>> presentation issues and to add a label:
>>>>>
>>>>>
>>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add
>>>>> -new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1
>>>>> <http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1>
>>>>>
>>>>>
>>>>> With that in, I am good with it. Code should be reviewed though.
>>>>>
>>>>> Thanks!
>>>>>
>>>>> Belén
>>>>>
>>>>> >
>>>>> >--
>>>>> >സുജിത് ഹരിദാസന്
>>>>> >Bangalore
>>>>> ><Project>Contributor to KDE project
>>>>> >
>>>>> ><Project>Contributor to Yocto project
>>>>> >
>>>>> >http://fci.wikia.com/wiki/Anti-DRM-Campaign
>>>>> ><Blog> http://sujithh.info
>>>>> >
>>>>> >C-x C-c
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> toaster mailing list
>>>>> toaster@yoctoproject.org
>>>>> https://lists.yoctoproject.org/listinfo/toaster
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Elliot Smith
>>>> Software Engineer
>>>> Intel Open Source Technology Centre
>>>>
>>>
>>>
>>>
>>> --
>>> സുജിത് ഹരിദാസന്
>>> Bangalore
>>> <Project>Contributor to KDE project
>>> <Project>Contributor to Yocto project
>>> http://fci.wikia.com/wiki/Anti-DRM-Campaign
>>> <Blog> http://sujithh.info
>>> C-x C-c
>>>
>>
>>
>>
>> --
>> സുജിത് ഹരിദാസന്
>> Bangalore
>> <Project>Contributor to KDE project
>> <Project>Contributor to Yocto project
>> http://fci.wikia.com/wiki/Anti-DRM-Campaign
>> <Blog> http://sujithh.info
>> C-x C-c
>>
>
>
>
> --
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c

[-- Attachment #2: Type: text/html, Size: 12056 bytes --]

Re: Review required for addition of imagefs types (#7828)

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 6790 bytes --]

This looks much better, thanks, Sujith.

Pushed to toaster-next and submitted to bitbake-devel.

Thanks.
Elliot

On 18 May 2016 at 11:10, sujith h <sujith.h@gmail.com> wrote:

>
>
> On Tue, May 17, 2016 at 9:50 PM, Smith, Elliot <elliot.smith@intel.com>
> wrote:
>
>> On 17 May 2016 at 15:02, sujith h <sujith.h@gmail.com> wrote:
>>
>>> Hi Elliot,
>>>
>>> I have updated
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828
>>> The top most commit comprises of a test case which you have suggested.
>>> Kindly let me know if you are ok
>>> with the changes.
>>>
>>
>> These look good, and very quickly done, too, thanks.
>>
>> I think there is another case which isn't covered by the tests, however
>> (if I read the code correctly): if the user deletes the text from the
>> textbox (with backspace or delete), and removes a file type, the
>> corresponding checkbox should be unchecked. That case isn't covered as far
>> as I can see.
>>
>> Also, the test_checkbox_verification() test you do have doesn't test the
>> values of the checkboxes after you enter "btrfs" in the text box.
>>
>> It would be good to get those changes in.
>>
>
> I have added those changes also in
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828
> . Let me know how the current state of the patch looks. Thanks for the
> feedback.
>
>
>>
>> Thanks.
>> Elliot
>>
>>
>>>
>>> Thanks,
>>> Sujith H
>>>
>>>
>>> On Mon, May 16, 2016 at 6:57 PM, sujith h <sujith.h@gmail.com> wrote:
>>>
>>>>
>>>>
>>>> On Mon, May 16, 2016 at 6:25 PM, Smith, Elliot <elliot.smith@intel.com>
>>>> wrote:
>>>>
>>>>> On 16 May 2016 at 13:32, Barros Pena, Belen <
>>>>> belen.barros.pena@intel.com> wrote:
>>>>>
>>>>>> On 13/05/2016 08:11, "toaster-bounces@yoctoproject.org on behalf of
>>>>>> sujith
>>>>>> h" <toaster-bounces@yoctoproject.org on behalf of sujith.h@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>> >I have created a branch for addition of new imagefs types:
>>>>>> >
>>>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-n
>>>>>> >ew-image-type-7828
>>>>>> ><
>>>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-
>>>>>> >new-image-type-7828> ( reference:
>>>>>> >https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The top
>>>>>> commit
>>>>>> >of this branch needs review. Thanks a bunch to Michael and Belen for
>>>>>> >helping me figure out the issue of disabling of
>>>>>> > save button in firefox.
>>>>>>
>>>>>
>>>>> Hi Elliot,
>>>>
>>>>
>>>>> Hello Sujith.
>>>>>
>>>>> Thanks for your patches. They generally look good, but I have a couple
>>>>> of comments:
>>>>>
>>>>> 1. While Toaster JS code doesn't always adhere to its own style guides
>>>>> (something we will hopefully address eventually), it will help us if new
>>>>> code *is* consistent with our guide where possible. You can find it at:
>>>>> https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Javascript
>>>>> In particular, please note how we prefer to lay out if...then blocks.
>>>>>
>>>>
>>>> I have pushed new changes at
>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=be85f177959bafddbdbaefe0cf57f02a74adf78a
>>>> Hope this looks much better and cleaner.
>>>>
>>>>
>>>>>
>>>>> 2. Toaster's test coverage isn't anywhere near as complete as we'd
>>>>> like, but we do try to provide tests for UI code where possible now that we
>>>>> have a framework for that in place. Your patch covers a case where a UI
>>>>> test would make sense. Would it be possible for you to write some tests to
>>>>> cover your code, please? You can find the existing tests in
>>>>> bitbake/lib/toaster/tests/browser/, along with a sample test template.
>>>>>
>>>>
>>>> Sure I would like to write the tests. Let me go through the path shared
>>>> by you. In case of any queries of help required I will get back to you.
>>>>
>>>> Thanks for the feedback.
>>>>
>>>>
>>>>>
>>>>> If you need any help with either, please get in touch with me.
>>>>>
>>>>> Thanks.
>>>>> Elliot
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> This seems to be working for me, both setting up the IMAGE_FSTYPES
>>>>>> value
>>>>>> and building with a custom value (I tried building rpi-basic-image
>>>>>> from
>>>>>> meta-raspberrypi adding rpi-sdimg as an image type).
>>>>>>
>>>>>> I've pushed a small patch to the branch to fix a couple of tiny
>>>>>> presentation issues and to add a label:
>>>>>>
>>>>>>
>>>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add
>>>>>> -new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1
>>>>>> <http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1>
>>>>>>
>>>>>>
>>>>>> With that in, I am good with it. Code should be reviewed though.
>>>>>>
>>>>>> Thanks!
>>>>>>
>>>>>> Belén
>>>>>>
>>>>>> >
>>>>>> >--
>>>>>> >സുജിത് ഹരിദാസന്
>>>>>> >Bangalore
>>>>>> ><Project>Contributor to KDE project
>>>>>> >
>>>>>> ><Project>Contributor to Yocto project
>>>>>> >
>>>>>> >http://fci.wikia.com/wiki/Anti-DRM-Campaign
>>>>>> ><Blog> http://sujithh.info
>>>>>> >
>>>>>> >C-x C-c
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>>
>>>>>> --
>>>>>> _______________________________________________
>>>>>> toaster mailing list
>>>>>> toaster@yoctoproject.org
>>>>>> https://lists.yoctoproject.org/listinfo/toaster
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Elliot Smith
>>>>> Software Engineer
>>>>> Intel Open Source Technology Centre
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> സുജിത് ഹരിദാസന്
>>>> Bangalore
>>>> <Project>Contributor to KDE project
>>>> <Project>Contributor to Yocto project
>>>> http://fci.wikia.com/wiki/Anti-DRM-Campaign
>>>> <Blog> http://sujithh.info
>>>> C-x C-c
>>>>
>>>
>>>
>>>
>>> --
>>> സുജിത് ഹരിദാസന്
>>> Bangalore
>>> <Project>Contributor to KDE project
>>> <Project>Contributor to Yocto project
>>> http://fci.wikia.com/wiki/Anti-DRM-Campaign
>>> <Blog> http://sujithh.info
>>> C-x C-c
>>>
>>
>>
>>
>> --
>> Elliot Smith
>> Software Engineer
>> Intel Open Source Technology Centre
>>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> <Project>Contributor to Yocto project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
> C-x C-c
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 12802 bytes --]