[meta-multimedia][PATCH] Add a working tvheadend recipe

[meta-multimedia][PATCH] Add a working tvheadend recipe

[Peter Bašista]

The original one was previously removed
by commit ec9e5ed06256ad92c818474cdb490dc0d3a0d0a3
as part of a clean-up of blacklisted recipes.

Signed-off-by: Peter Bašista <pbasista@gmail.com>
---
 .../recipes-dvb/tvheadend/tvheadend_git.bb    | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb

diff --git a/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb b/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
new file mode 100644
index 000000000..2a76d5d34
--- /dev/null
+++ b/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
@@ -0,0 +1,37 @@
+SUMMARY = "Tvheadend: TV streaming server and recorder"
+HOMEPAGE = "https://tvheadend.org/"
+
+DEPENDS = "avahi cmake-native gettext-native libpcre2 libdvbcsa openssl zlib python-native"
+
+LICENSE = "GPLv3+"
+LIC_FILES_CHKSUM = "file://LICENSE.md;md5=9cae5acac2e9ee2fc3aec01ac88ce5db"
+
+SRC_URI = "git://github.com/tvheadend/tvheadend.git"
+
+inherit gitpkgv
+SRCREV = "${AUTOREV}"
+PV = "4.3+git${SRCPV}"
+PKGV = "4.3+git${GITPKGV}"
+
+S = "${WORKDIR}/git"
+
+PACKAGECONFIG ?= ""
+PACKAGECONFIG[uriparser] = "--enable-uriparser,--disable-uriparser,uriparser"
+
+do_configure() {
+    ./configure ${PACKAGECONFIG_CONFARGS} \
+                --prefix=${prefix} \
+                --libdir=${libdir} \
+                --bindir=${bindir} \
+                --datadir=${datadir} \
+                --arch=${TARGET_ARCH} \
+                --disable-libav \
+                --disable-ffmpeg_static \
+                --disable-hdhomerun_static
+}
+
+do_install() {
+    oe_runmake install DESTDIR=${D}
+}
+
+FILES_${PN} += "${datadir}/${BPN}"
-- 
2.19.1

Re: [meta-multimedia][PATCH] Add a working tvheadend recipe

[Khem Raj]

On Sun, Nov 18, 2018 at 9:05 AM Peter Bašista <pbasista@gmail.com> wrote:
>
> The original one was previously removed
> by commit ec9e5ed06256ad92c818474cdb490dc0d3a0d0a3
> as part of a clean-up of blacklisted recipes.
>
> Signed-off-by: Peter Bašista <pbasista@gmail.com>
> ---
>  .../recipes-dvb/tvheadend/tvheadend_git.bb    | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
>
> diff --git a/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb b/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
> new file mode 100644
> index 000000000..2a76d5d34
> --- /dev/null
> +++ b/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
> @@ -0,0 +1,37 @@
> +SUMMARY = "Tvheadend: TV streaming server and recorder"
> +HOMEPAGE = "https://tvheadend.org/"
> +
> +DEPENDS = "avahi cmake-native gettext-native libpcre2 libdvbcsa openssl zlib python-native"

perhaps inheriting cmake, gettext and pythonnative classes is
appropriate here instead of adding
them to depends

> +
> +LICENSE = "GPLv3+"
> +LIC_FILES_CHKSUM = "file://LICENSE.md;md5=9cae5acac2e9ee2fc3aec01ac88ce5db"
> +
> +SRC_URI = "git://github.com/tvheadend/tvheadend.git"
> +

missing SRCREV, we need a locked down SHA

> +inherit gitpkgv
> +SRCREV = "${AUTOREV}"
> +PV = "4.3+git${SRCPV}"
> +PKGV = "4.3+git${GITPKGV}"
> +
> +S = "${WORKDIR}/git"
> +
> +PACKAGECONFIG ?= ""
> +PACKAGECONFIG[uriparser] = "--enable-uriparser,--disable-uriparser,uriparser"
> +
> +do_configure() {
> +    ./configure ${PACKAGECONFIG_CONFARGS} \
> +                --prefix=${prefix} \
> +                --libdir=${libdir} \
> +                --bindir=${bindir} \
> +                --datadir=${datadir} \
> +                --arch=${TARGET_ARCH} \
> +                --disable-libav \
> +                --disable-ffmpeg_static \
> +                --disable-hdhomerun_static
> +}
> +
> +do_install() {
> +    oe_runmake install DESTDIR=${D}
> +}
> +
> +FILES_${PN} += "${datadir}/${BPN}"
> --
> 2.19.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-multimedia][PATCH] Add a working tvheadend recipe

[Peter Bašista]

On Sun, Nov 18, 2018 at 10:35:08AM -0800, Khem Raj wrote:
> perhaps inheriting cmake, gettext and pythonnative classes is
> appropriate here instead of adding
> them to depends
Thank you. I have tried doing that but I was not fully successful.
For instance, inheriting cmake is probably not going to work well,
because the compilation uses standard make, which then calls cmake.
I am not sure whether there is a scenario for such a case within the
cmake bbclass.

So, I have only added inheritance from gettext and pkgconfig.

I have also removed pythonnative, because apparently it is not needed
and the recipe seems to be working well without it.

Finally, I have cleaned-up other parts which seemed unused or
unnecessary.

> missing SRCREV, we need a locked down SHA
Oh, I was not aware of that. Added.

I will send the v2 of the patch shortly.

Regards
Peter Bašista

Re: [meta-multimedia][PATCH] Add a working tvheadend recipe

[Martin Hundebøll]

On 18/11/2018 18.04, Peter Bašista wrote:
> The original one was previously removed
> by commit ec9e5ed06256ad92c818474cdb490dc0d3a0d0a3
> as part of a clean-up of blacklisted recipes.
> 
> Signed-off-by: Peter Bašista <pbasista@gmail.com>
> ---
>   .../recipes-dvb/tvheadend/tvheadend_git.bb    | 37 +++++++++++++++++++
>   1 file changed, 37 insertions(+)
>   create mode 100644 meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
> 
> diff --git a/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb b/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
> new file mode 100644
> index 000000000..2a76d5d34
> --- /dev/null
> +++ b/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
> @@ -0,0 +1,37 @@
> +SUMMARY = "Tvheadend: TV streaming server and recorder"
> +HOMEPAGE = "https://tvheadend.org/"
> +
> +DEPENDS = "avahi cmake-native gettext-native libpcre2 libdvbcsa openssl zlib python-native"
> +
> +LICENSE = "GPLv3+"
> +LIC_FILES_CHKSUM = "file://LICENSE.md;md5=9cae5acac2e9ee2fc3aec01ac88ce5db"
> +
> +SRC_URI = "git://github.com/tvheadend/tvheadend.git"
> +
> +inherit gitpkgv
> +SRCREV = "${AUTOREV}"
> +PV = "4.3+git${SRCPV}"
> +PKGV = "4.3+git${GITPKGV}"
> +
> +S = "${WORKDIR}/git"
> +
> +PACKAGECONFIG ?= ""
> +PACKAGECONFIG[uriparser] = "--enable-uriparser,--disable-uriparser,uriparser"
> +
> +do_configure() {
> +    ./configure ${PACKAGECONFIG_CONFARGS} \
> +                --prefix=${prefix} \
> +                --libdir=${libdir} \
> +                --bindir=${bindir} \
> +                --datadir=${datadir} \
> +                --arch=${TARGET_ARCH} \
> +                --disable-libav \
> +                --disable-ffmpeg_static \
> +                --disable-hdhomerun_static
> +}
> +
> +do_install() {
> +    oe_runmake install DESTDIR=${D}
> +}

do_configure() and do_install() look pretty much like the ones from 
autotools.bbclass. Wouldn't it be prettier to do:

inherit autotools

EXTRA_OECONF = "--disable-libav --disable-ffmpeg_static 
--disable-hdhomerun_static"

do_compile[noexec] = "1"

?

// Martin

> +
> +FILES_${PN} += "${datadir}/${BPN}"
> 

-- 
Kind regards,
Martin Hundebøll
Embedded Linux Consultant

+45 61 65 54 61
martin@geanix.com

Geanix IVS
https://geanix.com
DK39600706

Re: [meta-multimedia][PATCH] Add a working tvheadend recipe

[Martin Hundebøll]

Sorry, I hadn't noticed PATCHv3 on the list when I wrote this.

// Martin

On 23/11/2018 10.58, Martin Hundebøll wrote:
> 
> 
> On 18/11/2018 18.04, Peter Bašista wrote:
>> The original one was previously removed
>> by commit ec9e5ed06256ad92c818474cdb490dc0d3a0d0a3
>> as part of a clean-up of blacklisted recipes.
>>
>> Signed-off-by: Peter Bašista <pbasista@gmail.com>
>> ---
>>   .../recipes-dvb/tvheadend/tvheadend_git.bb    | 37 +++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>>   create mode 100644 
>> meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
>>
>> diff --git a/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb 
>> b/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
>> new file mode 100644
>> index 000000000..2a76d5d34
>> --- /dev/null
>> +++ b/meta-multimedia/recipes-dvb/tvheadend/tvheadend_git.bb
>> @@ -0,0 +1,37 @@
>> +SUMMARY = "Tvheadend: TV streaming server and recorder"
>> +HOMEPAGE = "https://tvheadend.org/"
>> +
>> +DEPENDS = "avahi cmake-native gettext-native libpcre2 libdvbcsa 
>> openssl zlib python-native"
>> +
>> +LICENSE = "GPLv3+"
>> +LIC_FILES_CHKSUM = 
>> "file://LICENSE.md;md5=9cae5acac2e9ee2fc3aec01ac88ce5db"
>> +
>> +SRC_URI = "git://github.com/tvheadend/tvheadend.git"
>> +
>> +inherit gitpkgv
>> +SRCREV = "${AUTOREV}"
>> +PV = "4.3+git${SRCPV}"
>> +PKGV = "4.3+git${GITPKGV}"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +PACKAGECONFIG ?= ""
>> +PACKAGECONFIG[uriparser] = 
>> "--enable-uriparser,--disable-uriparser,uriparser"
>> +
>> +do_configure() {
>> +    ./configure ${PACKAGECONFIG_CONFARGS} \
>> +                --prefix=${prefix} \
>> +                --libdir=${libdir} \
>> +                --bindir=${bindir} \
>> +                --datadir=${datadir} \
>> +                --arch=${TARGET_ARCH} \
>> +                --disable-libav \
>> +                --disable-ffmpeg_static \
>> +                --disable-hdhomerun_static
>> +}
>> +
>> +do_install() {
>> +    oe_runmake install DESTDIR=${D}
>> +}
> 
> do_configure() and do_install() look pretty much like the ones from 
> autotools.bbclass. Wouldn't it be prettier to do:
> 
> inherit autotools
> 
> EXTRA_OECONF = "--disable-libav --disable-ffmpeg_static 
> --disable-hdhomerun_static"
> 
> do_compile[noexec] = "1"
> 
> ?
> 
> // Martin
> 
>> +
>> +FILES_${PN} += "${datadir}/${BPN}"
>>
> 

-- 
Kind regards,
Martin Hundebøll
Embedded Linux Consultant

+45 61 65 54 61
martin@geanix.com

Geanix IVS
https://geanix.com
DK39600706

Re: [meta-multimedia][PATCH] Add a working tvheadend recipe

[Peter Bašista]

On Fri, Nov 23, 2018 at 11:03:36AM +0100, Martin Hundebøll wrote:
> Sorry, I hadn't noticed PATCHv3 on the list when I wrote this.

No worries. Your suggestion about autotools:

> > do_configure() and do_install() look pretty much like the ones from
> > autotools.bbclass. Wouldn't it be prettier to do:

seems useful. I did not realize that such a recipe would be usable
in this case.

So, thank you, I have used something like that in PATCH v4.

Regards
Peter Bašista