[PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[yann.dirson]

From: Yann Dirson <yann@blade-group.com>

Otherwise the build fails with:

  NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['${RDEPENDS_}']

This restores some truth in the "Otherwise install nothing" comment in the recipe.

Signed-off-by: Yann Dirson <yann@blade-group.com>
---
 .../packagegroups/packagegroup-tools-bluetooth.bb               | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb b/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
index 0ede5e57b..e81516fef 100644
--- a/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
+++ b/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
@@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
         '', d)} \
 "
 
+RDEPENDS_ = ""
+
 # Install bluez4 tools or bluez5 tools depending on what is specified in the distro.
 # Otherwise install nothing.
 RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
-- 
2.19.1

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

What about using some less confusing default BLUEZ value? RDEPENDS_ looks
wrong.

BLUEZ ??= "no-bluetooth"
RDEPENDS_no-bluetooth = ""

Might be a bit more clear.

On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com> wrote:

> From: Yann Dirson <yann@blade-group.com>
>
> Otherwise the build fails with:
>
>   NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
>   Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
>
> This restores some truth in the "Otherwise install nothing" comment in the
> recipe.
>
> Signed-off-by: Yann Dirson <yann@blade-group.com>
> ---
>  .../packagegroups/packagegroup-tools-bluetooth.bb               | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> b/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> index 0ede5e57b..e81516fef 100644
> --- a/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> +++ b/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
>          '', d)} \
>  "
>
> +RDEPENDS_ = ""
> +
>  # Install bluez4 tools or bluez5 tools depending on what is specified in
> the distro.
>  # Otherwise install nothing.
>  RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
> --
> 2.19.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2818 bytes --]

✗ patchtest: failure for packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Patchwork]

== Series Details ==

Series: packagegroup-tools-bluetooth: work as advertized on distro without bluez* support
Revision: 1
URL   : https://patchwork.openembedded.org/series/14575/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists [test_target_mailing_list] 
  Suggested fix    Send the series again to the correct mailing list (ML)
  Suggested ML     openembedded-devel@lists.openembedded.org [http://git.openembedded.org/meta-openembedded/]
  Patch's path:    meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb

* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 02646be9d3)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Yann Dirson]

[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]

Yeah, that looks like a better idea.

Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa@gmail.com> a
écrit :

> What about using some less confusing default BLUEZ value? RDEPENDS_ looks
> wrong.
>
> BLUEZ ??= "no-bluetooth"
> RDEPENDS_no-bluetooth = ""
>
> Might be a bit more clear.
>
> On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com> wrote:
>
>> From: Yann Dirson <yann@blade-group.com>
>>
>> Otherwise the build fails with:
>>
>>   NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
>>   Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
>>
>> This restores some truth in the "Otherwise install nothing" comment in
>> the recipe.
>>
>> Signed-off-by: Yann Dirson <yann@blade-group.com>
>> ---
>>  .../packagegroups/packagegroup-tools-bluetooth.bb               | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-oe/recipes-connectivity/packagegroups/
>> packagegroup-tools-bluetooth.bb
>> b/meta-oe/recipes-connectivity/packagegroups/
>> packagegroup-tools-bluetooth.bb
>> index 0ede5e57b..e81516fef 100644
>> --- a/meta-oe/recipes-connectivity/packagegroups/
>> packagegroup-tools-bluetooth.bb
>> +++ b/meta-oe/recipes-connectivity/packagegroups/
>> packagegroup-tools-bluetooth.bb
>> @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
>>          '', d)} \
>>  "
>>
>> +RDEPENDS_ = ""
>> +
>>  # Install bluez4 tools or bluez5 tools depending on what is specified in
>> the distro.
>>  # Otherwise install nothing.
>>  RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
>> --
>> 2.19.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>

-- 
Yann Dirson <yann@blade-group.com>
Blade -- 38 rue du Sentier, 75002 Paris

[-- Attachment #2: Type: text/html, Size: 3487 bytes --]

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

well, I realized that this won't work with the BLUEZ intentionally set to
empty value and setting BLUEZ to no-bluetooth globally also probably won't
work for cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe
inline python appending only either bluez4 or bluez5 alternative here?

On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <yann.dirson@blade-group.com>
wrote:

> Yeah, that looks like a better idea.
>
> Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa@gmail.com> a
> écrit :
>
>> What about using some less confusing default BLUEZ value? RDEPENDS_ looks
>> wrong.
>>
>> BLUEZ ??= "no-bluetooth"
>> RDEPENDS_no-bluetooth = ""
>>
>> Might be a bit more clear.
>>
>> On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com> wrote:
>>
>>> From: Yann Dirson <yann@blade-group.com>
>>>
>>> Otherwise the build fails with:
>>>
>>>   NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
>>>   Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
>>>
>>> This restores some truth in the "Otherwise install nothing" comment in
>>> the recipe.
>>>
>>> Signed-off-by: Yann Dirson <yann@blade-group.com>
>>> ---
>>>  .../packagegroups/packagegroup-tools-bluetooth.bb               | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta-oe/recipes-connectivity/packagegroups/
>>> packagegroup-tools-bluetooth.bb
>>> b/meta-oe/recipes-connectivity/packagegroups/
>>> packagegroup-tools-bluetooth.bb
>>> index 0ede5e57b..e81516fef 100644
>>> --- a/meta-oe/recipes-connectivity/packagegroups/
>>> packagegroup-tools-bluetooth.bb
>>> +++ b/meta-oe/recipes-connectivity/packagegroups/
>>> packagegroup-tools-bluetooth.bb
>>> @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
>>>          '', d)} \
>>>  "
>>>
>>> +RDEPENDS_ = ""
>>> +
>>>  # Install bluez4 tools or bluez5 tools depending on what is specified
>>> in the distro.
>>>  # Otherwise install nothing.
>>>  RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
>>> --
>>> 2.19.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>
>
> --
> Yann Dirson <yann@blade-group.com>
> Blade -- 38 rue du Sentier, 75002 Paris
>

[-- Attachment #2: Type: text/html, Size: 4156 bytes --]

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Yann Dirson]

[-- Attachment #1: Type: text/plain, Size: 2657 bytes --]

Well, inline python was what was originally used before 5397ae5.

Le mer. 17 oct. 2018 à 17:46, Martin Jansa <martin.jansa@gmail.com> a
écrit :

> well, I realized that this won't work with the BLUEZ intentionally set to
> empty value and setting BLUEZ to no-bluetooth globally also probably won't
> work for cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe
> inline python appending only either bluez4 or bluez5 alternative here?
>
> On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <yann.dirson@blade-group.com>
> wrote:
>
>> Yeah, that looks like a better idea.
>>
>> Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa@gmail.com> a
>> écrit :
>>
>>> What about using some less confusing default BLUEZ value? RDEPENDS_
>>> looks wrong.
>>>
>>> BLUEZ ??= "no-bluetooth"
>>> RDEPENDS_no-bluetooth = ""
>>>
>>> Might be a bit more clear.
>>>
>>> On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com> wrote:
>>>
>>>> From: Yann Dirson <yann@blade-group.com>
>>>>
>>>> Otherwise the build fails with:
>>>>
>>>>   NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
>>>>   Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
>>>>
>>>> This restores some truth in the "Otherwise install nothing" comment in
>>>> the recipe.
>>>>
>>>> Signed-off-by: Yann Dirson <yann@blade-group.com>
>>>> ---
>>>>  .../packagegroups/packagegroup-tools-bluetooth.bb               | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/meta-oe/recipes-connectivity/packagegroups/
>>>> packagegroup-tools-bluetooth.bb
>>>> b/meta-oe/recipes-connectivity/packagegroups/
>>>> packagegroup-tools-bluetooth.bb
>>>> index 0ede5e57b..e81516fef 100644
>>>> --- a/meta-oe/recipes-connectivity/packagegroups/
>>>> packagegroup-tools-bluetooth.bb
>>>> +++ b/meta-oe/recipes-connectivity/packagegroups/
>>>> packagegroup-tools-bluetooth.bb
>>>> @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
>>>>          '', d)} \
>>>>  "
>>>>
>>>> +RDEPENDS_ = ""
>>>> +
>>>>  # Install bluez4 tools or bluez5 tools depending on what is specified
>>>> in the distro.
>>>>  # Otherwise install nothing.
>>>>  RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
>>>> --
>>>> 2.19.1
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>
>>>
>>
>> --
>> Yann Dirson <yann@blade-group.com>
>> Blade -- 38 rue du Sentier, 75002 Paris
>>
>

-- 
Yann Dirson <yann@blade-group.com>
Blade -- 38 rue du Sentier, 75002 Paris

[-- Attachment #2: Type: text/html, Size: 4874 bytes --]

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3217 bytes --]

Hmm, you're right 5397ae5 would be better with just DISTRO_FEATURES
replaced with BLUEZ variable in

RDEPENDS_${PN} = " \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluez5', '${BLUEZ5_INSTALL}',
"", d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluez4', '${BLUEZ4_INSTALL}',
"", d)} \
"

Then it would work fine for both use cases and empty BLUEZ as well.

On Wed, Oct 17, 2018 at 5:47 PM Yann Dirson <yann.dirson@blade-group.com>
wrote:

> Well, inline python was what was originally used before 5397ae5.
>
> Le mer. 17 oct. 2018 à 17:46, Martin Jansa <martin.jansa@gmail.com> a
> écrit :
>
>> well, I realized that this won't work with the BLUEZ intentionally set to
>> empty value and setting BLUEZ to no-bluetooth globally also probably won't
>> work for cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe
>> inline python appending only either bluez4 or bluez5 alternative here?
>>
>> On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <yann.dirson@blade-group.com>
>> wrote:
>>
>>> Yeah, that looks like a better idea.
>>>
>>> Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa@gmail.com> a
>>> écrit :
>>>
>>>> What about using some less confusing default BLUEZ value? RDEPENDS_
>>>> looks wrong.
>>>>
>>>> BLUEZ ??= "no-bluetooth"
>>>> RDEPENDS_no-bluetooth = ""
>>>>
>>>> Might be a bit more clear.
>>>>
>>>> On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com> wrote:
>>>>
>>>>> From: Yann Dirson <yann@blade-group.com>
>>>>>
>>>>> Otherwise the build fails with:
>>>>>
>>>>>   NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
>>>>>   Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
>>>>>
>>>>> This restores some truth in the "Otherwise install nothing" comment in
>>>>> the recipe.
>>>>>
>>>>> Signed-off-by: Yann Dirson <yann@blade-group.com>
>>>>> ---
>>>>>  .../packagegroups/packagegroup-tools-bluetooth.bb               | 2
>>>>> ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/meta-oe/recipes-connectivity/packagegroups/
>>>>> packagegroup-tools-bluetooth.bb
>>>>> b/meta-oe/recipes-connectivity/packagegroups/
>>>>> packagegroup-tools-bluetooth.bb
>>>>> index 0ede5e57b..e81516fef 100644
>>>>> --- a/meta-oe/recipes-connectivity/packagegroups/
>>>>> packagegroup-tools-bluetooth.bb
>>>>> +++ b/meta-oe/recipes-connectivity/packagegroups/
>>>>> packagegroup-tools-bluetooth.bb
>>>>> @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
>>>>>          '', d)} \
>>>>>  "
>>>>>
>>>>> +RDEPENDS_ = ""
>>>>> +
>>>>>  # Install bluez4 tools or bluez5 tools depending on what is specified
>>>>> in the distro.
>>>>>  # Otherwise install nothing.
>>>>>  RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
>>>>> --
>>>>> 2.19.1
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core@lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>>
>>>>
>>>
>>> --
>>> Yann Dirson <yann@blade-group.com>
>>> Blade -- 38 rue du Sentier, 75002 Paris
>>>
>>
>
> --
> Yann Dirson <yann@blade-group.com>
> Blade -- 38 rue du Sentier, 75002 Paris
>

[-- Attachment #2: Type: text/html, Size: 5921 bytes --]

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Mark Hatle]

On 10/17/18 10:46 AM, Martin Jansa wrote:
> well, I realized that this won't work with the BLUEZ intentionally set to empty
> value and setting BLUEZ to no-bluetooth globally also probably won't work for
> cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe inline python
> appending only either bluez4 or bluez5 alternative here?

I'm slightly confused.  In the suggestion you made below, ??= within the
specific package, why would 'no-bluetooth' cause a problem.  For all other
recipes it will remain blank as expected.

--Mark

> On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <yann.dirson@blade-group.com
> <mailto:yann.dirson@blade-group.com>> wrote:
> 
>     Yeah, that looks like a better idea.
> 
>     Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa@gmail.com
>     <mailto:martin.jansa@gmail.com>> a écrit :
> 
>         What about using some less confusing default BLUEZ value? RDEPENDS_
>         looks wrong.
> 
>         BLUEZ ??= "no-bluetooth"
>         RDEPENDS_no-bluetooth = ""
> 
>         Might be a bit more clear.
> 
>         On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com
>         <mailto:yann.dirson@blade-group.com>> wrote:
> 
>             From: Yann Dirson <yann@blade-group.com <mailto:yann@blade-group.com>>
> 
>             Otherwise the build fails with:
> 
>               NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
>               Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
> 
>             This restores some truth in the "Otherwise install nothing" comment
>             in the recipe.
> 
>             Signed-off-by: Yann Dirson <yann@blade-group.com
>             <mailto:yann@blade-group.com>>
>             ---
>              .../packagegroups/packagegroup-tools-bluetooth.bb
>             <http://packagegroup-tools-bluetooth.bb>               | 2 ++
>              1 file changed, 2 insertions(+)
> 
>             diff --git
>             a/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
>             <http://packagegroup-tools-bluetooth.bb>
>             b/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
>             <http://packagegroup-tools-bluetooth.bb>
>             index 0ede5e57b..e81516fef 100644
>             ---
>             a/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
>             <http://packagegroup-tools-bluetooth.bb>
>             +++
>             b/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
>             <http://packagegroup-tools-bluetooth.bb>
>             @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
>                      '', d)} \
>              "
> 
>             +RDEPENDS_ = ""
>             +
>              # Install bluez4 tools or bluez5 tools depending on what is
>             specified in the distro.
>              # Otherwise install nothing.
>              RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
>             -- 
>             2.19.1
> 
>             -- 
>             _______________________________________________
>             Openembedded-core mailing list
>             Openembedded-core@lists.openembedded.org
>             <mailto:Openembedded-core@lists.openembedded.org>
>             http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
> 
>     -- 
>     Yann Dirson <yann@blade-group.com <mailto:yann@blade-group.com>>
>     Blade -- 38 rue du Sentier, 75002 Paris
> 
> 
> 

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Yann Dirson]

[-- Attachment #1: Type: text/plain, Size: 3602 bytes --]

BTW, patchwork made me resend the patch to openembedded-devel, which list
would be right for this ?

Le mer. 17 oct. 2018 à 17:54, Martin Jansa <martin.jansa@gmail.com> a
écrit :

> Hmm, you're right 5397ae5 would be better with just DISTRO_FEATURES
> replaced with BLUEZ variable in
>
> RDEPENDS_${PN} = " \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'bluez5',
> '${BLUEZ5_INSTALL}', "", d)} \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'bluez4',
> '${BLUEZ4_INSTALL}', "", d)} \
> "
>
> Then it would work fine for both use cases and empty BLUEZ as well.
>
> On Wed, Oct 17, 2018 at 5:47 PM Yann Dirson <yann.dirson@blade-group.com>
> wrote:
>
>> Well, inline python was what was originally used before 5397ae5.
>>
>> Le mer. 17 oct. 2018 à 17:46, Martin Jansa <martin.jansa@gmail.com> a
>> écrit :
>>
>>> well, I realized that this won't work with the BLUEZ intentionally set
>>> to empty value and setting BLUEZ to no-bluetooth globally also probably
>>> won't work for cases where it might be used in e.g. RDEPENDS_${PN} :/.
>>> Maybe inline python appending only either bluez4 or bluez5 alternative here?
>>>
>>> On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <yann.dirson@blade-group.com>
>>> wrote:
>>>
>>>> Yeah, that looks like a better idea.
>>>>
>>>> Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa@gmail.com> a
>>>> écrit :
>>>>
>>>>> What about using some less confusing default BLUEZ value? RDEPENDS_
>>>>> looks wrong.
>>>>>
>>>>> BLUEZ ??= "no-bluetooth"
>>>>> RDEPENDS_no-bluetooth = ""
>>>>>
>>>>> Might be a bit more clear.
>>>>>
>>>>> On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com> wrote:
>>>>>
>>>>>> From: Yann Dirson <yann@blade-group.com>
>>>>>>
>>>>>> Otherwise the build fails with:
>>>>>>
>>>>>>   NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
>>>>>>   Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
>>>>>>
>>>>>> This restores some truth in the "Otherwise install nothing" comment
>>>>>> in the recipe.
>>>>>>
>>>>>> Signed-off-by: Yann Dirson <yann@blade-group.com>
>>>>>> ---
>>>>>>  .../packagegroups/packagegroup-tools-bluetooth.bb               | 2
>>>>>> ++
>>>>>>  1 file changed, 2 insertions(+)
>>>>>>
>>>>>> diff --git a/meta-oe/recipes-connectivity/packagegroups/
>>>>>> packagegroup-tools-bluetooth.bb
>>>>>> b/meta-oe/recipes-connectivity/packagegroups/
>>>>>> packagegroup-tools-bluetooth.bb
>>>>>> index 0ede5e57b..e81516fef 100644
>>>>>> --- a/meta-oe/recipes-connectivity/packagegroups/
>>>>>> packagegroup-tools-bluetooth.bb
>>>>>> +++ b/meta-oe/recipes-connectivity/packagegroups/
>>>>>> packagegroup-tools-bluetooth.bb
>>>>>> @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
>>>>>>          '', d)} \
>>>>>>  "
>>>>>>
>>>>>> +RDEPENDS_ = ""
>>>>>> +
>>>>>>  # Install bluez4 tools or bluez5 tools depending on what is
>>>>>> specified in the distro.
>>>>>>  # Otherwise install nothing.
>>>>>>  RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
>>>>>> --
>>>>>> 2.19.1
>>>>>>
>>>>>> --
>>>>>> _______________________________________________
>>>>>> Openembedded-core mailing list
>>>>>> Openembedded-core@lists.openembedded.org
>>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Yann Dirson <yann@blade-group.com>
>>>> Blade -- 38 rue du Sentier, 75002 Paris
>>>>
>>>
>>
>> --
>> Yann Dirson <yann@blade-group.com>
>> Blade -- 38 rue du Sentier, 75002 Paris
>>
>

-- 
Yann Dirson <yann@blade-group.com>
Blade -- 38 rue du Sentier, 75002 Paris

[-- Attachment #2: Type: text/html, Size: 6694 bytes --]

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Yann Dirson]

[-- Attachment #1: Type: text/plain, Size: 4290 bytes --]

Le mer. 17 oct. 2018 à 17:58, Mark Hatle <mark.hatle@windriver.com> a
écrit :

> On 10/17/18 10:46 AM, Martin Jansa wrote:
> > well, I realized that this won't work with the BLUEZ intentionally set
> to empty
> > value and setting BLUEZ to no-bluetooth globally also probably won't
> work for
> > cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe inline
> python
> > appending only either bluez4 or bluez5 alternative here?
>
> I'm slightly confused.  In the suggestion you made below, ??= within the
> specific package, why would 'no-bluetooth' cause a problem.  For all other
> recipes it will remain blank as expected.
>

I guess the problem is more when it is globally set to "", we would anyway
need to handle that
case in addition to our recipe-specific default.


> --Mark
>
> > On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <yann.dirson@blade-group.com
> > <mailto:yann.dirson@blade-group.com>> wrote:
> >
> >     Yeah, that looks like a better idea.
> >
> >     Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa@gmail.com
> >     <mailto:martin.jansa@gmail.com>> a écrit :
> >
> >         What about using some less confusing default BLUEZ value?
> RDEPENDS_
> >         looks wrong.
> >
> >         BLUEZ ??= "no-bluetooth"
> >         RDEPENDS_no-bluetooth = ""
> >
> >         Might be a bit more clear.
> >
> >         On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com
> >         <mailto:yann.dirson@blade-group.com>> wrote:
> >
> >             From: Yann Dirson <yann@blade-group.com <mailto:
> yann@blade-group.com>>
> >
> >             Otherwise the build fails with:
> >
> >               NOTE: Runtime target '${RDEPENDS_}' is unbuildable,
> removing...
> >               Missing or unbuildable dependency chain was:
> ['${RDEPENDS_}']
> >
> >             This restores some truth in the "Otherwise install nothing"
> comment
> >             in the recipe.
> >
> >             Signed-off-by: Yann Dirson <yann@blade-group.com
> >             <mailto:yann@blade-group.com>>
> >             ---
> >              .../packagegroups/packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>               | 2
> ++
> >              1 file changed, 2 insertions(+)
> >
> >             diff --git
> >             a/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>
> >             b/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>
> >             index 0ede5e57b..e81516fef 100644
> >             ---
> >             a/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>
> >             +++
> >             b/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>
> >             @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
> >                      '', d)} \
> >              "
> >
> >             +RDEPENDS_ = ""
> >             +
> >              # Install bluez4 tools or bluez5 tools depending on what is
> >             specified in the distro.
> >              # Otherwise install nothing.
> >              RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
> >             --
> >             2.19.1
> >
> >             --
> >             _______________________________________________
> >             Openembedded-core mailing list
> >             Openembedded-core@lists.openembedded.org
> >             <mailto:Openembedded-core@lists.openembedded.org>
> >
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
> >
> >
> >     --
> >     Yann Dirson <yann@blade-group.com <mailto:yann@blade-group.com>>
> >     Blade -- 38 rue du Sentier, 75002 Paris
> >
> >
> >
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


-- 
Yann Dirson <yann@blade-group.com>
Blade -- 38 rue du Sentier, 75002 Paris

[-- Attachment #2: Type: text/html, Size: 7946 bytes --]

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 5015 bytes --]

On Wed, Oct 17, 2018 at 10:58:49AM -0500, Mark Hatle wrote:
> On 10/17/18 10:46 AM, Martin Jansa wrote:
> > well, I realized that this won't work with the BLUEZ intentionally set to empty
> > value and setting BLUEZ to no-bluetooth globally also probably won't work for
> > cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe inline python
> > appending only either bluez4 or bluez5 alternative here?
> 
> I'm slightly confused.  In the suggestion you made below, ??= within the
> specific package, why would 'no-bluetooth' cause a problem.  For all other
> recipes it will remain blank as expected.

Because if you set it to empty, then ??= won't be used and we'll be back
to RDEPENDS_.

And if you set BLUEZ to no-bluetooth e.g. in your DISTRO config than it
will break other recipes, e.g.:

meta/recipes-connectivity/ofono/ofono.inc:PACKAGECONFIG[bluez] = "--enable-bluetooth, --disable-bluetooth, ${BLUEZ}"
meta/recipes-core/packagegroups/packagegroup-base.bb:    ${BLUEZ} \
meta/recipes-devtools/python/python3.inc:PACKAGECONFIG[bluetooth] = ",ac_cv_header_bluetooth_bluetooth_h=no ac_cv_header_bluetooth_h=no,${BLUEZ}"
meta/recipes-devtools/qemu/qemu.inc:PACKAGECONFIG[bluez] = "--enable-bluez,--disable-bluez,${BLUEZ}"
meta/recipes-devtools/strace/strace_4.24.bb:PACKAGECONFIG[bluez] = "ac_cv_header_bluetooth_bluetooth_h=yes,ac_cv_header_bluetooth_bluetooth_h=no,${BLUEZ}"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.2.bb:PACKAGECONFIG[bluez]           = "--enable-bluez,--disable-bluez,${BLUEZ}"

> --Mark
> 
> > On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <yann.dirson@blade-group.com
> > <mailto:yann.dirson@blade-group.com>> wrote:
> > 
> >     Yeah, that looks like a better idea.
> > 
> >     Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa@gmail.com
> >     <mailto:martin.jansa@gmail.com>> a écrit :
> > 
> >         What about using some less confusing default BLUEZ value? RDEPENDS_
> >         looks wrong.
> > 
> >         BLUEZ ??= "no-bluetooth"
> >         RDEPENDS_no-bluetooth = ""
> > 
> >         Might be a bit more clear.
> > 
> >         On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com
> >         <mailto:yann.dirson@blade-group.com>> wrote:
> > 
> >             From: Yann Dirson <yann@blade-group.com <mailto:yann@blade-group.com>>
> > 
> >             Otherwise the build fails with:
> > 
> >               NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
> >               Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
> > 
> >             This restores some truth in the "Otherwise install nothing" comment
> >             in the recipe.
> > 
> >             Signed-off-by: Yann Dirson <yann@blade-group.com
> >             <mailto:yann@blade-group.com>>
> >             ---
> >              .../packagegroups/packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>               | 2 ++
> >              1 file changed, 2 insertions(+)
> > 
> >             diff --git
> >             a/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>
> >             b/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>
> >             index 0ede5e57b..e81516fef 100644
> >             ---
> >             a/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>
> >             +++
> >             b/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
> >             <http://packagegroup-tools-bluetooth.bb>
> >             @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
> >                      '', d)} \
> >              "
> > 
> >             +RDEPENDS_ = ""
> >             +
> >              # Install bluez4 tools or bluez5 tools depending on what is
> >             specified in the distro.
> >              # Otherwise install nothing.
> >              RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
> >             -- 
> >             2.19.1
> > 
> >             -- 
> >             _______________________________________________
> >             Openembedded-core mailing list
> >             Openembedded-core@lists.openembedded.org
> >             <mailto:Openembedded-core@lists.openembedded.org>
> >             http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > 
> > 
> > 
> >     -- 
> >     Yann Dirson <yann@blade-group.com <mailto:yann@blade-group.com>>
> >     Blade -- 38 rue du Sentier, 75002 Paris
> > 
> > 
> > 
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Yann Dirson]

[-- Attachment #1: Type: text/plain, Size: 5732 bytes --]

Sent v3 to -devel - that does not supercede the original series on patwork,
though.

Le mer. 17 oct. 2018 à 20:52, Martin Jansa <martin.jansa@gmail.com> a
écrit :

> On Wed, Oct 17, 2018 at 10:58:49AM -0500, Mark Hatle wrote:
> > On 10/17/18 10:46 AM, Martin Jansa wrote:
> > > well, I realized that this won't work with the BLUEZ intentionally set
> to empty
> > > value and setting BLUEZ to no-bluetooth globally also probably won't
> work for
> > > cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe inline
> python
> > > appending only either bluez4 or bluez5 alternative here?
> >
> > I'm slightly confused.  In the suggestion you made below, ??= within the
> > specific package, why would 'no-bluetooth' cause a problem.  For all
> other
> > recipes it will remain blank as expected.
>
> Because if you set it to empty, then ??= won't be used and we'll be back
> to RDEPENDS_.
>
> And if you set BLUEZ to no-bluetooth e.g. in your DISTRO config than it
> will break other recipes, e.g.:
>
> meta/recipes-connectivity/ofono/ofono.inc:PACKAGECONFIG[bluez] =
> "--enable-bluetooth, --disable-bluetooth, ${BLUEZ}"
> meta/recipes-core/packagegroups/packagegroup-base.bb:    ${BLUEZ} \
> meta/recipes-devtools/python/python3.inc:PACKAGECONFIG[bluetooth] =
> ",ac_cv_header_bluetooth_bluetooth_h=no
> ac_cv_header_bluetooth_h=no,${BLUEZ}"
> meta/recipes-devtools/qemu/qemu.inc:PACKAGECONFIG[bluez] =
> "--enable-bluez,--disable-bluez,${BLUEZ}"
> meta/recipes-devtools/strace/strace_4.24.bb:PACKAGECONFIG[bluez] =
> "ac_cv_header_bluetooth_bluetooth_h=yes,ac_cv_header_bluetooth_bluetooth_h=no,${BLUEZ}"
> meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.2.bb:PACKAGECONFIG[bluez]
>          = "--enable-bluez,--disable-bluez,${BLUEZ}"
>
> > --Mark
> >
> > > On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <
> yann.dirson@blade-group.com
> > > <mailto:yann.dirson@blade-group.com>> wrote:
> > >
> > >     Yeah, that looks like a better idea.
> > >
> > >     Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa@gmail.com
> > >     <mailto:martin.jansa@gmail.com>> a écrit :
> > >
> > >         What about using some less confusing default BLUEZ value?
> RDEPENDS_
> > >         looks wrong.
> > >
> > >         BLUEZ ??= "no-bluetooth"
> > >         RDEPENDS_no-bluetooth = ""
> > >
> > >         Might be a bit more clear.
> > >
> > >         On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson@blade-group.com
> > >         <mailto:yann.dirson@blade-group.com>> wrote:
> > >
> > >             From: Yann Dirson <yann@blade-group.com <mailto:
> yann@blade-group.com>>
> > >
> > >             Otherwise the build fails with:
> > >
> > >               NOTE: Runtime target '${RDEPENDS_}' is unbuildable,
> removing...
> > >               Missing or unbuildable dependency chain was:
> ['${RDEPENDS_}']
> > >
> > >             This restores some truth in the "Otherwise install
> nothing" comment
> > >             in the recipe.
> > >
> > >             Signed-off-by: Yann Dirson <yann@blade-group.com
> > >             <mailto:yann@blade-group.com>>
> > >             ---
> > >              .../packagegroups/packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>               |
> 2 ++
> > >              1 file changed, 2 insertions(+)
> > >
> > >             diff --git
> > >             a/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>
> > >             b/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>
> > >             index 0ede5e57b..e81516fef 100644
> > >             ---
> > >             a/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>
> > >             +++
> > >             b/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>
> > >             @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
> > >                      '', d)} \
> > >              "
> > >
> > >             +RDEPENDS_ = ""
> > >             +
> > >              # Install bluez4 tools or bluez5 tools depending on what
> is
> > >             specified in the distro.
> > >              # Otherwise install nothing.
> > >              RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
> > >             --
> > >             2.19.1
> > >
> > >             --
> > >             _______________________________________________
> > >             Openembedded-core mailing list
> > >             Openembedded-core@lists.openembedded.org
> > >             <mailto:Openembedded-core@lists.openembedded.org>
> > >
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > >
> > >
> > >
> > >     --
> > >     Yann Dirson <yann@blade-group.com <mailto:yann@blade-group.com>>
> > >     Blade -- 38 rue du Sentier, 75002 Paris
> > >
> > >
> > >
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


-- 
Yann Dirson <yann@blade-group.com>
Blade -- 38 rue du Sentier, 75002 Paris

[-- Attachment #2: Type: text/html, Size: 9919 bytes --]