From: Linus Torvalds <torvalds@linux-foundation.org> To: Al Viro <viro@zeniv.linux.org.uk> Cc: Matthew Wilcox <willy@infradead.org>, "Kirill A. Shutemov" <kirill@shutemov.name>, Peter Zijlstra <peterz@infradead.org>, Andrea Arcangeli <aarcange@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Mel Gorman <mgorman@techsingularity.net>, Tony Luck <tony.luck@intel.com>, Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@kernel.org>, "hillf.zj" <hillf.zj@alibaba-inc.com>, Hugh Dickins <hughd@google.com>, Oleg Nesterov <oleg@redhat.com>, Rik van Riel <riel@redhat.com>, Srikar Dronamraju <srikar@linux.vnet.ibm.com>, Vladimir Davydov <vdavydov.dev@gmail.com>, Ingo Molnar <mingo@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, "the arch/x86 maintainers" <x86@kernel.org> Subject: Re: [mm 4.15-rc8] Random oopses under memory pressure. Date: Fri, 19 Jan 2018 14:53:25 -0800 [thread overview] Message-ID: <CA+55aFw4mw32Mu0_+cgKAzxCNvDW1VPcESv7CyajexfDfMju1A@mail.gmail.com> (raw) In-Reply-To: <20180119221243.GL13338@ZenIV.linux.org.uk> On Fri, Jan 19, 2018 at 2:12 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > On Fri, Jan 19, 2018 at 10:42:18AM -0800, Linus Torvalds wrote: >> >> We *should* be careful about it. I guess sparse could be made to warn, >> but I'm afraid that we have so many of these things that a warning >> isn't reasonable. > > You mean like -Wptr-subtraction-blows? Heh. Apparently I already did that trivial warning back in 2005. I'd forgotten about it. > FWIW, allmodconfig on amd64 with C=2 CF=-Wptr-subtraction-blows is not too large > > IOW it's not terribly noisy. Might be an interesting idea to teach sparse to > print the type in question... Aha - with > > --- a/evaluate.c > +++ b/evaluate.c > @@ -848,7 +848,8 @@ static struct symbol *evaluate_ptr_sub(struct expression *expr) > > if (value & (value-1)) { > if (Wptr_subtraction_blows) > - warning(expr->pos, "potentially expensive pointer subtraction"); > + warning(expr->pos, "[%s] potentially expensive pointer subtraction", > + show_typename(lbase)); > } > > sub->op = '-'; > > we get things like > drivers/gpu/drm/i915/i915_gem_execbuffer.c:435:17: warning: [struct drm_i915_gem_exec_object2] potentially expensive pointer subtraction It would probably be good to add the size too, just to explain why it's potentially expensive. That said, apparently we do have hundreds of them, with just cpufreq_frequency_table having a ton. Maybe some are hidden in macros and removing one removes a lot. The real problem is that sometimes the subtraction is simply the right thing to do, and there's no sane way to say "yeah, this is one of those cases you shouldn't warn about". Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org> To: Al Viro <viro@zeniv.linux.org.uk> Cc: Matthew Wilcox <willy@infradead.org>, "Kirill A. Shutemov" <kirill@shutemov.name>, Peter Zijlstra <peterz@infradead.org>, Andrea Arcangeli <aarcange@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Mel Gorman <mgorman@techsingularity.net>, Tony Luck <tony.luck@intel.com>, Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@kernel.org>, "hillf.zj" <hillf.zj@alibaba-inc.com>, Hugh Dickins <hughd@google.com>, Oleg Nesterov <oleg@redhat.com>, Rik van Riel <riel@redhat.com>, Srikar Dronamraju <srikar@linux.vnet.ibm.com>, Vladimir Davydov <vdavydov.dev@gmail.com>, Ingo Molnar <mingo@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, the arch/x86 maintainers <x86@kernel.org> Subject: Re: [mm 4.15-rc8] Random oopses under memory pressure. Date: Fri, 19 Jan 2018 14:53:25 -0800 [thread overview] Message-ID: <CA+55aFw4mw32Mu0_+cgKAzxCNvDW1VPcESv7CyajexfDfMju1A@mail.gmail.com> (raw) In-Reply-To: <20180119221243.GL13338@ZenIV.linux.org.uk> On Fri, Jan 19, 2018 at 2:12 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > On Fri, Jan 19, 2018 at 10:42:18AM -0800, Linus Torvalds wrote: >> >> We *should* be careful about it. I guess sparse could be made to warn, >> but I'm afraid that we have so many of these things that a warning >> isn't reasonable. > > You mean like -Wptr-subtraction-blows? Heh. Apparently I already did that trivial warning back in 2005. I'd forgotten about it. > FWIW, allmodconfig on amd64 with C=2 CF=-Wptr-subtraction-blows is not too large > > IOW it's not terribly noisy. Might be an interesting idea to teach sparse to > print the type in question... Aha - with > > --- a/evaluate.c > +++ b/evaluate.c > @@ -848,7 +848,8 @@ static struct symbol *evaluate_ptr_sub(struct expression *expr) > > if (value & (value-1)) { > if (Wptr_subtraction_blows) > - warning(expr->pos, "potentially expensive pointer subtraction"); > + warning(expr->pos, "[%s] potentially expensive pointer subtraction", > + show_typename(lbase)); > } > > sub->op = '-'; > > we get things like > drivers/gpu/drm/i915/i915_gem_execbuffer.c:435:17: warning: [struct drm_i915_gem_exec_object2] potentially expensive pointer subtraction It would probably be good to add the size too, just to explain why it's potentially expensive. That said, apparently we do have hundreds of them, with just cpufreq_frequency_table having a ton. Maybe some are hidden in macros and removing one removes a lot. The real problem is that sometimes the subtraction is simply the right thing to do, and there's no sane way to say "yeah, this is one of those cases you shouldn't warn about". Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-19 22:53 UTC|newest] Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-05 14:45 [x86? mm? fs? 4.15-rc6] Random oopses by simple write under memory pressure Tetsuo Handa 2018-01-09 10:39 ` [mm? 4.15-rc7] " Tetsuo Handa 2018-01-10 11:49 ` [mm? 4.15-rc7] Random oopses " Tetsuo Handa 2018-01-10 12:45 ` Michal Hocko 2018-01-10 13:37 ` Tetsuo Handa 2018-01-11 13:57 ` Michal Hocko 2018-01-11 14:11 ` Tetsuo Handa 2018-01-11 14:21 ` Michal Hocko 2018-01-11 14:37 ` Tetsuo Handa 2018-01-12 1:31 ` [mm " Tetsuo Handa 2018-01-12 1:42 ` Linus Torvalds 2018-01-12 11:22 ` Tetsuo Handa 2018-01-14 11:54 ` Tetsuo Handa 2018-01-14 11:54 ` Tetsuo Handa 2018-01-15 23:05 ` Linus Torvalds 2018-01-15 23:05 ` Linus Torvalds 2018-01-16 1:15 ` [mm 4.15-rc8] " Tetsuo Handa 2018-01-16 1:15 ` Tetsuo Handa 2018-01-16 2:14 ` Linus Torvalds 2018-01-16 2:14 ` Linus Torvalds 2018-01-16 8:06 ` Dave Hansen 2018-01-16 8:06 ` Dave Hansen 2018-01-16 8:37 ` Ingo Molnar 2018-01-16 8:37 ` Ingo Molnar 2018-01-16 19:30 ` Linus Torvalds 2018-01-16 19:30 ` Linus Torvalds 2018-01-16 17:33 ` Tetsuo Handa 2018-01-16 17:33 ` Tetsuo Handa 2018-01-16 19:34 ` Linus Torvalds 2018-01-16 19:34 ` Linus Torvalds 2018-01-17 11:08 ` Tetsuo Handa 2018-01-17 11:08 ` Tetsuo Handa 2018-01-17 21:39 ` Linus Torvalds 2018-01-17 21:39 ` Linus Torvalds 2018-01-17 21:51 ` Linus Torvalds 2018-01-17 21:51 ` Linus Torvalds 2018-01-17 22:04 ` Dave Hansen 2018-01-17 22:04 ` Dave Hansen 2018-01-17 22:00 ` Dave Hansen 2018-01-17 22:00 ` Dave Hansen 2018-01-17 22:15 ` Linus Torvalds 2018-01-17 22:15 ` Linus Torvalds 2018-01-18 8:12 ` Tetsuo Handa 2018-01-18 8:12 ` Tetsuo Handa 2018-01-18 12:25 ` Kirill A. Shutemov 2018-01-18 12:25 ` Kirill A. Shutemov 2018-01-18 13:12 ` Kirill A. Shutemov 2018-01-18 13:12 ` Kirill A. Shutemov 2018-01-18 14:34 ` Kirill A. Shutemov 2018-01-18 14:34 ` Kirill A. Shutemov 2018-01-18 14:38 ` Dave Hansen 2018-01-18 14:38 ` Dave Hansen 2018-01-18 14:45 ` Kirill A. Shutemov 2018-01-18 14:45 ` Kirill A. Shutemov 2018-01-18 14:51 ` Dave Hansen 2018-01-18 14:51 ` Dave Hansen 2018-01-18 16:58 ` Linus Torvalds 2018-01-18 16:58 ` Linus Torvalds 2018-01-18 14:45 ` Dave Hansen 2018-01-18 14:45 ` Dave Hansen 2018-01-18 14:58 ` Andrea Arcangeli 2018-01-18 14:58 ` Andrea Arcangeli 2018-01-18 16:56 ` Kirill A. Shutemov 2018-01-18 16:56 ` Kirill A. Shutemov 2018-01-18 17:26 ` Luck, Tony 2018-01-18 17:26 ` Luck, Tony 2018-01-18 17:28 ` Linus Torvalds 2018-01-18 17:28 ` Linus Torvalds 2018-01-18 17:26 ` Linus Torvalds 2018-01-18 17:26 ` Linus Torvalds 2018-01-18 23:49 ` Kirill A. Shutemov 2018-01-18 23:49 ` Kirill A. Shutemov 2018-01-19 12:55 ` Matthew Wilcox 2018-01-19 12:55 ` Matthew Wilcox 2018-01-19 18:42 ` Linus Torvalds 2018-01-19 18:42 ` Linus Torvalds 2018-01-19 22:12 ` Al Viro 2018-01-19 22:12 ` Al Viro 2018-01-19 22:53 ` Linus Torvalds [this message] 2018-01-19 22:53 ` Linus Torvalds 2018-01-20 2:02 ` Al Viro 2018-01-20 2:02 ` Al Viro 2018-01-20 5:24 ` Al Viro 2018-01-20 5:24 ` Al Viro 2018-01-20 9:38 ` Luc Van Oostenryck 2018-01-20 9:38 ` Luc Van Oostenryck 2018-01-20 9:38 ` Luc Van Oostenryck 2018-01-20 14:45 ` Luc Van Oostenryck 2018-01-22 13:26 ` Rasmus Villemoes 2018-01-22 19:58 ` Linus Torvalds 2018-01-18 15:40 ` Kirill A. Shutemov 2018-01-18 15:40 ` Kirill A. Shutemov 2018-01-18 17:22 ` Michal Hocko 2018-01-18 17:22 ` Michal Hocko 2018-01-19 10:02 ` Kirill A. Shutemov 2018-01-19 10:02 ` Kirill A. Shutemov 2018-01-19 10:33 ` Michal Hocko 2018-01-19 10:33 ` Michal Hocko 2018-01-19 11:49 ` Kirill A. Shutemov 2018-01-19 11:49 ` Kirill A. Shutemov 2018-01-19 12:07 ` Michal Hocko 2018-01-19 12:07 ` Michal Hocko 2018-01-19 12:30 ` Kirill A. Shutemov 2018-01-19 12:30 ` Kirill A. Shutemov 2018-01-19 2:01 ` Tetsuo Handa 2018-01-19 2:01 ` Tetsuo Handa 2018-01-11 18:11 ` [mm? 4.15-rc7] " Linus Torvalds 2018-01-11 20:59 ` Tetsuo Handa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+55aFw4mw32Mu0_+cgKAzxCNvDW1VPcESv7CyajexfDfMju1A@mail.gmail.com \ --to=torvalds@linux-foundation.org \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=dave.hansen@linux.intel.com \ --cc=hannes@cmpxchg.org \ --cc=hillf.zj@alibaba-inc.com \ --cc=hughd@google.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=kirill@shutemov.name \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@techsingularity.net \ --cc=mhocko@kernel.org \ --cc=mingo@kernel.org \ --cc=oleg@redhat.com \ --cc=penguin-kernel@i-love.sakura.ne.jp \ --cc=peterz@infradead.org \ --cc=riel@redhat.com \ --cc=srikar@linux.vnet.ibm.com \ --cc=tony.luck@intel.com \ --cc=vbabka@suse.cz \ --cc=vdavydov.dev@gmail.com \ --cc=viro@zeniv.linux.org.uk \ --cc=willy@infradead.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.