From: Linus Torvalds <torvalds@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Kay Sievers <kay@vrfy.org>, "Ted Ts'o" <tytso@mit.edu>,
Ingo Molnar <mingo@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Sasha Levin <levinsasha928@gmail.com>,
Greg Kroah-Hartmann <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer
Date: Thu, 10 May 2012 13:52:39 -0700 [thread overview]
Message-ID: <CA+55aFwJgtVr9ZndEU-yhJW3wi-5Omga51pjun+J213awQwJZA@mail.gmail.com> (raw)
In-Reply-To: <1336682772.29763.6.camel@joe2Laptop>
On Thu, May 10, 2012 at 1:46 PM, Joe Perches <joe@perches.com> wrote:
>
> That's where I think you're still a bit
> uncertain how the _current_ printk system
> works.
No, you are. Read my answer from two days ago in this thread.
KERN_CONT is *not* the same as "". Not now, not ever. If you make it
the same, you're broken.
The reason is simple: KERN_CONT "<3>" should print out the string
"<3>". If you make KERN_CONT be "", it will do the wrong thing, and
think that the <3> is a priority marker.
Please people, this is subtle, and current code does things RIGHT. Any
code that changes it to do something else is almost certainly buggy.
The new semantics had better be the same as the old one.
The change to verify that 'current' matches the previous printout is
so far the *only* sane semantic change I've seen in this thread.
Everything else has been pure garbage.
Linus
next prev parent reply other threads:[~2012-05-10 20:53 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 0:29 [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer Kay Sievers
2012-05-03 19:48 ` Peter Zijlstra
2012-05-03 19:54 ` Kay Sievers
2012-05-03 19:55 ` Peter Zijlstra
2012-05-03 19:56 ` Linus Torvalds
2012-05-03 20:02 ` Peter Zijlstra
2012-05-03 20:09 ` Linus Torvalds
2012-05-03 20:11 ` Peter Zijlstra
2012-05-03 20:18 ` Greg Kroah-Hartmann
2012-05-08 8:48 ` Sasha Levin
2012-05-08 11:14 ` Kay Sievers
2012-05-08 13:33 ` Sasha Levin
2012-05-08 14:29 ` Kay Sievers
2012-05-08 15:33 ` Kay Sievers
2012-05-08 15:57 ` Sasha Levin
2012-05-08 16:27 ` Kay Sievers
2012-05-08 22:57 ` Greg Kroah-Hartmann
2012-05-09 3:52 ` Linus Torvalds
2012-05-09 4:06 ` Joe Perches
2012-05-09 4:11 ` Sasha Levin
2012-05-09 4:27 ` Linus Torvalds
2012-05-09 4:36 ` Linus Torvalds
2012-05-09 7:07 ` Ingo Molnar
2012-05-09 13:21 ` Kay Sievers
2012-05-09 13:29 ` Kay Sievers
2012-05-10 0:54 ` Kay Sievers
2012-05-10 1:18 ` Linus Torvalds
2012-05-10 2:32 ` Kay Sievers
2012-05-10 2:46 ` Joe Perches
2012-05-10 16:39 ` Kay Sievers
2012-05-10 16:47 ` Linus Torvalds
2012-05-10 18:49 ` Tony Luck
2012-05-10 19:09 ` Kay Sievers
2012-05-10 20:14 ` Ted Ts'o
2012-05-10 20:37 ` Joe Perches
2012-05-10 20:39 ` Kay Sievers
2012-05-10 20:46 ` Joe Perches
2012-05-10 20:52 ` Linus Torvalds [this message]
2012-05-10 21:11 ` Joe Perches
2012-05-10 21:15 ` Kay Sievers
2012-05-10 21:58 ` Linus Torvalds
2012-05-11 0:13 ` Joe Perches
2012-05-11 0:38 ` Kay Sievers
2012-05-11 1:23 ` Kay Sievers
2012-05-14 18:46 ` Kay Sievers
2012-05-10 21:01 ` Kay Sievers
2012-05-10 20:38 ` Kay Sievers
2012-05-09 9:38 ` Kay Sievers
2012-05-09 13:50 ` Joe Perches
2012-05-09 14:37 ` Kay Sievers
2012-05-09 23:02 ` Yinghai Lu
2012-05-09 23:06 ` Greg Kroah-Hartmann
2012-05-10 2:30 ` Kay Sievers
2012-05-11 10:35 ` Sasha Levin
2012-05-11 15:19 ` Greg KH
2012-05-11 15:22 ` Sasha Levin
2012-05-11 15:35 ` Linus Torvalds
2012-05-11 15:40 ` Kay Sievers
2012-05-11 15:47 ` Linus Torvalds
2012-05-11 19:51 ` Mark Lord
2012-05-11 20:02 ` Linus Torvalds
2012-05-12 18:04 ` Mark Lord
2012-05-12 7:43 ` Sasha Levin
2012-05-12 18:35 ` Linus Torvalds
2012-05-13 11:08 ` Kay Sievers
2012-05-13 13:22 ` Mark Lord
2012-05-13 18:01 ` Linus Torvalds
2012-05-13 22:19 ` Mark Lord
2012-05-14 16:40 ` valdis.kletnieks
2012-05-17 3:44 ` H. Peter Anvin
2012-05-13 21:48 ` Kay Sievers
2012-05-13 21:30 ` Kay Sievers
2012-05-26 11:11 ` Anton Vorontsov
2012-05-27 14:23 ` Kay Sievers
2012-05-29 16:07 ` Kay Sievers
2012-05-29 16:14 ` Joe Perches
2012-05-29 16:34 ` Kay Sievers
2012-05-29 16:51 ` Joe Perches
2012-05-29 17:11 ` Luck, Tony
2012-05-29 17:22 ` Kay Sievers
2012-05-30 11:29 ` Kay Sievers
2012-06-06 6:33 ` Greg Kroah-Hartmann
2012-06-15 0:04 ` Greg KH
2012-06-15 1:31 ` Anton Vorontsov
2012-06-15 12:07 ` Kay Sievers
2012-06-15 12:23 ` Ingo Molnar
2012-06-15 21:53 ` Greg KH
2012-06-15 12:23 ` Anton Vorontsov
2012-06-15 20:54 ` Tony Luck
2012-11-28 13:33 ` Michael Kerrisk
2012-11-28 16:22 ` Kay Sievers
2012-11-28 16:37 ` Linus Torvalds
2012-11-28 16:49 ` Kay Sievers
2012-11-28 17:51 ` Kay Sievers
2012-11-29 13:18 ` Michael Kerrisk (man-pages)
2012-11-29 13:28 ` Kay Sievers
2012-11-29 13:37 ` Michael Kerrisk (man-pages)
2012-11-29 14:08 ` Kay Sievers
2012-11-29 14:18 ` Michael Kerrisk (man-pages)
2012-11-29 14:31 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFwJgtVr9ZndEU-yhJW3wi-5Omga51pjun+J213awQwJZA@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=kay@vrfy.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.