All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	Quentin Casasnovas <quentin.casasnovas@oracle.com>,
	Vegard Nossum <vegard.nossum@oracle.com>,
	Andrew Morton <akpm@linuxfoundation.org>,
	Willy Tarreau <w@1wt.eu>, Andy Lutomirski <luto@amacapital.net>,
	Kees Cook <keescook@google.com>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Konstantin Khlebnikov <koct9i@gmail.com>,
	Pavel Emelyanov <xemul@virtuozzo.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH RFC] mm: Rework virtual memory accounting
Date: Fri, 22 Jan 2016 12:30:31 -0800	[thread overview]
Message-ID: <CA+55aFwPeMhGj47DLvD7BsUd66TjxmX4_Aw9SHihmmqZue-GeA@mail.gmail.com> (raw)
In-Reply-To: <56A28613.5070104@de.ibm.com>

On Fri, Jan 22, 2016 at 11:42 AM, Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
>
> Just want to mention that this patch breaks older versions of valgrind
> (including the current release)
> https://bugs.kde.org/show_bug.cgi?id=357833

Ugh. Looks like valgrind is doing something that fundamentally can't
be "tweaked" around in the algorithm. Setting the data limit to zero
will never work with any model that starts accounting any mmap, so we
can't just tweak things a bit..

> It is fixed in trunk (and even triggered some good cleanups, so the valgrind
> developers do NOT want it to get reverted).

Hmm. If we start getting complaints from users, I suspect we'll just
have to revert. The fact that the valgrind developers are ok with the
change doesn't much matter - all that matters is whether users are ok
with it.

The only saving grace is that valgrind is fairly specialized, so it's
not like it breaks some core workflow. But I could easily see people
who run valgrind as part of some regression suite having their
day-to-day work broken.

So I'll let it slide for now, but if I start seeing complaints, I
think we'll just have to revert and wait for fixed valgrind versions
to actually percolate out to people and re-do it later.. (The
"percolate out to people" tends to take a _loong_ time, though).

                 Linus

WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	Quentin Casasnovas <quentin.casasnovas@oracle.com>,
	Vegard Nossum <vegard.nossum@oracle.com>,
	Andrew Morton <akpm@linuxfoundation.org>,
	Willy Tarreau <w@1wt.eu>, Andy Lutomirski <luto@amacapital.net>,
	Kees Cook <keescook@google.com>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Konstantin Khlebnikov <koct9i@gmail.com>,
	Pavel Emelyanov <xemul@virtuozzo.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH RFC] mm: Rework virtual memory accounting
Date: Fri, 22 Jan 2016 12:30:31 -0800	[thread overview]
Message-ID: <CA+55aFwPeMhGj47DLvD7BsUd66TjxmX4_Aw9SHihmmqZue-GeA@mail.gmail.com> (raw)
In-Reply-To: <56A28613.5070104@de.ibm.com>

On Fri, Jan 22, 2016 at 11:42 AM, Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
>
> Just want to mention that this patch breaks older versions of valgrind
> (including the current release)
> https://bugs.kde.org/show_bug.cgi?id=357833

Ugh. Looks like valgrind is doing something that fundamentally can't
be "tweaked" around in the algorithm. Setting the data limit to zero
will never work with any model that starts accounting any mmap, so we
can't just tweak things a bit..

> It is fixed in trunk (and even triggered some good cleanups, so the valgrind
> developers do NOT want it to get reverted).

Hmm. If we start getting complaints from users, I suspect we'll just
have to revert. The fact that the valgrind developers are ok with the
change doesn't much matter - all that matters is whether users are ok
with it.

The only saving grace is that valgrind is fairly specialized, so it's
not like it breaks some core workflow. But I could easily see people
who run valgrind as part of some regression suite having their
day-to-day work broken.

So I'll let it slide for now, but if I start seeing complaints, I
think we'll just have to revert and wait for fixed valgrind versions
to actually percolate out to people and re-do it later.. (The
"percolate out to people" tends to take a _loong_ time, though).

                 Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-01-22 20:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-28 21:10 [PATCH RFC] mm: Rework virtual memory accounting Cyrill Gorcunov
2015-12-28 21:10 ` Cyrill Gorcunov
2015-12-28 22:22 ` Linus Torvalds
2015-12-28 22:22   ` Linus Torvalds
2015-12-29  9:43   ` Cyrill Gorcunov
2015-12-29  9:43     ` Cyrill Gorcunov
2016-01-22 19:42   ` Christian Borntraeger
2016-01-22 19:42     ` Christian Borntraeger
2016-01-22 20:20     ` Cyrill Gorcunov
2016-01-22 20:20       ` Cyrill Gorcunov
2016-01-22 20:21     ` Andrew Morton
2016-01-22 20:21       ` Andrew Morton
2016-01-22 20:30     ` Linus Torvalds [this message]
2016-01-22 20:30       ` Linus Torvalds
2015-12-28 23:10 ` Andrew Morton
2015-12-28 23:10   ` Andrew Morton
2015-12-29  9:48   ` Cyrill Gorcunov
2015-12-29  9:48     ` Cyrill Gorcunov
  -- strict thread matches above, loose matches on Subject: below --
2015-12-14  8:12 [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA Konstantin Khlebnikov
2015-12-14  8:12 ` [PATCH RFC] mm: rework virtual memory accounting Konstantin Khlebnikov
2015-12-14  8:12   ` Konstantin Khlebnikov
2015-12-14  9:08   ` Cyrill Gorcunov
2015-12-14  9:08     ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFwPeMhGj47DLvD7BsUd66TjxmX4_Aw9SHihmmqZue-GeA@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linuxfoundation.org \
    --cc=borntraeger@de.ibm.com \
    --cc=gorcunov@gmail.com \
    --cc=keescook@google.com \
    --cc=koct9i@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=quentin.casasnovas@oracle.com \
    --cc=vdavydov@virtuozzo.com \
    --cc=vegard.nossum@oracle.com \
    --cc=w@1wt.eu \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.