* [PULL] virtio: last minute bugfix
@ 2017-11-07 15:28 ` Michael S. Tsirkin
0 siblings, 0 replies; 12+ messages in thread
From: Michael S. Tsirkin @ 2017-11-07 15:28 UTC (permalink / raw)
To: Linus Torvalds
Cc: kvm, virtualization, netdev, linux-kernel, mhocko, mst,
penguin-kernel, wei.w.wang
We had a lot of trouble agreeing on a fix, but apparently there's
finally a consensus.
The following changes since commit 39dae59d66acd86d1de24294bd2f343fd5e7a625:
Linux 4.14-rc8 (2017-11-05 13:05:14 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
for you to fetch changes up to 823b45b4f154384941d57e124ed726847e293b36:
virtio_balloon: fix deadlock on OOM (2017-11-07 17:24:59 +0200)
----------------------------------------------------------------
virtio: bugfix
Fixes a deadlock encountered with the virtio balloon.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
----------------------------------------------------------------
Michael S. Tsirkin (1):
virtio_balloon: fix deadlock on OOM
drivers/virtio/virtio_balloon.c | 30 ++++++++++++++++++++++--------
include/linux/balloon_compaction.h | 38 +++++++++++++++++++++++++++++++++++++-
mm/balloon_compaction.c | 27 +++++++++++++++++++++------
3 files changed, 80 insertions(+), 15 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread* [PULL] virtio: last minute bugfix @ 2017-11-07 15:28 ` Michael S. Tsirkin 0 siblings, 0 replies; 12+ messages in thread From: Michael S. Tsirkin @ 2017-11-07 15:28 UTC (permalink / raw) To: Linus Torvalds Cc: mhocko, kvm, mst, penguin-kernel, netdev, linux-kernel, virtualization We had a lot of trouble agreeing on a fix, but apparently there's finally a consensus. The following changes since commit 39dae59d66acd86d1de24294bd2f343fd5e7a625: Linux 4.14-rc8 (2017-11-05 13:05:14 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 823b45b4f154384941d57e124ed726847e293b36: virtio_balloon: fix deadlock on OOM (2017-11-07 17:24:59 +0200) ---------------------------------------------------------------- virtio: bugfix Fixes a deadlock encountered with the virtio balloon. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Michael S. Tsirkin (1): virtio_balloon: fix deadlock on OOM drivers/virtio/virtio_balloon.c | 30 ++++++++++++++++++++++-------- include/linux/balloon_compaction.h | 38 +++++++++++++++++++++++++++++++++++++- mm/balloon_compaction.c | 27 +++++++++++++++++++++------ 3 files changed, 80 insertions(+), 15 deletions(-) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix 2017-11-07 15:28 ` Michael S. Tsirkin @ 2017-11-07 17:23 ` Linus Torvalds -1 siblings, 0 replies; 12+ messages in thread From: Linus Torvalds @ 2017-11-07 17:23 UTC (permalink / raw) To: Michael S. Tsirkin Cc: KVM list, virtualization, Network Development, Linux Kernel Mailing List, Michal Hocko, Tetsuo Handa, wei.w.wang On Tue, Nov 7, 2017 at 7:28 AM, Michael S. Tsirkin <mst@redhat.com> wrote: > We had a lot of trouble agreeing on a fix, but apparently there's > finally a consensus. This is big and doesn't have a sign-off on the commit itself, even if you then do it in the tag. That's not how this is all supposed to work. I guess I'll take it, but please don't do things like this to me. Linus ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix @ 2017-11-07 17:23 ` Linus Torvalds 0 siblings, 0 replies; 12+ messages in thread From: Linus Torvalds @ 2017-11-07 17:23 UTC (permalink / raw) To: Michael S. Tsirkin Cc: Michal Hocko, KVM list, Tetsuo Handa, Network Development, Linux Kernel Mailing List, virtualization On Tue, Nov 7, 2017 at 7:28 AM, Michael S. Tsirkin <mst@redhat.com> wrote: > We had a lot of trouble agreeing on a fix, but apparently there's > finally a consensus. This is big and doesn't have a sign-off on the commit itself, even if you then do it in the tag. That's not how this is all supposed to work. I guess I'll take it, but please don't do things like this to me. Linus ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix 2017-11-07 17:23 ` Linus Torvalds (?) @ 2017-11-07 17:29 ` Linus Torvalds 2017-11-07 18:13 ` Michael S. Tsirkin -1 siblings, 1 reply; 12+ messages in thread From: Linus Torvalds @ 2017-11-07 17:29 UTC (permalink / raw) To: Michael S. Tsirkin Cc: KVM list, virtualization, Network Development, Linux Kernel Mailing List, Michal Hocko, Tetsuo Handa, wei.w.wang On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > I guess I'll take it, but please don't do things like this to me. Oh no I wont. The garbage you sent me doesn't even compile cleanly, and is utter shite. Not acceptable for last-minute bugfixes, and you're now on my shit-list. Linus ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix 2017-11-07 17:29 ` Linus Torvalds @ 2017-11-07 18:13 ` Michael S. Tsirkin 0 siblings, 0 replies; 12+ messages in thread From: Michael S. Tsirkin @ 2017-11-07 18:13 UTC (permalink / raw) To: Linus Torvalds Cc: KVM list, virtualization, Network Development, Linux Kernel Mailing List, Michal Hocko, Tetsuo Handa, wei.w.wang On Tue, Nov 07, 2017 at 09:29:59AM -0800, Linus Torvalds wrote: > On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds > <torvalds@linux-foundation.org> wrote: > > > > I guess I'll take it, but please don't do things like this to me. > > Oh no I wont. > > The garbage you sent me doesn't even compile cleanly, and is utter shite. > > Not acceptable for last-minute bugfixes, and you're now on my shit-list. > > Linus Sorry about that. I'll investigate what went wrong. Will be more careful not to cut corners next time around, just follow the standard procedure. -- MST ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix @ 2017-11-07 18:13 ` Michael S. Tsirkin 0 siblings, 0 replies; 12+ messages in thread From: Michael S. Tsirkin @ 2017-11-07 18:13 UTC (permalink / raw) To: Linus Torvalds Cc: Michal Hocko, KVM list, Tetsuo Handa, Network Development, Linux Kernel Mailing List, virtualization On Tue, Nov 07, 2017 at 09:29:59AM -0800, Linus Torvalds wrote: > On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds > <torvalds@linux-foundation.org> wrote: > > > > I guess I'll take it, but please don't do things like this to me. > > Oh no I wont. > > The garbage you sent me doesn't even compile cleanly, and is utter shite. > > Not acceptable for last-minute bugfixes, and you're now on my shit-list. > > Linus Sorry about that. I'll investigate what went wrong. Will be more careful not to cut corners next time around, just follow the standard procedure. -- MST ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix 2017-11-07 18:13 ` Michael S. Tsirkin (?) @ 2017-11-07 19:23 ` Michael S. Tsirkin -1 siblings, 0 replies; 12+ messages in thread From: Michael S. Tsirkin @ 2017-11-07 19:23 UTC (permalink / raw) To: Linus Torvalds Cc: Michal Hocko, KVM list, Tetsuo Handa, Network Development, Linux Kernel Mailing List, virtualization On Tue, Nov 07, 2017 at 08:13:10PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 07, 2017 at 09:29:59AM -0800, Linus Torvalds wrote: > > On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds > > <torvalds@linux-foundation.org> wrote: > > > > > > I guess I'll take it, but please don't do things like this to me. > > > > Oh no I wont. > > > > The garbage you sent me doesn't even compile cleanly, and is utter shite. > > > > Not acceptable for last-minute bugfixes, and you're now on my shit-list. > > > > Linus > > Sorry about that. > > I'll investigate what went wrong. > > Will be more careful not to cut corners next time around, just follow > the standard procedure. All right, my local tests didn't fail on new warnings, and I didn't give the zero day infrastructure enough time to do it's job. Lesson hopefully learned - don't rush it, give tools the time to do their job. Wei, you'll want to respin your 4.15 patchset on top of my fixed tree. At this point the fix will only land in 4.15, sorry about that. Thanks everyone. > -- > MST ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix 2017-11-07 18:13 ` Michael S. Tsirkin (?) (?) @ 2017-11-07 19:23 ` Michael S. Tsirkin 2017-11-08 1:24 ` Wei Wang -1 siblings, 1 reply; 12+ messages in thread From: Michael S. Tsirkin @ 2017-11-07 19:23 UTC (permalink / raw) To: Linus Torvalds Cc: KVM list, virtualization, Network Development, Linux Kernel Mailing List, Michal Hocko, Tetsuo Handa, wei.w.wang On Tue, Nov 07, 2017 at 08:13:10PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 07, 2017 at 09:29:59AM -0800, Linus Torvalds wrote: > > On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds > > <torvalds@linux-foundation.org> wrote: > > > > > > I guess I'll take it, but please don't do things like this to me. > > > > Oh no I wont. > > > > The garbage you sent me doesn't even compile cleanly, and is utter shite. > > > > Not acceptable for last-minute bugfixes, and you're now on my shit-list. > > > > Linus > > Sorry about that. > > I'll investigate what went wrong. > > Will be more careful not to cut corners next time around, just follow > the standard procedure. All right, my local tests didn't fail on new warnings, and I didn't give the zero day infrastructure enough time to do it's job. Lesson hopefully learned - don't rush it, give tools the time to do their job. Wei, you'll want to respin your 4.15 patchset on top of my fixed tree. At this point the fix will only land in 4.15, sorry about that. Thanks everyone. > -- > MST ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix 2017-11-07 19:23 ` Michael S. Tsirkin @ 2017-11-08 1:24 ` Wei Wang 0 siblings, 0 replies; 12+ messages in thread From: Wei Wang @ 2017-11-08 1:24 UTC (permalink / raw) To: Michael S. Tsirkin, Linus Torvalds Cc: KVM list, virtualization, Network Development, Linux Kernel Mailing List, Michal Hocko, Tetsuo Handa On 11/08/2017 03:23 AM, Michael S. Tsirkin wrote: > On Tue, Nov 07, 2017 at 08:13:10PM +0200, Michael S. Tsirkin wrote: >> On Tue, Nov 07, 2017 at 09:29:59AM -0800, Linus Torvalds wrote: >>> On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds >>> <torvalds@linux-foundation.org> wrote: >>>> I guess I'll take it, but please don't do things like this to me. >>> Oh no I wont. >>> >>> The garbage you sent me doesn't even compile cleanly, and is utter shite. >>> >>> Not acceptable for last-minute bugfixes, and you're now on my shit-list. >>> >>> Linus >> Sorry about that. >> >> I'll investigate what went wrong. >> >> Will be more careful not to cut corners next time around, just follow >> the standard procedure. > All right, my local tests didn't fail on new warnings, and I didn't give > the zero day infrastructure enough time to do it's job. > > Lesson hopefully learned - don't rush it, give tools the time to do > their job. > > Wei, you'll want to respin your 4.15 patchset on top of my fixed tree. > At this point the fix will only land in 4.15, sorry about that. > > Thanks everyone. > OK, I'll use the fixed tree. Thanks, Michael. Best, Wei ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix @ 2017-11-08 1:24 ` Wei Wang 0 siblings, 0 replies; 12+ messages in thread From: Wei Wang @ 2017-11-08 1:24 UTC (permalink / raw) To: Michael S. Tsirkin, Linus Torvalds Cc: Michal Hocko, KVM list, Tetsuo Handa, Network Development, Linux Kernel Mailing List, virtualization On 11/08/2017 03:23 AM, Michael S. Tsirkin wrote: > On Tue, Nov 07, 2017 at 08:13:10PM +0200, Michael S. Tsirkin wrote: >> On Tue, Nov 07, 2017 at 09:29:59AM -0800, Linus Torvalds wrote: >>> On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds >>> <torvalds@linux-foundation.org> wrote: >>>> I guess I'll take it, but please don't do things like this to me. >>> Oh no I wont. >>> >>> The garbage you sent me doesn't even compile cleanly, and is utter shite. >>> >>> Not acceptable for last-minute bugfixes, and you're now on my shit-list. >>> >>> Linus >> Sorry about that. >> >> I'll investigate what went wrong. >> >> Will be more careful not to cut corners next time around, just follow >> the standard procedure. > All right, my local tests didn't fail on new warnings, and I didn't give > the zero day infrastructure enough time to do it's job. > > Lesson hopefully learned - don't rush it, give tools the time to do > their job. > > Wei, you'll want to respin your 4.15 patchset on top of my fixed tree. > At this point the fix will only land in 4.15, sorry about that. > > Thanks everyone. > OK, I'll use the fixed tree. Thanks, Michael. Best, Wei ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL] virtio: last minute bugfix 2017-11-07 17:23 ` Linus Torvalds (?) (?) @ 2017-11-07 17:29 ` Linus Torvalds -1 siblings, 0 replies; 12+ messages in thread From: Linus Torvalds @ 2017-11-07 17:29 UTC (permalink / raw) To: Michael S. Tsirkin Cc: Michal Hocko, KVM list, Tetsuo Handa, Network Development, Linux Kernel Mailing List, virtualization On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > I guess I'll take it, but please don't do things like this to me. Oh no I wont. The garbage you sent me doesn't even compile cleanly, and is utter shite. Not acceptable for last-minute bugfixes, and you're now on my shit-list. Linus ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-11-08 1:24 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-11-07 15:28 [PULL] virtio: last minute bugfix Michael S. Tsirkin 2017-11-07 15:28 ` Michael S. Tsirkin 2017-11-07 17:23 ` Linus Torvalds 2017-11-07 17:23 ` Linus Torvalds 2017-11-07 17:29 ` Linus Torvalds 2017-11-07 18:13 ` Michael S. Tsirkin 2017-11-07 18:13 ` Michael S. Tsirkin 2017-11-07 19:23 ` Michael S. Tsirkin 2017-11-07 19:23 ` Michael S. Tsirkin 2017-11-08 1:24 ` Wei Wang 2017-11-08 1:24 ` Wei Wang 2017-11-07 17:29 ` Linus Torvalds
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.