From: Linus Torvalds <torvalds@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Colin Ian King <colin.king@canonical.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] trivial for 4.9
Date: Fri, 7 Oct 2016 14:37:14 -0700 [thread overview]
Message-ID: <CA+55aFxnEd5HGbL9rk4XOs73Cd2Ji4HXBb-M_ZSx9bPq=mb2tg@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFzXfy3X5-0V=jNEKUVntfq_2e8-ExxCTfcgSr+LhVBv+w@mail.gmail.com>
On Fri, Oct 7, 2016 at 2:06 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> And btw, even without an explicit KERN_<level>, you should still not
> get any interleaving. Only an _explicit_ KERN_CONT should cause
> interleaving
Btw, note the "should" there. Because we do seem to have broken that
_again_. It worked fine at some point, but lookie here:
commit 61e99ab8e35a88b8c4d0f80d3df9ee16df471be5
Author: Joe Perches <joe@perches.com>
Date: Mon Jul 30 14:40:21 2012 -0700
printk: remove the now unnecessary "C" annotation for KERN_CONT
Now that all KERN_<LEVEL> uses are prefixed with ASCII SOH, there is no
need for a KERN_CONT. Keep it backward compatible by adding #define
KERN_CONT ""
Joe, you *are* the problem here.
So you are literally the person who broke this.
Goddammit, I don't want to hear another peep from you. You broke this
because you wanted to save a few bytes in those strings, and then
*because* you broke it, you then argue for putting those bytes back in
the form of "\n" characters.
Fuck me sideways. You make this big deal about how this interleaving
is a big problem, and at no point did you actually point to the real
issue, which was your very own breakage where you made it all fragile.
Christ.
Linus
next prev parent reply other threads:[~2016-10-07 21:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 8:51 [GIT PULL] trivial for 4.9 Jiri Kosina
2016-10-07 19:22 ` Linus Torvalds
2016-10-07 20:04 ` Joe Perches
2016-10-07 20:13 ` Linus Torvalds
2016-10-07 20:18 ` Joe Perches
2016-10-07 20:25 ` Linus Torvalds
2016-10-07 20:33 ` Joe Perches
2016-10-07 21:06 ` Linus Torvalds
2016-10-07 21:37 ` Linus Torvalds [this message]
2016-10-08 7:36 ` Joe Perches
2016-10-10 5:48 ` Joe Perches
2016-10-07 21:44 ` Joe Perches
2016-10-07 23:01 ` Tony Luck
2016-10-07 23:09 ` Tony Luck
2016-10-07 23:36 ` Linus Torvalds
2016-10-08 13:16 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxnEd5HGbL9rk4XOs73Cd2Ji4HXBb-M_ZSx9bPq=mb2tg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=jikos@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.