From: Linus Torvalds <torvalds@linux-foundation.org> To: Oleg Nesterov <oleg@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Michael Kerrisk <mtk.manpages@gmail.com>, linux-man@vger.kernel.org, libc-alpha <libc-alpha@sourceware.org> Subject: Re: signals: Bug or manpage inconsistency? Date: Tue, 30 May 2017 10:19:32 -0700 [thread overview] Message-ID: <CA+55aFygrsUhzQzEOX7YLzxMWE_GbKhJjQZ7nSDXnFFbRAWCJA@mail.gmail.com> (raw) In-Reply-To: <20170530170414.GA22463@redhat.com> On Tue, May 30, 2017 at 10:04 AM, Oleg Nesterov <oleg@redhat.com> wrote: > > I can't comment, I never tried to understand the rationality behind the current > behaviour. But at least the sending path should never drop a blocked SIG_DFL > signal, there is no other way to ensure you won't miss a signal during exec. Note that both SIG_DFL _and_ SIG_IGN are possible after exec, so if you don't want to drop particular signals to the new process (which may then add its own handler and want them), using the signal blocked mask is the rigth thing to do for both of them, SIG_IGN doesn't mean "ignore signal forever". It means "ignore signals right now", and I think that our current signal blocking semantics are likely the correct ones, exactly because it means "when you start blocking signals, the kernel will not drop them". There is no difference wrt SIG_DFL and SIG_IGN in this sense. > Obviously this is a user-visible change and it can break something. Say, an > application does sigwaitinfo(SIGCHLD) and SIGCHLD is ignored (SIG_IGN), this > will no longer work. That's an interesting special case. Yes, SIG_IGN actually has magical properties wrt SIGCHLD. It basically means the opposite of ignoring it, it's an "implicit signal handler". So I could imagine people using SIG_IGN to avoid the signal handler, but then block SIG_CHLD and using sigwait() for it. That sounds nonportable as hell, but I could imagine people doing it because it happens to work. So again, I really wouldn't want to change existing semantics unless there is a big real reason for it. Our current semantics are not wrong. Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> To: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, libc-alpha <libc-alpha-9JcytcrH/bA+uJoB2kUjGw@public.gmane.org> Subject: Re: signals: Bug or manpage inconsistency? Date: Tue, 30 May 2017 10:19:32 -0700 [thread overview] Message-ID: <CA+55aFygrsUhzQzEOX7YLzxMWE_GbKhJjQZ7nSDXnFFbRAWCJA@mail.gmail.com> (raw) In-Reply-To: <20170530170414.GA22463-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> On Tue, May 30, 2017 at 10:04 AM, Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: > > I can't comment, I never tried to understand the rationality behind the current > behaviour. But at least the sending path should never drop a blocked SIG_DFL > signal, there is no other way to ensure you won't miss a signal during exec. Note that both SIG_DFL _and_ SIG_IGN are possible after exec, so if you don't want to drop particular signals to the new process (which may then add its own handler and want them), using the signal blocked mask is the rigth thing to do for both of them, SIG_IGN doesn't mean "ignore signal forever". It means "ignore signals right now", and I think that our current signal blocking semantics are likely the correct ones, exactly because it means "when you start blocking signals, the kernel will not drop them". There is no difference wrt SIG_DFL and SIG_IGN in this sense. > Obviously this is a user-visible change and it can break something. Say, an > application does sigwaitinfo(SIGCHLD) and SIGCHLD is ignored (SIG_IGN), this > will no longer work. That's an interesting special case. Yes, SIG_IGN actually has magical properties wrt SIGCHLD. It basically means the opposite of ignoring it, it's an "implicit signal handler". So I could imagine people using SIG_IGN to avoid the signal handler, but then block SIG_CHLD and using sigwait() for it. That sounds nonportable as hell, but I could imagine people doing it because it happens to work. So again, I really wouldn't want to change existing semantics unless there is a big real reason for it. Our current semantics are not wrong. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-30 17:19 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-30 13:21 signals: Bug or manpage inconsistency? Thomas Gleixner 2017-05-30 16:14 ` Thomas Gleixner 2017-05-30 16:14 ` Thomas Gleixner 2017-05-30 17:04 ` Oleg Nesterov 2017-05-30 17:19 ` Linus Torvalds [this message] 2017-05-30 17:19 ` Linus Torvalds 2017-05-30 19:18 ` Oleg Nesterov 2017-05-30 19:18 ` Oleg Nesterov 2017-05-30 20:54 ` Thomas Gleixner 2017-05-30 20:54 ` Thomas Gleixner 2017-05-31 0:48 ` Eric W. Biederman 2017-05-31 0:48 ` Eric W. Biederman 2017-05-31 1:10 ` Eric W. Biederman 2017-05-31 1:10 ` Eric W. Biederman 2017-05-30 17:04 ` Linus Torvalds 2017-05-30 17:04 ` Linus Torvalds 2017-05-30 19:35 ` Thomas Gleixner 2017-05-30 19:35 ` Thomas Gleixner 2017-05-30 19:58 ` Linus Torvalds 2017-05-30 19:58 ` Linus Torvalds 2017-05-30 21:00 ` Thomas Gleixner 2017-05-30 21:00 ` Thomas Gleixner 2017-05-31 6:51 ` Michael Kerrisk (man-pages) 2017-05-31 6:51 ` Michael Kerrisk (man-pages) 2017-06-01 7:01 ` Eric W. Biederman 2017-06-01 7:01 ` Eric W. Biederman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+55aFygrsUhzQzEOX7YLzxMWE_GbKhJjQZ7nSDXnFFbRAWCJA@mail.gmail.com \ --to=torvalds@linux-foundation.org \ --cc=libc-alpha@sourceware.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-man@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=mtk.manpages@gmail.com \ --cc=oleg@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.