All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Airlie <airlied@gmail.com>,
	Jordan Crouse <jcrouse@codeaurora.org>,
	Rob Clark <robdclark@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm for v4.15
Date: Wed, 15 Nov 2017 20:59:33 -0800	[thread overview]
Message-ID: <CA+55aFzCfbqEn=VSn8rhcLm9sTqaRTCQ3AgxhZA2xuP-P3QFBA@mail.gmail.com> (raw)
In-Reply-To: <CAPM=9tz-HT7ynGrzXwtnaDcj+0MumLBj1Z8VUB+v6W=9P_eaNA@mail.gmail.com>

On Wed, Nov 15, 2017 at 6:34 PM, Dave Airlie <airlied@gmail.com> wrote:
>
> There is some code touched on sound/soc, but I think the sound tree
> should have the same commits from the same base,so this may luck different
> if you pulled it as I generated my pull request a couple of days ago. Otherwise
> the highlights are below.

I'm more curious about (and disgusted by) this one:

  include/dt-bindings/msm/msm-bus-ids.h

wtf? It's full of defines that aren't actually used anywhere.  Which
is just as well, since it doesn't seem to be included from anything
either.

There's something odd about drm people. You guys like these completely
insane generated header files, and you seem to be populating the whole
tree with this odd and diseased notion of "generated header files are
cool".

Is somebody getting paid by line of code?

Yeah, yeah, we have those nasty dt-bindings heades from before too,
but this one is one of the bigger ones, and it really comes with no
explanation, and a commit message that doesn't really mention
device-tree at all.

Honestly, it seems like it got committed by mistake.

I've pulled it, but Christ on a stick!

              Linus

WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Airlie <airlied@gmail.com>,
	Jordan Crouse <jcrouse@codeaurora.org>,
	Rob Clark <robdclark@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [git pull] drm for v4.15
Date: Wed, 15 Nov 2017 20:59:33 -0800	[thread overview]
Message-ID: <CA+55aFzCfbqEn=VSn8rhcLm9sTqaRTCQ3AgxhZA2xuP-P3QFBA@mail.gmail.com> (raw)
In-Reply-To: <CAPM=9tz-HT7ynGrzXwtnaDcj+0MumLBj1Z8VUB+v6W=9P_eaNA@mail.gmail.com>

On Wed, Nov 15, 2017 at 6:34 PM, Dave Airlie <airlied@gmail.com> wrote:
>
> There is some code touched on sound/soc, but I think the sound tree
> should have the same commits from the same base,so this may luck different
> if you pulled it as I generated my pull request a couple of days ago. Otherwise
> the highlights are below.

I'm more curious about (and disgusted by) this one:

  include/dt-bindings/msm/msm-bus-ids.h

wtf? It's full of defines that aren't actually used anywhere.  Which
is just as well, since it doesn't seem to be included from anything
either.

There's something odd about drm people. You guys like these completely
insane generated header files, and you seem to be populating the whole
tree with this odd and diseased notion of "generated header files are
cool".

Is somebody getting paid by line of code?

Yeah, yeah, we have those nasty dt-bindings heades from before too,
but this one is one of the bigger ones, and it really comes with no
explanation, and a commit message that doesn't really mention
device-tree at all.

Honestly, it seems like it got committed by mistake.

I've pulled it, but Christ on a stick!

              Linus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-11-16  4:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16  2:34 [git pull] drm for v4.15 Dave Airlie
2017-11-16  2:34 ` Dave Airlie
2017-11-16  4:59 ` Linus Torvalds [this message]
2017-11-16  4:59   ` Linus Torvalds
2017-11-16 13:57   ` Rob Clark
2017-11-16 13:57     ` Rob Clark
2017-11-16 17:17   ` Michel Dänzer
2017-11-16 17:17     ` Michel Dänzer
2017-11-16 20:57   ` Dave Airlie
2017-11-16 20:57     ` Dave Airlie
2017-11-16 21:05     ` Linus Torvalds
2017-11-16 21:05       ` Linus Torvalds
2017-11-17 12:51     ` Nicolai Hähnle
2017-11-17 12:51       ` Nicolai Hähnle
2017-11-17 16:57       ` Linus Torvalds
2017-11-17 16:57         ` Linus Torvalds
2017-11-17 17:19         ` Lukas Wunner
2017-11-17 17:24           ` Linus Torvalds
2017-11-17 17:24             ` Linus Torvalds
2017-11-17 18:14         ` Christian König
2017-11-17 18:14           ` Christian König
2017-11-17 18:55           ` Linus Torvalds
2017-11-17 18:55             ` Linus Torvalds
2017-11-17 19:18             ` Christian König
2017-11-17 19:18               ` Christian König
2017-11-18 10:49               ` Nicolai Hähnle
2017-11-18 10:49                 ` Nicolai Hähnle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+55aFzCfbqEn=VSn8rhcLm9sTqaRTCQ3AgxhZA2xuP-P3QFBA@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jcrouse@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.