All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Hugh Dickins <hughd@google.com>,
	kernel test robot <xiaolong.ye@intel.com>,
	Michal Hocko <mhocko@suse.com>,
	LKML <linux-kernel@vger.kernel.org>, LKP <lkp@01.org>
Subject: Re: [lkp-robot] [mm] 1be7107fbe: kernel_BUG_at_mm/mmap.c
Date: Wed, 21 Jun 2017 15:19:36 -0700	[thread overview]
Message-ID: <CA+55aFzVEzC=FkFihCOyHyDkMP+eq_DR826oXLinrJ7YmENZ7Q@mail.gmail.com> (raw)
In-Reply-To: <20170621205617.GA29841@redhat.com>

On Wed, Jun 21, 2017 at 1:56 PM, Oleg Nesterov <oleg@redhat.com> wrote:
>
> I understand. My point is that this check was invalidated by stack-guard-page
> a long ago, and this means that we add the user-visible change now.

Yeah. I guess we could consider it an *old* regression that got fixed,
but if people started relying on the regression...

>> Do you have a pointer to the report for this regression? I must have missed it.
>
> See http://marc.info/?t=149794523000001&r=1&w=2

Ok.

And thinking about it, while that is a silly test-case, the notion of
"create top-down segment, then start populating it _before_ moving the
stack pointer into it" is actually perfectly valid.

So I guess checking against the stack pointer is wrong in that case -
at least if the stack pointer isn't inside that vma to begin with.

So yes, removing that check looks like the right thing to do for now.

Do you want to send me the patch if you already have a commit message etc?

                    Linus

WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: lkp@lists.01.org
Subject: Re: [lkp-robot] [mm] 1be7107fbe: kernel_BUG_at_mm/mmap.c
Date: Wed, 21 Jun 2017 15:19:36 -0700	[thread overview]
Message-ID: <CA+55aFzVEzC=FkFihCOyHyDkMP+eq_DR826oXLinrJ7YmENZ7Q@mail.gmail.com> (raw)
In-Reply-To: <20170621205617.GA29841@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

On Wed, Jun 21, 2017 at 1:56 PM, Oleg Nesterov <oleg@redhat.com> wrote:
>
> I understand. My point is that this check was invalidated by stack-guard-page
> a long ago, and this means that we add the user-visible change now.

Yeah. I guess we could consider it an *old* regression that got fixed,
but if people started relying on the regression...

>> Do you have a pointer to the report for this regression? I must have missed it.
>
> See http://marc.info/?t=149794523000001&r=1&w=2

Ok.

And thinking about it, while that is a silly test-case, the notion of
"create top-down segment, then start populating it _before_ moving the
stack pointer into it" is actually perfectly valid.

So I guess checking against the stack pointer is wrong in that case -
at least if the stack pointer isn't inside that vma to begin with.

So yes, removing that check looks like the right thing to do for now.

Do you want to send me the patch if you already have a commit message etc?

                    Linus

  reply	other threads:[~2017-06-21 22:19 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  2:35 [lkp-robot] [mm] 1be7107fbe: kernel_BUG_at_mm/mmap.c kernel test robot
2017-06-21  2:35 ` kernel test robot
2017-06-21  2:41 ` Hugh Dickins
2017-06-21  2:41   ` Hugh Dickins
2017-06-21 18:29   ` Linus Torvalds
2017-06-21 18:29     ` Linus Torvalds
2017-06-21 19:33     ` Oleg Nesterov
2017-06-21 19:33       ` Oleg Nesterov
2017-06-21 19:39       ` Linus Torvalds
2017-06-21 19:39         ` Linus Torvalds
2017-06-21 20:27         ` Oleg Nesterov
2017-06-21 20:27           ` Oleg Nesterov
2017-06-21 20:30           ` Linus Torvalds
2017-06-21 20:30             ` Linus Torvalds
2017-06-21 20:56             ` Oleg Nesterov
2017-06-21 20:56               ` Oleg Nesterov
2017-06-21 22:19               ` Linus Torvalds [this message]
2017-06-21 22:19                 ` Linus Torvalds
2017-06-22  1:07                 ` Hugh Dickins
2017-06-22  1:07                   ` Hugh Dickins
2017-06-22 10:58                   ` Dmitry Safonov
2017-06-22 10:58                     ` Dmitry Safonov
2017-06-22 15:16                   ` Oleg Nesterov
2017-06-22 15:16                     ` Oleg Nesterov
2017-06-22 18:04                     ` Hugh Dickins
2017-06-22 18:04                       ` Hugh Dickins
2017-06-22 20:51                       ` Oleg Nesterov
2017-06-22 20:51                         ` Oleg Nesterov
2017-06-22  4:23       ` Hugh Dickins
2017-06-22  4:23         ` Hugh Dickins
2017-06-21 19:39     ` Hugh Dickins
2017-06-21 19:39       ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+55aFzVEzC=FkFihCOyHyDkMP+eq_DR826oXLinrJ7YmENZ7Q@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mhocko@suse.com \
    --cc=oleg@redhat.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.