* [BUG] cypress: Fix link direction
@ 2021-01-08 20:44 Jeremy Linton
2021-01-08 22:08 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Linton @ 2021-01-08 20:44 UTC (permalink / raw)
To: linux-firmware
Cc: Jeremy Linton, Peter Robinson, Hans de Goede, Chi-Hsien Lin, Josh Boyer
It appears the link direction was incorrect resulting
in dangling symlinks. This also causes the brcm devices
to be unable to find their firmware
Fixes: 060ad8b3d505e ("cypress: Link the new cypress firmware to the old brcm files")
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Cc: Peter Robinson <pbrobinson@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc: Josh Boyer <jwboyer@kernel.org>
---
WHENCE | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/WHENCE b/WHENCE
index 676bb18..cbde48d 100644
--- a/WHENCE
+++ b/WHENCE
@@ -2651,47 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details.
File: brcm/brcmfmac4373.bin
File: cypress/cyfmac43012-sdio.bin
-Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin
+Link: brcm/brcmfmac43012-sdio.bin -> ../cypress/cyfmac43012-sdio.bin
File: cypress/cyfmac43012-sdio.clm_blob
-Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob
+Link: brcm/brcmfmac43012-sdio.clm_blob -> ../cypress/cyfmac43012-sdio.clm_blob
File: cypress/cyfmac43340-sdio.bin
-Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin
+Link: brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin
File: cypress/cyfmac43362-sdio.bin
-Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin
+Link: brcm/brcmfmac43362-sdio.bin -> ../cypress/cyfmac43362-sdio.bin
File: cypress/cyfmac4339-sdio.bin
-Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin
+Link: brcm/brcmfmac4339-sdio.bin -> ../cypress/cyfmac4339-sdio.bin
File: cypress/cyfmac43430-sdio.bin
-Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin
+Link: brcm/brcmfmac43430-sdio.bin -> ../cypress/cyfmac43430-sdio.bin
File: cypress/cyfmac43430-sdio.clm_blob
-Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob
+Link: brcm/brcmfmac43430-sdio.clm_blob -> ../cypress/cyfmac43430-sdio.clm_blob
File: cypress/cyfmac43455-sdio.bin
-Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin
+Link: brcm/brcmfmac43455-sdio.bin -> ../cypress/cyfmac43455-sdio.bin
File: cypress/cyfmac43455-sdio.clm_blob
-Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob
+Link: brcm/brcmfmac43455-sdio.clm_blob -> ../cypress/cyfmac43455-sdio.clm_blob
File: cypress/cyfmac4354-sdio.bin
-Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin
+Link: brcm/brcmfmac4354-sdio.bin -> ../cypress/cyfmac4354-sdio.bin
File: cypress/cyfmac4354-sdio.clm_blob
-Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob
+Link: brcm/brcmfmac4354-sdio.clm_blob -> ../cypress/cyfmac4354-sdio.clm_blob
File: cypress/cyfmac4356-pcie.bin
-Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin
+Link: brcm/brcmfmac4356-pcie.bin -> ../cypress/cyfmac4356-pcie.bin
File: cypress/cyfmac4356-pcie.clm_blob
-Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob
+Link: brcm/brcmfmac4356-pcie.clm_blob -> ../cypress/cyfmac4356-pcie.clm_blob
File: cypress/cyfmac4356-sdio.bin
-Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin
+Link: brcm/brcmfmac4356-sdio.bin -> ../cypress/cyfmac4356-sdio.bin
File: cypress/cyfmac4356-sdio.clm_blob
-Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob
+Link: brcm/brcmfmac4356-sdio.clm_blob -> ../cypress/cyfmac4356-sdio.clm_blob
File: cypress/cyfmac43570-pcie.bin
-Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin
+Link: brcm/brcmfmac43570-pcie.bin -> ../cypress/cyfmac43570-pcie.bin
File: cypress/cyfmac43570-pcie.clm_blob
-Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob
+Link: brcm/brcmfmac43570-pcie.clm_blob -> ../cypress/cyfmac43570-pcie.clm_blob
File: cypress/cyfmac4373-sdio.bin
-Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin
+Link: brcm/brcmfmac4373-sdio.bin -> ../cypress/cyfmac4373-sdio.bin
File: cypress/cyfmac4373-sdio.clm_blob
-Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob
+Link: brcm/brcmfmac4373-sdio.clm_blob -> ../cypress/cyfmac4373-sdio.clm_blob
File: cypress/cyfmac54591-pcie.bin
-Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin
+Link: brcm/brcmfmac54591-pcie.bin -> ../cypress/cyfmac54591-pcie.bin
File: cypress/cyfmac54591-pcie.clm_blob
-Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob
+Link: brcm/brcmfmac54591-pcie.clm_blob -> ../cypress/cyfmac54591-pcie.clm_blob
Licence: Redistributable. See LICENCE.cypress for details.
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [BUG] cypress: Fix link direction
2021-01-08 20:44 [BUG] cypress: Fix link direction Jeremy Linton
@ 2021-01-08 22:08 ` Hans de Goede
2021-01-09 0:33 ` Josh Boyer
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2021-01-08 22:08 UTC (permalink / raw)
To: Jeremy Linton, linux-firmware; +Cc: Peter Robinson, Chi-Hsien Lin, Josh Boyer
Hi,
On 1/8/21 9:44 PM, Jeremy Linton wrote:
> It appears the link direction was incorrect resulting
> in dangling symlinks. This also causes the brcm devices
> to be unable to find their firmware
>
> Fixes: 060ad8b3d505e ("cypress: Link the new cypress firmware to the old brcm files")
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> Cc: Peter Robinson <pbrobinson@gmail.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> Cc: Josh Boyer <jwboyer@kernel.org>
<ugh>, thank you for catching this.
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> WHENCE | 42 +++++++++++++++++++++---------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/WHENCE b/WHENCE
> index 676bb18..cbde48d 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2651,47 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details.
>
> File: brcm/brcmfmac4373.bin
> File: cypress/cyfmac43012-sdio.bin
> -Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin
> +Link: brcm/brcmfmac43012-sdio.bin -> ../cypress/cyfmac43012-sdio.bin
> File: cypress/cyfmac43012-sdio.clm_blob
> -Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob
> +Link: brcm/brcmfmac43012-sdio.clm_blob -> ../cypress/cyfmac43012-sdio.clm_blob
> File: cypress/cyfmac43340-sdio.bin
> -Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin
> +Link: brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin
> File: cypress/cyfmac43362-sdio.bin
> -Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin
> +Link: brcm/brcmfmac43362-sdio.bin -> ../cypress/cyfmac43362-sdio.bin
> File: cypress/cyfmac4339-sdio.bin
> -Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin
> +Link: brcm/brcmfmac4339-sdio.bin -> ../cypress/cyfmac4339-sdio.bin
> File: cypress/cyfmac43430-sdio.bin
> -Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin
> +Link: brcm/brcmfmac43430-sdio.bin -> ../cypress/cyfmac43430-sdio.bin
> File: cypress/cyfmac43430-sdio.clm_blob
> -Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob
> +Link: brcm/brcmfmac43430-sdio.clm_blob -> ../cypress/cyfmac43430-sdio.clm_blob
> File: cypress/cyfmac43455-sdio.bin
> -Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin
> +Link: brcm/brcmfmac43455-sdio.bin -> ../cypress/cyfmac43455-sdio.bin
> File: cypress/cyfmac43455-sdio.clm_blob
> -Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob
> +Link: brcm/brcmfmac43455-sdio.clm_blob -> ../cypress/cyfmac43455-sdio.clm_blob
> File: cypress/cyfmac4354-sdio.bin
> -Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin
> +Link: brcm/brcmfmac4354-sdio.bin -> ../cypress/cyfmac4354-sdio.bin
> File: cypress/cyfmac4354-sdio.clm_blob
> -Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob
> +Link: brcm/brcmfmac4354-sdio.clm_blob -> ../cypress/cyfmac4354-sdio.clm_blob
> File: cypress/cyfmac4356-pcie.bin
> -Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin
> +Link: brcm/brcmfmac4356-pcie.bin -> ../cypress/cyfmac4356-pcie.bin
> File: cypress/cyfmac4356-pcie.clm_blob
> -Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob
> +Link: brcm/brcmfmac4356-pcie.clm_blob -> ../cypress/cyfmac4356-pcie.clm_blob
> File: cypress/cyfmac4356-sdio.bin
> -Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin
> +Link: brcm/brcmfmac4356-sdio.bin -> ../cypress/cyfmac4356-sdio.bin
> File: cypress/cyfmac4356-sdio.clm_blob
> -Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob
> +Link: brcm/brcmfmac4356-sdio.clm_blob -> ../cypress/cyfmac4356-sdio.clm_blob
> File: cypress/cyfmac43570-pcie.bin
> -Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin
> +Link: brcm/brcmfmac43570-pcie.bin -> ../cypress/cyfmac43570-pcie.bin
> File: cypress/cyfmac43570-pcie.clm_blob
> -Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob
> +Link: brcm/brcmfmac43570-pcie.clm_blob -> ../cypress/cyfmac43570-pcie.clm_blob
> File: cypress/cyfmac4373-sdio.bin
> -Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin
> +Link: brcm/brcmfmac4373-sdio.bin -> ../cypress/cyfmac4373-sdio.bin
> File: cypress/cyfmac4373-sdio.clm_blob
> -Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob
> +Link: brcm/brcmfmac4373-sdio.clm_blob -> ../cypress/cyfmac4373-sdio.clm_blob
> File: cypress/cyfmac54591-pcie.bin
> -Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin
> +Link: brcm/brcmfmac54591-pcie.bin -> ../cypress/cyfmac54591-pcie.bin
> File: cypress/cyfmac54591-pcie.clm_blob
> -Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob
> +Link: brcm/brcmfmac54591-pcie.clm_blob -> ../cypress/cyfmac54591-pcie.clm_blob
>
> Licence: Redistributable. See LICENCE.cypress for details.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [BUG] cypress: Fix link direction
2021-01-08 22:08 ` Hans de Goede
@ 2021-01-09 0:33 ` Josh Boyer
0 siblings, 0 replies; 3+ messages in thread
From: Josh Boyer @ 2021-01-09 0:33 UTC (permalink / raw)
To: Hans de Goede
Cc: Jeremy Linton, Linux Firmware, Peter Robinson, Chi-Hsien Lin
On Fri, Jan 8, 2021 at 5:08 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 1/8/21 9:44 PM, Jeremy Linton wrote:
> > It appears the link direction was incorrect resulting
> > in dangling symlinks. This also causes the brcm devices
> > to be unable to find their firmware
> >
> > Fixes: 060ad8b3d505e ("cypress: Link the new cypress firmware to the old brcm files")
> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> > Cc: Peter Robinson <pbrobinson@gmail.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> > Cc: Josh Boyer <jwboyer@kernel.org>
>
> <ugh>, thank you for catching this.
Indeed. I should have caught this as well. Thank you.
Patch applied and pushed out. I'll get to the rest tomorrow.
josh
> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Regards,
>
> Hans
>
> > ---
> > WHENCE | 42 +++++++++++++++++++++---------------------
> > 1 file changed, 21 insertions(+), 21 deletions(-)
> >
> > diff --git a/WHENCE b/WHENCE
> > index 676bb18..cbde48d 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -2651,47 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details.
> >
> > File: brcm/brcmfmac4373.bin
> > File: cypress/cyfmac43012-sdio.bin
> > -Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin
> > +Link: brcm/brcmfmac43012-sdio.bin -> ../cypress/cyfmac43012-sdio.bin
> > File: cypress/cyfmac43012-sdio.clm_blob
> > -Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob
> > +Link: brcm/brcmfmac43012-sdio.clm_blob -> ../cypress/cyfmac43012-sdio.clm_blob
> > File: cypress/cyfmac43340-sdio.bin
> > -Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin
> > +Link: brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin
> > File: cypress/cyfmac43362-sdio.bin
> > -Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin
> > +Link: brcm/brcmfmac43362-sdio.bin -> ../cypress/cyfmac43362-sdio.bin
> > File: cypress/cyfmac4339-sdio.bin
> > -Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin
> > +Link: brcm/brcmfmac4339-sdio.bin -> ../cypress/cyfmac4339-sdio.bin
> > File: cypress/cyfmac43430-sdio.bin
> > -Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin
> > +Link: brcm/brcmfmac43430-sdio.bin -> ../cypress/cyfmac43430-sdio.bin
> > File: cypress/cyfmac43430-sdio.clm_blob
> > -Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob
> > +Link: brcm/brcmfmac43430-sdio.clm_blob -> ../cypress/cyfmac43430-sdio.clm_blob
> > File: cypress/cyfmac43455-sdio.bin
> > -Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin
> > +Link: brcm/brcmfmac43455-sdio.bin -> ../cypress/cyfmac43455-sdio.bin
> > File: cypress/cyfmac43455-sdio.clm_blob
> > -Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob
> > +Link: brcm/brcmfmac43455-sdio.clm_blob -> ../cypress/cyfmac43455-sdio.clm_blob
> > File: cypress/cyfmac4354-sdio.bin
> > -Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin
> > +Link: brcm/brcmfmac4354-sdio.bin -> ../cypress/cyfmac4354-sdio.bin
> > File: cypress/cyfmac4354-sdio.clm_blob
> > -Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob
> > +Link: brcm/brcmfmac4354-sdio.clm_blob -> ../cypress/cyfmac4354-sdio.clm_blob
> > File: cypress/cyfmac4356-pcie.bin
> > -Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin
> > +Link: brcm/brcmfmac4356-pcie.bin -> ../cypress/cyfmac4356-pcie.bin
> > File: cypress/cyfmac4356-pcie.clm_blob
> > -Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob
> > +Link: brcm/brcmfmac4356-pcie.clm_blob -> ../cypress/cyfmac4356-pcie.clm_blob
> > File: cypress/cyfmac4356-sdio.bin
> > -Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin
> > +Link: brcm/brcmfmac4356-sdio.bin -> ../cypress/cyfmac4356-sdio.bin
> > File: cypress/cyfmac4356-sdio.clm_blob
> > -Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob
> > +Link: brcm/brcmfmac4356-sdio.clm_blob -> ../cypress/cyfmac4356-sdio.clm_blob
> > File: cypress/cyfmac43570-pcie.bin
> > -Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin
> > +Link: brcm/brcmfmac43570-pcie.bin -> ../cypress/cyfmac43570-pcie.bin
> > File: cypress/cyfmac43570-pcie.clm_blob
> > -Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob
> > +Link: brcm/brcmfmac43570-pcie.clm_blob -> ../cypress/cyfmac43570-pcie.clm_blob
> > File: cypress/cyfmac4373-sdio.bin
> > -Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin
> > +Link: brcm/brcmfmac4373-sdio.bin -> ../cypress/cyfmac4373-sdio.bin
> > File: cypress/cyfmac4373-sdio.clm_blob
> > -Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob
> > +Link: brcm/brcmfmac4373-sdio.clm_blob -> ../cypress/cyfmac4373-sdio.clm_blob
> > File: cypress/cyfmac54591-pcie.bin
> > -Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin
> > +Link: brcm/brcmfmac54591-pcie.bin -> ../cypress/cyfmac54591-pcie.bin
> > File: cypress/cyfmac54591-pcie.clm_blob
> > -Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob
> > +Link: brcm/brcmfmac54591-pcie.clm_blob -> ../cypress/cyfmac54591-pcie.clm_blob
> >
> > Licence: Redistributable. See LICENCE.cypress for details.
> >
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-09 0:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 20:44 [BUG] cypress: Fix link direction Jeremy Linton
2021-01-08 22:08 ` Hans de Goede
2021-01-09 0:33 ` Josh Boyer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.