From: Amitoj Kaur Chawla <amitoj1606@gmail.com> To: Wolfram Sang <wsa@the-dreams.de> Cc: Julia Lawall <Julia.Lawall@lip6.fr>, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, mmarek@suse.com, cocci@systeme.lip6.fr, "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org> Subject: Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource Date: Thu, 30 Jun 2016 08:13:28 +0530 [thread overview] Message-ID: <CA+5yK5GBcm3TFdU_vAFDsob2CqsUuVwaZEQEL-8bc4pEGoP12Q@mail.gmail.com> (raw) In-Reply-To: <20160629192357.GA9260@tetsubishi> On Thu, Jun 30, 2016 at 12:53 AM, Wolfram Sang <wsa@the-dreams.de> wrote: > On Thu, Jun 30, 2016 at 12:03:47AM +0530, Amitoj Kaur Chawla wrote: >> This script detects cases which have incorrect error handling for >> devm_ioremap_resource function, employing a NULL test instead of an >> IS_ERR() test. >> >> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> > > Why don't we fix the code at the same time? > Thank you for your suggestion. I will fix this up and resend. > And it should not be restricted to devm_ioremap_resource() but > extensible so other functions could be added later? > > (Surprised to see that we don't have such a script yet) > I am working on a more general solution, extending to other functions. Amitoj
WARNING: multiple messages have this Message-ID (diff)
From: amitoj1606@gmail.com (Amitoj Kaur Chawla) To: cocci@systeme.lip6.fr Subject: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource Date: Thu, 30 Jun 2016 08:13:28 +0530 [thread overview] Message-ID: <CA+5yK5GBcm3TFdU_vAFDsob2CqsUuVwaZEQEL-8bc4pEGoP12Q@mail.gmail.com> (raw) In-Reply-To: <20160629192357.GA9260@tetsubishi> On Thu, Jun 30, 2016 at 12:53 AM, Wolfram Sang <wsa@the-dreams.de> wrote: > On Thu, Jun 30, 2016 at 12:03:47AM +0530, Amitoj Kaur Chawla wrote: >> This script detects cases which have incorrect error handling for >> devm_ioremap_resource function, employing a NULL test instead of an >> IS_ERR() test. >> >> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> > > Why don't we fix the code at the same time? > Thank you for your suggestion. I will fix this up and resend. > And it should not be restricted to devm_ioremap_resource() but > extensible so other functions could be added later? > > (Surprised to see that we don't have such a script yet) > I am working on a more general solution, extending to other functions. Amitoj
next prev parent reply other threads:[~2016-06-30 2:44 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-29 18:33 [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource Amitoj Kaur Chawla 2016-06-29 18:33 ` [Cocci] " Amitoj Kaur Chawla 2016-06-29 19:23 ` Wolfram Sang 2016-06-29 19:23 ` Wolfram Sang 2016-06-30 2:43 ` Amitoj Kaur Chawla [this message] 2016-06-30 2:43 ` Amitoj Kaur Chawla 2016-06-30 7:14 ` Wolfram Sang 2016-06-30 7:14 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+5yK5GBcm3TFdU_vAFDsob2CqsUuVwaZEQEL-8bc4pEGoP12Q@mail.gmail.com \ --to=amitoj1606@gmail.com \ --cc=Gilles.Muller@lip6.fr \ --cc=Julia.Lawall@lip6.fr \ --cc=cocci@systeme.lip6.fr \ --cc=linux-kernel@vger.kernel.org \ --cc=mmarek@suse.com \ --cc=nicolas.palix@imag.fr \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.